You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Erick Erickson (Jira)" <ji...@apache.org> on 2020/06/24 13:00:00 UTC
[jira] [Created] (SOLR-14591) Move JoinQuery in JoinQParserPlugin
to its own class
Erick Erickson created SOLR-14591:
-------------------------------------
Summary: Move JoinQuery in JoinQParserPlugin to its own class
Key: SOLR-14591
URL: https://issues.apache.org/jira/browse/SOLR-14591
Project: Solr
Issue Type: Sub-task
Reporter: Erick Erickson
Assignee: Erick Erickson
Not sure why this isn't being flagged as a warning in master, but it did cause an error on a Jenkins build, there's no reason NOT to fix it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [jira] [Created] (SOLR-14591) Move JoinQuery in JoinQParserPlugin
to its own class
Posted by Atri Sharma <at...@apache.org>.
I noticed this today — am testing a patch to fix this right now
On Wed, 24 Jun 2020 at 18:30, Erick Erickson (Jira) <ji...@apache.org> wrote:
> Erick Erickson created SOLR-14591:
> -------------------------------------
>
> Summary: Move JoinQuery in JoinQParserPlugin to its own class
> Key: SOLR-14591
> URL: https://issues.apache.org/jira/browse/SOLR-14591
> Project: Solr
> Issue Type: Sub-task
> Reporter: Erick Erickson
> Assignee: Erick Erickson
>
>
> Not sure why this isn't being flagged as a warning in master, but it did
> cause an error on a Jenkins build, there's no reason NOT to fix it.
>
>
>
> --
> This message was sent by Atlassian Jira
> (v8.3.4#803005)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
> For additional commands, e-mail: issues-help@lucene.apache.org
>
> --
Regards,
Atri
Apache Concerted
Re: [jira] [Created] (SOLR-14591) Move JoinQuery in JoinQParserPlugin
to its own class
Posted by Atri Sharma <at...@apache.org>.
No, it did not fail for me locally. I tracked it from failing build in a PR
I had raised.
On Wed, 24 Jun 2020 at 18:51, Erick Erickson <er...@gmail.com>
wrote:
> Cool. You want to take over SOLR-14591 then? Or mark it as duplicate if
> you already have one.
>
> Curiosity question: Did you have gradlew check or precommit fail locally?
> Because I’m puzzled why
> it doesn’t fail locally for me.
>
> Erick
>
> > On Jun 24, 2020, at 9:00 AM, Erick Erickson (Jira) <ji...@apache.org>
> wrote:
> >
> > Erick Erickson created SOLR-14591:
> > -------------------------------------
> >
> > Summary: Move JoinQuery in JoinQParserPlugin to its own class
> > Key: SOLR-14591
> > URL: https://issues.apache.org/jira/browse/SOLR-14591
> > Project: Solr
> > Issue Type: Sub-task
> > Reporter: Erick Erickson
> > Assignee: Erick Erickson
> >
> >
> > Not sure why this isn't being flagged as a warning in master, but it did
> cause an error on a Jenkins build, there's no reason NOT to fix it.
> >
> >
> >
> > --
> > This message was sent by Atlassian Jira
> > (v8.3.4#803005)
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: issues-help@lucene.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
> --
Regards,
Atri
Apache Concerted
Re: [jira] [Created] (SOLR-14591) Move JoinQuery in JoinQParserPlugin
to its own class
Posted by Erick Erickson <er...@gmail.com>.
Cool. You want to take over SOLR-14591 then? Or mark it as duplicate if you already have one.
Curiosity question: Did you have gradlew check or precommit fail locally? Because I’m puzzled why
it doesn’t fail locally for me.
Erick
> On Jun 24, 2020, at 9:00 AM, Erick Erickson (Jira) <ji...@apache.org> wrote:
>
> Erick Erickson created SOLR-14591:
> -------------------------------------
>
> Summary: Move JoinQuery in JoinQParserPlugin to its own class
> Key: SOLR-14591
> URL: https://issues.apache.org/jira/browse/SOLR-14591
> Project: Solr
> Issue Type: Sub-task
> Reporter: Erick Erickson
> Assignee: Erick Erickson
>
>
> Not sure why this isn't being flagged as a warning in master, but it did cause an error on a Jenkins build, there's no reason NOT to fix it.
>
>
>
> --
> This message was sent by Atlassian Jira
> (v8.3.4#803005)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
> For additional commands, e-mail: issues-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org