You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Vasily Zakharov <vm...@apache.org> on 2008/04/15 20:20:48 UTC
svn:ignore properties update
Hi, all,
Don't anyone mind if I add the following files to svn:ignore
properties, so that they don't get in the way when commiting/creating
patches?
working_vm/junit*.properties
working_jdktools/modules/jpda/src/main/native/jdwp/windows/dt_shmem.dll
working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.obj
working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/vc70.pdb
working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_socket/vc70.pdb
Vasily
Re: svn:ignore properties update
Posted by Gregory Shimansky <gs...@apache.org>.
On 16 April 2008 Tim Ellison wrote:
> Gregory Shimansky wrote:
> > On 15 April 2008 Vasily Zakharov wrote:
> >> Hi, all,
> >>
> >> Don't anyone mind if I add the following files to svn:ignore
> >> properties, so that they don't get in the way when commiting/creating
> >> patches?
> >>
> >> working_vm/junit*.properties
> >> working_jdktools/modules/jpda/src/main/native/jdwp/windows/dt_shmem.dll
> >> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_
> >>shm em/SharedMemTransport.obj
> >> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_
> >>shm em/vc70.pdb
> >> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_
> >>soc ket/vc70.pdb
> >
> > I think that junit*.properties files appear only when tests are
> > terminated abnormally, and they shouldn't be added to ignore list in
> > normal circumstances.
> >
> > All of the other files are ok to me. I think it is even better to add
> > *.obj \n *.pdb \n *.dll to the svn:ignore.
>
> We said exactly the same thing at the same time! :-)
Great minds think alike?... :)
--
Gregory
Re: svn:ignore properties update
Posted by Tim Ellison <t....@gmail.com>.
Gregory Shimansky wrote:
> On 15 April 2008 Vasily Zakharov wrote:
>> Hi, all,
>>
>> Don't anyone mind if I add the following files to svn:ignore
>> properties, so that they don't get in the way when commiting/creating
>> patches?
>>
>> working_vm/junit*.properties
>> working_jdktools/modules/jpda/src/main/native/jdwp/windows/dt_shmem.dll
>> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_shm
>> em/SharedMemTransport.obj
>> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_shm
>> em/vc70.pdb
>> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_soc
>> ket/vc70.pdb
>
> I think that junit*.properties files appear only when tests are terminated
> abnormally, and they shouldn't be added to ignore list in normal
> circumstances.
>
> All of the other files are ok to me. I think it is even better to add *.obj \n
> *.pdb \n *.dll to the svn:ignore.
We said exactly the same thing at the same time! :-)
Re: svn:ignore properties update
Posted by Gregory Shimansky <gs...@apache.org>.
On 15 April 2008 Vasily Zakharov wrote:
> Hi, all,
>
> Don't anyone mind if I add the following files to svn:ignore
> properties, so that they don't get in the way when commiting/creating
> patches?
>
> working_vm/junit*.properties
> working_jdktools/modules/jpda/src/main/native/jdwp/windows/dt_shmem.dll
> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_shm
>em/SharedMemTransport.obj
> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_shm
>em/vc70.pdb
> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_soc
>ket/vc70.pdb
I think that junit*.properties files appear only when tests are terminated
abnormally, and they shouldn't be added to ignore list in normal
circumstances.
All of the other files are ok to me. I think it is even better to add *.obj \n
*.pdb \n *.dll to the svn:ignore.
--
Gregory
Re: svn:ignore properties update
Posted by Vasily Zakharov <vm...@apache.org>.
Thanks everybody for concerns, changes committed at r648482.
Vasily
On Wed, Apr 16, 2008 at 1:32 AM, Tim Ellison <t....@gmail.com> wrote:
>
> Gregory Shimansky wrote:
>
> > On 16 April 2008 Alexey Petrenko wrote:
> >
> > > 2008/4/16, Gregory Shimansky <gs...@apache.org>:
> > >
> > > > On 16 April 2008 Alexey Petrenko wrote:
> > > >
> > > > > 2008/4/16, Tim Ellison <t....@gmail.com>:
> > > > >
> > > > > > Vasily Zakharov wrote:
> > > > > >
> > > > > > > Don't anyone mind if I add the following files to svn:ignore
> > > > > > > properties, so that they don't get in the way when
> > > > > > > commiting/creating patches?
> > > > > > >
> > > > > > No objections.
> > > > > >
> > > > > >
> > > > > > > working_vm/junit*.properties
> > > > > > >
> > > > > > Isn't that just an artifact of an interrupted JUnit run? Probably
> > > > > > just delete your file, no need to add to ignore.
> > > > > >
> > > > > Since these files are result of error then we definitely do not want
> > > > > to see them in svn repository. Right?
> > > > > If so why don't we want to add the to ignore list?
> > > > >
> > > > I think it is better to avoid such errors. When such file appears in
> your
> > > > "svn status" you would know that something didn't go right even if you
> > > > didn't notice it right away.
> > > > Files added to svn:ignore are files expected to be generated.
> > > >
> > > Why? I think that all the files, which we do not want to see in svn,
> > > worths to be added to ignore list.
> > >
> >
> > -1
> >
> > I disagree. Or else we'd add "*" to svn:ignore for all of subdirectories.
> This makes no sense.
> >
> > Only files that are expected to be generated should be ignored. All other
> files are a warning for the developer that all other developers didn't
> expect them to appear in the source tree.
> >
> > You should want to find files like "junit*.properties" or "core.*" to know
> that the build doesn't work as expected by all other people.
> >
>
> I agree. Just name the expected ignores.
>
> Regards,
> Tim
>
Re: svn:ignore properties update
Posted by Tim Ellison <t....@gmail.com>.
Gregory Shimansky wrote:
> On 16 April 2008 Alexey Petrenko wrote:
>> 2008/4/16, Gregory Shimansky <gs...@apache.org>:
>>> On 16 April 2008 Alexey Petrenko wrote:
>>>> 2008/4/16, Tim Ellison <t....@gmail.com>:
>>>>> Vasily Zakharov wrote:
>>>>>> Don't anyone mind if I add the following files to svn:ignore
>>>>>> properties, so that they don't get in the way when
>>>>>> commiting/creating patches?
>>>>> No objections.
>>>>>
>>>>>> working_vm/junit*.properties
>>>>> Isn't that just an artifact of an interrupted JUnit run? Probably
>>>>> just delete your file, no need to add to ignore.
>>>> Since these files are result of error then we definitely do not want
>>>> to see them in svn repository. Right?
>>>> If so why don't we want to add the to ignore list?
>>> I think it is better to avoid such errors. When such file appears in your
>>> "svn status" you would know that something didn't go right even if you
>>> didn't notice it right away.
>>> Files added to svn:ignore are files expected to be generated.
>> Why? I think that all the files, which we do not want to see in svn,
>> worths to be added to ignore list.
>
> -1
>
> I disagree. Or else we'd add "*" to svn:ignore for all of subdirectories. This
> makes no sense.
>
> Only files that are expected to be generated should be ignored. All other
> files are a warning for the developer that all other developers didn't expect
> them to appear in the source tree.
>
> You should want to find files like "junit*.properties" or "core.*" to know
> that the build doesn't work as expected by all other people.
I agree. Just name the expected ignores.
Regards,
Tim
Re: svn:ignore properties update
Posted by Gregory Shimansky <gs...@apache.org>.
On 16 April 2008 Alexey Petrenko wrote:
> 2008/4/16, Gregory Shimansky <gs...@apache.org>:
> > On 16 April 2008 Alexey Petrenko wrote:
> > > 2008/4/16, Tim Ellison <t....@gmail.com>:
> > > > Vasily Zakharov wrote:
> > > > > Don't anyone mind if I add the following files to svn:ignore
> > > > > properties, so that they don't get in the way when
> > > > > commiting/creating patches?
> > > >
> > > > No objections.
> > > >
> > > > > working_vm/junit*.properties
> > > >
> > > > Isn't that just an artifact of an interrupted JUnit run? Probably
> > > > just delete your file, no need to add to ignore.
> > >
> > > Since these files are result of error then we definitely do not want
> > > to see them in svn repository. Right?
> > > If so why don't we want to add the to ignore list?
> >
> > I think it is better to avoid such errors. When such file appears in your
> > "svn status" you would know that something didn't go right even if you
> > didn't notice it right away.
> > Files added to svn:ignore are files expected to be generated.
>
> Why? I think that all the files, which we do not want to see in svn,
> worths to be added to ignore list.
-1
I disagree. Or else we'd add "*" to svn:ignore for all of subdirectories. This
makes no sense.
Only files that are expected to be generated should be ignored. All other
files are a warning for the developer that all other developers didn't expect
them to appear in the source tree.
You should want to find files like "junit*.properties" or "core.*" to know
that the build doesn't work as expected by all other people.
--
Gregory
Re: svn:ignore properties update
Posted by Alexey Petrenko <al...@gmail.com>.
2008/4/16, Gregory Shimansky <gs...@apache.org>:
> On 16 April 2008 Alexey Petrenko wrote:
> > 2008/4/16, Tim Ellison <t....@gmail.com>:
> > > Vasily Zakharov wrote:
> > > > Don't anyone mind if I add the following files to svn:ignore
> > > > properties, so that they don't get in the way when commiting/creating
> > > > patches?
> > >
> > > No objections.
> > >
> > > > working_vm/junit*.properties
> > >
> > > Isn't that just an artifact of an interrupted JUnit run? Probably just
> > > delete your file, no need to add to ignore.
> >
> > Since these files are result of error then we definitely do not want
> > to see them in svn repository. Right?
> > If so why don't we want to add the to ignore list?
>
> I think it is better to avoid such errors. When such file appears in your "svn
> status" you would know that something didn't go right even if you didn't
> notice it right away.
> Files added to svn:ignore are files expected to be generated.
Why? I think that all the files, which we do not want to see in svn,
worths to be added to ignore list.
SY, Alexey
Re: svn:ignore properties update
Posted by Gregory Shimansky <gs...@apache.org>.
On 16 April 2008 Alexey Petrenko wrote:
> 2008/4/16, Tim Ellison <t....@gmail.com>:
> > Vasily Zakharov wrote:
> > > Don't anyone mind if I add the following files to svn:ignore
> > > properties, so that they don't get in the way when commiting/creating
> > > patches?
> >
> > No objections.
> >
> > > working_vm/junit*.properties
> >
> > Isn't that just an artifact of an interrupted JUnit run? Probably just
> > delete your file, no need to add to ignore.
>
> Since these files are result of error then we definitely do not want
> to see them in svn repository. Right?
> If so why don't we want to add the to ignore list?
I think it is better to avoid such errors. When such file appears in your "svn
status" you would know that something didn't go right even if you didn't
notice it right away.
Files added to svn:ignore are files expected to be generated. Those files that
are not expected to be generated in normal circumstances _should_ be noticed.
--
Gregory
Re: svn:ignore properties update
Posted by Alexey Petrenko <al...@gmail.com>.
2008/4/16, Tim Ellison <t....@gmail.com>:
> Vasily Zakharov wrote:
> > Don't anyone mind if I add the following files to svn:ignore
> > properties, so that they don't get in the way when commiting/creating
> > patches?
> >
>
> No objections.
>
> > working_vm/junit*.properties
> Isn't that just an artifact of an interrupted JUnit run? Probably just
> delete your file, no need to add to ignore.
Since these files are result of error then we definitely do not want
to see them in svn repository. Right?
If so why don't we want to add the to ignore list?
SY, Alexey
Re: svn:ignore properties update
Posted by Tim Ellison <t....@gmail.com>.
Vasily Zakharov wrote:
> Don't anyone mind if I add the following files to svn:ignore
> properties, so that they don't get in the way when commiting/creating
> patches?
No objections.
> working_vm/junit*.properties
Isn't that just an artifact of an interrupted JUnit run? Probably just
delete your file, no need to add to ignore.
> working_jdktools/modules/jpda/src/main/native/jdwp/windows/dt_shmem.dll
> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/SharedMemTransport.obj
> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_shmem/vc70.pdb
> working_jdktools/modules/jpda/src/main/native/jdwp/windows/transport/dt_socket/vc70.pdb
I'd be inclined to go mad and ignore *.dll, *.obj and *.pdb
Regards,
Tim