You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/10/07 08:04:35 UTC
[GitHub] [incubator-pegasus] AlexNodex opened a new pull request, #1180: Update README.md
AlexNodex opened a new pull request, #1180:
URL: https://github.com/apache/incubator-pegasus/pull/1180
Added javascript syntax highlighting to your code snippets
### What problem does this PR solve? <!--add issue link with summary if exists-->
Adds syntax highlighting to code snippets
### What is changed and how does it work?
Uses markdown syntax to highlight JS code snippets
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] AlexNodex commented on pull request #1180: docs: Update nodejs-client/README.md
Posted by GitBox <gi...@apache.org>.
AlexNodex commented on PR #1180:
URL: https://github.com/apache/incubator-pegasus/pull/1180#issuecomment-1272469107
Hi
I don’t k ow how to do that sorry, I did the whole thing on GitHub in the editor there
Sent from my iPhone
> On 9 Oct 2022, at 07:17, Yingchun Lai ***@***.***> wrote:
>
>
> @acelyc111 approved this pull request.
>
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you were mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1180: docs: Update nodejs-client/README.md
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1180:
URL: https://github.com/apache/incubator-pegasus/pull/1180#issuecomment-1272473550
> Hi I don’t k ow how to do that sorry, I did the whole thing on GitHub in the editor there
> […](#)
> Sent from my iPhone
> On 9 Oct 2022, at 07:17, Yingchun Lai ***@***.***> wrote: @acelyc111 approved this pull request. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.
OK, anyway it works now, all CIs passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1180: Update README.md
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1180:
URL: https://github.com/apache/incubator-pegasus/pull/1180#issuecomment-1272442720
@AlexNodex Thanks for the contribution, could you please rebase the master branch at first? There is a bug has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1180: docs: Update nodejs-client/README.md
Posted by GitBox <gi...@apache.org>.
empiredan merged PR #1180:
URL: https://github.com/apache/incubator-pegasus/pull/1180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org