[zeppelin] branch master updated: [ZEPPELIN-4333] escape dialog title and message

[mo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

moon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new a7cf49c  [ZEPPELIN-4333] escape dialog title and message
a7cf49c is described below

commit a7cf49cbee7208045f1eeaca23164466dd03f099
Author: Lee moon soo <mo...@apache.org>
AuthorDate: Tue Sep 17 10:41:42 2019 -0700

    [ZEPPELIN-4333] escape dialog title and message
    
    ### What is this PR for?
    There're couple of places in the code that dialog title and message is not being escaped
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-4333
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Lee moon soo <mo...@apache.org>
    
    Closes #3449 from Leemoonsoo/ZEPPELIN-4333 and squashes the following commits:
    
    82dab1244 [Lee moon soo] escape dialog title and message
---
 zeppelin-web/src/app/helium/helium.controller.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/zeppelin-web/src/app/helium/helium.controller.js b/zeppelin-web/src/app/helium/helium.controller.js
index 81e0853..e409393 100644
--- a/zeppelin-web/src/app/helium/helium.controller.js
+++ b/zeppelin-web/src/app/helium/helium.controller.js
@@ -218,7 +218,7 @@ export default function HeliumCtrl($scope, $rootScope, $sce,
               confirm.close();
               console.log('Failed to install an interpreter %o %o', name, artifact);
               BootstrapDialog.show({
-                title: 'Error while starting to install ' + name + ' interpreter',
+                title: 'Error while starting to install ' + _.escape(name) + ' interpreter',
                 message: _.escape(data.message),
               });
             });