You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/27 16:29:22 UTC
[PR] Align MCP E2E tests with SQL E2E naming [shardingsphere]
terrymanu opened a new pull request, #39981:
URL: https://github.com/apache/shardingsphere/pull/39981
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align MCP E2E tests with SQL E2E naming [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39981:
URL: https://github.com/apache/shardingsphere/pull/39981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Align MCP E2E tests with SQL E2E naming [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39981:
URL: https://github.com/apache/shardingsphere/pull/39981#issuecomment-5857679557
### Result
**Review Result: Mergeable**
The local changes meet the agreed MCP E2E naming and startup requirements. This is a code correctness assessment; GitHub CI results were not reviewed.
### Evidence
- The 14 Java file renames change only class names, file names, and references. Test methods and runtime conditions are unchanged. No references to the old MCP class names remain in the repository.
- A normal `install` ran no MCP E2E tests through Surefire. Failsafe discovered 61 tests and skipped all of them because `DOCKER` was not specified; the build succeeded.
- The functionality profile selected 56 tests; an LLM method selector selected 1; the release class and two-method selectors selected 8 and 2, respectively.
- Spotless passed for the 14 Java files, MCP POM, and 2 workflows. Checkstyle passed for the Java files. YAML parsing and Apache RAT passed.
### Coverage
Standalone local candidate based on `7f1b55421a67a70ec84882fd83cb6d0a2771cf53`. The review covered 14 rename pairs and 5 POM, workflow, and documentation files, with no unresolved issues. Actual Docker/LLM E2E runs and GitHub CI were not run locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org