You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by keith-turner <gi...@git.apache.org> on 2017/01/26 20:22:05 UTC
[GitHub] accumulo pull request #208: ACCUMULO-4575 Fixed concurrent delete issue in F...
GitHub user keith-turner opened a pull request:
https://github.com/apache/accumulo/pull/208
ACCUMULO-4575 Fixed concurrent delete issue in FATE ops
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith-turner/accumulo ACCUMULO-4575-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #208
----
commit 63d5771992db7f56b051df8a1fa92b2007e5e967
Author: Keith Turner <kt...@apache.org>
Date: 2017-01-25T21:57:03Z
ACCUMULO-4575 Fixed concurrent delete issue in FATE ops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #208: ACCUMULO-4575 Fixed concurrent delete issue in F...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/208#discussion_r98107165
--- Diff: server/master/src/main/java/org/apache/accumulo/master/tableOps/TableRangeOp.java ---
@@ -38,19 +37,24 @@
private static final long serialVersionUID = 1L;
private final String tableId;
+ private final String namespaceId;
--- End diff --
The [Java Object Serialization Specification] seems to indicate that order doesn't matter, also. Very cool.
[1]: https://docs.oracle.com/javase/7/docs/platform/serialization/spec/version.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #208: ACCUMULO-4575 Fixed concurrent delete issue in F...
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner closed the pull request at:
https://github.com/apache/accumulo/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #208: ACCUMULO-4575 Fixed concurrent delete issue in FATE ops
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/208
I ran ITs that exercised each fate op that I changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #208: ACCUMULO-4575 Fixed concurrent delete issue in FATE ops
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/208
merged 7b9a11a
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #208: ACCUMULO-4575 Fixed concurrent delete issue in FATE ops
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/208
For #206 only delete table running concurrently with delete table was fixed. This PR handles the case of other FATE ops running concurrently with delete table.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #208: ACCUMULO-4575 Fixed concurrent delete issue in F...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/208#discussion_r98086859
--- Diff: server/master/src/main/java/org/apache/accumulo/master/tableOps/TableRangeOp.java ---
@@ -38,19 +37,24 @@
private static final long serialVersionUID = 1L;
private final String tableId;
+ private final String namespaceId;
--- End diff --
I'm surprised if inserting a new field in-between other fields actually works. I would have expected the order of the existing fields being disrupted to have an effect on serialization. This should be tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #208: ACCUMULO-4575 Fixed concurrent delete issue in F...
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/208#discussion_r98106864
--- Diff: server/master/src/main/java/org/apache/accumulo/master/tableOps/TableRangeOp.java ---
@@ -38,19 +37,24 @@
private static final long serialVersionUID = 1L;
private final String tableId;
+ private final String namespaceId;
--- End diff --
I did some experiments with this and order does not seem to matter. I tried reordering existing fields and inserting new fields and it did not matter. Also I found some information that suggest the fields name is stored by serialization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---