You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/22 18:31:49 UTC

[GitHub] [spark] cloud-fan commented on pull request #33012: [SPARK-33298][CORE] Introduce new API to FileCommitProtocol allow flexible file naming

cloud-fan commented on pull request #33012:
URL: https://github.com/apache/spark/pull/33012#issuecomment-866233612


   It's not a public API (under package `org.apache.spark.internal`) and we are conservative here simply because we know some third party libraries are using it, e.g. https://github.com/steveloughran/zero-rename-committer
   
   The old API needs to be deprecated as it's not fully functional now. To support hive bucket table, Spark needs to ask the commit protocol to add a certain prefix in the file name, and the old API can never know this prefix requirement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org