[PR] 11.x: regex_remap: Remove // prefix from host match string [trafficserver]

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt opened a new pull request, #12706:
URL: https://github.com/apache/trafficserver/pull/12706

   When the host option was enabled, regex_remap prepended '//' before the host in the match string, resulting in '//host/path' instead of 'host/path'. This was confusing because users associated the '//' with the 'http://' scheme, leading to double-slash issues when writing HTTP-to-HTTPS redirect rules. The match string now uses 'host/path' format. Documentation and tests have been updated accordingly, including new examples for host and method options.
   
   Fixes: #12691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 11.x: regex_remap: Remove // prefix from host match string [trafficserver]

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt closed pull request #12706: 11.x: regex_remap: Remove // prefix from host match string
URL: https://github.com/apache/trafficserver/pull/12706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 11.x: regex_remap: Remove // prefix from host match string [trafficserver]

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt commented on PR #12706:
URL: https://github.com/apache/trafficserver/pull/12706#issuecomment-3597824534

   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 11.x: regex_remap: Remove // prefix from host match string [trafficserver]

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt commented on PR #12706:
URL: https://github.com/apache/trafficserver/pull/12706#issuecomment-3609326378

   @zwoop had the following comment to the mailing list thread:
   
   ```
   I don’t have a strong opinion either way, but I have a vague recollection
   that this came from the fact that someone used to have hostnames in the
   path. E.g. something like (maybe…)
   
       https://cdn.example.com/origin1.example.com/some/path/
       https://cdn.example.com/origin2.example.com/some/path/
   
   etc. And I *think* that's the reason for keeping the // with the authority,
   making it easy, safe (and maybe even possible sometimes) to distinguish it
   from the path. I.e. a regex like
   
      /\/\/cdn.*.com\/(.*\.example\.com)/
   
   So, I’m -0 on this change, and I don’t know if it’s a use case anyone have
   now. As such, I’m ok landing this, but given a choice I probably wouldn’t.
   
   Cheers,
   
   — Leif
   ```
   
   This is a good point. That being the case, I'm going to close this PR and replace it with a documentation update PR making sure this behavior is well explained: #12730


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org