You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/21 10:57:30 UTC

[GitHub] [skywalking-client-js] zouzou6321 opened a new pull request #22: 支持一个页面内基于axios的链路上报包括请求和错误日志生成多条链路

zouzou6321 opened a new pull request #22:
URL: https://github.com/apache/skywalking-client-js/pull/22


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] Fine0830 commented on pull request #22: 支持一个页面内基于axios的链路上报包括请求和错误日志生成多条链路

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #22:
URL: https://github.com/apache/skywalking-client-js/pull/22#issuecomment-749409937


   First of all, now, different projects use different HTTP request technology, and there are many libraries and tools to implement this technology, such as `Axios`, `Superagent` ....., and tools such as `OpenAPI` ...... If every library or tool implements an interception, it will be more troublesome. All the front-end HTTP request technologies are implemented based on XMLHttpRequest (`Axios`, `Superagent`) and fetch (`OpenAPI`). Therefore, I think it is better to implement interception from the underlying technology. All projects can be covered only by supporting XMLHttpRequest and fetch interception.
   Now, I implemented interception and header settings based on `XMLHttpReques`. Next, I will do `fetch` based part.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] Fine0830 commented on pull request #22: 支持一个页面内基于axios的链路上报包括请求和错误日志生成多条链路

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #22:
URL: https://github.com/apache/skywalking-client-js/pull/22#issuecomment-749406951


   > 1. Update all things to English please.
   > 2. All new files are required Apache 2.0 headers.
   > 3. Make CI passed.
   > 4. Keep alive is not required, actually.
   > 
   > We need your example data of trace segment and http header data. Please explain that
   > 
   > @Fine0830 I know you are implementing the tracing too. Could you update the progress here?
   
   OK


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] zouzou6321 closed pull request #22: Support tracing in axios

Posted by GitBox <gi...@apache.org>.
zouzou6321 closed pull request #22:
URL: https://github.com/apache/skywalking-client-js/pull/22


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] wu-sheng commented on pull request #22: 支持一个页面内基于axios的链路上报包括请求和错误日志生成多条链路

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #22:
URL: https://github.com/apache/skywalking-client-js/pull/22#issuecomment-749412112


   > Now, I implemented interception and header settings based on XMLHttpReques. Next, I will do fetch based part.
   WDYT
   
   Make sense to me. Try to isolate the core implementations, such as assembling the headers, and span/segment in an independent libs, which could be shared in different interceptors.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] kezhenxu94 commented on pull request #22: 支持一个页面内基于axios的链路上报包括请求和错误日志生成多条链路

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #22:
URL: https://github.com/apache/skywalking-client-js/pull/22#issuecomment-748916113


   Please always use English on GitHub 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] Fine0830 edited a comment on pull request #22: 支持一个页面内基于axios的链路上报包括请求和错误日志生成多条链路

Posted by GitBox <gi...@apache.org>.
Fine0830 edited a comment on pull request #22:
URL: https://github.com/apache/skywalking-client-js/pull/22#issuecomment-749409937


   First of all, now, different projects use different HTTP request technology, and there are many libraries and tools to implement this technology, such as `Axios`, `Superagent` ....., and tools such as `OpenAPI` ...... If every library or tool implements an interception, it will be more troublesome. All the front-end HTTP request technologies are implemented based on `XMLHttpRequest` (`Axios`, `Superagent`) and `fetch` (`OpenAPI`). Therefore, I think it is better to implement interception from the underlying technology. All projects can be covered only by supporting `XMLHttpRequest` and `fetch` interception.
   Now, I implemented interception and header settings based on `XMLHttpReques`. Next, I will do `fetch` based part.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] wu-sheng commented on pull request #22: 支持一个页面内基于axios的链路上报包括请求和错误日志生成多条链路

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #22:
URL: https://github.com/apache/skywalking-client-js/pull/22#issuecomment-748919650


   1. Update all things to English please. 
   2. All new files are required Apache 2.0 headers. 
   3. Make CI passed.
   4. Keep alive is not required, actually.
   
   We need your example data of trace segment and http header data. Please explain that
   
   @Fine0830 I know you are implementing the tracing too. Could you update the progress here? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] Fine0830 edited a comment on pull request #22: 支持一个页面内基于axios的链路上报包括请求和错误日志生成多条链路

Posted by GitBox <gi...@apache.org>.
Fine0830 edited a comment on pull request #22:
URL: https://github.com/apache/skywalking-client-js/pull/22#issuecomment-749409937


   First of all, now, different projects use different HTTP request technology, and there are many libraries and tools to implement this technology, such as `Axios`, `Superagent` ....., and tools such as `OpenAPI` ...... If every library or tool implements an interception, it will be more troublesome. All the front-end HTTP request technologies are implemented based on `XMLHttpRequest` (`Axios`, `Superagent`) and `fetch` (`OpenAPI`). Therefore, I think it is better to implement interception from the underlying technology. All projects can be covered only by supporting `XMLHttpRequest` and `fetch` interception.
   Now, I implemented interception and header settings based on `XMLHttpReques`. Next, I will do `fetch` based part.
   WDYT @wu-sheng @zouzou6321


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-client-js] zouzou6321 commented on pull request #22: Support tracing in axios

Posted by GitBox <gi...@apache.org>.
zouzou6321 commented on pull request #22:
URL: https://github.com/apache/skywalking-client-js/pull/22#issuecomment-749439033


   
   
   
   
   > First of all, now, different projects use different HTTP request technology, and there are many libraries and tools to implement this technology, such as `Axios`, `Superagent` ....., and tools such as `OpenAPI` ...... If every library or tool implements an interception, it will be more troublesome. All the front-end HTTP request technologies are implemented based on `XMLHttpRequest` (`Axios`, `Superagent`) and `fetch` (`OpenAPI`). Therefore, I think it is better to implement interception from the underlying technology. All projects can be covered only by supporting `XMLHttpRequest` and `fetch` interception.
   > Now, I implemented interception and header settings based on `XMLHttpReques`. Next, I will do `fetch` based part.
   > WDYT @wu-sheng @zouzou6321
   
   
   I'm looking forward to using it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org