You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/26 15:46:03 UTC

[GitHub] [arrow] nevi-me commented on a change in pull request #8528: ARROW-10390: [Rust][Parquet] Ensure it is possible to create custom parquet writers

nevi-me commented on a change in pull request #8528:
URL: https://github.com/apache/arrow/pull/8528#discussion_r512063425



##########
File path: rust/parquet/src/file/writer.rs
##########
@@ -114,6 +114,7 @@ pub trait RowGroupWriter {
 // ----------------------------------------------------------------------
 // Serialized impl for file & row group writers
 
+pub use crate::util::io::TryClone;

Review comment:
       I'd prefer if the import is still close to line 41. Here it's hidden, especially as a `pub use`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org