You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ab...@apache.org on 2017/02/15 19:00:13 UTC
[09/52] [abbrv] lucene-solr:jira/solr-9858: SOLR-10090
MBeansHandlerTest assertion fails (test ordering/number dependence) (Dawid
Weiss via ab)
SOLR-10090 MBeansHandlerTest assertion fails (test ordering/number
dependence) (Dawid Weiss via ab)
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/723b2027
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/723b2027
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/723b2027
Branch: refs/heads/jira/solr-9858
Commit: 723b20279ae4a6e2d9eef2a70e2d1c699952e81c
Parents: 0b3710a
Author: Andrzej Bialecki <ab...@apache.org>
Authored: Fri Feb 10 09:17:46 2017 -0800
Committer: Andrzej Bialecki <ab...@apache.org>
Committed: Fri Feb 10 09:19:02 2017 -0800
----------------------------------------------------------------------
.../apache/solr/handler/admin/MBeansHandlerTest.java | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/723b2027/solr/core/src/test/org/apache/solr/handler/admin/MBeansHandlerTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/handler/admin/MBeansHandlerTest.java b/solr/core/src/test/org/apache/solr/handler/admin/MBeansHandlerTest.java
index 21634b7..84e2382 100644
--- a/solr/core/src/test/org/apache/solr/handler/admin/MBeansHandlerTest.java
+++ b/solr/core/src/test/org/apache/solr/handler/admin/MBeansHandlerTest.java
@@ -18,6 +18,8 @@ package org.apache.solr.handler.admin;
import java.util.ArrayList;
import java.util.List;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
import org.apache.solr.SolrTestCaseJ4;
import org.apache.solr.common.params.CommonParams;
@@ -59,7 +61,17 @@ public class MBeansHandlerTest extends SolrTestCaseJ4 {
NamedList stats = (NamedList)diff.get("ADMIN").get("/admin/mbeans").get("stats");
//System.out.println("stats:"+stats);
- assertEquals("Was: 1, Now: 2, Delta: 1", stats.get("requests"));
+ Pattern p = Pattern.compile("Was: (?<was>[0-9]+), Now: (?<now>[0-9]+), Delta: (?<delta>[0-9]+)");
+ String response = stats.get("requests").toString();
+ Matcher m = p.matcher(response);
+ if (!m.matches()) {
+ fail("Response did not match pattern: " + response);
+ }
+
+ assertEquals(1, Integer.parseInt(m.group("delta")));
+ int was = Integer.parseInt(m.group("was"));
+ int now = Integer.parseInt(m.group("now"));
+ assertEquals(1, now - was);
xml = h.query(req(
CommonParams.QT,"/admin/mbeans",