You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tvm.apache.org by Tianqi Chen <no...@github.com> on 2019/10/13 05:22:58 UTC
[dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)
This PR introduces a new object protocol to unify the node and object.
We also updated the existing runtime::vm code to make use of the new system.
Update to the node will be done in a follow-up PR.
Other changes:
- Remove object-related code in json serializer as that code logic was not complete
and we have a separate serializer for VM, can revisit later.
You can view, comment on, or merge this pull request online at:
https://github.com/dmlc/tvm/pull/4115
-- Commit Summary --
* [RUNTIME] Introduce new object protocol.
-- File Changes --
M Makefile (2)
M include/tvm/node/node.h (4)
A include/tvm/runtime/memory.h (108)
M include/tvm/runtime/object.h (555)
M include/tvm/runtime/packed_func.h (25)
M include/tvm/runtime/vm.h (101)
M python/tvm/_ffi/vmobj.py (6)
M src/api/dsl_api.cc (4)
M src/lang/reflection.cc (30)
M src/relay/backend/vm/compiler.cc (2)
M src/relay/backend/vm/deserializer.cc (2)
M src/relay/backend/vm/serializer.cc (7)
M src/relay/ir/pretty_printer.cc (2)
A src/runtime/object.cc (179)
M src/runtime/vm/object.cc (115)
M src/runtime/vm/profiler/vm.cc (2)
M src/runtime/vm/profiler/vm.h (2)
M src/runtime/vm/vm.cc (91)
M tests/python/relay/test_vm.py (2)
-- Patch Links --
https://github.com/dmlc/tvm/pull/4115.patch
https://github.com/dmlc/tvm/pull/4115.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115
Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)
Posted by Tianqi Chen <no...@github.com>.
Yes, the goal is to migrate noderef/node to be subclass of object/objectref. The migration needs to take a few steps to complete
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115#issuecomment-541768683
Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)
Posted by Tianqi Chen <no...@github.com>.
cc @jroesch @icemelon9 @junrushao1994 @zhiics
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115#issuecomment-541387894
Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)
Posted by Tianqi Chen <no...@github.com>.
@junrushao1994 @icemelon9 @yzh119 can you help review this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115#issuecomment-541470010
Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)
Posted by Zhi <no...@github.com>.
Merged #4115 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115#event-2712622451
Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)
Posted by Tianqi Chen <no...@github.com>.
ping @zhiics for another round of review
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115#issuecomment-542026749
Re: [dmlc/tvm] [RFC][RUNTIME] Introduce new object protocol. (#4115)
Posted by Zhi <no...@github.com>.
@tqchen thanks. This is now merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/4115#issuecomment-542047511