You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/07 01:52:15 UTC
[GitHub] [apisix-ingress-controller] soulbird opened a new pull request, #1136: doc(apisix_upstream): fix apiVersion to v2beta3
soulbird opened a new pull request, #1136:
URL: https://github.com/apache/apisix-ingress-controller/pull/1136
<!-- Please answer these questions before submitting a pull request -->
```
error: resource mapping not found for name: "httpbin" namespace: "" from "httpbin-upstream.yaml": no matches for kind "ApisixUpstream" in version "apisix.apache.org/v1"
```
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] soulbird closed pull request #1136: doc(apisix_upstream): fix apiVersion to v2beta3
Posted by GitBox <gi...@apache.org>.
soulbird closed pull request #1136: doc(apisix_upstream): fix apiVersion to v2beta3
URL: https://github.com/apache/apisix-ingress-controller/pull/1136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1136: doc(apisix_upstream): fix apiVersion to v2beta3
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1136:
URL: https://github.com/apache/apisix-ingress-controller/pull/1136#issuecomment-1176967389
@soulbird You may not understand what I mean.
Whether it's done in #1134 or in this PR I think it's ok.
We welcome any type of contribution, these are valuable.
If you have the time and interest, then you can modify the content except #1134.
This way #1134 doesn't need to make any changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] soulbird commented on pull request #1136: doc(apisix_upstream): fix apiVersion to v2beta3
Posted by GitBox <gi...@apache.org>.
soulbird commented on PR #1136:
URL: https://github.com/apache/apisix-ingress-controller/pull/1136#issuecomment-1176955107
> please see: [#1134 (review)](https://github.com/apache/apisix-ingress-controller/pull/1134#pullrequestreview-1030448085)
OK， I'll close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1136: doc(apisix_upstream): fix apiVersion to v2beta3
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1136:
URL: https://github.com/apache/apisix-ingress-controller/pull/1136#issuecomment-1176954551
please see: https://github.com/apache/apisix-ingress-controller/pull/1134#pullrequestreview-1030448085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] soulbird commented on pull request #1136: doc(apisix_upstream): fix apiVersion to v2beta3
Posted by GitBox <gi...@apache.org>.
soulbird commented on PR #1136:
URL: https://github.com/apache/apisix-ingress-controller/pull/1136#issuecomment-1177003216
> @soulbird You may not understand what I mean.
>
> Whether it's done in #1134 or in this PR I think it's ok. We welcome any type of contribution, these are valuable.
>
> If you have the time and interest, then you can modify the content except #1134. This way #1134 doesn't need to make any changes.
Let's see if the contributor is willing to continue to improve, if there is no feedback, I will complete it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org