You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Liyin Tang (Created) (JIRA)" <ji...@apache.org> on 2011/10/27 21:50:32 UTC
[jira] [Created] (HBASE-4689) [89-fb] Fix table level rpc* metrics
[89-fb] Fix table level rpc* metrics
------------------------------------
Key: HBASE-4689
URL: https://issues.apache.org/jira/browse/HBASE-4689
Project: HBase
Issue Type: Sub-task
Affects Versions: 0.89.20100924
Reporter: Liyin Tang
Assignee: Liyin Tang
In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4689) [89-fb] Make the table level metrics
work with rpc* metrics
Posted by "Liyin Tang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liyin Tang updated HBASE-4689:
------------------------------
Attachment: (was: hbase-4689.patch)
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4689) [89-fb] Make the table level
metrics work with rpc* metrics
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137694#comment-13137694 ]
jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/#review2896
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6475>
That's only if the client issues RPC queries for all 2^F combinations of column families. This potential exponential space complexity already existed before this patch, although it does multiply the space requirement by the number of tables.
- Mikhail
On 2011-10-27 20:23:31, Liyin Tang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2587/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-27 20:23:31)
bq.
bq.
bq. Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
bq. Fix this bug here.
bq.
bq.
bq. This addresses bug HBASE-4689.
bq. https://issues.apache.org/jira/browse/HBASE-4689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
bq. src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe
bq. src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a
bq.
bq. Diff: https://reviews.apache.org/r/2587/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passed all the unit tests and tested the rpc metrics in the dev cluster
bq.
bq.
bq. Thanks,
bq.
bq. Liyin
bq.
bq.
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4689) [89-fb] Make the table level metrics
work with rpc* metrics
Posted by "Liyin Tang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liyin Tang updated HBASE-4689:
------------------------------
Attachment: hbase-4689.patch
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4689) [89-fb] Make the table level
metrics work with rpc* metrics
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137707#comment-13137707 ]
jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------
bq. On 2011-10-27 21:09:56, Nicolas Spiegelberg wrote:
bq. > src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java, line 237
bq. > <https://reviews.apache.org/r/2587/diff/2/?file=53822#file53822line237>
bq. >
bq. > as an aside: have we currently started using table-level metrics in our dashboards yet? the common abbreviation for table is "tbl" instead of "tab" (normally, cut out the vowels). would be nice to change if we're not dependent on this format yet.
Some applications has started to using this format:(
But I agree to rename it as 'tbl'.
- Liyin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/#review2893
-----------------------------------------------------------
On 2011-10-27 20:23:31, Liyin Tang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2587/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-27 20:23:31)
bq.
bq.
bq. Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
bq. Fix this bug here.
bq.
bq.
bq. This addresses bug HBASE-4689.
bq. https://issues.apache.org/jira/browse/HBASE-4689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
bq. src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe
bq. src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a
bq.
bq. Diff: https://reviews.apache.org/r/2587/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passed all the unit tests and tested the rpc metrics in the dev cluster
bq.
bq.
bq. Thanks,
bq.
bq. Liyin
bq.
bq.
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4689) [89-fb] Make the table level
metrics work with rpc* metrics
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137728#comment-13137728 ]
jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/
-----------------------------------------------------------
(Updated 2011-10-27 23:26:27.328348)
Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
Changes
-------
Address Nicolas' comments.
Summary
-------
In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
Fix this bug here.
This addresses bug HBASE-4689.
https://issues.apache.org/jira/browse/HBASE-4689
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a
Diff: https://reviews.apache.org/r/2587/diff
Testing
-------
Passed all the unit tests and tested the rpc metrics in the dev cluster
Thanks,
Liyin
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-4689) [89-fb] Fix table level rpc*
metrics
Posted by "Liyin Tang (Work started) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HBASE-4689 started by Liyin Tang.
> [89-fb] Fix table level rpc* metrics
> ------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4689) [89-fb] Make the table level metrics
work with rpc* metrics
Posted by "Liyin Tang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liyin Tang updated HBASE-4689:
------------------------------
Summary: [89-fb] Make the table level metrics work with rpc* metrics (was: [89-fb] Fix table level rpc* metrics)
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4689) [89-fb] Make the table level
metrics work with rpc* metrics
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137736#comment-13137736 ]
jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/#review2898
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6478>
Please use this constant in the unit test instead of hard-coding "cf".
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6477>
Please also use the constant from SchemaMetrics instead of "cf".
- Mikhail
On 2011-10-27 23:26:27, Liyin Tang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2587/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-27 23:26:27)
bq.
bq.
bq. Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
bq. Fix this bug here.
bq.
bq.
bq. This addresses bug HBASE-4689.
bq. https://issues.apache.org/jira/browse/HBASE-4689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
bq. src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe
bq. src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a
bq.
bq. Diff: https://reviews.apache.org/r/2587/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passed all the unit tests and tested the rpc metrics in the dev cluster
bq.
bq.
bq. Thanks,
bq.
bq. Liyin
bq.
bq.
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4689) [89-fb] Make the table level
metrics work with rpc* metrics
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137490#comment-13137490 ]
jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/
-----------------------------------------------------------
(Updated 2011-10-27 20:23:31.651831)
Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
Summary
-------
In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
Fix this bug here.
This addresses bug HBASE-4689.
https://issues.apache.org/jira/browse/HBASE-4689
Diffs
-----
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a
Diff: https://reviews.apache.org/r/2587/diff
Testing (updated)
-------
Passed all the unit tests and tested the rpc metrics in the dev cluster
Thanks,
Liyin
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4689) [89-fb] Make the table level
metrics work with rpc* metrics
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137478#comment-13137478 ]
jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/
-----------------------------------------------------------
Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
Summary
-------
In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
Fix this bug here.
This addresses bug HBASE-4689.
https://issues.apache.org/jira/browse/HBASE-4689
Diffs
-----
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a
Diff: https://reviews.apache.org/r/2587/diff
Testing
-------
passed all the unit tests and the metrics in the dev cluster
Thanks,
Liyin
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4689) [89-fb] Make the table level
metrics work with rpc* metrics
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137556#comment-13137556 ]
jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/#review2893
-----------------------------------------------------------
there's a decent bit of refactoring here. what are the critical parts to look at?
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6472>
Is printing multi-CF metrics scalable? With F families, isn't the space complexity O(2^F)?
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6471>
as an aside: have we currently started using table-level metrics in our dashboards yet? the common abbreviation for table is "tbl" instead of "tab" (normally, cut out the vowels). would be nice to change if we're not dependent on this format yet.
- Nicolas
On 2011-10-27 20:23:31, Liyin Tang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2587/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-27 20:23:31)
bq.
bq.
bq. Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
bq. Fix this bug here.
bq.
bq.
bq. This addresses bug HBASE-4689.
bq. https://issues.apache.org/jira/browse/HBASE-4689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
bq. src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe
bq. src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a
bq.
bq. Diff: https://reviews.apache.org/r/2587/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passed all the unit tests and tested the rpc metrics in the dev cluster
bq.
bq.
bq. Thanks,
bq.
bq. Liyin
bq.
bq.
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4689) [89-fb] Make the table level
metrics work with rpc* metrics
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137749#comment-13137749 ]
jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/#review2899
-----------------------------------------------------------
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6479>
Mikhail, I have already used the constant for the prefix:)
The cf name below is "real" column family name.
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6480>
The constant has been used in line #236:)
Here is just the real cf name, not metric's prefix :)
- Liyin
On 2011-10-27 23:26:27, Liyin Tang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2587/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-27 23:26:27)
bq.
bq.
bq. Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
bq. Fix this bug here.
bq.
bq.
bq. This addresses bug HBASE-4689.
bq. https://issues.apache.org/jira/browse/HBASE-4689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
bq. src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe
bq. src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a
bq.
bq. Diff: https://reviews.apache.org/r/2587/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passed all the unit tests and tested the rpc metrics in the dev cluster
bq.
bq.
bq. Thanks,
bq.
bq. Liyin
bq.
bq.
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4689) [89-fb] Make the table level
metrics work with rpc* metrics
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137751#comment-13137751 ]
jiraposter@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/#review2900
-----------------------------------------------------------
Ship it!
Changes look good. Nice work, Liyin!
- Mikhail
On 2011-10-27 23:26:27, Liyin Tang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2587/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-27 23:26:27)
bq.
bq.
bq. Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
bq. Fix this bug here.
bq.
bq.
bq. This addresses bug HBASE-4689.
bq. https://issues.apache.org/jira/browse/HBASE-4689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
bq. src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java 8776ffe
bq. src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java c03532a
bq.
bq. Diff: https://reviews.apache.org/r/2587/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passed all the unit tests and tested the rpc metrics in the dev cluster
bq.
bq.
bq. Thanks,
bq.
bq. Liyin
bq.
bq.
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4689) [89-fb] Make the table level metrics
work with rpc* metrics
Posted by "Liyin Tang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liyin Tang updated HBASE-4689:
------------------------------
Attachment: (was: hbase-4689.patch)
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4689) [89-fb] Make the table level metrics
work with rpc* metrics
Posted by "Liyin Tang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liyin Tang updated HBASE-4689:
------------------------------
Attachment: hbase-4689.patch
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4689) [89-fb] Fix table level rpc* metrics
Posted by "Liyin Tang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liyin Tang updated HBASE-4689:
------------------------------
Attachment: hbase-4689.patch
> [89-fb] Fix table level rpc* metrics
> ------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira