[GitHub] [datasketches-memory] leerho commented on a diff in pull request #173: Remove incompatible methods

["leerho (via GitHub)" <gi...@apache.org>]

leerho commented on code in PR #173:
URL: https://github.com/apache/datasketches-memory/pull/173#discussion_r1093893764


##########
datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/BaseWritableBufferImpl.java:
##########
@@ -387,9 +387,13 @@ final void putNativeOrderedShort(final long offsetBytes, final short value) {
     unsafe.putShort(getUnsafeObject(), getCumulativeOffset(offsetBytes), value);
   }
 
-  //OTHER
-  @Override
-  public final Object getArray() {
+  //OTHER WRITE METHODS
+
+  /**
+   * Returns the primitive backing array, otherwise null.
+   * @return the primitive backing array, otherwise null.
+   */

Review Comment:
   Yes, that is its purpose. As for the declaration part, that is a very good catch.  I will have to go through nearly all the methods add a declaration to that effect.  -- But I will do that in the next phase.   --Thanks, this was very helpful!  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org