You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by tianlileer <gi...@git.apache.org> on 2017/03/28 09:49:57 UTC
[GitHub] incubator-carbondata pull request #707: [CARBONDATA-828] CarbonGlobalDiction...
GitHub user tianlileer opened a pull request:
https://github.com/apache/incubator-carbondata/pull/707
[CARBONDATA-828] CarbonGlobalDictionaryRDD model.isComplexes model.dimensions\u957f\u5ea6\u53ef\u80fd\u4e0d\u4e00\u81f4
org.apache.carbondata.spark.rdd.CarbonGlobalDictionaryGenerateRDD find a bug:
code line 378-380
if (model.isFirstLoad && model.highCardIdentifyEnable
&& !model.isComplexes(split.index)
&& model.dimensions(split.index).isColumnar) {
model.dimensions(split.index).isColumnar must change to model.primDimensions(split.index).isColumnar because model.isComplexes.length may be != model.dimensions.length when create table use DICTIONARY_EXCLUDE or column datatype is complex
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tianlileer/incubator-carbondata master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/707.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #707
----
commit a418dd5ca20e008c40ababa26fc5f7e563a291f7
Author: tianli <ti...@admaster.com.cn>
Date: 2017-03-28T09:45:29Z
CarbonGlobalDictionaryRDD \u5b57\u6bb5\u6bd4\u8f83\u4e0d\u4e00\u81f4
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #707: [CARBONDATA-828] CarbonGlobalDictionaryRDD ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/707
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1363/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #707: [CARBONDATA-828] CarbonGlobalDictionaryRDD ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/707
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #707: [CARBONDATA-828] CarbonGlobalDiction...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/707
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #707: [CARBONDATA-828] CarbonGlobalDictionaryRDD ...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/707
@tianlileer please use english to describe the pr title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #707: [CARBONDATA-828] CarbonGlobalDictionaryRDD ...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/707
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #707: [CARBONDATA-828] CarbonGlobalDictionaryRDD ...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/707
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---