You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/06 14:08:35 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #19953: update upper bound for MarkupSafe

potiuk commented on a change in pull request #19953:
URL: https://github.com/apache/airflow/pull/19953#discussion_r763037847



##########
File path: tests/www/views/test_views_rendered.py
##########
@@ -154,13 +154,17 @@ def test_user_defined_filter_and_macros_raise_error(admin_client, create_dag_run
     url = f'rendered-templates?task_id=task2&dag_id=testdag&execution_date={quote_plus(str(DEFAULT_DATE))}'
 
     resp = admin_client.get(url, follow_redirects=True)
+    assert resp.status_code == 200
 
-    check_content_not_in_response("echo Hello Apache Airflow", resp)
-    check_content_in_response(
+    resp_html: str = resp.data.decode("utf-8")
+    assert "echo Hello Apache Airflow" in resp_html
+    assert (
         "Webserver does not have access to User-defined Macros or Filters when "
         "Dag Serialization is enabled. Hence for the task that have not yet "
         "started running, please use &#39;airflow tasks render&#39; for "
-        "debugging the rendering of template_fields.<br><br>OriginalError: no "
-        "filter named &#39;hello&#39",
-        resp,
-    )
+        "debugging the rendering of template_fields.<br><br>"
+    ) in resp_html
+
+    # MarkupSafe changed the exception detail from 'no filter named' to

Review comment:
       :D




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org