Changelists on directories

[Hyrum K Wright <hy...@hyrumwright.org>]

Issue #3310 is about adding directory support for changelists.  As I
work through updating the way that changelists are set and unset in
wc-ng, it seems like more work to *not* allow changelists on
directories.

The issue is a bit sparse on details, so before I go changing this
behavior, I'd like to have a bit more information.  Other than simple
storage mechanisms, what other considerations came into the decision
not to allow changelists on directories?  Was there some bikeshed
which just never got painted the right color?

-Hyrum

[1] http://subversion.tigris.org/issues/show_bug.cgi?id=3310

Re: Changelists on directories

[Greg Stein <gs...@gmail.com>]

On Mon, Apr 18, 2011 at 14:37, Hyrum K Wright <hy...@hyrumwright.org> wrote:
>...
> But this could just be my simplistic, cli-centric, anglophile brain
> talking here.  If there is a simple solution, let's do it.  If we need
> to make a relatively simple decision, let'd make it.  If we need to
> debate it for a while (which I'm not opposed to, if needed), let's
> table it and I'll work on more important stuff.

I vote to punt the design process to post-1.7.

Cheers,
-g

Re: Changelists on directories

[Hyrum K Wright <hy...@hyrumwright.org>]

On Mon, Apr 18, 2011 at 1:15 PM, C. Michael Pilato <cm...@collab.net> wrote:
> On 04/18/2011 02:05 PM, Hyrum K Wright wrote:
>> The issue is a bit sparse on details, so before I go changing this
>> behavior, I'd like to have a bit more information.  Other than simple
>> storage mechanisms, what other considerations came into the decision
>> not to allow changelists on directories?  Was there some bikeshed
>> which just never got painted the right color?
>
> First thing that comes to mind is pretty straightforward:
>
>   $ svn cl my-changelist dir
>   $ svn pset my-prop my-value dir
>   $ cat "New line of text." >> dir/file
>   $ svn ci --cl my-changelist
>
> Do we, or do we not, commit dir/file?

My gut reaction would be changelists should act like a built-in list
of targets, similar to using the '--targets' option.  Putting
something in a changelist should simply be shorthand for specifying it
on the command line.  I don't think there is any ambiguity about:
  $ svn ci dir

nor:
  $ echo 'dir' > targets
  $ svn ci --targets targets

But this could just be my simplistic, cli-centric, anglophile brain
talking here.  If there is a simple solution, let's do it.  If we need
to make a relatively simple decision, let'd make it.  If we need to
debate it for a while (which I'm not opposed to, if needed), let's
table it and I'll work on more important stuff.

-Hyrum

Re: Changelists on directories

["C. Michael Pilato" <cm...@collab.net>]

On 04/18/2011 02:05 PM, Hyrum K Wright wrote:
> The issue is a bit sparse on details, so before I go changing this
> behavior, I'd like to have a bit more information.  Other than simple
> storage mechanisms, what other considerations came into the decision
> not to allow changelists on directories?  Was there some bikeshed
> which just never got painted the right color?

First thing that comes to mind is pretty straightforward:

   $ svn cl my-changelist dir
   $ svn pset my-prop my-value dir
   $ cat "New line of text." >> dir/file
   $ svn ci --cl my-changelist

Do we, or do we not, commit dir/file?

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

RE: Changelists on directories

[Bert Huijben <be...@qqmail.nl>]

> -----Original Message-----
> From: Hyrum K Wright [mailto:hyrum@hyrumwright.org]
> Sent: maandag 18 april 2011 20:06
> To: Subversion Development
> Subject: Changelists on directories
> 
> Issue #3310 is about adding directory support for changelists.  As I
> work through updating the way that changelists are set and unset in
> wc-ng, it seems like more work to *not* allow changelists on
> directories.
> 
> The issue is a bit sparse on details, so before I go changing this
> behavior, I'd like to have a bit more information.  Other than simple
> storage mechanisms, what other considerations came into the decision
> not to allow changelists on directories?  Was there some bikeshed
> which just never got painted the right color?

This was discussed in the last weeks/months before releasing 1.5.

The problem here is that we don't know how certain operations should behave.

Things like:
* What should a 'svn commit' do with one directory in a changelist and an
entire tree full of changes?
(Current behavior is that 'commit' commits all directories and only files in
the changelist below all targets)

* How should a delete work when you combine depth with changelists like 'svn
rm --changelist Q --depth=files DIR'? 
(Delete the directory; or just the files below it? Something else?)

* What should a 'svn revert --depth=files --changelist Q DIR' do?

Instead of enabling it without thinking about it, we decided to disable it
for 1.5. 

That way we could later enable it without breaking backwards compatibility.

	Bert