[GitHub] [cassandra] maedhroz commented on a diff in pull request #1621: CASSANDRA-17623 - Fix issue where frozen maps may not be serialized in the correct order

[GitBox <gi...@apache.org>]

maedhroz commented on code in PR #1621:
URL: https://github.com/apache/cassandra/pull/1621#discussion_r874163058


##########
test/unit/org/apache/cassandra/cql3/CQLTester.java:
##########
@@ -1429,6 +1430,13 @@ protected void assertRowsNet(ProtocolVersion protocolVersion, ResultSet result,
                                         rows.length>i ? "less" : "more", rows.length, i, protocolVersion), i == rows.length);
     }
 
+    protected void assertRowCountNet(ResultSet r1, int expectedCount)
+    {
+        Assert.assertFalse("Received a null resultset when expected count was > 0", expectedCount > 0 && r1 == null);
+        final int actualRowCount = Iterables.size(r1);

Review Comment:
   super nit: could ditch the `final`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org