You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "RobertIndie (via GitHub)" <gi...@apache.org> on 2023/08/24 13:29:01 UTC

[GitHub] [pulsar] RobertIndie commented on pull request #21061: [fix][broker]fix 'Observable Timing Discrepancy' vulnerability by replacing String.equals

RobertIndie commented on PR #21061:
URL: https://github.com/apache/pulsar/pull/21061#issuecomment-1691678891

   
   > I saw the Pulsar CI / Build and License check (pull_request) has been failed. Is there anything shall I change?I saw the Pulsar CI / Build and License check (pull_request) has been failed. Is there anything shall I change?
   
   @Crispy-fried-chicken Yes, you need to fix the code style issue:
   
   ```
   Error:  src/main/java/org/apache/pulsar/broker/authentication/SaslRoleTokenSigner.java:[79,9] (whitespace) WhitespaceAround: 'if' is not followed by whitespace.
   Error:  src/main/java/org/apache/pulsar/broker/authentication/SaslRoleTokenSigner.java:[79,63] (whitespace) WhitespaceAfter: ',' is not followed by whitespace.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org