[GitHub] ctubbsii commented on a change in pull request #479: More intellij automated fixes

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #479: More intellij automated fixes
URL: https://github.com/apache/accumulo/pull/479#discussion_r186915619
 
 

 ##########
 File path: server/base/src/test/java/org/apache/accumulo/server/util/FileSystemMonitorTest.java
 ##########
 @@ -37,7 +37,7 @@
 
   @Test
   public void testFilteredMountEntries() throws Exception {
-    String[] mountEntries = new String[] {"rootfs / rootfs rw 0 0",
+    String[] mountEntries = {"rootfs / rootfs rw 0 0",
 
 Review comment:
   Thoughts: I really wonder about the portability of this FileSystemMonitor. It seems dubious. I'm not even sure if it works properly with systemd or recognizes m.2 and nvme drives. The FileSystemMonitor seems more like a monitoring utility which should exist separate from Accumulo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services