You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "techdocsmith (via GitHub)" <gi...@apache.org> on 2023/05/17 20:30:20 UTC

[GitHub] [druid] techdocsmith commented on a diff in pull request #14225: Clarify compaction docs.

techdocsmith commented on code in PR #14225:
URL: https://github.com/apache/druid/pull/14225#discussion_r1197020780


##########
docs/data-management/automatic-compaction.md:
##########
@@ -116,10 +116,10 @@ The following properties are automatically set by the Coordinator:
 * `context`: Set according to the user-provided `taskContext`.
 
 Compaction tasks fetch all [relevant segments](compaction.md#compaction-io-configuration) prior to launching any subtasks,
-_unless_ the following items are all set. It is strongly recommended to set all of these items to maximize performance
-and minimize disk usage of the `compact` tasks launched by auto-compaction:
+_unless_ the following items are all set. It is strongly recommended to set all of these items to non-null values to

Review Comment:
   I think for `JSON` prefer `properties` over item.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org