[GitHub] [avro] aromanenko-dev commented on a diff in pull request #2137: [AVRO-2943] Add new GenericData String/Utf8 ARRAY comparison test

["aromanenko-dev (via GitHub)" <gi...@apache.org>]

aromanenko-dev commented on code in PR #2137:
URL: https://github.com/apache/avro/pull/2137#discussion_r1132377399


##########
lang/java/avro/src/test/java/org/apache/avro/generic/TestGenericData.java:
##########
@@ -198,6 +198,25 @@ public void testMapValuesEquals() {
     assertEquals(r1, r0);
   }
 
+  @Test
+  public void testArrayValuesEqualsStringAndUtf8Compatibility() {
+    Schema arrayElementSchema = new Schema.Parser().parse("{\"type\": \"string\"}");

Review Comment:
   Why don't you use the full schema description for type `array`, like for similar `map` test above?
   According to [type specification](Just a side question - why here we use the full schema description for type `map` and not ) they have a similar description, don't they?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org