You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "kennknowles (via GitHub)" <gi...@apache.org> on 2023/05/01 19:48:42 UTC
[GitHub] [beam] kennknowles opened a new pull request, #26490: Remove experimental annotation from Beam
kennknowles opened a new pull request, #26490:
URL: https://github.com/apache/beam/pull/26490
Drop @Experimental annotations and concept from Beam. Discussion occurred at https://lists.apache.org/thread/tvvdckdom8jtv2xr9mzg0ltjjpbmydrv.
Largely automated change. There are likely mentions in comments and elsewhere that will have follow-up changes to clean up the conceptual framework.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a diff in pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on code in PR #26490:
URL: https://github.com/apache/beam/pull/26490#discussion_r1183113803
##########
sdks/python/apache_beam/utils/annotations.py:
##########
@@ -192,10 +190,4 @@ def inner(*args, **kwargs):
# 'current' will be optional in both deprecated and experimental
# while 'since' will be mandatory for deprecated.
deprecated = partial(
- annotate, label='deprecated', current=None, extra_message=None)
-experimental = partial(
- annotate,
- label='experimental',
- current=None,
- since=None,
- extra_message=None)
+ annotate, label='deprecated', current=None, extra_message=None)
Review Comment:
I just ran `yapf` over the whole codebase according to https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-Runningyapfformattermanually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530421691
Run PythonLint PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles merged PR #26490:
URL: https://github.com/apache/beam/pull/26490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540565743
Run Java_IOs_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a diff in pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on code in PR #26490:
URL: https://github.com/apache/beam/pull/26490#discussion_r1183085334
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowProfilingOptions.java:
##########
@@ -18,14 +18,12 @@
package org.apache.beam.runners.dataflow.options;
import java.util.HashMap;
-import org.apache.beam.sdk.annotations.Experimental;
import org.apache.beam.sdk.options.Description;
import org.apache.beam.sdk.options.Hidden;
import org.apache.beam.sdk.options.PipelineOptions;
/** Options for controlling profiling of pipeline execution. */
@Description("[Experimental] Used to configure profiling of the Dataflow pipeline")
Review Comment:
Agree! Thank you.
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -1059,12 +1058,11 @@ message StandardCoders {
// Logical types understood by all SDKs should be defined in schema.proto.
// Example of well known logical types:
// beam:logical_type:schema:v1
- // - Representation type: BYTES
+ // - Representation type: BYTE
Review Comment:
Curious and not intended for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dspasic commented on a diff in pull request #26490: Remove experimental annotation from Beam
Posted by "dspasic (via GitHub)" <gi...@apache.org>.
dspasic commented on code in PR #26490:
URL: https://github.com/apache/beam/pull/26490#discussion_r1181947394
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowProfilingOptions.java:
##########
@@ -18,14 +18,12 @@
package org.apache.beam.runners.dataflow.options;
import java.util.HashMap;
-import org.apache.beam.sdk.annotations.Experimental;
import org.apache.beam.sdk.options.Description;
import org.apache.beam.sdk.options.Hidden;
import org.apache.beam.sdk.options.PipelineOptions;
/** Options for controlling profiling of pipeline execution. */
@Description("[Experimental] Used to configure profiling of the Dataflow pipeline")
Review Comment:
I would suggest to remove the experimental from the description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530421444
Run Java_IOs_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540528896
Resolved conflicts and pushed. So all the tests need to re-run anyhow. The problem was a known timeout in the GitHub Actions workflows. We will see if we can get it green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530423253
Run SQL_Java17 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26490: Remove experimental annotation from Beam
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1532316512
Test failure related:
```
19:29:10 > Task :sdks:java:extensions:sql:zetasql:buildDependents
19:29:10
19:29:10 FAILURE: Build failed with an exception.
19:29:10
19:29:10 * What went wrong:
19:29:10 Execution failed for task ':sdks:java:extensions:sql:jdbc:analyzeClassesDependencies'.
19:29:10 > Dependency analysis found issues.
19:29:10 unusedDeclaredArtifacts
19:29:10 - beam.sdks.java:core:2.48.0-SNAPSHOT@jar
```
it appears that extensions-sql-setasql no longer directly depends on java core
and a couple of whitespace and spotless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #26490: Remove experimental annotation from Beam
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1531628079
assign to next reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1538703379
Java_Spark3_Versions failed with gradle executor dying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on a diff in pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on code in PR #26490:
URL: https://github.com/apache/beam/pull/26490#discussion_r1181907470
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -1059,12 +1058,11 @@ message StandardCoders {
// Logical types understood by all SDKs should be defined in schema.proto.
// Example of well known logical types:
// beam:logical_type:schema:v1
- // - Representation type: BYTES
+ // - Representation type: BYTE
Review Comment:
Doesn't seem related to the purpose of the PR -- but OK anyways
##########
sdks/python/apache_beam/utils/annotations_test.py:
##########
@@ -101,51 +100,6 @@ def fnc_test_deprecated_without_since_custom_should_fail():
fnc_test_deprecated_without_since_custom_should_fail()
assert not w
- def test_experimental_with_current_message(self):
- with warnings.catch_warnings(record=True) as w:
-
- @experimental(current='multiply', extra_message='Do this')
- def fnc_test_experimental_with_current_message():
- return 'lol'
Review Comment:
lol
##########
sdks/python/apache_beam/utils/annotations.py:
##########
@@ -192,10 +190,4 @@ def inner(*args, **kwargs):
# 'current' will be optional in both deprecated and experimental
# while 'since' will be mandatory for deprecated.
deprecated = partial(
- annotate, label='deprecated', current=None, extra_message=None)
-experimental = partial(
- annotate,
- label='experimental',
- current=None,
- since=None,
- extra_message=None)
+ annotate, label='deprecated', current=None, extra_message=None)
Review Comment:
do we not care about newlines at end of file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530353375
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540736908
[org.apache.beam.sdk.io.gcp.spanner.SpannerReadIT.testReadWithDataBoost](https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Commit/2569/testReport/junit/org.apache.beam.sdk.io.gcp.spanner/SpannerReadIT/testReadWithDataBoost/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540975434
[org.apache.beam.sdk.io.gcp.spanner.SpannerReadIT.testReadWithDataBoost](https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Phrase/148/testReport/junit/org.apache.beam.sdk.io.gcp.spanner/SpannerReadIT/testReadWithDataBoost/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530422745
Run SQL_Java11 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] liferoad commented on pull request #26490: Remove experimental annotation from Beam
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530189100
Will we release this in Beam 2.48.0? If so, can we update the `CHANGES.md`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1538704575
Cassandra and SQL+Java17 actually were hung jobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1538704770
Run SQL_Java17 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on a diff in pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on code in PR #26490:
URL: https://github.com/apache/beam/pull/26490#discussion_r1183115288
##########
sdks/python/apache_beam/utils/annotations.py:
##########
@@ -192,10 +190,4 @@ def inner(*args, **kwargs):
# 'current' will be optional in both deprecated and experimental
# while 'since' will be mandatory for deprecated.
deprecated = partial(
- annotate, label='deprecated', current=None, extra_message=None)
-experimental = partial(
- annotate,
- label='experimental',
- current=None,
- since=None,
- extra_message=None)
+ annotate, label='deprecated', current=None, extra_message=None)
Review Comment:
makes sense, then isn't part of the config -- definitely don't want to be nitpicky [ manually ] about such things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530422345
Run SQL PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530421170
Run Java_Hbase_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1538701612
Failures, from java precommit:
- [org.apache.beam.runners.flink.FlinkRequiresStableInputTest.testParDoRequiresStableInputPortable](https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/27103/testReport/junit/org.apache.beam.runners.flink/FlinkRequiresStableInputTest/testParDoRequiresStableInputPortable/)
- [org.apache.beam.runners.flink.FlinkRequiresStableInputTest.testParDoRequiresStableInputStatefulPortable](https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/27103/testReport/junit/org.apache.beam.runners.flink/FlinkRequiresStableInputTest/testParDoRequiresStableInputStatefulPortable/)
- [org.apache.beam.sdk.util.UnboundedScheduledExecutorServiceTest.testThreadsAreAddedOnlyAsNeededWithContention](https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/27103/testReport/junit/org.apache.beam.sdk.util/UnboundedScheduledExecutorServiceTest/testThreadsAreAddedOnlyAsNeededWithContention/)
They all look like unrelated flakes to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540543045
> The problem was a known timeout in the GitHub Actions workflows. We will see if we can get it green.
The "known timeout" ... is this something we have some ability to do anything about. Ex: if we run some 'self-hosted' runners [ https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners ]? I don't know enough about the issue. Happy to help configure things, sort out a solution, assuming there is some good docs on the known issue and we believe there might be a solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540566320
RabbitMQ failed to come up for the tests. I'll check if it fails again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540992561
I think we've kicked the flakes enough times here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540975631
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540738431
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1538704967
Run Java_Cassandra_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1538701736
run java precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26490: Remove experimental annotation from Beam
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530157121
## [Codecov](https://codecov.io/gh/apache/beam/pull/26490?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26490](https://codecov.io/gh/apache/beam/pull/26490?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0ec437) into [master](https://codecov.io/gh/apache/beam/commit/f343b819d7e9254c7a8dca83bae2bcca61e7ee2e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f343b81) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #26490 +/- ##
=======================================
Coverage 71.93% 71.94%
=======================================
Files 752 752
Lines 101696 101677 -19
=======================================
- Hits 73158 73149 -9
+ Misses 27042 27032 -10
Partials 1496 1496
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `81.14% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 20 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26490/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26490: Remove experimental annotation from Beam
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530269479
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @jrmccluskey for label python.
R: @Abacn for label java.
R: @Abacn for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1532253122
I did another pass and eliminated a very large number of occurrences in comments. I also reverted a couple weird changes that did not belong, and added a note to CHANGES.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] brucearctor commented on pull request #26490: Remove experimental annotation from Beam
Posted by "brucearctor (via GitHub)" <gi...@apache.org>.
brucearctor commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1530420605
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26490: Remove experimental annotation from Beam
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1531630735
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label python.
R: @Abacn for label java.
R: @Abacn for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1533434374
- Fixed Python lint manually. I guess `yapf` doesn't automatically fix it :-/
- Removed whitespace from `CHANGES.md`
- Ran `spotlessApply`
- Fixed deps until `analyzeClassesDependencies` for SQL but having some weird stuff in the Kafka IT area:
```
* What went wrong:
Execution failed for task ':sdks:java:io:kafka:kafka-01103:analyzeClassesDependencies'.
> Dependency analysis found issues.
unusedDeclaredArtifacts
- beam.sdks.java.io:kafka:2.48.0-SNAPSHOT@jar
- org.apache.kafka:kafka-clients:2.4.1@jar
```
It also seems we are generating gradle projects that do not match directories. This is going to cause a real headache in the future since it is not intended usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1538703482
Run Java_Spark3_Versions PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540738226
@darshan-sj saw the above failure in Spanner databoost and I noticed you authored #26007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540902392
[org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOWriteTest.testTriggeredFileLoadsWithTempTablesToExistingNullSchemaTable[1]](https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Phrase/147/testReport/junit/org.apache.beam.sdk.io.gcp.bigquery/BigQueryIOWriteTest/testTriggeredFileLoadsWithTempTablesToExistingNullSchemaTable_1_/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #26490: Remove experimental annotation from Beam
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #26490:
URL: https://github.com/apache/beam/pull/26490#issuecomment-1540902574
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org