[jira] [Updated] (SOLR-7262) Registering / changing request handlers not thread safe

["Yonik Seeley (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-7262:
-------------------------------
    Attachment: SOLR-7262.patch

OK, so it looks like SOLR-7073 consolidated different types of plugin loading into one mechanism/container.  Some of them were thread safe (request handlers) and most were not.

I didn't change everything to thread safe because it could have performance implications... there can be dozens or more lookups to all these plugins per request.  For now, I've only enabled thread safety (for writes) for request handlers.

Patch attached.

> Registering / changing request handlers not thread safe
> -------------------------------------------------------
>
>                 Key: SOLR-7262
>                 URL: https://issues.apache.org/jira/browse/SOLR-7262
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>         Attachments: SOLR-7262.patch
>
>
> Here's part of the javadoc for RequestHandlers.register()
> {code}
>    * This call is thread safe.
>    * 
>    * @return the previous handler at the given path or null
>    */
>   public SolrRequestHandler register( String handlerName, SolrRequestHandler handler ) {
> {code}
> But looking at the changes from SOLR-7073, this is clearly not the case (it's no longer thread safe).  Was this thread safety removed on purpose or was it accidental?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org