You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xalan.apache.org by cu...@apache.org on 2002/03/11 14:28:32 UTC
cvs commit: xml-xalan/test/java/src/org/apache/qetest FileTestlet.java
curcuru 02/03/11 05:28:32
Modified: test/java/src/org/apache/qetest FileTestlet.java
Log:
Clean up logging messages; more explicit comments
Revision Changes Path
1.2 +8 -5 xml-xalan/test/java/src/org/apache/qetest/FileTestlet.java
Index: FileTestlet.java
===================================================================
RCS file: /home/cvs/xml-xalan/test/java/src/org/apache/qetest/FileTestlet.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- FileTestlet.java 5 Mar 2002 21:25:32 -0000 1.1
+++ FileTestlet.java 11 Mar 2002 13:28:32 -0000 1.2
@@ -71,7 +71,7 @@
* the output to a known good gold file.
*
* @author Shane_Curcuru@us.ibm.com
- * @version $Id: FileTestlet.java,v 1.1 2002/03/05 21:25:32 curcuru Exp $
+ * @version $Id: FileTestlet.java,v 1.2 2002/03/11 13:28:32 curcuru Exp $
*/
public class FileTestlet extends TestletImpl
{
@@ -161,12 +161,12 @@
try
{
boolean btmp = (new File(output)).delete();
- logger.logMsg(Logger.TRACEMSG, "Deleting OutFile of::" + output
+ logger.logMsg(logger.TRACEMSG, "initDatalet delete: " + output
+ " status: " + btmp);
}
catch (SecurityException se)
{
- logger.logMsg(Logger.WARNINGMSG, "Deleting OutFile of::" + output
+ logger.logMsg(logger.WARNINGMSG, "initDatalet delete: " + output
+ " threw: " + se.toString());
}
}
@@ -216,7 +216,7 @@
if (null == fileChecker)
{
String clazzName = datalet.getOptions().getProperty("fileChecker");
- if (!(null == clazzName))
+ if (null != clazzName)
{
// ...find and create a class of the default classname given
Class fClazz = QetestUtils.testClassForName(clazzName, QetestUtils.defaultPackages, null);
@@ -228,7 +228,10 @@
fileChecker = QetestFactory.newCheckService(logger, QetestFactory.TYPE_FILES);
}
// Apply any testing options to the fileChecker
- fileChecker.applyAttributes(datalet.getOptions());
+ fileChecker.applyAttributes(datalet.getOptions());
+ // Note assumption that if we got the fileCheckerImpl
+ // directly from the datalet that we do not need to
+ // set the Attributes here again
}
int result = fileChecker.check(logger,
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-cvs-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-cvs-help@xml.apache.org