Re: [PR] [SPARK-46487][SQL] Push down part of filter through aggregate with nondeterministic field [spark]

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on PR #44460:
URL: https://github.com/apache/spark/pull/44460#issuecomment-1919151613

   I checked the aggregate execution implementation. Basically, it has an embedded `Project` operator and applies the result projection for aggregated values. That said, I think it has the same property as `Project` and we shouldn't relax the requirement.
   
   On the other hand, the aggregate operator itself is already non-deterministic, as the output row order is different between hash and sort aggregate. But we shouldn't make it worse.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org