[GitHub] [hudi] xushiyan commented on a change in pull request #5143: [HUDI-2520] Fix drop table issue when sync to Hive

[GitBox <gi...@apache.org>]

xushiyan commented on a change in pull request #5143:
URL: https://github.com/apache/hudi/pull/5143#discussion_r836103540



##########
File path: hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieCatalog.scala
##########
@@ -116,7 +116,10 @@ class HoodieCatalog extends DelegatingCatalogExtension
 
   override def tableExists(ident: Identifier): Boolean = super.tableExists(ident)
 
-  override def dropTable(ident: Identifier): Boolean = super.dropTable(ident)
+  override def dropTable(ident: Identifier): Boolean = {
+    DropHoodieTableCommand(ident.asTableIdentifier, ifExists = true, isView = false, purge = false).run(spark)
+    true
+  }

Review comment:
       @leesf there are other `super.dropTable()` usage in this class, should change them too?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org