You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/07/02 12:10:19 UTC

[GitHub] [calcite] zinking commented on a change in pull request #1641: [CALCITE-3549] Lex config for view & materialized view & lattice expa…

zinking commented on a change in pull request #1641:
URL: https://github.com/apache/calcite/pull/1641#discussion_r448955040



##########
File path: core/src/main/java/org/apache/calcite/materialize/Lattice.java
##########
@@ -501,6 +514,11 @@ public boolean isAlwaysMeasure(Column column) {
     return !columnUses.get(column.ordinal).contains(false);
   }
 
+  /** Specifies the dialect used to generate SQL query when populate tile. */
+  public static SqlDialect dialectUsedToGenerateSqlWhenPopulateTile() {

Review comment:
       this naming is really just in-consistent with calcite. 
   what makes it worse is that this is a public static method. 
   
   is getDialect significantly worse ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org