You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/03 20:43:46 UTC
[GitHub] [lucene-solr] orenovadia opened a new pull request #2298: LUCENE-9680 - Backport to 8x - Remove deprecation from getFieldNames
orenovadia opened a new pull request #2298:
URL: https://github.com/apache/lucene-solr/pull/2298
In [LUCENE-9680](https://issues.apache.org/jira/browse/LUCENE-9680) we re-added `IW::getFieldNames` back to `master`. The method still exists in 8x, so this simply removes the deprecation annotation.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand commented on pull request #2298: LUCENE-9680 - Backport to 8x - Remove deprecation from getFieldNames
Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #2298:
URL: https://github.com/apache/lucene-solr/pull/2298#issuecomment-772819746
Looks great, thanks @orenovadia -- I'll merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand merged pull request #2298: LUCENE-9680 - Backport to 8x - Remove deprecation from getFieldNames
Posted by GitBox <gi...@apache.org>.
mikemccand merged pull request #2298:
URL: https://github.com/apache/lucene-solr/pull/2298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] orenovadia commented on pull request #2298: LUCENE-9680 - Backport to 8x - Remove deprecation from getFieldNames
Posted by GitBox <gi...@apache.org>.
orenovadia commented on pull request #2298:
URL: https://github.com/apache/lucene-solr/pull/2298#issuecomment-772872719
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org