You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/25 19:49:49 UTC

[GitHub] [spark] MaxGekk opened a new pull request, #38805: [MINOR][SQL] Fix the pretty name of the `AnyValue` expression

MaxGekk opened a new pull request, #38805:
URL: https://github.com/apache/spark/pull/38805

   ### What changes were proposed in this pull request?
   In the PR, I propose to override the `prettyName` method of the `AnyValue` expression and set to `any_value` by default as in `FunctionRegistry`:
   https://github.com/apache/spark/blob/40b7d29e14cfa96984c5b0a231a75b210dd85a7e/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L466
   
   ### Why are the changes needed?
   To don't confuse users by non-existent function name.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, it could be.
   
   ### How was this patch tested?
   By running the affected test suite:
   ```
   $ build/sbt "sql/testOnly *ExpressionsSchemaSuite"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #38805: [MINOR][SQL] Fix the pretty name of the `AnyValue` expression

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38805:
URL: https://github.com/apache/spark/pull/38805#issuecomment-1328188122

   Merging to master. Thank you, @srowen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk closed pull request #38805: [MINOR][SQL] Fix the pretty name of the `AnyValue` expression

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38805: [MINOR][SQL] Fix the pretty name of the `AnyValue` expression
URL: https://github.com/apache/spark/pull/38805


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org