You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/03/17 23:50:51 UTC
Review Request 44990: GEODE-947 Client log message misleading
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44990/
-----------------------------------------------------------
Review request for geode, Darrel Schneider, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
Logging of local-mode or client-mode is now done in GemFireCacheImpl when the cache is created. If there is a connection pool or the cache is marked isClient we want to say it's running in client-mode. If it's not in client-mode and the DistributedSystem is not actually configured to be able to distribute anything we say it's running in local-mode.
I corrected the text of the local-mode message to remove the reference to multicast since multicast discovery is not supported in Geode.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 201acc015bf1729fbfacb03e68fa1c2f0fdb7e09
geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java 248353fe6130d27c109b1c738de99b40512876ea
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LogWriterFactory.java f08847abd5ed9f11441eefbb0de2b9c0d52028f9
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterAppenders.java 7dd936614142343f9e660be212868678154b5526
geode-core/src/test/java/com/gemstone/gemfire/internal/logging/TestLogWriterFactory.java 4c46503d3f773f4cb5c3a2c35bdae2090f9ac0ca
Diff: https://reviews.apache.org/r/44990/diff/
Testing
-------
precheckin testing is underway
Thanks,
Bruce Schuchardt
Re: Review Request 44990: GEODE-947 Client log message misleading
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44990/#review124118
-----------------------------------------------------------
Ship it!
Ship It!
- Jianxia Chen
On March 17, 2016, 10:50 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44990/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 10:50 p.m.)
>
>
> Review request for geode, Darrel Schneider, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Logging of local-mode or client-mode is now done in GemFireCacheImpl when the cache is created. If there is a connection pool or the cache is marked isClient we want to say it's running in client-mode. If it's not in client-mode and the DistributedSystem is not actually configured to be able to distribute anything we say it's running in local-mode.
>
> I corrected the text of the local-mode message to remove the reference to multicast since multicast discovery is not supported in Geode.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 201acc015bf1729fbfacb03e68fa1c2f0fdb7e09
> geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java 248353fe6130d27c109b1c738de99b40512876ea
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/LogWriterFactory.java f08847abd5ed9f11441eefbb0de2b9c0d52028f9
> geode-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/LogWriterAppenders.java 7dd936614142343f9e660be212868678154b5526
> geode-core/src/test/java/com/gemstone/gemfire/internal/logging/TestLogWriterFactory.java 4c46503d3f773f4cb5c3a2c35bdae2090f9ac0ca
>
> Diff: https://reviews.apache.org/r/44990/diff/
>
>
> Testing
> -------
>
> precheckin testing is underway
>
>
> Thanks,
>
> Bruce Schuchardt
>
>