You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by johnnyws <gi...@git.apache.org> on 2016/03/25 05:19:22 UTC
[GitHub] incubator-zeppelin pull request: remove overwritten style for p
GitHub user johnnyws opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/797
remove overwritten style for p
### What is this PR for?
I don't know why we overwrite `p` in paragraph.css, but the layout is much nicer for markdown paragraphs
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
[ZEPPELIN-649](https://issues.apache.org/jira/browse/ZEPPELIN-649)
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
NO
* Is there breaking changes for older versions?
NO
* Does this needs documentation?
NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnnyws/incubator-zeppelin seraph/fix-md-paragraph
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/797.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #797
----
commit 6578e5f25dda609a3b13af7365ae59f5d3bd202a
Author: johnnyws <jz...@gmail.com>
Date: 2016-03-25T03:59:22Z
remove overwritten style for p
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: remove overwritten style for p
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-203052062
ah nice! thanks for the fix. @corneadoug any comment on this css fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: remove overwritten style for p
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-203189083
I didn't see any effect on other part of the app, so LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: remove overwritten style for p
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-204643388
@johnnyws what's your JIRA account name? Would like to assign this fix to you. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: remove overwritten style for p
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-201420701
could you share a before/after screenshot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: remove overwritten style for p
Posted by johnnyws <gi...@git.apache.org>.
Github user johnnyws commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-202698867
@felixcheung sorry for the delay. I've uploaded the screenshots
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: remove overwritten style for p
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-204068612
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: remove overwritten style for p
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/797
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---