You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/03 01:14:36 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #19508: :bug: (BigQueryHook) fix compatibility with sqlalchemy engine

mik-laj commented on a change in pull request #19508:
URL: https://github.com/apache/airflow/pull/19508#discussion_r798141866



##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -161,6 +161,23 @@ def get_client(self, project_id: Optional[str] = None, location: Optional[str] =
             credentials=self._get_credentials(),
         )
 
+    def get_uri(self) -> str:
+        """Override DbApiHook get_uri method for get_sqlalchemy_engine()"""
+        return "bigquery://"

Review comment:
       You need to update setup.py https://github.com/apache/airflow/blob/d353f023ff8856c00b9f054526cb2e40ff0116ae/setup.py#L294-L346




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org