You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:43:28 UTC

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #1134: add python binding for `approx_distinct` aggregate function

Jimexist opened a new pull request #1134:
URL: https://github.com/apache/arrow-datafusion/pull/1134


   # Which issue does this PR close?
   
   add python binding for `approx_distinct` aggregate function
   
   Closes #1133 
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] houqp commented on pull request #1134: add python binding for `approx_distinct` aggregate function

Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1134:
URL: https://github.com/apache/arrow-datafusion/pull/1134#issuecomment-944928081


   the diff seems to include changes from the lit fix pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] houqp merged pull request #1134: add python binding for `approx_distinct` aggregate function

Posted by GitBox <gi...@apache.org>.
houqp merged pull request #1134:
URL: https://github.com/apache/arrow-datafusion/pull/1134


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] houqp edited a comment on pull request #1134: add python binding for `approx_distinct` aggregate function

Posted by GitBox <gi...@apache.org>.
houqp edited a comment on pull request #1134:
URL: https://github.com/apache/arrow-datafusion/pull/1134#issuecomment-944928081


   the diff seems to include changes from the lit fix pr.
   
   EDIT: never mind, you already mentioned this in the PR description :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org