You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kathey Marsden (JIRA)" <de...@db.apache.org> on 2005/08/18 15:48:54 UTC
[jira] Created: (DERBY-515) Network Server should log server start and shutdown time to derby.log
Network Server should log server start and shutdown time to derby.log
---------------------------------------------------------------------
Key: DERBY-515
URL: http://issues.apache.org/jira/browse/DERBY-515
Project: Derby
Type: Improvement
Components: Network Server
Versions: 10.2.0.0, 10.1.1.1
Reporter: Kathey Marsden
Fix For: 10.2.0.0, 10.1.1.1
Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (DERBY-515) Network Server should log server start and shutdown time to derby.log
Posted by Deepa Remesh <dr...@gmail.com>.
>
> With this patch, I ran derbynetmats and derbynetclientmats with Sun JDK1.4.2. 1 failure in derbynetmats (jdbcapi/checkDataSource30.java) also seen in tinderbox tests.
>
Sorry. A small correction. I got failure in
jdbcapi/checkDataSource30.java in derbynetclientmats suite not
derbynetmats.
[jira] Updated: (DERBY-515) Network Server should log server start
and shutdown time to derby.log
Posted by "Deepa Remesh (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Deepa Remesh updated DERBY-515:
-------------------------------
Other Info: [Patch available]
Thanks Bryan for reading patch2.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-515) Network Server should log server start and shutdown time to derby.log
Posted by "Deepa Remesh (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Deepa Remesh updated DERBY-515:
-------------------------------
Attachment: derby-515.diff
derby-515.status
Attaching a patch 'derby-515.diff' which does the following:
* Adds timestamp to server start and shutdown messages written to derby.log and console. Timestamp formatting is done in the same way as it is done for Derby boot message.
* Adds additional parameters to start and shutdown messages in the properties files.
* Modifies test output of derbynet/NSinSameJVM.java and derbynet/testProperties.java
Ran derbyall with Sun JDK 1.4.2 on Windows XP. No failures. Please review/commit this patch. Thanks.
For the issue mentioned by Oystein "This would be even more helpful if the derby.log file was not overwritten on the next startup. (Probably a separate issue)." - property derby.infolog.append can be used to avoid overwriting derby.log file.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515.diff, derby-515.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12362113 ]
Kathey Marsden commented on DERBY-515:
--------------------------------------
A few thoughts looking at this patch. I am interested in input from others.
1) I think maybe we should print the time on the same line because it doesn't look clear what the time is associated with, particularly for shutdown.
2) For the messages, I think it is ok to checkin just the English message and wait for someone with interest to translate particularly if the first parameter stays the same (see 3)
3) Maybe now that the startup and shutdown messages are printing to the log and not just the network server console, we should consider something more descriptive for our start and shutdown messages. Perhaps:
Apache Derby Network Server - 10.2.0.0 started and ready to accept connections on port 1527 at 2006-01-08 05:46:31.527 GMT
Apache Derby Network Server - 10.2.0.0 shutdown at 2006-01-08 05:46:31.527 GMT
------ derby.log output --------------------
2006-01-08 05:46:31.527 GMT:
Server is ready to accept connections on port 1527.
----------------------------------------------------------------
2006-01-08 05:46:41.021 GMT:
Booting Derby version The Apache Software Foundation - Apache Derby - 10.2.0.0
alpha - (1): instance c013800d-0108-a88d-3029-000000098a28
on database directory D:\testout\wombat
Database Class Loader started - derby.database.classpath=''
----------------------------------------------------------------
2006-01-08 05:47:13.678 GMT:
Booting Derby version The Apache Software Foundation - Apache Derby - 10.2.0.0
alpha - (1): instance a816c00e-0108-a88d-3029-000000098a28
on database directory D:\testout\wombat2
Database Class Loader started - derby.database.classpath=''
2006-01-08 06:09:44.080 GMT:
Shutdown successful.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515.diff, derby-515.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-515) Network Server should log server start
and shutdown time to derby.log
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Kathey Marsden closed DERBY-515:
--------------------------------
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by "Deepa Remesh (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12367233 ]
Deepa Remesh commented on DERBY-515:
------------------------------------
Suresh pointed out to me that this change caused the following failure in derbynetclientmats with 10.1 client and 10.2 server:
derbynetclientmats/derbynetmats/derbynetmats.fail:derbynet/testProperties.java:
(< Shutdown successful.
6a6
> Apache Derby Network Server - 10.2.0.0 alpha shutdown at xxxxxxFILTERED-TIMESTAMPxxxxxGMT
11 del
)
The diff is in the shutdown message. The test executes a process to shutdown the network server that it started. This process currently dumps results to standard out. I am planning to change this test to make the shutdown process not write to the standard output. The test can use execCmd instead of execCmdDumpResults method for the shutdown process. I will submit a patch for this in a while.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-515) Network Server should log server start and shutdown time to derby.log
Posted by "Øystein Grøvlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12319327 ]
Øystein Grøvlen commented on DERBY-515:
---------------------------------------
This would be even more helpful if the derby.log file was not overwritten on the next startup. (Probably a separate issue).
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.1.1, 10.2.0.0
> Reporter: Kathey Marsden
> Fix For: 10.1.1.1, 10.2.0.0
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-515) Network Server should log server start
and shutdown time to derby.log
Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Bryan Pendleton updated DERBY-515:
----------------------------------
Other Info: (was: [Patch available])
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12366519 ]
Bryan Pendleton commented on DERBY-515:
---------------------------------------
I think this is quite nice -- thanks!
I don't see any need to timestamp the trace or other messages
at this time. I think we should just start with the startup
and shutdown messages and get some feel for it.
Why did you choose GMT for the timestamp? Since it's intended
for a human to read, it seems like it might be slightly nicer to
display the time in the server's local timezone?
Lastly, what do you think about handling the version number in
the error message with a test-time filter, the same way that
the xxxxxxFILTERED-TIMESTAMPxxxxxx is handled, so that the master
test files would say xxxxxxFILTERED-VERSION-NUMBERxxxxxx? Presumably,
we could make it so that the software which did the filtering
verified that the version number was correct, then filtered it out;
that would mean fewer files had to change when bumping the version number.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12366972 ]
Kathey Marsden commented on DERBY-515:
--------------------------------------
Bryan, would you be willing to commit this when you get the needed accounts and karma?
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by Bryan Pendleton <bp...@amberpoint.com>.
> I chose GMT to keep it consistent with what is used for Derby boot message.
Sounds good.
> About using xxxxxxFILTERED-VERSION-NUMBERxxxxxx, I did'nt see other tests
> doing it. I saw the current pattern in tests is to add master files with
> version number to release/build.xml file. I would like to know what
> problems you see if there are more files in this list.
Sorry, I shouldn't have introduced this red herring. I was remembering
the discussion of a few weeks ago:
http://www.nabble.com/forum/ViewPost.jtp?post=2342175&framed=y
in which there were a bunch of problems due to having release-specific
values in test output, and so I was sort of inventing a new mechanism
on the spot to see if it helped.
But I don't think it does; I think you should stick with the implementation
in your current patch proposal.
So, bottom line: thumbs up from me on your patch, and thanks for answering
my questions!
thanks,
bryan
[jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by "Deepa Remesh (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12366554 ]
Deepa Remesh commented on DERBY-515:
------------------------------------
Thanks Bryan for looking at the patch.
I chose GMT to keep it consistent with what is used for Derby boot message. The network server start and shutdown messages get printed along with derby boot messages in derby.log. Something like this:
Apache Derby Network Server - 10.2.0.0 alpha started and ready to accept connections on port 1527 at 2006-02-15 21:43:13.252 GMT
----------------------------------------------------------------
2006-02-15 21:44:07.871 GMT:
Booting Derby version The Apache Software Foundation - Apache Derby - 10.2.0.0 alpha - (1): instance c013800d-0109-6faa-b988-00000015dbe8
on database directory C:\deepa\Derby\derby_testing\nwserver\testdb
Database Class Loader started - derby.database.classpath=''
Apache Derby Network Server - 10.2.0.0 alpha shutdown at 2006-02-15 21:47:02.772 GMT
If we are using local time, I think we should do it for all messages to keep it consistent in derby.log.
About using xxxxxxFILTERED-VERSION-NUMBERxxxxxx, I did'nt see other tests doing it. I saw the current pattern in tests is to add master files with version number to release/build.xml file. I would like to know what problems you see if there are more files in this list.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-515) Network Server should log server start and shutdown time to derby.log
Posted by Deepa Remesh <dr...@gmail.com>.
On 2/23/06, Bryan Pendleton <bp...@amberpoint.com> wrote:
> >> Network Server should log server start and shutdown time to derby.log
> >> ---------------------------------------------------------------------
> >>
> >> Key: DERBY-515
> >> URL: http://issues.apache.org/jira/browse/DERBY-515
>
> I am intending to (re)review and commit derby-515-patch2-v1.diff in the
> next few days.
Thanks Bryan.
>
> Deepa, one question: regarding your last comment in JIRA: that problem
> is actually being tracked as DERBY-1041, is that correct?
Yes.
>
> I just want to confirm that we think derby-515-patch2-v1.diff is ready
> to go, and we're not waiting for any additional handling of the 10.1
> compatibility issue as part of *this* change submission.
derby-515-patch2-v1.diff is ready to go. I have opened a sub-task
DERBY-1041 and submitted a patch for the 10.1 compatibility issue.
Deepa
Re: [jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by Bryan Pendleton <bp...@amberpoint.com>.
>> Network Server should log server start and shutdown time to derby.log
>> ---------------------------------------------------------------------
>>
>> Key: DERBY-515
>> URL: http://issues.apache.org/jira/browse/DERBY-515
I am intending to (re)review and commit derby-515-patch2-v1.diff in the
next few days.
Deepa, one question: regarding your last comment in JIRA: that problem
is actually being tracked as DERBY-1041, is that correct?
I just want to confirm that we think derby-515-patch2-v1.diff is ready
to go, and we're not waiting for any additional handling of the 10.1
compatibility issue as part of *this* change submission.
thanks,
bryan
[jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12366973 ]
Bryan Pendleton commented on DERBY-515:
---------------------------------------
Yes, that sounds like a fine idea. Once I am fully set up, I will review and commit this change.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-515) Network Server should log server start
and shutdown time to derby.log
Posted by "Deepa Remesh (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Deepa Remesh updated DERBY-515:
-------------------------------
Attachment: (was: derby-515.status)
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-515) Network Server should log server start
and shutdown time to derby.log
Posted by "Deepa Remesh (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Deepa Remesh updated DERBY-515:
-------------------------------
Attachment: derby-515-v2.diff
derby-515-v2.status
Attaching a revised patch 'derby-515-v2.diff' which adds timestamp to network server start and shutdown messages.
Summary of patch:
* Changes network server start and shutdown messages to include product name, version and timestamp. I changed the messages to what Kathey suggested. With the patch, messages will look like this:
Apache Derby Network Server - 10.2.0.0 alpha started and ready to accept connections on port 1527 at 2006-02-15 03:42:51.676 GMT
Apache Derby Network Server - 10.2.0.0 alpha shutdown at 2006-02-15 03:49:14.988 GMT
* Changes only English messages. The first parameter for start message is kept the same.
* Modifies NetworkServerControlImpl to pass in the additional parameters to the messages. Formatiing of timestamp is done same way as it is done for Derby boot message.
* Modifies master files.
* Since the changed master files contain version information, they are added to tools\release\build.xml so that version will get bumped at release time.
In Derby Server and Admin guide, we may have to change the messages in sample output for NsSample program. I will open another jira once this patch is reviewed and committed.
I have a couple of questions and would appreciate if someone can answer them:
1. I found that the test derbynet/NSinSameJVM.java has two masters - one for client and one for jcc driver. These masters are identical. Can we remove these and keep a single copy in top "master" folder?
2. Will it be useful to add timestamp to messages for other netwrok server commands (like trace, timeslice, maxthreads etc) ?
With this patch, I ran derbynetmats and derbynetclientmats with Sun JDK 1.4.2 on Win XP. No failures. Please take a look at this patch. Thanks.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12366714 ]
Kathey Marsden commented on DERBY-515:
--------------------------------------
I committed this patch.
I think it would be good to add a comment to the code regarding why we use CheapDateFormatter and GMT.
On your questions
1. I found that the test derbynet/NSinSameJVM.java has two masters - one for client and one for jcc driver. These masters are identical. Can we remove these and keep a single copy in top "master" folder?
Yes, that sounds like a good idea
2. Will it be useful to add timestamp to messages for other netwrok server commands (like trace, timeslice, maxthreads etc) ?
I think it would be useful for all messages to the console be timestamped, particularly for the connection messages an any exception information.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-515) Network Server should log server start
and shutdown time to derby.log
Posted by "Deepa Remesh (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Deepa Remesh updated DERBY-515:
-------------------------------
Attachment: derby-515-patch2-v1.diff
derby-515-patch2-v1.status
Attaching a second patch 'derby-515-patch2-v1.diff' for Kathey's comments. Summary of patch:
* Removes identical master files in DerbyNetClient and DerbyNet for derbynet/NSinSameJVM.java and moves it the top master directory.
* Modified tools/release/build.xml to point to the new master file.
* Adds comments as to why CheapDateFormatter and GMT is used to format timestamp. Moves formatting of timestamp to a method getFormattedTimestamp(). This will be helpful if timestamp is planned to be used for more messages as Kathey indicated. I will open a JIRA for this.
With this patch, I ran derbynetmats and derbynetclientmats with Sun JDK1.4.2. 1 failure in derbynetmats (jdbcapi/checkDataSource30.java) also seen in tinderbox tests. Please take a look at this patch. Thanks.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-515) Network Server should log server start and shutdown time to derby.log
Posted by "Deepa Remesh (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Deepa Remesh reassigned DERBY-515:
----------------------------------
Assign To: Deepa Remesh
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-515) Network Server should log server start
and shutdown time to derby.log
Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Bryan Pendleton resolved DERBY-515:
-----------------------------------
Resolution: Fixed
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12367681 ]
Bryan Pendleton commented on DERBY-515:
---------------------------------------
Committed derby-515-patch2-v1.diff to the trunk as revision 380722.
http://svn.apache.org/viewcvs?rev=380722&view=rev
This was my first commit (yay!) -- please let me know if I missed out a step.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-515) Network Server should log server start and shutdown time to derby.log
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Kathey Marsden updated DERBY-515:
---------------------------------
Fix Version: (was: 10.1.2.0)
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Fix For: 10.2.0.0
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-515) Network Server should log server start
and shutdown time to derby.log
Posted by "Deepa Remesh (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=all ]
Deepa Remesh updated DERBY-515:
-------------------------------
Attachment: (was: derby-515.diff)
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-515) Network Server should log server
start and shutdown time to derby.log
Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-515?page=comments#action_12366971 ]
Bryan Pendleton commented on DERBY-515:
---------------------------------------
I checked derby-515-patch2-v1.diff.
I thought it was a little odd that the diff contains changes to the two master files which are to be deleted. The status file is clear about the files which are to be deleted and the file which is to be added, so maybe I'm just not practiced at reading diffs which contain deleted files.
The changes to NetworkServerControlImpl.java look good to me, and the patch applied cleanly (modulo my confusion about the deleted files) and derbynet/NSinSameJVM.java passed for me with both client frameworks. So it looks good to me.
> Network Server should log server start and shutdown time to derby.log
> ---------------------------------------------------------------------
>
> Key: DERBY-515
> URL: http://issues.apache.org/jira/browse/DERBY-515
> Project: Derby
> Type: Improvement
> Components: Network Server
> Versions: 10.1.2.0, 10.2.0.0
> Reporter: Kathey Marsden
> Assignee: Deepa Remesh
> Fix For: 10.2.0.0
> Attachments: derby-515-patch2-v1.diff, derby-515-patch2-v1.status, derby-515-v2.diff, derby-515-v2.status
>
> Network server currently only reports the start and stop of network server to the console output and does not print an associated timestamp.
> It would be helpful if the start and stop times of network server were recorded in the derby.log, so there would not be a need to check t the console output.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira