You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/11/19 21:21:04 UTC

[kudu-CR] [Java] Upgrade dependencies 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14746


Change subject: [Java] Upgrade dependencies
......................................................................

[Java] Upgrade dependencies

Upgrades the Java dependencies and Gradle versions.

Major version upgrades:
- mockito 2.27.0 -> 3.1.0

Minor version upgrades:
- guava 27.1-jre -> 28.1-jre
- hamcrest 2.1 -> 2.2
- protobuf 3.7.1 -> 3.10.0
- yetus 0.10.0 -> 0.11.1

Maintenance version upgrades:
- hadoop 3.2.0 - 3.2.1
- httpClient 4.5.8 -> 4.5.10
- jetty 9.4.18.v20190429 -> 9.4.22.v20191022
- scalatest 3.0.7 -> 3.0.8

Gradle upgrades:
- gradle 5.4.1 -> 5.6.4
- gradle-errorprone-plugin 0.8 -> 1.1.1
- gradle-version 0.21.0 -> 0.27.0
- gson 2.8.5 -> 2.8.6
- nebula-clojure-plugin 8.1.1 -> 9.1.1
- protobuf-gradle-plugin 0.8.8 -> 0.8.10
- shadow 5.0.0 -> 5.2.0
- spotbugs-gradle-plugin 1.7.1 -> 2.0.1

Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
---
M java/buildSrc/build.gradle
M java/config/checkstyle/checkstyle.xml
M java/gradle/dependencies.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
5 files changed, 41 insertions(+), 45 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/14746/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [Java] Upgrade dependencies

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14746 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14746/1/java/config/checkstyle/checkstyle.xml
File java/config/checkstyle/checkstyle.xml:

PS1: 
What was the rationale for the change here?



-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 Nov 2019 21:41:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14746 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14746/2/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:

http://gerrit.cloudera.org:8080/#/c/14746/2/java/gradle/dependencies.gradle@30
PS2, Line 30:     checkstyle     : "8.26",
> Should this be in your commit message?
Done


http://gerrit.cloudera.org:8080/#/c/14746/2/java/gradle/quality.gradle
File java/gradle/quality.gradle:

http://gerrit.cloudera.org:8080/#/c/14746/2/java/gradle/quality.gradle@29
PS2, Line 29:   toolVersion = versions.checkstyle 
> Got trailing whitespace here.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 15:49:18 +0000
Gerrit-HasComments: Yes

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14746

to look at the new patch set (#2).

Change subject: [Java] Upgrade dependencies
......................................................................

[Java] Upgrade dependencies

Upgrades the Java dependencies and Gradle versions.

Major version upgrades:
- mockito 2.27.0 -> 3.1.0

Minor version upgrades:
- guava 27.1-jre -> 28.1-jre
- hamcrest 2.1 -> 2.2
- protobuf 3.7.1 -> 3.10.0
- yetus 0.10.0 -> 0.11.1

Maintenance version upgrades:
- hadoop 3.2.0 - 3.2.1
- httpClient 4.5.8 -> 4.5.10
- jetty 9.4.18.v20190429 -> 9.4.22.v20191022
- scalatest 3.0.7 -> 3.0.8

Gradle upgrades:
- gradle 5.4.1 -> 5.6.4
- gradle-errorprone-plugin 0.8 -> 1.1.1
- gradle-version 0.21.0 -> 0.27.0
- gson 2.8.5 -> 2.8.6
- nebula-clojure-plugin 8.1.1 -> 9.1.1
- protobuf-gradle-plugin 0.8.8 -> 0.8.10
- shadow 5.0.0 -> 5.2.0
- spotbugs-gradle-plugin 1.7.1 -> 2.0.1

Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
---
M java/buildSrc/build.gradle
M java/config/checkstyle/checkstyle.xml
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
6 files changed, 43 insertions(+), 45 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/14746/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14746 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 16:15:38 +0000
Gerrit-HasComments: No

[kudu-CR] [Java] Upgrade dependencies

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14746 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 18:53:32 +0000
Gerrit-HasComments: No

[kudu-CR] [Java] Upgrade dependencies

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14746 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14746/2/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:

http://gerrit.cloudera.org:8080/#/c/14746/2/java/gradle/dependencies.gradle@30
PS2, Line 30:     checkstyle     : "8.26",
Should this be in your commit message?


http://gerrit.cloudera.org:8080/#/c/14746/2/java/gradle/quality.gradle
File java/gradle/quality.gradle:

http://gerrit.cloudera.org:8080/#/c/14746/2/java/gradle/quality.gradle@29
PS2, Line 29:   toolVersion = versions.checkstyle 
Got trailing whitespace here.



-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 05:34:01 +0000
Gerrit-HasComments: Yes

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: [Java] Upgrade dependencies
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14746

to look at the new patch set (#3).

Change subject: [Java] Upgrade dependencies
......................................................................

[Java] Upgrade dependencies

Upgrades the Java dependencies and Gradle versions.

Major version upgrades:
- mockito 2.27.0 -> 3.1.0

Minor version upgrades:
- guava 27.1-jre -> 28.1-jre
- hamcrest 2.1 -> 2.2
- protobuf 3.7.1 -> 3.10.0
- yetus 0.10.0 -> 0.11.1

Maintenance version upgrades:
- hadoop 3.2.0 - 3.2.1
- httpClient 4.5.8 -> 4.5.10
- jetty 9.4.18.v20190429 -> 9.4.22.v20191022
- scalatest 3.0.7 -> 3.0.8

Gradle upgrades:
- gradle 5.4.1 -> 5.6.4
- gradle-errorprone-plugin 0.8 -> 1.1.1
- gradle-version 0.21.0 -> 0.27.0
- gson 2.8.5 -> 2.8.6
- nebula-clojure-plugin 8.1.1 -> 9.1.1
- protobuf-gradle-plugin 0.8.8 -> 0.8.10
- shadow 5.0.0 -> 5.2.0
- spotbugs-gradle-plugin 1.7.1 -> 2.0.1

I also set checkstyle to 8.26 to ensure Gradle upgrades don’t change the
version and break.

Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
---
M java/buildSrc/build.gradle
M java/config/checkstyle/checkstyle.xml
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
6 files changed, 43 insertions(+), 45 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/14746/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14746 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14746/1/java/config/checkstyle/checkstyle.xml
File java/config/checkstyle/checkstyle.xml:

PS1: 
> What was the rationale for the change here?
It was a change in checkstyle on upgrade. Without it, upgrading checkstyle breaks that LineLength is not supposed to be under TreeWalker. The outcome is the same.



-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 Nov 2019 22:24:25 +0000
Gerrit-HasComments: Yes

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14746 )

Change subject: [Java] Upgrade dependencies
......................................................................

[Java] Upgrade dependencies

Upgrades the Java dependencies and Gradle versions.

Major version upgrades:
- mockito 2.27.0 -> 3.1.0

Minor version upgrades:
- guava 27.1-jre -> 28.1-jre
- hamcrest 2.1 -> 2.2
- protobuf 3.7.1 -> 3.10.0
- yetus 0.10.0 -> 0.11.1

Maintenance version upgrades:
- hadoop 3.2.0 - 3.2.1
- httpClient 4.5.8 -> 4.5.10
- jetty 9.4.18.v20190429 -> 9.4.22.v20191022
- scalatest 3.0.7 -> 3.0.8

Gradle upgrades:
- gradle 5.4.1 -> 5.6.4
- gradle-errorprone-plugin 0.8 -> 1.1.1
- gradle-version 0.21.0 -> 0.27.0
- gson 2.8.5 -> 2.8.6
- nebula-clojure-plugin 8.1.1 -> 9.1.1
- protobuf-gradle-plugin 0.8.8 -> 0.8.10
- shadow 5.0.0 -> 5.2.0
- spotbugs-gradle-plugin 1.7.1 -> 2.0.1

I also set checkstyle to 8.26 to ensure Gradle upgrades don’t change the
version and break.

Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Reviewed-on: http://gerrit.cloudera.org:8080/14746
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/buildSrc/build.gradle
M java/config/checkstyle/checkstyle.xml
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
6 files changed, 43 insertions(+), 45 deletions(-)

Approvals:
  Grant Henke: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee6b7b178f1dd7412ecb88261ef88f282c5744e7
Gerrit-Change-Number: 14746
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)