You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2015/12/15 11:54:33 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
GitHub user bzz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/534
ZEPPELIN-501 Notebook search
This implements [ZEPPELIN-501](https://issues.apache.org/jira/browse/ZEPPELIN-501) - a full-text search though paragraph inputs.
For more context, please check JIRA link above.
The search is pretty basic now, fine-tuning it for better search over all types of source code will be a subject of further work.
@felizbear contributed major parts of the frontend changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bzz/incubator-zeppelin notebook-search
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #534
----
commit c5928f9fa10a6dba54f4807aa711cb9560fb66f5
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-11-19T09:39:46Z
Search: form added to navbar in frontend
commit 78802372e13c9c6edc39ae9fc2ba3b0ec9b60813
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-11-19T10:29:22Z
Search: backend REST API scetch /notebooks/search?q=... added
commit 3900b60c76f819c5c42691b787ceb8496ef3f316
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-11-19T10:44:58Z
Search: disabling UI on disconnect
commit bc2458a24d65b8fde45b49f594da318ab5e0cdbb
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-11-20T06:14:10Z
Get rid of compiler warnings
commit 163a465e172ab7c00f4fcc12577afb71dc7d260a
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-11-20T10:23:19Z
Search: add search/result-list and switch to
commit c2c2a5252649e65ae50f873759e642dfbe35d7a2
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-11-23T00:38:57Z
Search: backend indexing using Lucene added to zengine
commit 11127f033c4c3e9ed047c6a8222b85a99b902603
Author: felizbear <il...@nflabs.com>
Date: 2015-11-24T01:35:36Z
style search widget for notebook search
commit db246faa4ed4bf35bb056f1cd8b3bbcc54022c26
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-11-24T03:45:44Z
Search: highlighting added using fragments
commit 9ca86289db0a955ec4df14694e19edea12e3dabe
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-11-26T02:09:30Z
Search: merge first 3 fragments + full paragraph in search result
commit 865925c33ed04c43faf8af00b171f1239b068b9d
Author: felizbear <il...@nflabs.com>
Date: 2015-11-26T02:37:28Z
highlight syntax and search terms in search results
commit 227c6b443e737e4c8fcb7a59fd791cbf279a98b4
Author: felizbear <il...@nflabs.com>
Date: 2015-11-26T03:08:51Z
update search results view: add panels for results
commit aa5ddb3f8f3c4b4e1c6179e1e25ee2b6ee1d08f1
Author: felizbear <il...@nflabs.com>
Date: 2015-11-26T03:52:41Z
center search results on screen
commit 6ccd6f11d482d2225f0e02f01eab63d0a86eeb49
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-11T06:12:29Z
Search: nuke compiler warnings in NotebookRestApi
commit 7aad5cf8679d1bf94f8b239a84685b65db9575be
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-11T06:13:20Z
Search: make checkstyle happy
commit e363ed45e5557205e5f8f249a746e16abd134edd
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-11T07:08:15Z
Search: make jshint happy
commit 5c1e3e4791e24234c367c3116b9ea5022122ad36
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-11T07:13:01Z
Refatoring - removing old annotations
commit 98f4e59051526b52a35cec9c79bbd11015b7e41c
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-11T07:13:43Z
Search: refactoring, rename fragment -> snippet
commit 63a4e057bb6d5228ea24f639ef510312c9dbbcb1
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-11T07:41:10Z
Search: adding search API docs
commit 08fe806b0e7ad877a6bdc4e447b4e63b40c49760
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-11T07:41:26Z
Search: adding tests
commit b2b93c436aa6a67707b02897159c4b27271d6378
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-11T08:30:39Z
Search: refatoring, move SearchService from NotebookRepoSync -> Notebook
commit 09d44d231322dd96cff5e49c1c1430fb65511030
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-11T10:11:21Z
Search: re-index note on every change
commit 1e1357c02cf5f53b804ae74a275e4cf12c9eca35
Author: felizbear <il...@nflabs.com>
Date: 2015-12-14T23:13:24Z
redirect to notebook and scroll to paragraph from search view
commit 71ec51f976f3e51429f385246251cc886f2233a2
Author: felizbear <il...@nflabs.com>
Date: 2015-12-15T05:37:42Z
clear search field on navigation to home view (/)
commit 82c7dd76ca56b838fd419ce48a519e5dd57a0174
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-12-15T09:53:00Z
ZEPPELIN-501: reverting accidental changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164727893
LGTM...
It is a good feature
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164978015
@khalidhuseynov
>in case of large number or notebooks (volume to be indexed), can there be any problem (e.g. system resources exhaustion) because of in-memory indexing (usage of RAMDirectory)? also any other performance issues possible
Good question! As stated in PR description and JIRA issue:
>The search is pretty basic now, fine-tuning it for better search over all types of source code will be a subject of further work.
Performance, on-disk index, and code-search instead of word one are definitely those direction I'd love to see explored in further work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164752442
@vgmartinez than you for positive feedback!
@corneadoug well, I expected a bit more of the code review, rather than "Wrong formatting of the PR description" ;)
I think I did a good job with JIRA issue. If you never the less feel that something is wrong - please contribute a new description you like better in the form of comment here and I will be willing to updated it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-165378082
History re-written to exclude accidental commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166783404
@Leemoonsoo thank you for thought testing and review! Scope is updated, will address all the feedback, and let you know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164917189
@bzz @felizbear This is cool feature!
I tried this branch and couple of feedbacks.
1. Error on notebook.controller.js after loading a notebook
2. Updating / Removing / Creating new notebook and paragraph does not update the index
3. I think indexing notebook title and paragraph title really make sense.
4. `zeppelin-distribution/src/bin_license/LICENSE` need to be updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164945411
Thank you all guys for timely reviews and kind feedback!
TODOs:
- [ ] tix fypos :dancer:
- [ ] fix js issue in js console
- [ ] update index on paragraph CRUD
- [ ] add license to `zeppelin-distribution/src/bin_license/LICENSE` (both, backend for lucene and front `angular-resource`)
- [ ] add missing Apache headers
- [ ] fix CI (now failing RAT on zengine `Too many files with unapproved license: 2` )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164978523
@corneadoug thanks for description update, have moved everything there
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166856151
Tested and works really well. Thanks for really useful new feature.
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166856636
Thank you! Merging if there are no other discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164742605
@bzz Could you rewrite the PR description following the PR template (https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md#creating-a-pull-request)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164975439
thanks for a nice feature! one more question: in case of large number or notebooks (volume to be indexed), can there be any problem (e.g. system resources exhaustion) because of in-memory indexing (usage of `RAMDirectory`)? also any other performance issues possible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166600360
@Leemoonsoo All reviews are addressed, I think it's ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-165332326
CI now fails with exactly the same case as on master under [ZEPPELIN-510](https://issues.apache.org/jira/browse/ZEPPELIN-510)
```
pabilities [{platform=LINUX, acceptSslCerts=true, javascriptEnabled=true, cssSelectorsEnabled=true, databaseEnabled=true, browserName=firefox, handlesAlerts=true, nativeEvents=false, webStorageEnabled=true, rotatable=false, locationContextEnabled=true, applicationCacheEnabled=true, takesScreenshot=true, version=31.0}]
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
at org.openqa.selenium.remote.ErrorHandler.createThrowable(ErrorHandler.java:206)
at org.openqa.selenium.remote.ErrorHandler.throwIfResponseFailed(ErrorHandler.java:158)
at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:647)
at org.openqa.selenium.remote.RemoteWebElement.execute(RemoteWebElement.java:326)
at org.openqa.selenium.remote.RemoteWebElement.sendKeys(RemoteWebElement.java:121)
at org.apache.zeppelin.ZeppelinIT.testAngularDisplay(ZeppelinIT.java:240)
Caused by: org.openqa.selenium.ElementNotVisibleException: Element is not currently visible and so may not be interacted with
Build info: version: '2.48.2', revision: '41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
System info: host: 'testing-worker-linux-docker-484929b1-3177-linux-6', ip: '172.17.4.152', os.name: 'Linux', os.arch: 'amd64', os.version: '3.13.0-40-generic', java.version: '1.7.0_76'
Driver info: driver.version: unknown
at <anonymous class>.fxdriver.preconditions.visible(file:///tmp/anonymous6937570328313435477webdriver-profile/extensions/fxdriver@googlecode.com/components/command-processor.js:9981)
at <anonymous class>.DelayedCommand.prototype.checkPreconditions_(file:///tmp/anonymous6937570328313435477webdriver-profile/extensions/fxdriver@googlecode.com/components/command-processor.js:12517)
at <anonymous class>.DelayedCommand.prototype.executeInternal_/h(file:///tmp/anonymous6937570328313435477webdriver-profile/extensions/fxdriver@googlecode.com/components/command-processor.js:12534)
at <anonymous class>.DelayedCommand.prototype.executeInternal_(file:///tmp/anonymous6937570328313435477webdriver-profile/extensions/fxdriver@googlecode.com/components/command-processor.js:12539)
at <anonymous class>.DelayedCommand.prototype.execute/<(file:///tmp/anonymous6937570328313435477webdriver-profile/extensions/fxdriver@googlecode.com/components/command-processor.js:12481)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164755385
@bzz Of course, the code review will come :)
Well, JIRA issue is JIRA issue, PR Template is PR Template :)
You will find that there is a lot of nice categories and questions that will help review the PR.
One good example is:
>Does the licenses files need update?
Which answer in this PR's case would be: Yes
But ``angular-resource`` was not added to the license file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166614398
Following error is thrown when persisting changes of notebook which loaded on Zeppelin startup (not created after start up)
```
java.lang.NullPointerException
at org.apache.zeppelin.notebook.Note.persist(Note.java:380)
at org.apache.zeppelin.socket.NotebookServer.updateParagraph(NotebookServer.java:451)
at org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:123)
at org.apache.zeppelin.socket.NotebookSocket.onMessage(NotebookSocket.java:56)
at org.eclipse.jetty.websocket.WebSocketConnectionRFC6455$WSFrameHandler.onFrame(WebSocketConnectionRFC6455.java:835)
at org.eclipse.jetty.websocket.WebSocketParserRFC6455.parseNext(WebSocketParserRFC6455.java:349)
at org.eclipse.jetty.websocket.WebSocketConnectionRFC6455.handle(WebSocketConnectionRFC6455.java:225)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:667)
at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:52)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
at java.lang.Thread.run(Thread.java:745)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164976691
Here is my contribution for your PR Description
```
### What is this PR for?
This PR has for goal to allow the user to search through the code in all the paragraphs of all the notebooks
It add a simple 'search bar' to the nav-bar of Zeppelin WebApp, and an in-memory fulltext search index of paragraphs to the backend.
### What type of PR is it?
Feature
### Todos
* [x] - Fix fypos :dancer: b853aa6
* [ ] - fix js issue in js console
* [ ] - update index on paragraph CRUD
* [x] - add license to zeppelin-distribution/src/bin_license/LICENSE (backend for lucene, not sure about angular-resource as it is part of the AngularJS codebase, but will add just in case)
* [ ] - add missing Apache headers
* [ ] - fix CI (now failing RAT on zengine Too many files with unapproved license: 2 )
* [x] - index notebook names e80c3e5
* [x] - make NotebookRepoSync.sync() package private again
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-501
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? Yes, added to license files
* Is there breaking changes for older versions? No
* Does this needs documentation?
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166832381
@Leemoonsoo all the feedback has been addressed now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-166612706
@bzz Great work.
Seems like index is not updated after paragraph remove. Is it possible to be handled?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-501 Notebook search
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/534#issuecomment-164999005
CI fails now with unapproved licence, though last lines in log (`cat rat.txt`) do not have any reference of those...
```
[INFO] Rat check: Summary of files. Unapproved: 2 unknown: 2 generated: 0 approved: 6 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [ 8.718 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [01:17 min]
[INFO] Zeppelin: Zengine .................................. FAILURE [ 12.028 s]
```
Can anybody please verify that `mvn verify -Pusing-packaged-distr -Pspark-1.5 -Phadoop-2.3 -Ppyspark -B` passes?
As it looks like it hangs forever for me..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---