You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2013/08/14 22:05:57 UTC
svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml Wed Aug 14 20:05:54 2013
@@ -30,10 +30,10 @@
</appenders>
<loggers>
<logger name="org.apache.test" level="trace" additivity="false">
- <appender-ref ref="List"/>
+ <AppenderRef ref="List"/>
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml Wed Aug 14 20:05:54 2013
@@ -25,7 +25,7 @@
<loggers>
<logger name="org.foo" level="DEBUG" />
<root level="TRACE">
- <appender-ref ref="Console" />
+ <AppenderRef ref="Console" />
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml Wed Aug 14 20:05:54 2013
@@ -25,7 +25,7 @@
<loggers>
<logger name="org.foo" level="DEBUG" />
<root level="TRACE">
- <appender-ref ref="Console" />
+ <AppenderRef ref="Console" />
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml Wed Aug 14 20:05:54 2013
@@ -25,7 +25,7 @@
<loggers>
<logger name="org.foo" level="DEBUG" />
<root level="TRACE">
- <appender-ref ref="Console" />
+ <AppenderRef ref="Console" />
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml Wed Aug 14 20:05:54 2013
@@ -25,7 +25,7 @@
<loggers>
<logger name="org.foo" level="DEBUG" />
<root level="TRACE">
- <appender-ref ref="Console" />
+ <AppenderRef ref="Console" />
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml Wed Aug 14 20:05:54 2013
@@ -25,7 +25,7 @@
<loggers>
<logger name="org.foo" level="DEBUG" />
<root level="TRACE">
- <appender-ref ref="Console" />
+ <AppenderRef ref="Console" />
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml Wed Aug 14 20:05:54 2013
@@ -25,7 +25,7 @@
<loggers>
<logger name="org.foo" level="DEBUG" />
<root level="TRACE">
- <appender-ref ref="Console" />
+ <AppenderRef ref="Console" />
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml Wed Aug 14 20:05:54 2013
@@ -27,7 +27,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml Wed Aug 14 20:05:54 2013
@@ -28,7 +28,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="LIST"/>
+ <AppenderRef ref="LIST"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml Wed Aug 14 20:05:54 2013
@@ -30,7 +30,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="TestLogfile"/>
+ <AppenderRef ref="TestLogfile"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml Wed Aug 14 20:05:54 2013
@@ -26,7 +26,7 @@
</appenders>
<loggers>
<root level="debug">
- <appender-ref ref="TestLogfile"/>
+ <AppenderRef ref="TestLogfile"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml Wed Aug 14 20:05:54 2013
@@ -26,7 +26,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="TestLogfile"/>
+ <AppenderRef ref="TestLogfile"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml Wed Aug 14 20:05:54 2013
@@ -28,7 +28,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="LIST"/>
+ <AppenderRef ref="LIST"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml Wed Aug 14 20:05:54 2013
@@ -23,6 +23,6 @@
</appender>
<root level="error">
- <appender-ref ref="Console" />
+ <AppenderRef ref="Console" />
</root>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml Wed Aug 14 20:05:54 2013
@@ -31,6 +31,6 @@
</appender>
<root level="error">
- <appender-ref ref="TestLogfile" />
+ <AppenderRef ref="TestLogfile" />
</root>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml Wed Aug 14 20:05:54 2013
@@ -25,6 +25,6 @@
</appender>
<root level="debug">
- <appender-ref ref="TestLogfile" />
+ <AppenderRef ref="TestLogfile" />
</root>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml Wed Aug 14 20:05:54 2013
@@ -24,6 +24,6 @@
</appender>
<root level="error">
- <appender-ref ref="TestLogfile" />
+ <AppenderRef ref="TestLogfile" />
</root>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml Wed Aug 14 20:05:54 2013
@@ -23,6 +23,6 @@
</appender>
<root level="debug">
- <appender-ref ref="stdout" />
+ <AppenderRef ref="stdout" />
</root>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml Wed Aug 14 20:05:54 2013
@@ -11,11 +11,11 @@
<loggers>
<!--
<root level="info" includeLocation="false">
- <appender-ref ref="List"/>
+ <AppenderRef ref="List"/>
</root>
-->
<logger name="sample" level="info" includeLocation="false">
- <appender-ref ref="List"/>
+ <AppenderRef ref="List"/>
</logger>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml Wed Aug 14 20:05:54 2013
@@ -34,11 +34,11 @@
<loggers>
<logger name="org.apache.logging.log4j.core.appender.db" level="debug">
- <appender-ref ref="databaseAppender" />
+ <AppenderRef ref="databaseAppender" />
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml Wed Aug 14 20:05:54 2013
@@ -34,11 +34,11 @@
<loggers>
<logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
- <appender-ref ref="databaseAppender" />
+ <AppenderRef ref="databaseAppender" />
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml Wed Aug 14 20:05:54 2013
@@ -35,11 +35,11 @@
<loggers>
<logger name="org.apache.logging.log4j.core.appender.db" level="debug">
- <appender-ref ref="databaseAppender" />
+ <AppenderRef ref="databaseAppender" />
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml Wed Aug 14 20:05:54 2013
@@ -34,11 +34,11 @@
<loggers>
<logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
- <appender-ref ref="databaseAppender" />
+ <AppenderRef ref="databaseAppender" />
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml Wed Aug 14 20:05:54 2013
@@ -35,11 +35,11 @@
<loggers>
<logger name="org.apache.logging.log4j.core.appender.db" level="debug">
- <appender-ref ref="databaseAppender" />
+ <AppenderRef ref="databaseAppender" />
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml Wed Aug 14 20:05:54 2013
@@ -27,11 +27,11 @@
<loggers>
<logger name="org.apache.logging.log4j.core.appender.db" level="debug">
- <appender-ref ref="databaseAppender" />
+ <AppenderRef ref="databaseAppender" />
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml Wed Aug 14 20:05:54 2013
@@ -27,11 +27,11 @@
<loggers>
<logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
- <appender-ref ref="databaseAppender" />
+ <AppenderRef ref="databaseAppender" />
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml Wed Aug 14 20:05:54 2013
@@ -27,11 +27,11 @@
<loggers>
<logger name="org.apache.logging.log4j.core.appender.db" level="debug">
- <appender-ref ref="databaseAppender" />
+ <AppenderRef ref="databaseAppender" />
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml Wed Aug 14 20:05:54 2013
@@ -27,11 +27,11 @@
<loggers>
<logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
- <appender-ref ref="databaseAppender" />
+ <AppenderRef ref="databaseAppender" />
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml Wed Aug 14 20:05:54 2013
@@ -11,10 +11,10 @@
</appender>
<appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
<param name="BufferSize" value="262144"/>
- <appender-ref ref="File"/>
+ <AppenderRef ref="File"/>
</appender>
<root>
<priority value="debug" />
- <appender-ref ref="ASYNC" />
+ <AppenderRef ref="ASYNC" />
</root>
</log4j:configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml Wed Aug 14 20:05:54 2013
@@ -11,6 +11,6 @@
</appender>
<root>
<priority value="debug" />
- <appender-ref ref="File" />
+ <AppenderRef ref="File" />
</root>
</log4j:configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml Wed Aug 14 20:05:54 2013
@@ -12,10 +12,10 @@
<queueSize>262144</queueSize>
<discardingThreshold>0</discardingThreshold>
<includeCallerData>false</includeCallerData>
- <appender-ref ref="FILE" />
+ <AppenderRef ref="FILE" />
</appender>
<root level="debug">
- <appender-ref ref="ASYNC" />
+ <AppenderRef ref="ASYNC" />
</root>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml Wed Aug 14 20:05:54 2013
@@ -10,6 +10,6 @@
</appender>
<root level="debug">
- <appender-ref ref="FILE" />
+ <AppenderRef ref="FILE" />
</root>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml Wed Aug 14 20:05:54 2013
@@ -9,7 +9,7 @@
</appenders>
<loggers>
<root level="info" includeLocation="false">
- <appender-ref ref="RandomAccessFile"/>
+ <AppenderRef ref="RandomAccessFile"/>
</root>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml Wed Aug 14 20:05:54 2013
@@ -9,7 +9,7 @@
</appenders>
<loggers>
<root level="info" includeLocation="false">
- <appender-ref ref="File"/>
+ <AppenderRef ref="File"/>
</root>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml Wed Aug 14 20:05:54 2013
@@ -14,7 +14,7 @@
</appenders>
<loggers>
<root level="info" includeLocation="false">
- <appender-ref ref="RollingRandomAccessFile"/>
+ <AppenderRef ref="RollingRandomAccessFile"/>
</root>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml Wed Aug 14 20:05:54 2013
@@ -14,7 +14,7 @@
</appenders>
<loggers>
<root level="info" includeLocation="false">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml Wed Aug 14 20:05:54 2013
@@ -9,7 +9,7 @@
</appenders>
<loggers>
<root level="info" includeLocation="false">
- <appender-ref ref="RandomAccessFile"/>
+ <AppenderRef ref="RandomAccessFile"/>
</root>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml Wed Aug 14 20:05:54 2013
@@ -9,7 +9,7 @@
</appenders>
<loggers>
<root level="info" includeLocation="true">
- <appender-ref ref="RandomAccessFile"/>
+ <AppenderRef ref="RandomAccessFile"/>
</root>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml Wed Aug 14 20:05:54 2013
@@ -7,12 +7,12 @@
</PatternLayout>
</RandomAccessFile>
<Async name="Async" blocking="true" bufferSize="262144">
- <appender-ref ref="RandomAccessFile"/>
+ <AppenderRef ref="RandomAccessFile"/>
</Async>
</appenders>
<loggers>
<root level="info" includeLocation="false">
- <appender-ref ref="Async"/>
+ <AppenderRef ref="Async"/>
</root>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml Wed Aug 14 20:05:54 2013
@@ -7,12 +7,12 @@
</PatternLayout>
</RandomAccessFile>
<Async name="Async" includeLocation="true" blocking="true" bufferSize="262144">
- <appender-ref ref="RandomAccessFile"/>
+ <AppenderRef ref="RandomAccessFile"/>
</Async>
</appenders>
<loggers>
<root level="info" includeLocation="true">
- <appender-ref ref="Async"/>
+ <AppenderRef ref="Async"/>
</root>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml Wed Aug 14 20:05:54 2013
@@ -9,7 +9,7 @@
</appenders>
<loggers>
<asyncRoot level="info" includeLocation="false">
- <appender-ref ref="RandomAccessFile"/>
+ <AppenderRef ref="RandomAccessFile"/>
</asyncRoot>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml Wed Aug 14 20:05:54 2013
@@ -9,7 +9,7 @@
</appenders>
<loggers>
<asyncRoot level="info" includeLocation="true">
- <appender-ref ref="RandomAccessFile"/>
+ <AppenderRef ref="RandomAccessFile"/>
</asyncRoot>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml (original)
+++ logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml Wed Aug 14 20:05:54 2013
@@ -10,10 +10,10 @@
</appenders>
<loggers>
<logger name="EventLogger" level="info">
- <appender-ref ref="events"/>
+ <AppenderRef ref="events"/>
</logger>
<root level="warn">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml (original)
+++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml Wed Aug 14 20:05:54 2013
@@ -12,10 +12,10 @@
</appenders>
<loggers>
<logger name="EventLogger" level="info" additivity="false">
- <appender-ref ref="eventLogger"/>
+ <AppenderRef ref="eventLogger"/>
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml (original)
+++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml Wed Aug 14 20:05:54 2013
@@ -32,10 +32,10 @@
</appenders>
<loggers>
<logger name="EventLogger" level="info" additivity="false">
- <appender-ref ref="eventLogger"/>
+ <AppenderRef ref="eventLogger"/>
</logger>
<root level="warn">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml (original)
+++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml Wed Aug 14 20:05:54 2013
@@ -15,10 +15,10 @@
</appenders>
<loggers>
<logger name="EventLogger" level="info" additivity="false">
- <appender-ref ref="eventLogger"/>
+ <AppenderRef ref="eventLogger"/>
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml (original)
+++ logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml Wed Aug 14 20:05:54 2013
@@ -24,15 +24,15 @@
<loggers>
<logger name="EventLogger" level="info" additivity="false">
- <appender-ref ref="EventLogger"/>
+ <AppenderRef ref="EventLogger"/>
</logger>>
<logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
- <appender-ref ref="File"/>
+ <AppenderRef ref="File"/>
</logger>>
<root level="trace">
- <appender-ref ref="List"/>
+ <AppenderRef ref="List"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java (original)
+++ logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java Wed Aug 14 20:05:54 2013
@@ -24,22 +24,23 @@ import static org.junit.Assert.assertTru
import java.util.Date;
import java.util.List;
-import ch.qos.logback.classic.joran.JoranConfigurator;
-import ch.qos.logback.classic.spi.ILoggingEvent;
-import ch.qos.logback.core.joran.spi.JoranException;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.logging.log4j.ThreadContext;
import org.apache.logging.log4j.message.MessageFactory;
import org.apache.logging.log4j.message.ParameterizedMessageFactory;
import org.apache.logging.log4j.message.StringFormatterMessageFactory;
-import ch.qos.logback.core.testUtil.StringListAppender;
-import ch.qos.logback.classic.LoggerContext;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;
import org.slf4j.LoggerFactory;
+import ch.qos.logback.classic.LoggerContext;
+import ch.qos.logback.classic.joran.JoranConfigurator;
+import ch.qos.logback.classic.spi.ILoggingEvent;
+import ch.qos.logback.core.joran.spi.JoranException;
+import ch.qos.logback.core.testUtil.StringListAppender;
+
/**
*
*/
@@ -74,6 +75,8 @@ public class LoggerTest {
@Before
public void before() {
+ assertNotNull(list);
+ assertNotNull(list.strList);
list.strList.clear();
}
Modified: logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml (original)
+++ logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml Wed Aug 14 20:05:54 2013
@@ -27,13 +27,13 @@
</appenders>
<loggers>
<logger name="org.apache.test.logging" level="debug" additivity="false">
- <appender-ref ref="List"/>
+ <AppenderRef ref="List"/>
</logger>
<logger name="org.apache.test" level="trace" additivity="false">
- <appender-ref ref="List"/>
+ <AppenderRef ref="List"/>
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>
\ No newline at end of file
Modified: logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml (original)
+++ logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml Wed Aug 14 20:05:54 2013
@@ -40,10 +40,10 @@
</appenders>
<loggers>
<logger name="EventLogger" level="WARN" additivity="false">
- <appender-ref ref="flume" />
+ <AppenderRef ref="flume" />
</logger>
<root level="debug">
- <appender-ref ref="RollingFile" />
+ <AppenderRef ref="RollingFile" />
</root>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml (original)
+++ logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml Wed Aug 14 20:05:54 2013
@@ -40,10 +40,10 @@
</appenders>
<loggers>
<logger name="EventLogger" level="WARN" additivity="false">
- <appender-ref ref="flume" />
+ <AppenderRef ref="flume" />
</logger>
<root level="debug">
- <appender-ref ref="RollingFile" />
+ <AppenderRef ref="RollingFile" />
</root>
</loggers>
</configuration>
Modified: logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml (original)
+++ logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml Wed Aug 14 20:05:54 2013
@@ -25,15 +25,15 @@
<loggers>
<logger name="EventLogger" level="info" additivity="false">
- <appender-ref ref="EventLogger"/>
+ <AppenderRef ref="EventLogger"/>
</logger>>
<logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
- <appender-ref ref="File"/>
+ <AppenderRef ref="File"/>
</logger>>
<root level="trace">
- <appender-ref ref="List"/>
+ <AppenderRef ref="List"/>
</root>
</loggers>
Modified: logging/log4j/log4j2/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/changes/changes.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/src/changes/changes.xml (original)
+++ logging/log4j/log4j2/trunk/src/changes/changes.xml Wed Aug 14 20:05:54 2013
@@ -432,7 +432,7 @@
The blocking parameter did not work properly on AsynchAppender.
</action>
<action issue="LOG4J2-188" dev="rgoers" type="fix" due-to="Werner">
- appender-refs on AsynchAppender didn't support the level and filter elements.
+ AppenderRefs on AsynchAppender didn't support the level and filter elements.
</action>
<action issue="LOG4J2-176" dev="rgoers" type="fix" due-to="Remko Popma">
Avoid IllegalArgumentException in AsynchAppender.
@@ -797,7 +797,7 @@
</release>
<release version="2.0-alpha1" date="2012-07-29" description="Rewrite of Log4j">
<action issue="LOG4J2-60" dev="rgoers" type="add" due-to="Shane Kelly">
- Added ability to filter on the appender-ref by adding either a level or a filter.
+ Added ability to filter on the AppenderRef by adding either a level or a filter.
</action>
<action issue="LOG4J2-56" dev="rgoers" type="fix" due-to="John Owen Atala">
Level.toLevel would throw an IllegalArgumentException instead of returning the default value.
Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml (original)
+++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml Wed Aug 14 20:05:54 2013
@@ -59,9 +59,9 @@
<th>Description</th>
</tr>
<tr>
- <td>appender-ref</td>
+ <td>AppenderRef</td>
<td>String</td>
- <td>The name of the Appenders to invoke asynchronously. Multiple appender-ref
+ <td>The name of the Appenders to invoke asynchronously. Multiple AppenderRef
elements can be configured.</td>
</tr>
<tr>
@@ -122,12 +122,12 @@
</PatternLayout>
</File>
<Async name="Async">
- <appender-ref ref="MyFile"/>
+ <AppenderRef ref="MyFile"/>
</Async>
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="Async"/>
+ <AppenderRef ref="Async"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -196,7 +196,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -271,13 +271,13 @@
</Console>
<Failover name="Failover" primary="RollingFile">
<Failovers>
- <appender-ref ref="Console"/>
+ <AppenderRef ref="Console"/>
</Failovers>
</Failover>
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="Failover"/>
+ <AppenderRef ref="Failover"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -387,7 +387,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="MyFile"/>
+ <AppenderRef ref="MyFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -588,7 +588,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingRandomAccessFile"/>
+ <AppenderRef ref="RollingRandomAccessFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -613,7 +613,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingRandomAccessFile"/>
+ <AppenderRef ref="RollingRandomAccessFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -647,7 +647,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingRandomAccessFile"/>
+ <AppenderRef ref="RollingRandomAccessFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -749,7 +749,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="MyFile"/>
+ <AppenderRef ref="MyFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -927,7 +927,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="eventLogger"/>
+ <AppenderRef ref="eventLogger"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -948,7 +948,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="eventLogger"/>
+ <AppenderRef ref="eventLogger"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -972,10 +972,10 @@
</appenders>
<loggers>
<logger name="EventLogger" level="info">
- <appender-ref ref="eventLogger"/>
+ <AppenderRef ref="eventLogger"/>
</logger>
<root level="warn">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1016,10 +1016,10 @@
</appenders>
<loggers>
<logger name="EventLogger" level="info">
- <appender-ref ref="eventLogger"/>
+ <AppenderRef ref="eventLogger"/>
</logger>
<root level="warn">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1216,7 +1216,7 @@
</appenders>
<loggers>
<root level="warn">
- <appender-ref ref="databaseAppender"/>
+ <AppenderRef ref="databaseAppender"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1235,7 +1235,7 @@
</appenders>
<loggers>
<root level="warn">
- <appender-ref ref="databaseAppender"/>
+ <AppenderRef ref="databaseAppender"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1255,7 +1255,7 @@
</appenders>
<loggers>
<root level="warn">
- <appender-ref ref="databaseAppender"/>
+ <AppenderRef ref="databaseAppender"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1365,7 +1365,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="jmsQueue"/>
+ <AppenderRef ref="jmsQueue"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1476,7 +1476,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="jmsQueue"/>
+ <AppenderRef ref="jmsQueue"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1552,7 +1552,7 @@
</appenders>
<loggers>
<root level="warn">
- <appender-ref ref="databaseAppender"/>
+ <AppenderRef ref="databaseAppender"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1806,7 +1806,7 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<root level="warn">
- <appender-ref ref="databaseAppender"/>
+ <AppenderRef ref="databaseAppender"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1821,7 +1821,7 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<root level="warn">
- <appender-ref ref="databaseAppender"/>
+ <AppenderRef ref="databaseAppender"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1836,7 +1836,7 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<root level="warn">
- <appender-ref ref="databaseAppender"/>
+ <AppenderRef ref="databaseAppender"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -1919,9 +1919,9 @@ public class JpaLogEntity extends Abstra
<th>Description</th>
</tr>
<tr>
- <td>appender-ref</td>
+ <td>AppenderRef</td>
<td>String</td>
- <td>The name of the Appenders to call after the LogEvent has been manipulated. Multiple appender-ref
+ <td>The name of the Appenders to call after the LogEvent has been manipulated. Multiple AppenderRef
elements can be configured.</td>
</tr>
<tr>
@@ -1989,7 +1989,7 @@ public class JpaLogEntity extends Abstra
<PatternLayout pattern="%m%n"/>
</Console>
<Rewrite name="rewrite">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
<MapRewritePolicy mode="Add">
<KeyValuePair key="product" value="TestProduct"/>
</MapRewritePolicy>
@@ -1997,7 +1997,7 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="Rewrite"/>
+ <AppenderRef ref="Rewrite"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -2032,7 +2032,7 @@ public class JpaLogEntity extends Abstra
<PatternLayout pattern="%m%n"/>
</Console>
<Rewrite name="rewrite">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
<PropertiesRewritePolicy>
<Property key="user">${sys:user.name}</Property>
<Property key="env">${sys:environment}</Property>
@@ -2041,7 +2041,7 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="Rewrite"/>
+ <AppenderRef ref="Rewrite"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -2357,7 +2357,7 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -2381,7 +2381,7 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -2408,7 +2408,7 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -2468,7 +2468,7 @@ public class JpaLogEntity extends Abstra
can be configured as the default.
</p>
<p>
- Each Route must reference an Appender. If the Route contains an appender-ref attribute then the
+ Each Route must reference an Appender. If the Route contains an AppenderRef attribute then the
Route will reference an Appender that was defined in the configuration. If the Route contains an
Appender definition then an Appender will be created within the context of the RoutingAppender and
will be reused each time a matching Appender name is referenced through a Route.
@@ -2498,13 +2498,13 @@ public class JpaLogEntity extends Abstra
<SizeBasedTriggeringPolicy size="500" />
</RollingFile>
</Route>
- <Route appender-ref="AuditLogger" key="Audit"/>
+ <Route AppenderRef="AuditLogger" key="Audit"/>
</Routes>
</Routing>
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="Routing"/>
+ <AppenderRef ref="Routing"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -2631,7 +2631,7 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="Mail"/>
+ <AppenderRef ref="Mail"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -2722,7 +2722,7 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="socket"/>
+ <AppenderRef ref="socket"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -2904,10 +2904,10 @@ public class JpaLogEntity extends Abstra
</appenders>
<loggers>
<logger name="com.mycorp" level="error">
- <appender-ref ref="RFC5424"/>
+ <AppenderRef ref="RFC5424"/>
</logger>
<root level="error">
- <appender-ref ref="bsd"/>
+ <AppenderRef ref="bsd"/>
</root>
</loggers>
</configuration>]]></pre>
Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml (original)
+++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml Wed Aug 14 20:05:54 2013
@@ -162,7 +162,7 @@
</appenders>
<loggers>
<root level="info" includeLocation="false">
- <appender-ref ref="RandomAccessFile"/>
+ <AppenderRef ref="RandomAccessFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -360,10 +360,10 @@
<loggers>
<!-- pattern layout actually uses location, so we need to include it -->
<asyncLogger name="com.foo.Bar" level="trace" includeLocation="true">
- <appender-ref ref="RandomAccessFile"/>
+ <AppenderRef ref="RandomAccessFile"/>
</asyncLogger>
<root level="info" includeLocation="true">
- <appender-ref ref="RandomAccessFile"/>
+ <AppenderRef ref="RandomAccessFile"/>
</root>
</loggers>
</configuration>]]></pre>
Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm (original)
+++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm Wed Aug 14 20:05:54 2013
@@ -161,7 +161,7 @@ public class Bar {
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="Console"/>
+ <AppenderRef ref="Console"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -186,7 +186,7 @@ public class Bar {
<pre class="prettyprint linenums"><![CDATA[
<logger name="com.foo.Bar" level="TRACE"/>
<root level="ERROR">
- <appender-ref ref="STDOUT">
+ <AppenderRef ref="STDOUT">
</root>]]></pre>
<p>
With this configuration all log events from <code>com.foo.Bar</code> will be recorded while only error events will
@@ -210,10 +210,10 @@ public class Bar {
</appenders>
<loggers>
<logger name="com.foo.Bar" level="trace">
- <appender-ref ref="Console"/>
+ <AppenderRef ref="Console"/>
</logger>
<root level="error">
- <appender-ref ref="Console"/>
+ <AppenderRef ref="Console"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -242,10 +242,10 @@ public class Bar {
</appenders>
<loggers>
<logger name="com.foo.Bar" level="trace" additivity="false">
- <appender-ref ref="Console"/>
+ <AppenderRef ref="Console"/>
</logger>
<root level="error">
- <appender-ref ref="Console"/>
+ <AppenderRef ref="Console"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -408,7 +408,7 @@ public class Bar {
</logger>
...
<root level="level">
- <appender-ref ref="name"/>
+ <AppenderRef ref="name"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -443,7 +443,7 @@ public class Bar {
</logger>
...
<root level="level">
- <appender-ref ref="name"/>
+ <AppenderRef ref="name"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -488,15 +488,15 @@ public class Bar {
<filter type="ThreadContextMapFilter">
<KeyValuePair key="test" value="123"/>
</filter>
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</logger>>
<logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
- <appender-ref ref="File"/>
+ <AppenderRef ref="File"/>
</logger>>
<root level="trace">
- <appender-ref ref="List"/>
+ <AppenderRef ref="List"/>
</root>
</loggers>
@@ -537,16 +537,16 @@ public class Bar {
"SizeBasedTriggeringPolicy": { "size": "500" }
}
},
- { "appender-ref": "STDOUT", "key": "Audit"},
- { "appender-ref": "List", "key": "Service"}
+ { "AppenderRef": "STDOUT", "key": "Audit"},
+ { "AppenderRef": "List", "key": "Service"}
]
}
}
},
"loggers": {
"logger": { "name": "EventLogger", "level": "info", "additivity": "false",
- "appender-ref": { "ref": "Routing" }},
- "root": { "level": "error", "appender-ref": { "ref": "STDOUT" }}
+ "AppenderRef": { "ref": "Routing" }},
+ "root": { "level": "error", "AppenderRef": { "ref": "STDOUT" }}
}
}
}</pre>
@@ -580,8 +580,8 @@ public class Bar {
"SizeBasedTriggeringPolicy": { "size": "500" }
}
},
- { "appender-ref": "STDOUT", "key": "Audit"},
- { "appender-ref": "List", "key": "Service"}
+ { "AppenderRef": "STDOUT", "key": "Audit"},
+ { "AppenderRef": "List", "key": "Service"}
]
}
}
@@ -590,11 +590,11 @@ public class Bar {
"loggers": {
"logger": [
{ "name": "EventLogger", "level": "info", "additivity": "false",
- "appender-ref": { "ref": "Routing" }},
+ "AppenderRef": { "ref": "Routing" }},
{ "name": "com.foo.bar", "level": "error", "additivity": "false",
- "appender-ref": { "ref": "Console" }}
+ "AppenderRef": { "ref": "Console" }}
],
- "root": { "level": "error", "appender-ref": { "ref": "STDOUT" }}
+ "root": { "level": "error", "AppenderRef": { "ref": "STDOUT" }}
}
}
}</pre>
@@ -638,7 +638,7 @@ public class Bar {
using variables.
</p>
<p>
- The LoggerConfig may also be configured with one or more appender-ref elements. Each appender
+ The LoggerConfig may also be configured with one or more AppenderRef elements. Each appender
referenced will become associated with the specified LoggerConfig. If multiple appenders
are configured on the LoggerConfig each of them be called when processing logging events.
</p>
@@ -718,21 +718,21 @@ public class Bar {
<ThreadContextMapFilter>
<KeyValuePair key="test" value="123"/>
</ThreadContextMapFilter>
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</logger>>
<logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
<property name="user">${dollar}{sys:user.name}</property>
- <appender-ref ref="File">
+ <AppenderRef ref="File">
<ThreadContextMapFilter>
<KeyValuePair key="test" value="123"/>
</ThreadContextMapFilter>
- </appender-ref>
- <appender-ref ref="STDOUT" level="error"/>
+ </AppenderRef>
+ <AppenderRef ref="STDOUT" level="error"/>
</logger>>
<root level="trace">
- <appender-ref ref="List"/>
+ <AppenderRef ref="List"/>
</root>
</loggers>
@@ -776,19 +776,19 @@ public class Bar {
<SizeBasedTriggeringPolicy size="500" />
</RollingFile>
</Route>
- <Route appender-ref="STDOUT" key="Audit"/>
- <Route appender-ref="List" key="Service"/>
+ <Route AppenderRef="STDOUT" key="Audit"/>
+ <Route AppenderRef="List" key="Service"/>
</Routes>
</Routing>
</appenders>
<loggers>
<logger name="EventLogger" level="info" additivity="false">
- <appender-ref ref="Routing"/>
+ <AppenderRef ref="Routing"/>
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
@@ -916,19 +916,19 @@ public class Bar {
<SizeBasedTriggeringPolicy size="500" />
</RollingFile>
</Route>
- <Route appender-ref="STDOUT" key="Audit"/>
- <Route appender-ref="List" key="Service"/>
+ <Route AppenderRef="STDOUT" key="Audit"/>
+ <Route AppenderRef="List" key="Service"/>
</Routes>
</Routing>
</appenders>
<loggers>
<logger name="EventLogger" level="info" additivity="false">
- <appender-ref ref="Routing"/>
+ <AppenderRef ref="Routing"/>
</logger>
<root level="error">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
@@ -961,11 +961,11 @@ public class Bar {
appender.ListAppender for element List with params(name="List", entryPerNewLine="null",
raw="null", null, ThresholdFilter(DEBUG))
2011-11-23 17:08:00,813 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.
- routing.Route for element Route with params(appender-ref="null", key="null", Node=Route)
+ routing.Route for element Route with params(AppenderRef="null", key="null", Node=Route)
2011-11-23 17:08:00,823 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.
- routing.Route for element Route with params(appender-ref="STDOUT", key="Audit", Node=Route)
+ routing.Route for element Route with params(AppenderRef="STDOUT", key="Audit", Node=Route)
2011-11-23 17:08:00,824 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.
- routing.Route for element Route with params(appender-ref="List", key="Service", Node=Route)
+ routing.Route for element Route with params(AppenderRef="List", key="Service", Node=Route)
2011-11-23 17:08:00,825 DEBUG Calling createRoutes on class org.apache.logging.log4j.core.appender.
routing.Routes for element Routes with params(pattern="${dollar}{sd:type}",
routes={Route(type=dynamic default), Route(type=static Reference=STDOUT key='Audit'),
@@ -978,16 +978,16 @@ public class Bar {
2011-11-23 17:08:00,827 DEBUG Calling createAppenders on class org.apache.logging.log4j.core.config.
plugins.AppendersPlugin for element appenders with params(appenders={STDOUT, List, Routing})
2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.
- config.plugins.AppenderRefPlugin for element appender-ref with params(ref="Routing")
+ config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="Routing")
2011-11-23 17:08:00,829 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.
LoggerConfig for element logger with params(additivity="false", level="info", name="EventLogger",
- appender-ref={Routing}, null)
+ AppenderRef={Routing}, null)
2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.
- config.plugins.AppenderRefPlugin for element appender-ref with params(ref="STDOUT")</pre>
+ config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="STDOUT")</pre>
<pre class="prettyprint linenums">
2011-11-23 17:08:00,831 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.
LoggerConfig$RootLogger for element root with params(additivity="null", level="error",
- appender-ref={STDOUT}, null)
+ AppenderRef={STDOUT}, null)
2011-11-23 17:08:00,833 DEBUG Calling createLoggers on class org.apache.logging.log4j.core.
config.plugins.LoggersPlugin for element loggers with params(loggers={EventLogger, root})
2011-11-23 17:08:00,834 DEBUG Reconfiguration completed
@@ -1024,16 +1024,16 @@ public class Bar {
2011-11-23 17:08:00,804 DEBUG Calling createAppender on class org.apache.logging.log4j.core.appender.ConsoleAppender for element Console with params(PatternLayout(%m%n), null, target="null", name="STDOUT", ignoreExceptions="null")
2011-11-23 17:08:00,804 DEBUG Calling createFilter on class org.apache.logging.log4j.core.filter.ThresholdFilter for element ThresholdFilter with params(level="debug", onMatch="null", onMismatch="null")
2011-11-23 17:08:00,806 DEBUG Calling createAppender on class org.apache.logging.log4j.test.appender.ListAppender for element List with params(name="List", entryPerNewLine="null", raw="null", null, ThresholdFilter(DEBUG))
-2011-11-23 17:08:00,813 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(appender-ref="null", key="null", Node=Route)
-2011-11-23 17:08:00,823 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(appender-ref="STDOUT", key="Audit", Node=Route)
-2011-11-23 17:08:00,824 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(appender-ref="List", key="Service", Node=Route)
+2011-11-23 17:08:00,813 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(AppenderRef="null", key="null", Node=Route)
+2011-11-23 17:08:00,823 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(AppenderRef="STDOUT", key="Audit", Node=Route)
+2011-11-23 17:08:00,824 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(AppenderRef="List", key="Service", Node=Route)
2011-11-23 17:08:00,825 DEBUG Calling createRoutes on class org.apache.logging.log4j.core.appender.routing.Routes for element Routes with params(pattern="${dollar}{sd:type}", routes={Route(type=dynamic default), Route(type=static Reference=STDOUT key='Audit'), Route(type=static Reference=List key='Service')})
2011-11-23 17:08:00,827 DEBUG Calling createAppender on class org.apache.logging.log4j.core.appender.routing.RoutingAppender for element Routing with params(name="Routing", ignoreExceptions="null", Routes({Route(type=dynamic default),Route(type=static Reference=STDOUT key='Audit'),Route(type=static Reference=List key='Service')}), Configuration(RoutingTest), null, null)
2011-11-23 17:08:00,827 DEBUG Calling createAppenders on class org.apache.logging.log4j.core.config.plugins.AppendersPlugin for element appenders with params(appenders={STDOUT, List, Routing})
-2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element appender-ref with params(ref="Routing")
-2011-11-23 17:08:00,829 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig for element logger with params(additivity="false", level="info", name="EventLogger", appender-ref={Routing}, null)
-2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element appender-ref with params(ref="STDOUT")
-2011-11-23 17:08:00,831 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element root with params(additivity="null", level="error", appender-ref={STDOUT}, null)
+2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="Routing")
+2011-11-23 17:08:00,829 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig for element logger with params(additivity="false", level="info", name="EventLogger", AppenderRef={Routing}, null)
+2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="STDOUT")
+2011-11-23 17:08:00,831 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element root with params(additivity="null", level="error", AppenderRef={STDOUT}, null)
2011-11-23 17:08:00,833 DEBUG Calling createLoggers on class org.apache.logging.log4j.core.config.plugins.LoggersPlugin for element loggers with params(loggers={EventLogger, root})
2011-11-23 17:08:00,834 DEBUG Reconfiguration completed
2011-11-23 17:08:00,846 DEBUG Calling createLayout on class org.apache.logging.log4j.core.layout.PatternLayout for element PatternLayout with params(pattern="%d %p %c{1.} [%t] %m%n", Configuration(RoutingTest), null, charset="null")
@@ -1053,7 +1053,7 @@ public class Bar {
makes troubleshooting configuration errors possible. As an example, if the configuration above is changed
to have the status set to error and the logger declaration is:</p>
<pre class="prettyprint linenums"><![CDATA[<logger name="EventLogger" level="info" additivity="false">
- <appender-ref ref="Routng"/>
+ <AppenderRef ref="Routng"/>
</logger>]]></pre>
<p>
the following error message will be produced.
Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml (original)
+++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml Wed Aug 14 20:05:54 2013
@@ -143,7 +143,7 @@ public static class RootLogger extends L
@PluginFactory
public static LoggerConfig createLogger(@PluginAttr("additivity") String additivity,
@PluginAttr("level") String loggerLevel,
- @PluginElement("appender-ref") AppenderRef[] refs,
+ @PluginElement("AppenderRef") AppenderRef[] refs,
@PluginElement("filters") Filter filter) {
List<AppenderRef> appenderRefs = Arrays.asList(refs);
Level level;
Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml (original)
+++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml Wed Aug 14 20:05:54 2013
@@ -109,7 +109,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -151,10 +151,10 @@
</appenders>
<loggers>
<logger name="EventLogger" level="info">
- <appender-ref ref="Audit"/>
+ <AppenderRef ref="Audit"/>
</logger>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -220,7 +220,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -284,7 +284,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -311,8 +311,8 @@
<KeyValuePair key="eventId" value="Login"/>
<KeyValuePair key="eventId" value="Logout"/>
</MapFilter>
- <appender-ref ref="RollingFile">
- </appender-ref>
+ <AppenderRef ref="RollingFile">
+ </AppenderRef>
</root>
</loggers>
</configuration>]]></pre>
@@ -335,12 +335,12 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile">
+ <AppenderRef ref="RollingFile">
<MapFilter onMatch="ACCEPT" onMismatch="NEUTRAL" operator="or">
<KeyValuePair key="eventId" value="Login"/>
<KeyValuePair key="eventId" value="Logout"/>
</MapFilter>
- </appender-ref>
+ </AppenderRef>
</root>
</loggers>
</configuration>]]></pre>
@@ -396,7 +396,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -456,7 +456,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -523,7 +523,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -587,7 +587,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -608,7 +608,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
<ThreadContextMapFilter onMatch="ACCEPT" onMismatch="NEUTRAL" operator="or">
<KeyValuePair key="foo" value="bar"/>
<KeyValuePair key="User2" value="WARN"/>
@@ -670,7 +670,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -740,7 +740,7 @@
</appenders>
<loggers>
<root level="error">
- <appender-ref ref="RollingFile"/>
+ <AppenderRef ref="RollingFile"/>
</root>
</loggers>
</configuration>]]></pre>
Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml (original)
+++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml Wed Aug 14 20:05:54 2013
@@ -154,7 +154,7 @@ public class App {
</appenders>
<loggers>
<root level="trace">
- <appender-ref ref="log"/>
+ <AppenderRef ref="log"/>
</root>
</loggers>
</configuration>]]></pre>
Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml (original)
+++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml Wed Aug 14 20:05:54 2013
@@ -81,7 +81,7 @@
</category>
<root>
<priority value ="debug" />
- <appender-ref ref="STDOUT" />
+ <AppenderRef ref="STDOUT" />
</root>
</log4j:configuration>]]></pre>
<p>Log4j 2 XML configuration</p>
@@ -95,7 +95,7 @@
<loggers>
<logger name="org.apache.log4j.xml" level="info"/>
<root level="debug">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -119,11 +119,11 @@
</appender>
<category name="org.apache.log4j.xml">
<priority value="debug" />
- <appender-ref ref="A1" />
+ <AppenderRef ref="A1" />
</category>
<root>
<priority value ="debug" />
- <appender-ref ref="STDOUT" />
+ <AppenderRef ref="STDOUT" />
</root>
</log4j:configuration>]]></pre>
@@ -140,10 +140,10 @@
</appenders>
<loggers>
<logger name="org.apache.log4j.xml" level="debug">
- <appender-ref ref="A1"/>
+ <AppenderRef ref="A1"/>
</logger>
<root level="debug">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -169,11 +169,11 @@
</appender>
<category name="org.apache.log4j.xml">
<priority value="debug"/>
- <appender-ref ref="A1"/>
+ <AppenderRef ref="A1"/>
</category>
<root>
<priority value="debug"/>
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</log4j:configuration>]]></pre>
@@ -190,10 +190,10 @@
</appenders>
<loggers>
<logger name="org.apache.log4j.xml" level="debug">
- <appender-ref ref="A1"/>
+ <AppenderRef ref="A1"/>
</logger>
<root level="debug">
- <appender-ref ref="STDOUT"/>
+ <AppenderRef ref="STDOUT"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -204,7 +204,7 @@
<!DOCTYPE log4j:configuration PUBLIC "-//APACHE//DTD LOG4J 1.2//EN" "log4j.dtd">
<log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/" configDebug="true">
<appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
- <appender-ref ref="TEMP"/>
+ <AppenderRef ref="TEMP"/>
</appender>
<appender name="TEMP" class="org.apache.log4j.FileAppender">
<param name="File" value="temp"/>
@@ -214,7 +214,7 @@
</appender>
<root>
<priority value="debug"/>
- <appender-ref ref="ASYNC"/>
+ <AppenderRef ref="ASYNC"/>
</root>
</log4j:configuration>]]></pre>
@@ -226,12 +226,12 @@
<PatternLayout pattern="%d %-5p [%t] %C{2} (%F:%L) - %m%n"/>
</File>
<Async name="ASYNC">
- <appender-ref ref="TEMP"/>
+ <AppenderRef ref="TEMP"/>
</Async>
</appenders>
<loggers>
<root level="debug">
- <appender-ref ref="ASYNC"/>
+ <AppenderRef ref="ASYNC"/>
</root>
</loggers>
</configuration>]]></pre>
@@ -243,8 +243,8 @@
<!DOCTYPE log4j:configuration PUBLIC "-//APACHE//DTD LOG4J 1.2//EN" "log4j.dtd">
<log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/" configDebug="true">
<appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
- <appender-ref ref="TEMP"/>
- <appender-ref ref="CONSOLE"/>
+ <AppenderRef ref="TEMP"/>
+ <AppenderRef ref="CONSOLE"/>
</appender>
<appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender">
<layout class="org.apache.log4j.PatternLayout">
@@ -259,7 +259,7 @@
</appender>
<root>
<priority value="debug"/>
- <appender-ref ref="ASYNC"/>
+ <AppenderRef ref="ASYNC"/>
</root>
</log4j:configuration>]]></pre>
@@ -275,13 +275,13 @@
<PatternLayout pattern="%d %-5p [%t] %C{2} (%F:%L) - %m%n"/>
</File>
<Async name="ASYNC">
- <appender-ref ref="TEMP"/>
- <appender-ref ref="CONSOLE"/>
+ <AppenderRef ref="TEMP"/>
+ <AppenderRef ref="CONSOLE"/>
</Async>
</appenders>
<loggers>
<root level="debug">
- <appender-ref ref="ASYNC"/>
+ <AppenderRef ref="ASYNC"/>
</root>
</loggers>
</configuration>]]></pre>
Modified: logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml (original)
+++ logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml Wed Aug 14 20:05:54 2013
@@ -24,15 +24,15 @@
<loggers>
<logger name="EventLogger" level="info" additivity="false">
- <appender-ref ref="EventLogger"/>
+ <AppenderRef ref="EventLogger"/>
</logger>>
<logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
- <appender-ref ref="File"/>
+ <AppenderRef ref="File"/>
</logger>>
<root level="trace">
- <appender-ref ref="List"/>
+ <AppenderRef ref="List"/>
</root>
<logger name="IfEnabledTagTest" level="warn" />
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Aug 16, 2013 at 9:38 AM, Remko Popma <re...@gmail.com> wrote:
> Maybe we just need another plugin for the 2nd name then. Subclass or
> delegate?
This is the kind of growing pains / evolution alpha or beta software goes
through IMO. We are not jumping through hoops for the change from the "fast
file" appender to the "random access file" appender for example.
Doing a search and replace from "appender-ref" to "AppenderRef" is not a
big deal IMO.
Gary
>
> On Friday, August 16, 2013, Ralph Goers wrote:
>
>> I had the same thought. People switching from log4j 1 or logback will
>> probably make that mistake a lot. Plus this breaks virtually everyone
>> currently using Log4j 2. The problem is that I don't think there is
>> currently a way for a plugin to have 2 names.
>>
>> Sent from my iPad
>>
>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>
>> Would it be an idea to support both appender-ref and appenderRef
>> attributes?
>>
>>
>>
>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory <ga...@gmail.com>wrote:
>>
>> I never thought that Log4J 2 configuration files should be backward
>> compatible with version 1, and even less so with a different product.
>>
>> Gary
>>
>>
>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers <ra...@dslextreme.com>wrote:
>>
>> Now that I see this it kind of scares me. Log4j 1.x and Logback both use
>> appender-ref. Anyone using Log4j 2 will now be broken.
>>
>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -30,10 +30,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="org.apache.test" level="trace" additivity="false">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -25,7 +25,7 @@
>> > <loggers>
>> > <logger name="org.foo" level="DEBUG" />
>> > <root level="TRACE">
>> > - <appender-ref ref="Console" />
>> > + <AppenderRef ref="Console" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>> (original)
>>
>>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Remko Popma <re...@gmail.com>.
I'm fine with number 2 (for the elements and attributes that used to have a
hyphen in their name).
Not a big fan of 1, not sure what the benefit would be.
On Sat, Aug 17, 2013 at 10:58 AM, Ralph Goers <ra...@dslextreme.com>wrote:
> Easily done, assuming we have consensus. I am hearing two options:
> 1) strip '-' characters from element names.
> 2) allow aliases for element names.
>
> These are not mutually exclusive. I see no reason not to go ahead with
> number 2 and we can continue to discuss where else number 1 might be used.
>
> Ralph
>
> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>
> Ralph,
> Don't forget the error-ref attribute for AsyncAppender.
>
> Remko
>
> On Saturday, August 17, 2013, Ralph Goers wrote:
>
>> I'm not in favor of just allowing arbitrary '-' characters wherever users
>> want. But allowing aliases makes it possible to allow for variations. I
>> already have this working.
>>
>> Ralph
>>
>>
>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>
>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
>>
>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>>
>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>> stick with he dash format due to folks being familiar with it from
>> log4j 1.
>>
>>
>> That's a thin argument IMO considering you'll have to read the version 2
>> config docs to get off the ground anyway, even if you know your way around
>> version 1.
>>
>>
>> And this is also an opportunity to make our config code even fancier by
>> normalizing '-' chars ;)
>>
>> Gary
>>
>>
>>
>> Gary
>>
>>
>>
>> Scott
>>
>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>> > <ra...@dslextreme.com>wrote:
>> >
>> >> I'm adding an aliases attribute to the Plugin annotation.
>> >>
>> >
>> > Hold on to your horses ;)
>> >
>> > Another way to look at this is that our config parsing that is already
>> > case-insensitive could be augmented to strip out "-"s, no aliases
>> needed.
>> >
>> > As someone pointed out here, some folks like-to-talk-like-this (see
>> JPA).
>> >
>> > Gary
>> >
>> >
>> >>
>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>> >>
>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>> >> delegate?
>> >>
>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>> >>
>> >>> I had the same thought. People switching from log4j 1 or logback will
>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>> >>> currently using Log4j 2. The problem is that I don't think there is
>> >>> currently a way for a plugin to have 2 names.
>> >>>
>> >>> Sent from my iPad
>> >>>
>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
>> wrote:
>> >>>
>> >>> Would it be an idea to support both appender-ref and appenderRef
>> >>> attributes?
>> >>>
>> >>>
>> >>>
>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>> >>> <ga...@gmail.com>wrote:
>> >>>
>> >>> I never thought that Log4J 2 configuration files should be backward
>> >>> compatible with version 1, and even less so with a different product.
>> >>>
>> >>> Gary
>> >>>
>> >>>
>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>> >>> <ra...@dslextreme.com>wrote:
>> >>>
>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>> >>> use
>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>> >>>
>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>> >>>
>> >>> > Modified:
>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> >>> > URL:
>> >>>
>> <http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff>
>>
>>
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
For an implementation of allowing hyphens, please see the patch in
https://issues.apache.org/jira/browse/LOG4J2-361:
https://issues.apache.org/jira/secure/attachment/12598574/log4j2-361.diff
Note that there is no existing JSONConfigurationTest like there is an
XMLConfigurationTest.
Gary
On Sat, Aug 17, 2013 at 2:14 AM, Ralph Goers <ra...@dslextreme.com>wrote:
> On Aug 10 Nick said "I actually really like hyphenated attributes, but I
> like consistency better.". However, that doesn't imply that he is going to
> like allowing '-' to appear anywhere and be stripped out. Providing
> aliases would be a more sane way to do that.
>
> Ralph
>
>
>
>
> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>
> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com>wrote:
>
>> So far yours is the only vote for that. Anyone else?
>>
>
> Whomever else mentioned it in the first place! ;) I can't recall who...
> but it's 2am here...
> G
>
>>
>> Ralph
>>
>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>
>> I think we should do both.
>>
>> Gary
>>
>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>
>> Easily done, assuming we have consensus. I am hearing two options:
>> 1) strip '-' characters from element names.
>> 2) allow aliases for element names.
>>
>> These are not mutually exclusive. I see no reason not to go ahead with
>> number 2 and we can continue to discuss where else number 1 might be used.
>>
>> Ralph
>>
>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>
>> Ralph,
>> Don't forget the error-ref attribute for AsyncAppender.
>>
>> Remko
>>
>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>
>>> I'm not in favor of just allowing arbitrary '-' characters wherever
>>> users want. But allowing aliases makes it possible to allow for variations.
>>> I already have this working.
>>>
>>> Ralph
>>>
>>>
>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>
>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
>>>
>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>>>
>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>> stick with he dash format due to folks being familiar with it from
>>> log4j 1.
>>>
>>>
>>> That's a thin argument IMO considering you'll have to read the version 2
>>> config docs to get off the ground anyway, even if you know your way around
>>> version 1.
>>>
>>>
>>> And this is also an opportunity to make our config code even fancier by
>>> normalizing '-' chars ;)
>>>
>>> Gary
>>>
>>>
>>>
>>> Gary
>>>
>>>
>>>
>>> Scott
>>>
>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>> > <ra...@dslextreme.com>wrote:
>>> >
>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>> >>
>>> >
>>> > Hold on to your horses ;)
>>> >
>>> > Another way to look at this is that our config parsing that is already
>>> > case-insensitive could be augmented to strip out "-"s, no aliases
>>> needed.
>>> >
>>> > As someone pointed out here, some folks like-to-talk-like-this (see
>>> JPA).
>>> >
>>> > Gary
>>> >
>>> >
>>> >>
>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>> >>
>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>> >> delegate?
>>> >>
>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>> >>
>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>> >>> currently a way for a plugin to have 2 names.
>>> >>>
>>> >>> Sent from my iPad
>>> >>>
>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
>>> wrote:
>>> >>>
>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>> >>> attributes?
>>> >>>
>>> >>>
>>> >>>
>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>> >>> <ga...@gmail.com>wrote:
>>> >>>
>>> >>> I never thought that Log4J 2 configuration files should be backward
>>> >>> compatible with version 1, and even less so with a different product.
>>> >>>
>>> >>> Gary
>>> >>>
>>> >>>
>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>> >>> <ra...@dslextreme.com>wrote:
>>> >>>
>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>> >>> use
>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>> >>>
>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>> >>>
>>> >>> > Modified:
>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>> >>> > URL:
>>> >>>
>>> <http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff>
>>>
>>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
I've not received any comments on this patch. I plan to commit it tomorrow.
Ralph
On Aug 17, 2013, at 9:01 AM, Ralph Goers wrote:
> I've added it to LOG4J2-360.
>
> Ralph
>
> On Aug 17, 2013, at 8:59 AM, Ralph Goers wrote:
>
>> I will just upload what I currently have as a patch to the Jira issue and then you can take a look. I don't think it is all that messy myself.
>>
>> Ralph
>>
>> On Aug 17, 2013, at 8:52 AM, Nick Williams wrote:
>>
>>> I do see the upside to how you do it, but at the same time annotating a method parameter with BOTH annotations is going to get messy. Hmmm...
>>>
>>> I'm not sure what I think. How important is being able to search for plugins with aliases?
>>>
>>> N
>>>
>>> On Aug 17, 2013, at 10:45 AM, Ralph Goers wrote:
>>>
>>>> This isn't quite what I did but I can certainly change it if you think what you have below is better. @Plugin and @PluginAttr are unchanged. @PluginAliases allows you to specify one or more aliases as
>>>>
>>>> @PluginAliases("appender-ref")
>>>>
>>>> or
>>>>
>>>> @PluginAliases({"appender-ref", "AppenderReference"})
>>>>
>>>> You add the PluginAliases annotation to the plugin class declaration and/or the plugin factory's parameter declaration.
>>>>
>>>> The advantage I see in this is that Plugins and attributes still only have one primary name and it is pretty easy to find plugins with aliases just by searching for uses of the annotation. With what you have below the first item in the array would have to be presumed to be the primary name.
>>>>
>>>> Ralph
>>>>
>>>>
>>>> On Aug 17, 2013, at 7:57 AM, Nick Williams wrote:
>>>>
>>>>> Nope.
>>>>>
>>>>> - String name() in @Plugin (for element-mapped plugin classes) becomes String[] names(). Annotation can be used @Plugin(names = "element") for single-worders or @Plugin(names = { "elementName", "element-name" }) for multi-worders.
>>>>>
>>>>> - String value() in @PluginAttr (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Annotation can be used @PluginAttr("attribute") for single-worders or @Plugin({ "attributeName", "attribute-name" }) for multi-worders.
>>>>>
>>>>> - String value() in @PluginElement (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Ditto on usage as $PluginAttr.
>>>>>
>>>>> Nick
>>>>>
>>>>> On Aug 17, 2013, at 9:49 AM, Gary Gregory wrote:
>>>>>
>>>>>> I am ok with an alias feature.
>>>>>>
>>>>>> Like this?
>>>>>>
>>>>>> @pluginElement(names="a, b, c")
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> On Aug 17, 2013, at 10:19, Ralph Goers <rg...@apache.org> wrote:
>>>>>>
>>>>>>> So I think Remko and I agree that consistency is good but that there are two cases where exceptions should be made. If I commit the change to alias those two things is anyone so strongly against it that they would veto it? If not then I would like to commit it.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>> On Aug 17, 2013, at 12:45 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>
>>>>>>>> ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
>>>>>>>> but that is not the point.
>>>>>>>>
>>>>>>>> I think the rule "config files are case-insensite" is much a more intuitive rule than "all hyphens are stripped from attribute and element names".
>>>>>>>>
>>>>>>>> To me, the "-ref" extension in the <appender-ref> element is a nice, visually distinct indicator that this element points to another element in the configuration. To me, these pointer elements/attributes are special elements and attributes and we actually *lose* something if we bend over backwards to make them look consistent with other elements. It's okay if they look different because they *are* different.
>>>>>>>>
>>>>>>>> If we prefer not to have aliases then I propose we revert back the appender-ref and error-ref elements to the hyphen version. I think they are better names.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>> Dancing angels and pin heads:
>>>>>>>>
>>>>>>>> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>>>>>>>>
>>>>>>>> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>>>>>>>>
>>>>>>>> How is that any better/worse, more/less confusing?
>>>>>>>>
>>>>>>>> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>>>>>>>
>>>>>>>> Ralph
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>>>>>>>
>>>>>>>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>>>>>>>
>>>>>>>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>>>>>>>
>>>>>>>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>>>>>>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>>>>>>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>>>>>>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>>>>>>>
>>>>>>>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>>>>>>>
>>>>>>>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>>>>>>>
>>>>>>>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>>>>>>>
>>>>>>>>> - Consistency, consistency, consistency.
>>>>>>>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>>>>>>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>>>>>>>> - camelCase elements AND camelCase attributes.
>>>>>>>>> - PascalCase elements AND PascalCase attributes.
>>>>>>>>>
>>>>>>>>> Nick
>>>>>>>>>
>>>>>>>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>>>>>>>
>>>>>>>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>>>>>>>
>>>>>>>>>> Ralph
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>>>>>>>
>>>>>>>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>>>>> So far yours is the only vote for that. Anyone else?
>>>>>>>>>>>
>>>>>>>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>>>>>>>> G
>>>>>>>>>>>
>>>>>>>>>>> Ralph
>>>>>>>>>>>
>>>>>>>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>>>>>>>
>>>>>>>>>>>> I think we should do both.
>>>>>>>>>>>>
>>>>>>>>>>>> Gary
>>>>>>>>>>>>
>>>>>>>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>>>>>>>> 1) strip '-' characters from element names.
>>>>>>>>>>>>> 2) allow aliases for element names.
>>>>>>>>>>>>>
>>>>>>>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Ralph
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Ralph,
>>>>>>>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Remko
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Ralph
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>>>>>>>> log4j 1.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Scott
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>>>>>> On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Hold on to your horses ;)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Another way to look at this is that our config parsing that is already
>>>>>>>>>>>>>>>> case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>>>>>>>>>> delegate?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>>>>>>>>>>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>>>>>>>>>>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>>>>>>>>>>> currently a way for a plugin to have 2 names.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Sent from my iPad
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>>>>>>>>>>> attributes?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>>>>>>>>>>> <ga...@gmail.com>wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>>>>>>>>>>> compatible with version 1, and even less so with a different product.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>>>>>>>>>>> use
>>>>>>>>>>>>>>>>>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Modified:
>>>>>>>>>>>>>>>>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>>>>> JUnit in Action, Second Edition
>>>>>>>>>>> Spring Batch in Action
>>>>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>>>>> Home: http://garygregory.com/
>>>>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>> JUnit in Action, Second Edition
>>>>>>>> Spring Batch in Action
>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>> Home: http://garygregory.com/
>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
I've added it to LOG4J2-360.
Ralph
On Aug 17, 2013, at 8:59 AM, Ralph Goers wrote:
> I will just upload what I currently have as a patch to the Jira issue and then you can take a look. I don't think it is all that messy myself.
>
> Ralph
>
> On Aug 17, 2013, at 8:52 AM, Nick Williams wrote:
>
>> I do see the upside to how you do it, but at the same time annotating a method parameter with BOTH annotations is going to get messy. Hmmm...
>>
>> I'm not sure what I think. How important is being able to search for plugins with aliases?
>>
>> N
>>
>> On Aug 17, 2013, at 10:45 AM, Ralph Goers wrote:
>>
>>> This isn't quite what I did but I can certainly change it if you think what you have below is better. @Plugin and @PluginAttr are unchanged. @PluginAliases allows you to specify one or more aliases as
>>>
>>> @PluginAliases("appender-ref")
>>>
>>> or
>>>
>>> @PluginAliases({"appender-ref", "AppenderReference"})
>>>
>>> You add the PluginAliases annotation to the plugin class declaration and/or the plugin factory's parameter declaration.
>>>
>>> The advantage I see in this is that Plugins and attributes still only have one primary name and it is pretty easy to find plugins with aliases just by searching for uses of the annotation. With what you have below the first item in the array would have to be presumed to be the primary name.
>>>
>>> Ralph
>>>
>>>
>>> On Aug 17, 2013, at 7:57 AM, Nick Williams wrote:
>>>
>>>> Nope.
>>>>
>>>> - String name() in @Plugin (for element-mapped plugin classes) becomes String[] names(). Annotation can be used @Plugin(names = "element") for single-worders or @Plugin(names = { "elementName", "element-name" }) for multi-worders.
>>>>
>>>> - String value() in @PluginAttr (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Annotation can be used @PluginAttr("attribute") for single-worders or @Plugin({ "attributeName", "attribute-name" }) for multi-worders.
>>>>
>>>> - String value() in @PluginElement (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Ditto on usage as $PluginAttr.
>>>>
>>>> Nick
>>>>
>>>> On Aug 17, 2013, at 9:49 AM, Gary Gregory wrote:
>>>>
>>>>> I am ok with an alias feature.
>>>>>
>>>>> Like this?
>>>>>
>>>>> @pluginElement(names="a, b, c")
>>>>>
>>>>> Gary
>>>>>
>>>>> On Aug 17, 2013, at 10:19, Ralph Goers <rg...@apache.org> wrote:
>>>>>
>>>>>> So I think Remko and I agree that consistency is good but that there are two cases where exceptions should be made. If I commit the change to alias those two things is anyone so strongly against it that they would veto it? If not then I would like to commit it.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>> On Aug 17, 2013, at 12:45 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>
>>>>>>> ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
>>>>>>> but that is not the point.
>>>>>>>
>>>>>>> I think the rule "config files are case-insensite" is much a more intuitive rule than "all hyphens are stripped from attribute and element names".
>>>>>>>
>>>>>>> To me, the "-ref" extension in the <appender-ref> element is a nice, visually distinct indicator that this element points to another element in the configuration. To me, these pointer elements/attributes are special elements and attributes and we actually *lose* something if we bend over backwards to make them look consistent with other elements. It's okay if they look different because they *are* different.
>>>>>>>
>>>>>>> If we prefer not to have aliases then I propose we revert back the appender-ref and error-ref elements to the hyphen version. I think they are better names.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>> Dancing angels and pin heads:
>>>>>>>
>>>>>>> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>>>>>>>
>>>>>>> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>>>>>>>
>>>>>>> How is that any better/worse, more/less confusing?
>>>>>>>
>>>>>>> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>>>>>>
>>>>>>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>>>>>>
>>>>>>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>>>>>>
>>>>>>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>>>>>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>>>>>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>>>>>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>>>>>>
>>>>>>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>>>>>>
>>>>>>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>>>>>>
>>>>>>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>>>>>>
>>>>>>>> - Consistency, consistency, consistency.
>>>>>>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>>>>>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>>>>>>> - camelCase elements AND camelCase attributes.
>>>>>>>> - PascalCase elements AND PascalCase attributes.
>>>>>>>>
>>>>>>>> Nick
>>>>>>>>
>>>>>>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>>>>>>
>>>>>>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>>>>>>
>>>>>>>>> Ralph
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>>>>>>
>>>>>>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>>>> So far yours is the only vote for that. Anyone else?
>>>>>>>>>>
>>>>>>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>>>>>>> G
>>>>>>>>>>
>>>>>>>>>> Ralph
>>>>>>>>>>
>>>>>>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>>>>>>
>>>>>>>>>>> I think we should do both.
>>>>>>>>>>>
>>>>>>>>>>> Gary
>>>>>>>>>>>
>>>>>>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>>>>>>> 1) strip '-' characters from element names.
>>>>>>>>>>>> 2) allow aliases for element names.
>>>>>>>>>>>>
>>>>>>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>>>>>>
>>>>>>>>>>>> Ralph
>>>>>>>>>>>>
>>>>>>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Ralph,
>>>>>>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Remko
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Ralph
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>>>>>>> log4j 1.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Scott
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>>>>> On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hold on to your horses ;)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Another way to look at this is that our config parsing that is already
>>>>>>>>>>>>>>> case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>>>>>>>>> delegate?
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>>>>>>>>>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>>>>>>>>>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>>>>>>>>>> currently a way for a plugin to have 2 names.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Sent from my iPad
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>>>>>>>>>> attributes?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>>>>>>>>>> <ga...@gmail.com>wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>>>>>>>>>> compatible with version 1, and even less so with a different product.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>>>>>>>>>> use
>>>>>>>>>>>>>>>>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Modified:
>>>>>>>>>>>>>>>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>>>> JUnit in Action, Second Edition
>>>>>>>>>> Spring Batch in Action
>>>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>>>> Home: http://garygregory.com/
>>>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>> JUnit in Action, Second Edition
>>>>>>> Spring Batch in Action
>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>> Home: http://garygregory.com/
>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
I will just upload what I currently have as a patch to the Jira issue and then you can take a look. I don't think it is all that messy myself.
Ralph
On Aug 17, 2013, at 8:52 AM, Nick Williams wrote:
> I do see the upside to how you do it, but at the same time annotating a method parameter with BOTH annotations is going to get messy. Hmmm...
>
> I'm not sure what I think. How important is being able to search for plugins with aliases?
>
> N
>
> On Aug 17, 2013, at 10:45 AM, Ralph Goers wrote:
>
>> This isn't quite what I did but I can certainly change it if you think what you have below is better. @Plugin and @PluginAttr are unchanged. @PluginAliases allows you to specify one or more aliases as
>>
>> @PluginAliases("appender-ref")
>>
>> or
>>
>> @PluginAliases({"appender-ref", "AppenderReference"})
>>
>> You add the PluginAliases annotation to the plugin class declaration and/or the plugin factory's parameter declaration.
>>
>> The advantage I see in this is that Plugins and attributes still only have one primary name and it is pretty easy to find plugins with aliases just by searching for uses of the annotation. With what you have below the first item in the array would have to be presumed to be the primary name.
>>
>> Ralph
>>
>>
>> On Aug 17, 2013, at 7:57 AM, Nick Williams wrote:
>>
>>> Nope.
>>>
>>> - String name() in @Plugin (for element-mapped plugin classes) becomes String[] names(). Annotation can be used @Plugin(names = "element") for single-worders or @Plugin(names = { "elementName", "element-name" }) for multi-worders.
>>>
>>> - String value() in @PluginAttr (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Annotation can be used @PluginAttr("attribute") for single-worders or @Plugin({ "attributeName", "attribute-name" }) for multi-worders.
>>>
>>> - String value() in @PluginElement (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Ditto on usage as $PluginAttr.
>>>
>>> Nick
>>>
>>> On Aug 17, 2013, at 9:49 AM, Gary Gregory wrote:
>>>
>>>> I am ok with an alias feature.
>>>>
>>>> Like this?
>>>>
>>>> @pluginElement(names="a, b, c")
>>>>
>>>> Gary
>>>>
>>>> On Aug 17, 2013, at 10:19, Ralph Goers <rg...@apache.org> wrote:
>>>>
>>>>> So I think Remko and I agree that consistency is good but that there are two cases where exceptions should be made. If I commit the change to alias those two things is anyone so strongly against it that they would veto it? If not then I would like to commit it.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Aug 17, 2013, at 12:45 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>
>>>>>> ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
>>>>>> but that is not the point.
>>>>>>
>>>>>> I think the rule "config files are case-insensite" is much a more intuitive rule than "all hyphens are stripped from attribute and element names".
>>>>>>
>>>>>> To me, the "-ref" extension in the <appender-ref> element is a nice, visually distinct indicator that this element points to another element in the configuration. To me, these pointer elements/attributes are special elements and attributes and we actually *lose* something if we bend over backwards to make them look consistent with other elements. It's okay if they look different because they *are* different.
>>>>>>
>>>>>> If we prefer not to have aliases then I propose we revert back the appender-ref and error-ref elements to the hyphen version. I think they are better names.
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>> Dancing angels and pin heads:
>>>>>>
>>>>>> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>>>>>>
>>>>>> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>>>>>>
>>>>>> How is that any better/worse, more/less confusing?
>>>>>>
>>>>>> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>>>>>
>>>>>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>>>>>
>>>>>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>>>>>
>>>>>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>>>>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>>>>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>>>>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>>>>>
>>>>>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>>>>>
>>>>>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>>>>>
>>>>>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>>>>>
>>>>>>> - Consistency, consistency, consistency.
>>>>>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>>>>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>>>>>> - camelCase elements AND camelCase attributes.
>>>>>>> - PascalCase elements AND PascalCase attributes.
>>>>>>>
>>>>>>> Nick
>>>>>>>
>>>>>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>>>>>
>>>>>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>>>>>
>>>>>>>> Ralph
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>>>>>
>>>>>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>>> So far yours is the only vote for that. Anyone else?
>>>>>>>>>
>>>>>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>>>>>> G
>>>>>>>>>
>>>>>>>>> Ralph
>>>>>>>>>
>>>>>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>>>>>
>>>>>>>>>> I think we should do both.
>>>>>>>>>>
>>>>>>>>>> Gary
>>>>>>>>>>
>>>>>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>>>>>> 1) strip '-' characters from element names.
>>>>>>>>>>> 2) allow aliases for element names.
>>>>>>>>>>>
>>>>>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>>>>>
>>>>>>>>>>> Ralph
>>>>>>>>>>>
>>>>>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Ralph,
>>>>>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>>>>>
>>>>>>>>>>>> Remko
>>>>>>>>>>>>
>>>>>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>>>>>
>>>>>>>>>>>> Ralph
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>>>>>> log4j 1.
>>>>>>>>>>>>>
>>>>>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>>>>>
>>>>>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Scott
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>>>> On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hold on to your horses ;)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Another way to look at this is that our config parsing that is already
>>>>>>>>>>>>>> case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>>>>>>>> delegate?
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>>>>>>>>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>>>>>>>>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>>>>>>>>> currently a way for a plugin to have 2 names.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Sent from my iPad
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>>>>>>>>> attributes?
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>>>>>>>>> <ga...@gmail.com>wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>>>>>>>>> compatible with version 1, and even less so with a different product.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>>>>>>>>> use
>>>>>>>>>>>>>>>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Modified:
>>>>>>>>>>>>>>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>>> JUnit in Action, Second Edition
>>>>>>>>> Spring Batch in Action
>>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>>> Home: http://garygregory.com/
>>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> JUnit in Action, Second Edition
>>>>>> Spring Batch in Action
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Nick Williams <ni...@nicholaswilliams.net>.
I do see the upside to how you do it, but at the same time annotating a method parameter with BOTH annotations is going to get messy. Hmmm...
I'm not sure what I think. How important is being able to search for plugins with aliases?
N
On Aug 17, 2013, at 10:45 AM, Ralph Goers wrote:
> This isn't quite what I did but I can certainly change it if you think what you have below is better. @Plugin and @PluginAttr are unchanged. @PluginAliases allows you to specify one or more aliases as
>
> @PluginAliases("appender-ref")
>
> or
>
> @PluginAliases({"appender-ref", "AppenderReference"})
>
> You add the PluginAliases annotation to the plugin class declaration and/or the plugin factory's parameter declaration.
>
> The advantage I see in this is that Plugins and attributes still only have one primary name and it is pretty easy to find plugins with aliases just by searching for uses of the annotation. With what you have below the first item in the array would have to be presumed to be the primary name.
>
> Ralph
>
>
> On Aug 17, 2013, at 7:57 AM, Nick Williams wrote:
>
>> Nope.
>>
>> - String name() in @Plugin (for element-mapped plugin classes) becomes String[] names(). Annotation can be used @Plugin(names = "element") for single-worders or @Plugin(names = { "elementName", "element-name" }) for multi-worders.
>>
>> - String value() in @PluginAttr (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Annotation can be used @PluginAttr("attribute") for single-worders or @Plugin({ "attributeName", "attribute-name" }) for multi-worders.
>>
>> - String value() in @PluginElement (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Ditto on usage as $PluginAttr.
>>
>> Nick
>>
>> On Aug 17, 2013, at 9:49 AM, Gary Gregory wrote:
>>
>>> I am ok with an alias feature.
>>>
>>> Like this?
>>>
>>> @pluginElement(names="a, b, c")
>>>
>>> Gary
>>>
>>> On Aug 17, 2013, at 10:19, Ralph Goers <rg...@apache.org> wrote:
>>>
>>>> So I think Remko and I agree that consistency is good but that there are two cases where exceptions should be made. If I commit the change to alias those two things is anyone so strongly against it that they would veto it? If not then I would like to commit it.
>>>>
>>>> Ralph
>>>>
>>>> On Aug 17, 2013, at 12:45 AM, Remko Popma <re...@gmail.com> wrote:
>>>>
>>>>> ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
>>>>> but that is not the point.
>>>>>
>>>>> I think the rule "config files are case-insensite" is much a more intuitive rule than "all hyphens are stripped from attribute and element names".
>>>>>
>>>>> To me, the "-ref" extension in the <appender-ref> element is a nice, visually distinct indicator that this element points to another element in the configuration. To me, these pointer elements/attributes are special elements and attributes and we actually *lose* something if we bend over backwards to make them look consistent with other elements. It's okay if they look different because they *are* different.
>>>>>
>>>>> If we prefer not to have aliases then I propose we revert back the appender-ref and error-ref elements to the hyphen version. I think they are better names.
>>>>>
>>>>>
>>>>>
>>>>> On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>> Dancing angels and pin heads:
>>>>>
>>>>> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>>>>>
>>>>> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>>>>>
>>>>> How is that any better/worse, more/less confusing?
>>>>>
>>>>> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>>>>>
>>>>> Gary
>>>>>
>>>>>
>>>>>
>>>>> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>>>>
>>>>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>>>>
>>>>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>>>>
>>>>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>>>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>>>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>>>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>>>>
>>>>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>>>>
>>>>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>>>>
>>>>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>>>>
>>>>>> - Consistency, consistency, consistency.
>>>>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>>>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>>>>> - camelCase elements AND camelCase attributes.
>>>>>> - PascalCase elements AND PascalCase attributes.
>>>>>>
>>>>>> Nick
>>>>>>
>>>>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>>>>
>>>>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>>>>
>>>>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>> So far yours is the only vote for that. Anyone else?
>>>>>>>>
>>>>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>>>>> G
>>>>>>>>
>>>>>>>> Ralph
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>>>>
>>>>>>>>> I think we should do both.
>>>>>>>>>
>>>>>>>>> Gary
>>>>>>>>>
>>>>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>>>
>>>>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>>>>> 1) strip '-' characters from element names.
>>>>>>>>>> 2) allow aliases for element names.
>>>>>>>>>>
>>>>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>>>>
>>>>>>>>>> Ralph
>>>>>>>>>>
>>>>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>>>>
>>>>>>>>>>> Ralph,
>>>>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>>>>
>>>>>>>>>>> Remko
>>>>>>>>>>>
>>>>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>>>>
>>>>>>>>>>> Ralph
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>>>>> log4j 1.
>>>>>>>>>>>>
>>>>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>>>>
>>>>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>>>>
>>>>>>>>>>>> Gary
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Gary
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Scott
>>>>>>>>>>>>
>>>>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>>> On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Hold on to your horses ;)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Another way to look at this is that our config parsing that is already
>>>>>>>>>>>>> case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>>>>>>
>>>>>>>>>>>>> As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>>>>>>
>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>>>>>>> delegate?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>>>>>>>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>>>>>>>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>>>>>>>> currently a way for a plugin to have 2 names.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Sent from my iPad
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>>>>>>>> attributes?
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>>>>>>>> <ga...@gmail.com>wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>>>>>>>> compatible with version 1, and even less so with a different product.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>>>>>>>> use
>>>>>>>>>>>>>>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Modified:
>>>>>>>>>>>>>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>> JUnit in Action, Second Edition
>>>>>>>> Spring Batch in Action
>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>> Home: http://garygregory.com/
>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> JUnit in Action, Second Edition
>>>>> Spring Batch in Action
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
This isn't quite what I did but I can certainly change it if you think what you have below is better. @Plugin and @PluginAttr are unchanged. @PluginAliases allows you to specify one or more aliases as
@PluginAliases("appender-ref")
or
@PluginAliases({"appender-ref", "AppenderReference"})
You add the PluginAliases annotation to the plugin class declaration and/or the plugin factory's parameter declaration.
The advantage I see in this is that Plugins and attributes still only have one primary name and it is pretty easy to find plugins with aliases just by searching for uses of the annotation. With what you have below the first item in the array would have to be presumed to be the primary name.
Ralph
On Aug 17, 2013, at 7:57 AM, Nick Williams wrote:
> Nope.
>
> - String name() in @Plugin (for element-mapped plugin classes) becomes String[] names(). Annotation can be used @Plugin(names = "element") for single-worders or @Plugin(names = { "elementName", "element-name" }) for multi-worders.
>
> - String value() in @PluginAttr (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Annotation can be used @PluginAttr("attribute") for single-worders or @Plugin({ "attributeName", "attribute-name" }) for multi-worders.
>
> - String value() in @PluginElement (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Ditto on usage as $PluginAttr.
>
> Nick
>
> On Aug 17, 2013, at 9:49 AM, Gary Gregory wrote:
>
>> I am ok with an alias feature.
>>
>> Like this?
>>
>> @pluginElement(names="a, b, c")
>>
>> Gary
>>
>> On Aug 17, 2013, at 10:19, Ralph Goers <rg...@apache.org> wrote:
>>
>>> So I think Remko and I agree that consistency is good but that there are two cases where exceptions should be made. If I commit the change to alias those two things is anyone so strongly against it that they would veto it? If not then I would like to commit it.
>>>
>>> Ralph
>>>
>>> On Aug 17, 2013, at 12:45 AM, Remko Popma <re...@gmail.com> wrote:
>>>
>>>> ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
>>>> but that is not the point.
>>>>
>>>> I think the rule "config files are case-insensite" is much a more intuitive rule than "all hyphens are stripped from attribute and element names".
>>>>
>>>> To me, the "-ref" extension in the <appender-ref> element is a nice, visually distinct indicator that this element points to another element in the configuration. To me, these pointer elements/attributes are special elements and attributes and we actually *lose* something if we bend over backwards to make them look consistent with other elements. It's okay if they look different because they *are* different.
>>>>
>>>> If we prefer not to have aliases then I propose we revert back the appender-ref and error-ref elements to the hyphen version. I think they are better names.
>>>>
>>>>
>>>>
>>>> On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>> Dancing angels and pin heads:
>>>>
>>>> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>>>>
>>>> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>>>>
>>>> How is that any better/worse, more/less confusing?
>>>>
>>>> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>>>>
>>>> Gary
>>>>
>>>>
>>>>
>>>> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>>>
>>>> Ralph
>>>>
>>>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>>>
>>>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>>>
>>>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>>>
>>>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>>>
>>>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>>>
>>>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>>>
>>>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>>>
>>>>> - Consistency, consistency, consistency.
>>>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>>>> - camelCase elements AND camelCase attributes.
>>>>> - PascalCase elements AND PascalCase attributes.
>>>>>
>>>>> Nick
>>>>>
>>>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>>>
>>>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>>>
>>>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>> So far yours is the only vote for that. Anyone else?
>>>>>>>
>>>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>>>> G
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>>>
>>>>>>>> I think we should do both.
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>>
>>>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>>>> 1) strip '-' characters from element names.
>>>>>>>>> 2) allow aliases for element names.
>>>>>>>>>
>>>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>>>
>>>>>>>>> Ralph
>>>>>>>>>
>>>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>>>
>>>>>>>>>> Ralph,
>>>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>>>
>>>>>>>>>> Remko
>>>>>>>>>>
>>>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>>>
>>>>>>>>>> Ralph
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>>>
>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>>>> log4j 1.
>>>>>>>>>>>
>>>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>>>
>>>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>>>
>>>>>>>>>>> Gary
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Gary
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Scott
>>>>>>>>>>>
>>>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>> On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Hold on to your horses ;)
>>>>>>>>>>>>
>>>>>>>>>>>> Another way to look at this is that our config parsing that is already
>>>>>>>>>>>> case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>>>>>
>>>>>>>>>>>> As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>>>>>
>>>>>>>>>>>> Gary
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>>>>>> delegate?
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>>>>>>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>>>>>>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>>>>>>> currently a way for a plugin to have 2 names.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Sent from my iPad
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>>>>>>> attributes?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>>>>>>> <ga...@gmail.com>wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>>>>>>> compatible with version 1, and even less so with a different product.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>>>>>>> use
>>>>>>>>>>>>>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Modified:
>>>>>>>>>>>>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>> JUnit in Action, Second Edition
>>>>>>> Spring Batch in Action
>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>> Home: http://garygregory.com/
>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> JUnit in Action, Second Edition
>>>> Spring Batch in Action
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
Ok that's a standard use of annotations. Looks good.
Gary
On Aug 17, 2013, at 10:57, Nick Williams <ni...@nicholaswilliams.net> wrote:
> Nope.
>
> - String name() in @Plugin (for element-mapped plugin classes) becomes String[] names(). Annotation can be used @Plugin(names = "element") for single-worders or @Plugin(names = { "elementName", "element-name" }) for multi-worders.
>
> - String value() in @PluginAttr (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Annotation can be used @PluginAttr("attribute") for single-worders or @Plugin({ "attributeName", "attribute-name" }) for multi-worders.
>
> - String value() in @PluginElement (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Ditto on usage as $PluginAttr.
>
> Nick
>
> On Aug 17, 2013, at 9:49 AM, Gary Gregory wrote:
>
>> I am ok with an alias feature.
>>
>> Like this?
>>
>> @pluginElement(names="a, b, c")
>>
>> Gary
>>
>> On Aug 17, 2013, at 10:19, Ralph Goers <rg...@apache.org> wrote:
>>
>>> So I think Remko and I agree that consistency is good but that there are two cases where exceptions should be made. If I commit the change to alias those two things is anyone so strongly against it that they would veto it? If not then I would like to commit it.
>>>
>>> Ralph
>>>
>>> On Aug 17, 2013, at 12:45 AM, Remko Popma <re...@gmail.com> wrote:
>>>
>>>> ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
>>>> but that is not the point.
>>>>
>>>> I think the rule "config files are case-insensite" is much a more intuitive rule than "all hyphens are stripped from attribute and element names".
>>>>
>>>> To me, the "-ref" extension in the <appender-ref> element is a nice, visually distinct indicator that this element points to another element in the configuration. To me, these pointer elements/attributes are special elements and attributes and we actually *lose* something if we bend over backwards to make them look consistent with other elements. It's okay if they look different because they *are* different.
>>>>
>>>> If we prefer not to have aliases then I propose we revert back the appender-ref and error-ref elements to the hyphen version. I think they are better names.
>>>>
>>>>
>>>>
>>>> On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>> Dancing angels and pin heads:
>>>>
>>>> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>>>>
>>>> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>>>>
>>>> How is that any better/worse, more/less confusing?
>>>>
>>>> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>>>>
>>>> Gary
>>>>
>>>>
>>>>
>>>> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>>>
>>>> Ralph
>>>>
>>>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>>>
>>>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>>>
>>>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>>>
>>>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>>>
>>>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>>>
>>>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>>>
>>>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>>>
>>>>> - Consistency, consistency, consistency.
>>>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>>>> - camelCase elements AND camelCase attributes.
>>>>> - PascalCase elements AND PascalCase attributes.
>>>>>
>>>>> Nick
>>>>>
>>>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>>>
>>>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>>>
>>>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>> So far yours is the only vote for that. Anyone else?
>>>>>>>
>>>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>>>> G
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>>>
>>>>>>>> I think we should do both.
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>>
>>>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>>>> 1) strip '-' characters from element names.
>>>>>>>>> 2) allow aliases for element names.
>>>>>>>>>
>>>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>>>
>>>>>>>>> Ralph
>>>>>>>>>
>>>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>>>
>>>>>>>>>> Ralph,
>>>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>>>
>>>>>>>>>> Remko
>>>>>>>>>>
>>>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>>>
>>>>>>>>>> Ralph
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>>>
>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>>>> log4j 1.
>>>>>>>>>>>
>>>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>>>
>>>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>>>
>>>>>>>>>>> Gary
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Gary
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Scott
>>>>>>>>>>>
>>>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>> On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>>>>>
>>>>>>>>>>>> Hold on to your horses ;)
>>>>>>>>>>>>
>>>>>>>>>>>> Another way to look at this is that our config parsing that is already
>>>>>>>>>>>> case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>>>>>
>>>>>>>>>>>> As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>>>>>
>>>>>>>>>>>> Gary
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>>>>>> delegate?
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>>>>>>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>>>>>>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>>>>>>> currently a way for a plugin to have 2 names.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Sent from my iPad
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>>>>>>> attributes?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>>>>>>> <ga...@gmail.com>wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>>>>>>> compatible with version 1, and even less so with a different product.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Gary
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>>>>>>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>>>>>>> use
>>>>>>>>>>>>>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Modified:
>>>>>>>>>>>>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>>>>>>>> URL:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>> JUnit in Action, Second Edition
>>>>>>> Spring Batch in Action
>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>> Home: http://garygregory.com/
>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> JUnit in Action, Second Edition
>>>> Spring Batch in Action
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Nick Williams <ni...@nicholaswilliams.net>.
Nope.
- String name() in @Plugin (for element-mapped plugin classes) becomes String[] names(). Annotation can be used @Plugin(names = "element") for single-worders or @Plugin(names = { "elementName", "element-name" }) for multi-worders.
- String value() in @PluginAttr (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Annotation can be used @PluginAttr("attribute") for single-worders or @Plugin({ "attributeName", "attribute-name" }) for multi-worders.
- String value() in @PluginElement (for attribute-mapped method parameters) becomes String[] value(). Keeping this singular is important for Java language reasons. Ditto on usage as $PluginAttr.
Nick
On Aug 17, 2013, at 9:49 AM, Gary Gregory wrote:
> I am ok with an alias feature.
>
> Like this?
>
> @pluginElement(names="a, b, c")
>
> Gary
>
> On Aug 17, 2013, at 10:19, Ralph Goers <rg...@apache.org> wrote:
>
>> So I think Remko and I agree that consistency is good but that there are two cases where exceptions should be made. If I commit the change to alias those two things is anyone so strongly against it that they would veto it? If not then I would like to commit it.
>>
>> Ralph
>>
>> On Aug 17, 2013, at 12:45 AM, Remko Popma <re...@gmail.com> wrote:
>>
>>> ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
>>> but that is not the point.
>>>
>>> I think the rule "config files are case-insensite" is much a more intuitive rule than "all hyphens are stripped from attribute and element names".
>>>
>>> To me, the "-ref" extension in the <appender-ref> element is a nice, visually distinct indicator that this element points to another element in the configuration. To me, these pointer elements/attributes are special elements and attributes and we actually *lose* something if we bend over backwards to make them look consistent with other elements. It's okay if they look different because they *are* different.
>>>
>>> If we prefer not to have aliases then I propose we revert back the appender-ref and error-ref elements to the hyphen version. I think they are better names.
>>>
>>>
>>>
>>> On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>>> Dancing angels and pin heads:
>>>
>>> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>>>
>>> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>>>
>>> How is that any better/worse, more/less confusing?
>>>
>>> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>>>
>>> Gary
>>>
>>>
>>>
>>> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>>
>>> Ralph
>>>
>>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>>
>>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>>
>>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>>
>>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>>
>>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>>
>>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>>
>>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>>
>>>> - Consistency, consistency, consistency.
>>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>>> - camelCase elements AND camelCase attributes.
>>>> - PascalCase elements AND PascalCase attributes.
>>>>
>>>> Nick
>>>>
>>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>>
>>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>>
>>>>> Ralph
>>>>>
>>>>>
>>>>>
>>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>>
>>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>> So far yours is the only vote for that. Anyone else?
>>>>>>
>>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>>> G
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>>
>>>>>>> I think we should do both.
>>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>
>>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>>> 1) strip '-' characters from element names.
>>>>>>>> 2) allow aliases for element names.
>>>>>>>>
>>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>>
>>>>>>>> Ralph
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>>
>>>>>>>>> Ralph,
>>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>>
>>>>>>>>> Remko
>>>>>>>>>
>>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>>
>>>>>>>>> Ralph
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>>
>>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>>> log4j 1.
>>>>>>>>>>
>>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>>
>>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>>
>>>>>>>>>> Gary
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Gary
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Scott
>>>>>>>>>>
>>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>>>>>> >
>>>>>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>>> >>
>>>>>>>>>> >
>>>>>>>>>> > Hold on to your horses ;)
>>>>>>>>>> >
>>>>>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>>> >
>>>>>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>>> >
>>>>>>>>>> > Gary
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> >>
>>>>>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>>> >>
>>>>>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>>> >> delegate?
>>>>>>>>>> >>
>>>>>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>>> >>
>>>>>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>>>>>> >>>
>>>>>>>>>> >>> Sent from my iPad
>>>>>>>>>> >>>
>>>>>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>>> >>>
>>>>>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>>> >>> attributes?
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>>>>>> >>>
>>>>>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>>>>>> >>>
>>>>>>>>>> >>> Gary
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>>>>>> >>>
>>>>>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>>> >>> use
>>>>>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>>> >>>
>>>>>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>>> >>>
>>>>>>>>>> >>> > Modified:
>>>>>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>>> >>> > URL:
>>>>>>>>>> >>>
>>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> JUnit in Action, Second Edition
>>>>>> Spring Batch in Action
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>
>>>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> JUnit in Action, Second Edition
>>> Spring Batch in Action
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
I am ok with an alias feature.
Like this?
@pluginElement(names="a, b, c")
Gary
On Aug 17, 2013, at 10:19, Ralph Goers <rg...@apache.org> wrote:
So I think Remko and I agree that consistency is good but that there are
two cases where exceptions should be made. If I commit the change to alias
those two things is anyone so strongly against it that they would veto it?
If not then I would like to commit it.
Ralph
On Aug 17, 2013, at 12:45 AM, Remko Popma <re...@gmail.com> wrote:
ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
but that is not the point.
I think the rule "config files are case-insensite" is much a more intuitive
rule than "all hyphens are stripped from attribute and element names".
To me, the "-ref" extension in the <appender-ref> element is a nice,
visually distinct indicator that this element points to another element in
the configuration. To me, these pointer elements/attributes are special
elements and attributes and we actually *lose* something if we bend over
backwards to make them look consistent with other elements. It's okay if
they look different because they *are* different.
If we prefer not to have aliases then I propose we revert back the
appender-ref and error-ref elements to the hyphen version. I think they are
better names.
On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com>wrote:
> Dancing angels and pin heads:
>
> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f
> r-e-f="Console"/> but the point is that is allows <appender-ref
> ref="Console>
>
> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>
> How is that any better/worse, more/less confusing?
>
> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>
> Gary
>
>
>
> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com>wrote:
>
>> OK. In general I guess I agree with your philosophy. However, I
>> consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f
>> r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is
>> because I really believe users who are used to the "other" logging
>> frameworks are constantly going to screw up and do <appender-ref
>> ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are
>> used to it. However, if my choice is between stripping or leaving it the
>> way it is then I vote to leave it the way it is. Again, I just detest the
>> idea of stripping hyphens.
>>
>> Ralph
>>
>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>
>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>
>> I like consistency. I like the same rules to apply to all parts of the
>> configuration. For example:
>>
>> - If we decide that an element should be PascalCase, then they should ALL
>> be PascalCase.
>> - If we decide that an attribute should be camelCase, then they should
>> ALL be camelCase.
>> - If we decide that an element and/or attribute should be
>> case-insensitive, then ALL elements AND attributes should be
>> case-insensitive.
>> - If we decide that an element and/or attribute should allow hyphens
>> between words, then ALL elements AND attributes should allow hyphens
>> between words.
>>
>> This last one is a key point here. Providing aliases would not be a sane
>> way to do this, because what if a developer added an attribute but forgot
>> to create a hyphenated alias? Suddenly, all elements and attributes would
>> allow hyphenation—except that one attribute. This is a consistency failure.
>>
>> I'm not arguing against aliases, necessarily. I just think they're a Bad
>> way to solve the hyphenation dispute (yes, capital Bad). With the
>> hyphenation issue solved otherwise (either by disallowing hyphens or by
>> stripping hyphens automatically), I no longer see a compelling need for
>> aliases. The addition of aliases also makes the task for users of extending
>> Log4j / writing plugins for Log4j more confusing.
>>
>> If I had to chose what we were going to do here, these are my
>> preferences/priorities, in order from most important to least important:
>>
>> - Consistency, consistency, consistency.
>> - A strict schema that must be validated against for the Log4j
>> configuration to work. No case insensitivity, no stripping of hyphens.
>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no
>> camelCase.
>> - camelCase elements AND camelCase attributes.
>> - PascalCase elements AND PascalCase attributes.
>>
>> Nick
>>
>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>
>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I
>> like consistency better.". However, that doesn't imply that he is going to
>> like allowing '-' to appear anywhere and be stripped out. Providing
>> aliases would be a more sane way to do that.
>>
>> Ralph
>>
>>
>>
>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>
>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com>wrote:
>>
>>> So far yours is the only vote for that. Anyone else?
>>>
>>
>> Whomever else mentioned it in the first place! ;) I can't recall who...
>> but it's 2am here...
>> G
>>
>>>
>>> Ralph
>>>
>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>
>>> I think we should do both.
>>>
>>> Gary
>>>
>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com>
>>> wrote:
>>>
>>> Easily done, assuming we have consensus. I am hearing two options:
>>> 1) strip '-' characters from element names.
>>> 2) allow aliases for element names.
>>>
>>> These are not mutually exclusive. I see no reason not to go ahead with
>>> number 2 and we can continue to discuss where else number 1 might be used.
>>>
>>> Ralph
>>>
>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>
>>> Ralph,
>>> Don't forget the error-ref attribute for AsyncAppender.
>>>
>>> Remko
>>>
>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>
>>>> I'm not in favor of just allowing arbitrary '-' characters wherever
>>>> users want. But allowing aliases makes it possible to allow for variations.
>>>> I already have this working.
>>>>
>>>> Ralph
>>>>
>>>>
>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>
>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
>>>>
>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>>>>
>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>> stick with he dash format due to folks being familiar with it from
>>>> log4j 1.
>>>>
>>>>
>>>> That's a thin argument IMO considering you'll have to read the version
>>>> 2 config docs to get off the ground anyway, even if you know your way
>>>> around version 1.
>>>>
>>>>
>>>> And this is also an opportunity to make our config code even fancier by
>>>> normalizing '-' chars ;)
>>>>
>>>> Gary
>>>>
>>>>
>>>>
>>>> Gary
>>>>
>>>>
>>>>
>>>> Scott
>>>>
>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>> > <ra...@dslextreme.com>wrote:
>>>> >
>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>> >>
>>>> >
>>>> > Hold on to your horses ;)
>>>> >
>>>> > Another way to look at this is that our config parsing that is already
>>>> > case-insensitive could be augmented to strip out "-"s, no aliases
>>>> needed.
>>>> >
>>>> > As someone pointed out here, some folks like-to-talk-like-this (see
>>>> JPA).
>>>> >
>>>> > Gary
>>>> >
>>>> >
>>>> >>
>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>> >>
>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>> >> delegate?
>>>> >>
>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>> >>
>>>> >>> I had the same thought. People switching from log4j 1 or logback
>>>> will
>>>> >>> probably make that mistake a lot. Plus this breaks virtually
>>>> everyone
>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>> >>> currently a way for a plugin to have 2 names.
>>>> >>>
>>>> >>> Sent from my iPad
>>>> >>>
>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
>>>> wrote:
>>>> >>>
>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>> >>> attributes?
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>> >>> <ga...@gmail.com>wrote:
>>>> >>>
>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>> >>> compatible with version 1, and even less so with a different
>>>> product.
>>>> >>>
>>>> >>> Gary
>>>> >>>
>>>> >>>
>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>> >>> <ra...@dslextreme.com>wrote:
>>>> >>>
>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback
>>>> both
>>>> >>> use
>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>> >>>
>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>> >>>
>>>> >>> > Modified:
>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>> >>> > URL:
>>>> >>>
>>>> <http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff>
>>>>
>>>>
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Nick Williams <ni...@nicholaswilliams.net>.
I will support the commit. I have to admit, I do like the strictness of it. It allows <appender-ref> while disallowing <a-p-p-e-n-d-e-r--r-e-f>, which is as close to strict schema compliance that I think I'm going to get anyone to agree to. :-)
But we must document the heck out of it and we must be vigilant to ALWAYS create an alias for every plugin AND every attribute that has multiple words. Otherwise we're creating more room for users to trip up.
Nick
On Aug 17, 2013, at 9:18 AM, Ralph Goers wrote:
> So I think Remko and I agree that consistency is good but that there are two cases where exceptions should be made. If I commit the change to alias those two things is anyone so strongly against it that they would veto it? If not then I would like to commit it.
>
> Ralph
>
> On Aug 17, 2013, at 12:45 AM, Remko Popma <re...@gmail.com> wrote:
>
>> ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
>> but that is not the point.
>>
>> I think the rule "config files are case-insensite" is much a more intuitive rule than "all hyphens are stripped from attribute and element names".
>>
>> To me, the "-ref" extension in the <appender-ref> element is a nice, visually distinct indicator that this element points to another element in the configuration. To me, these pointer elements/attributes are special elements and attributes and we actually *lose* something if we bend over backwards to make them look consistent with other elements. It's okay if they look different because they *are* different.
>>
>> If we prefer not to have aliases then I propose we revert back the appender-ref and error-ref elements to the hyphen version. I think they are better names.
>>
>>
>>
>> On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>> Dancing angels and pin heads:
>>
>> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>>
>> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>>
>> How is that any better/worse, more/less confusing?
>>
>> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>>
>> Gary
>>
>>
>>
>> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>
>> Ralph
>>
>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>
>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>
>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>
>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>
>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>
>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>
>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>
>>> - Consistency, consistency, consistency.
>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>> - camelCase elements AND camelCase attributes.
>>> - PascalCase elements AND PascalCase attributes.
>>>
>>> Nick
>>>
>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>
>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>
>>>> Ralph
>>>>
>>>>
>>>>
>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>
>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>> So far yours is the only vote for that. Anyone else?
>>>>>
>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>> G
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>
>>>>>> I think we should do both.
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>
>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>> 1) strip '-' characters from element names.
>>>>>>> 2) allow aliases for element names.
>>>>>>>
>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>
>>>>>>>> Ralph,
>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>
>>>>>>>> Remko
>>>>>>>>
>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>
>>>>>>>> Ralph
>>>>>>>>
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>
>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>> log4j 1.
>>>>>>>>>
>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>
>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>
>>>>>>>>> Gary
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Gary
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Scott
>>>>>>>>>
>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>>>>> >
>>>>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>> >>
>>>>>>>>> >
>>>>>>>>> > Hold on to your horses ;)
>>>>>>>>> >
>>>>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>> >
>>>>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>> >
>>>>>>>>> > Gary
>>>>>>>>> >
>>>>>>>>> >
>>>>>>>>> >>
>>>>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>> >>
>>>>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>> >> delegate?
>>>>>>>>> >>
>>>>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>> >>
>>>>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>>>>> >>>
>>>>>>>>> >>> Sent from my iPad
>>>>>>>>> >>>
>>>>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>> >>> attributes?
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>>>>> >>>
>>>>>>>>> >>> Gary
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>> >>> use
>>>>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>> >>>
>>>>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> > Modified:
>>>>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>> >>> > URL:
>>>>>>>>> >>>
>>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> JUnit in Action, Second Edition
>>>>> Spring Batch in Action
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <rg...@apache.org>.
So I think Remko and I agree that consistency is good but that there are two cases where exceptions should be made. If I commit the change to alias those two things is anyone so strongly against it that they would veto it? If not then I would like to commit it.
Ralph
On Aug 17, 2013, at 12:45 AM, Remko Popma <re...@gmail.com> wrote:
> ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
> but that is not the point.
>
> I think the rule "config files are case-insensite" is much a more intuitive rule than "all hyphens are stripped from attribute and element names".
>
> To me, the "-ref" extension in the <appender-ref> element is a nice, visually distinct indicator that this element points to another element in the configuration. To me, these pointer elements/attributes are special elements and attributes and we actually *lose* something if we bend over backwards to make them look consistent with other elements. It's okay if they look different because they *are* different.
>
> If we prefer not to have aliases then I propose we revert back the appender-ref and error-ref elements to the hyphen version. I think they are better names.
>
>
>
> On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com> wrote:
>> Dancing angels and pin heads:
>>
>> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>>
>> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>>
>> How is that any better/worse, more/less confusing?
>>
>> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>>
>> Gary
>>
>>
>>
>> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>>
>>> Ralph
>>>
>>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>>
>>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>>
>>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>>
>>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>>
>>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>>
>>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>>
>>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>>
>>>> - Consistency, consistency, consistency.
>>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>>> - camelCase elements AND camelCase attributes.
>>>> - PascalCase elements AND PascalCase attributes.
>>>>
>>>> Nick
>>>>
>>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>>
>>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>>
>>>>> Ralph
>>>>>
>>>>>
>>>>>
>>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>>
>>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>> So far yours is the only vote for that. Anyone else?
>>>>>>
>>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>>> G
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>>>
>>>>>>>> I think we should do both.
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>>
>>>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>>>> 1) strip '-' characters from element names.
>>>>>>>>> 2) allow aliases for element names.
>>>>>>>>>
>>>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>>>
>>>>>>>>> Ralph
>>>>>>>>>
>>>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>>>
>>>>>>>>>> Ralph,
>>>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>>>
>>>>>>>>>> Remko
>>>>>>>>>>
>>>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>>>>
>>>>>>>>>>> Ralph
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>>>>> log4j 1.
>>>>>>>>>>>>
>>>>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>>>>
>>>>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>>>>
>>>>>>>>>>>> Gary
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Gary
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Scott
>>>>>>>>>>>>
>>>>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>>>>>>>> >
>>>>>>>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>>>>> >>
>>>>>>>>>>>> >
>>>>>>>>>>>> > Hold on to your horses ;)
>>>>>>>>>>>> >
>>>>>>>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>>>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>>>>> >
>>>>>>>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>>>>> >
>>>>>>>>>>>> > Gary
>>>>>>>>>>>> >
>>>>>>>>>>>> >
>>>>>>>>>>>> >>
>>>>>>>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>>>>> >>
>>>>>>>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>>>>> >> delegate?
>>>>>>>>>>>> >>
>>>>>>>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>>>>> >>
>>>>>>>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>> Sent from my iPad
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>>>>> >>> attributes?
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>> Gary
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>>>>> >>> use
>>>>>>>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>>>>> >>>
>>>>>>>>>>>> >>> > Modified:
>>>>>>>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>>>>> >>> > URL:
>>>>>>>>>>>> >>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> JUnit in Action, Second Edition
>>>>>> Spring Batch in Action
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Remko Popma <re...@gmail.com>.
ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
but that is not the point.
I think the rule "config files are case-insensite" is much a more intuitive
rule than "all hyphens are stripped from attribute and element names".
To me, the "-ref" extension in the <appender-ref> element is a nice,
visually distinct indicator that this element points to another element in
the configuration. To me, these pointer elements/attributes are special
elements and attributes and we actually *lose* something if we bend over
backwards to make them look consistent with other elements. It's okay if
they look different because they *are* different.
If we prefer not to have aliases then I propose we revert back the
appender-ref and error-ref elements to the hyphen version. I think they are
better names.
On Sat, Aug 17, 2013 at 3:48 PM, Gary Gregory <ga...@gmail.com>wrote:
> Dancing angels and pin heads:
>
> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f
> r-e-f="Console"/> but the point is that is allows <appender-ref
> ref="Console>
>
> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>
> How is that any better/worse, more/less confusing?
>
> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>
> Gary
>
>
>
> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com>wrote:
>
>> OK. In general I guess I agree with your philosophy. However, I
>> consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f
>> r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is
>> because I really believe users who are used to the "other" logging
>> frameworks are constantly going to screw up and do <appender-ref
>> ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are
>> used to it. However, if my choice is between stripping or leaving it the
>> way it is then I vote to leave it the way it is. Again, I just detest the
>> idea of stripping hyphens.
>>
>> Ralph
>>
>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>
>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>
>> I like consistency. I like the same rules to apply to all parts of the
>> configuration. For example:
>>
>> - If we decide that an element should be PascalCase, then they should ALL
>> be PascalCase.
>> - If we decide that an attribute should be camelCase, then they should
>> ALL be camelCase.
>> - If we decide that an element and/or attribute should be
>> case-insensitive, then ALL elements AND attributes should be
>> case-insensitive.
>> - If we decide that an element and/or attribute should allow hyphens
>> between words, then ALL elements AND attributes should allow hyphens
>> between words.
>>
>> This last one is a key point here. Providing aliases would not be a sane
>> way to do this, because what if a developer added an attribute but forgot
>> to create a hyphenated alias? Suddenly, all elements and attributes would
>> allow hyphenation—except that one attribute. This is a consistency failure.
>>
>> I'm not arguing against aliases, necessarily. I just think they're a Bad
>> way to solve the hyphenation dispute (yes, capital Bad). With the
>> hyphenation issue solved otherwise (either by disallowing hyphens or by
>> stripping hyphens automatically), I no longer see a compelling need for
>> aliases. The addition of aliases also makes the task for users of extending
>> Log4j / writing plugins for Log4j more confusing.
>>
>> If I had to chose what we were going to do here, these are my
>> preferences/priorities, in order from most important to least important:
>>
>> - Consistency, consistency, consistency.
>> - A strict schema that must be validated against for the Log4j
>> configuration to work. No case insensitivity, no stripping of hyphens.
>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no
>> camelCase.
>> - camelCase elements AND camelCase attributes.
>> - PascalCase elements AND PascalCase attributes.
>>
>> Nick
>>
>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>
>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I
>> like consistency better.". However, that doesn't imply that he is going to
>> like allowing '-' to appear anywhere and be stripped out. Providing
>> aliases would be a more sane way to do that.
>>
>> Ralph
>>
>>
>>
>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>
>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com>wrote:
>>
>>> So far yours is the only vote for that. Anyone else?
>>>
>>
>> Whomever else mentioned it in the first place! ;) I can't recall who...
>> but it's 2am here...
>> G
>>
>>>
>>> Ralph
>>>
>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>
>>> I think we should do both.
>>>
>>> Gary
>>>
>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com>
>>> wrote:
>>>
>>> Easily done, assuming we have consensus. I am hearing two options:
>>> 1) strip '-' characters from element names.
>>> 2) allow aliases for element names.
>>>
>>> These are not mutually exclusive. I see no reason not to go ahead with
>>> number 2 and we can continue to discuss where else number 1 might be used.
>>>
>>> Ralph
>>>
>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>
>>> Ralph,
>>> Don't forget the error-ref attribute for AsyncAppender.
>>>
>>> Remko
>>>
>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>
>>>> I'm not in favor of just allowing arbitrary '-' characters wherever
>>>> users want. But allowing aliases makes it possible to allow for variations.
>>>> I already have this working.
>>>>
>>>> Ralph
>>>>
>>>>
>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>
>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
>>>>
>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>>>>
>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>> stick with he dash format due to folks being familiar with it from
>>>> log4j 1.
>>>>
>>>>
>>>> That's a thin argument IMO considering you'll have to read the version
>>>> 2 config docs to get off the ground anyway, even if you know your way
>>>> around version 1.
>>>>
>>>>
>>>> And this is also an opportunity to make our config code even fancier by
>>>> normalizing '-' chars ;)
>>>>
>>>> Gary
>>>>
>>>>
>>>>
>>>> Gary
>>>>
>>>>
>>>>
>>>> Scott
>>>>
>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>> > <ra...@dslextreme.com>wrote:
>>>> >
>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>> >>
>>>> >
>>>> > Hold on to your horses ;)
>>>> >
>>>> > Another way to look at this is that our config parsing that is already
>>>> > case-insensitive could be augmented to strip out "-"s, no aliases
>>>> needed.
>>>> >
>>>> > As someone pointed out here, some folks like-to-talk-like-this (see
>>>> JPA).
>>>> >
>>>> > Gary
>>>> >
>>>> >
>>>> >>
>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>> >>
>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>> >> delegate?
>>>> >>
>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>> >>
>>>> >>> I had the same thought. People switching from log4j 1 or logback
>>>> will
>>>> >>> probably make that mistake a lot. Plus this breaks virtually
>>>> everyone
>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>> >>> currently a way for a plugin to have 2 names.
>>>> >>>
>>>> >>> Sent from my iPad
>>>> >>>
>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
>>>> wrote:
>>>> >>>
>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>> >>> attributes?
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>> >>> <ga...@gmail.com>wrote:
>>>> >>>
>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>> >>> compatible with version 1, and even less so with a different
>>>> product.
>>>> >>>
>>>> >>> Gary
>>>> >>>
>>>> >>>
>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>> >>> <ra...@dslextreme.com>wrote:
>>>> >>>
>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback
>>>> both
>>>> >>> use
>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>> >>>
>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>> >>>
>>>> >>> > Modified:
>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>> >>> > URL:
>>>> >>>
>>>> <http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff>
>>>>
>>>>
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Nick Williams <ni...@nicholaswilliams.net>.
On Aug 17, 2013, at 1:48 AM, Gary Gregory wrote:
> Dancing angels and pin heads:
>
> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>
> But! the current code also allows <ApPeNdeRrEf ref="Console/>
A fantastic point.
> How is that any better/worse, more/less confusing?
It's not.
>
> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
Yes.
> Gary
>
>
>
> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>
> Ralph
>
> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>
>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>
>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>
>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>
>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>
>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>
>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>
>> - Consistency, consistency, consistency.
>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>> - camelCase elements AND camelCase attributes.
>> - PascalCase elements AND PascalCase attributes.
>>
>> Nick
>>
>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>
>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>
>>> Ralph
>>>
>>>
>>>
>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>
>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>> So far yours is the only vote for that. Anyone else?
>>>>
>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>> G
>>>>
>>>> Ralph
>>>>
>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>
>>>>> I think we should do both.
>>>>>
>>>>> Gary
>>>>>
>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>
>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>> 1) strip '-' characters from element names.
>>>>>> 2) allow aliases for element names.
>>>>>>
>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>
>>>>>>> Ralph,
>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>
>>>>>>> Remko
>>>>>>>
>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>>
>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>
>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>> log4j 1.
>>>>>>>>
>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>
>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>>
>>>>>>>> Scott
>>>>>>>>
>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>>>> >
>>>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>> >>
>>>>>>>> >
>>>>>>>> > Hold on to your horses ;)
>>>>>>>> >
>>>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>> >
>>>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>> >
>>>>>>>> > Gary
>>>>>>>> >
>>>>>>>> >
>>>>>>>> >>
>>>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>> >>
>>>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>> >> delegate?
>>>>>>>> >>
>>>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>> >>
>>>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>>>> >>>
>>>>>>>> >>> Sent from my iPad
>>>>>>>> >>>
>>>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>> >>>
>>>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>> >>> attributes?
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>>>> >>>
>>>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>>>> >>>
>>>>>>>> >>> Gary
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>>>> >>>
>>>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>> >>> use
>>>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>> >>>
>>>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>> >>>
>>>>>>>> >>> > Modified:
>>>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>> >>> > URL:
>>>>>>>> >>>
>>>>>>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> JUnit in Action, Second Edition
>>>> Spring Batch in Action
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
OK - so it sounds like LOG4J2-360 is going to get closed as "Will not fix". I am pretty sure LOG4J2-361 will as well.
Ralph
On Aug 16, 2013, at 11:57 PM, Ralph Goers wrote:
> Yup. You are correct that the mixed case does allow something just as stupid.
>
> Yes, attributes are also case insensitive. See BaseConfiguration.getAttrValue().
>
> Ralph
>
> On Aug 16, 2013, at 11:48 PM, Gary Gregory wrote:
>
>> Dancing angels and pin heads:
>>
>> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>>
>> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>>
>> How is that any better/worse, more/less confusing?
>>
>> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>>
>> Gary
>>
>>
>>
>> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>
>> Ralph
>>
>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>
>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>
>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>
>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>
>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>
>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>
>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>
>>> - Consistency, consistency, consistency.
>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>> - camelCase elements AND camelCase attributes.
>>> - PascalCase elements AND PascalCase attributes.
>>>
>>> Nick
>>>
>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>
>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>
>>>> Ralph
>>>>
>>>>
>>>>
>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>
>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>> So far yours is the only vote for that. Anyone else?
>>>>>
>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>> G
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>
>>>>>> I think we should do both.
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>
>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>> 1) strip '-' characters from element names.
>>>>>>> 2) allow aliases for element names.
>>>>>>>
>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>
>>>>>>>> Ralph,
>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>
>>>>>>>> Remko
>>>>>>>>
>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>
>>>>>>>> Ralph
>>>>>>>>
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>
>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>> log4j 1.
>>>>>>>>>
>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>
>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>
>>>>>>>>> Gary
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Gary
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Scott
>>>>>>>>>
>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>>>>> >
>>>>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>> >>
>>>>>>>>> >
>>>>>>>>> > Hold on to your horses ;)
>>>>>>>>> >
>>>>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>> >
>>>>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>> >
>>>>>>>>> > Gary
>>>>>>>>> >
>>>>>>>>> >
>>>>>>>>> >>
>>>>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>> >>
>>>>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>> >> delegate?
>>>>>>>>> >>
>>>>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>> >>
>>>>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>>>>> >>>
>>>>>>>>> >>> Sent from my iPad
>>>>>>>>> >>>
>>>>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>> >>> attributes?
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>>>>> >>>
>>>>>>>>> >>> Gary
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>> >>> use
>>>>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>> >>>
>>>>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> > Modified:
>>>>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>> >>> > URL:
>>>>>>>>> >>>
>>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> JUnit in Action, Second Edition
>>>>> Spring Batch in Action
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
Yup. You are correct that the mixed case does allow something just as stupid.
Yes, attributes are also case insensitive. See BaseConfiguration.getAttrValue().
Ralph
On Aug 16, 2013, at 11:48 PM, Gary Gregory wrote:
> Dancing angels and pin heads:
>
> Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> but the point is that is allows <appender-ref ref="Console>
>
> But! the current code also allows <ApPeNdeRrEf ref="Console/>
>
> How is that any better/worse, more/less confusing?
>
> BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
>
> Gary
>
>
>
> On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com> wrote:
> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>
> Ralph
>
> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>
>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>
>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>
>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>
>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>
>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>
>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>
>> - Consistency, consistency, consistency.
>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>> - camelCase elements AND camelCase attributes.
>> - PascalCase elements AND PascalCase attributes.
>>
>> Nick
>>
>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>
>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>
>>> Ralph
>>>
>>>
>>>
>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>
>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>> So far yours is the only vote for that. Anyone else?
>>>>
>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>> G
>>>>
>>>> Ralph
>>>>
>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>
>>>>> I think we should do both.
>>>>>
>>>>> Gary
>>>>>
>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>
>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>> 1) strip '-' characters from element names.
>>>>>> 2) allow aliases for element names.
>>>>>>
>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>
>>>>>>> Ralph,
>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>
>>>>>>> Remko
>>>>>>>
>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>>
>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>
>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>> log4j 1.
>>>>>>>>
>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>
>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>>
>>>>>>>> Scott
>>>>>>>>
>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>>>> >
>>>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>> >>
>>>>>>>> >
>>>>>>>> > Hold on to your horses ;)
>>>>>>>> >
>>>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>> >
>>>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>> >
>>>>>>>> > Gary
>>>>>>>> >
>>>>>>>> >
>>>>>>>> >>
>>>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>> >>
>>>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>> >> delegate?
>>>>>>>> >>
>>>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>> >>
>>>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>>>> >>>
>>>>>>>> >>> Sent from my iPad
>>>>>>>> >>>
>>>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>> >>>
>>>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>> >>> attributes?
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>>>> >>>
>>>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>>>> >>>
>>>>>>>> >>> Gary
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>>>> >>>
>>>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>> >>> use
>>>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>> >>>
>>>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>> >>>
>>>>>>>> >>> > Modified:
>>>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>> >>> > URL:
>>>>>>>> >>>
>>>>>>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> JUnit in Action, Second Edition
>>>> Spring Batch in Action
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
Dancing angels and pin heads:
Yep, the patch I provided allows for <a-p-p-e-n-d-e-r-r-e-f
r-e-f="Console"/> but the point is that is allows <appender-ref
ref="Console>
But! the current code also allows <ApPeNdeRrEf ref="Console/>
How is that any better/worse, more/less confusing?
BTW, are attributes also case-insensitive? <ApPeNdeRrEf ReF="Console/>
Gary
On Sat, Aug 17, 2013 at 2:38 AM, Ralph Goers <ra...@dslextreme.com>wrote:
> OK. In general I guess I agree with your philosophy. However, I consider
> stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f
> r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is
> because I really believe users who are used to the "other" logging
> frameworks are constantly going to screw up and do <appender-ref
> ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are
> used to it. However, if my choice is between stripping or leaving it the
> way it is then I vote to leave it the way it is. Again, I just detest the
> idea of stripping hyphens.
>
> Ralph
>
> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>
> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>
> I like consistency. I like the same rules to apply to all parts of the
> configuration. For example:
>
> - If we decide that an element should be PascalCase, then they should ALL
> be PascalCase.
> - If we decide that an attribute should be camelCase, then they should ALL
> be camelCase.
> - If we decide that an element and/or attribute should be
> case-insensitive, then ALL elements AND attributes should be
> case-insensitive.
> - If we decide that an element and/or attribute should allow hyphens
> between words, then ALL elements AND attributes should allow hyphens
> between words.
>
> This last one is a key point here. Providing aliases would not be a sane
> way to do this, because what if a developer added an attribute but forgot
> to create a hyphenated alias? Suddenly, all elements and attributes would
> allow hyphenation—except that one attribute. This is a consistency failure.
>
> I'm not arguing against aliases, necessarily. I just think they're a Bad
> way to solve the hyphenation dispute (yes, capital Bad). With the
> hyphenation issue solved otherwise (either by disallowing hyphens or by
> stripping hyphens automatically), I no longer see a compelling need for
> aliases. The addition of aliases also makes the task for users of extending
> Log4j / writing plugins for Log4j more confusing.
>
> If I had to chose what we were going to do here, these are my
> preferences/priorities, in order from most important to least important:
>
> - Consistency, consistency, consistency.
> - A strict schema that must be validated against for the Log4j
> configuration to work. No case insensitivity, no stripping of hyphens.
> - All lowercase, hyphenated elements AND attributes. No PascalCase, no
> camelCase.
> - camelCase elements AND camelCase attributes.
> - PascalCase elements AND PascalCase attributes.
>
> Nick
>
> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>
> On Aug 10 Nick said "I actually really like hyphenated attributes, but I
> like consistency better.". However, that doesn't imply that he is going to
> like allowing '-' to appear anywhere and be stripped out. Providing
> aliases would be a more sane way to do that.
>
> Ralph
>
>
>
> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>
> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com>wrote:
>
>> So far yours is the only vote for that. Anyone else?
>>
>
> Whomever else mentioned it in the first place! ;) I can't recall who...
> but it's 2am here...
> G
>
>>
>> Ralph
>>
>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>
>> I think we should do both.
>>
>> Gary
>>
>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>
>> Easily done, assuming we have consensus. I am hearing two options:
>> 1) strip '-' characters from element names.
>> 2) allow aliases for element names.
>>
>> These are not mutually exclusive. I see no reason not to go ahead with
>> number 2 and we can continue to discuss where else number 1 might be used.
>>
>> Ralph
>>
>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>
>> Ralph,
>> Don't forget the error-ref attribute for AsyncAppender.
>>
>> Remko
>>
>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>
>>> I'm not in favor of just allowing arbitrary '-' characters wherever
>>> users want. But allowing aliases makes it possible to allow for variations.
>>> I already have this working.
>>>
>>> Ralph
>>>
>>>
>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>
>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
>>>
>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>>>
>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>> stick with he dash format due to folks being familiar with it from
>>> log4j 1.
>>>
>>>
>>> That's a thin argument IMO considering you'll have to read the version 2
>>> config docs to get off the ground anyway, even if you know your way around
>>> version 1.
>>>
>>>
>>> And this is also an opportunity to make our config code even fancier by
>>> normalizing '-' chars ;)
>>>
>>> Gary
>>>
>>>
>>>
>>> Gary
>>>
>>>
>>>
>>> Scott
>>>
>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>> > <ra...@dslextreme.com>wrote:
>>> >
>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>> >>
>>> >
>>> > Hold on to your horses ;)
>>> >
>>> > Another way to look at this is that our config parsing that is already
>>> > case-insensitive could be augmented to strip out "-"s, no aliases
>>> needed.
>>> >
>>> > As someone pointed out here, some folks like-to-talk-like-this (see
>>> JPA).
>>> >
>>> > Gary
>>> >
>>> >
>>> >>
>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>> >>
>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>> >> delegate?
>>> >>
>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>> >>
>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>> >>> currently a way for a plugin to have 2 names.
>>> >>>
>>> >>> Sent from my iPad
>>> >>>
>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
>>> wrote:
>>> >>>
>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>> >>> attributes?
>>> >>>
>>> >>>
>>> >>>
>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>> >>> <ga...@gmail.com>wrote:
>>> >>>
>>> >>> I never thought that Log4J 2 configuration files should be backward
>>> >>> compatible with version 1, and even less so with a different product.
>>> >>>
>>> >>> Gary
>>> >>>
>>> >>>
>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>> >>> <ra...@dslextreme.com>wrote:
>>> >>>
>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>> >>> use
>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>> >>>
>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>> >>>
>>> >>> > Modified:
>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>> >>> > URL:
>>> >>>
>>> <http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff>
>>>
>>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Nick Williams <ni...@nicholaswilliams.net>.
On Aug 17, 2013, at 2:24 AM, Gary Gregory wrote:
> On Sat, Aug 17, 2013 at 3:07 AM, Nick Williams <ni...@nicholaswilliams.net> wrote:
>
> On Aug 17, 2013, at 2:01 AM, Ralph Goers wrote:
>
>>
>> On Aug 16, 2013, at 11:58 PM, Nick Williams wrote:
>>
>>>
>>> On Aug 17, 2013, at 1:54 AM, Ralph Goers wrote:
>>>
>>>> That doesn't really help much. I find the syntax below oddly annoying. What is strange is that I don't really mind it when there is only a single '-' character but when there is more than one I find it irritating - especially with size-based-triggering-policy. I can't tell you how many times I hit '=' instead of '-' when typing it.
>>>
>>> Well there's an easy and obvious solution to THAT. Switch to Dvorak. You won't accidentally hit = instead of - then. QWERTY sucks. ;-)
>>>
>>
>> Right. Instead I will mistype everything. :-)
>
> Hah!
>
> Off topic, I switched about two years ago. Before I was touch typing 70-80 WPM and my wrists hurt. All. The. Time.
>
> Now I touch type 100-110 WPM and my wrists rarely hurt anymore. QWERTY was invented for the typewriter, and it was intended to prevent jams by slowing typists down by moving all of the most commonly-used keys as far away from each other as possible. This causes you to constantly stretch and stress your fingers and wrists to type common words. Dvorak [1] was designed to bring the 11 most common keys to the home row, the 12 most common keys to the top row (second-easiest to reach), and the 10 least common keys to the bottom row (hardest to reach). It's possible to type dozens of entire words without your fingers leaving the home row. Only possible to type 1-2 that way with QWERTY.
>
> [1] http://upload.wikimedia.org/wikipedia/commons/thumb/2/25/KB_United_States_Dvorak.svg/400px-KB_United_States_Dvorak.svg.png
>
> Which Dvorak keyboard would you get/recommend today?
Well you can't actually buy them. Nobody really makes them. You might be able to find one or two somewhere out there, but they're the really old keyboards that take a lot of pressure to press, unlike today's modern ergonomic keyboards that are easier to press the keys on.
For my MacBook Pro, I simply got a keyboard cover [1]. For my Dell laptop at $work I popped off the keys and rearranged them. For my Apple Bluetooth Keyboard (older edition), I just popped off the keys and rearranged them. For my Microsoft keyboard at $work, I also popped off the keys and rearranged them. It's a much better (and cheaper) solution than trying to actually buy a Dvorak keyboard.
The only reason you would ever need to buy a Dvorak keyboard is if you needed to type Dvorak on an old system (like DOS) that didn't support Dvorak in software, or BIOS. In these cases, the few Dvorak keyboards out there actually have hardware switches on them to turn on a mode that makes it look like a QWERTY keyboard to the operating system. However, there's rarely a need for this anymore (all modern operating systems support Dvorak in software), and for the few cases I need it (BIOS), I keep a spare Microsoft keyboard with the keys still arranged in QWERTY. Sometimes I don't even need to use it. I never forgot how to type QWERTY. Takes me only about two sentences to switch modes without looking at the keys.
[1] http://www.kbcovers.com/servlet/Detail?no=284
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Aug 17, 2013 at 3:07 AM, Nick Williams <
nicholas@nicholaswilliams.net> wrote:
>
> On Aug 17, 2013, at 2:01 AM, Ralph Goers wrote:
>
>
> On Aug 16, 2013, at 11:58 PM, Nick Williams wrote:
>
>
> On Aug 17, 2013, at 1:54 AM, Ralph Goers wrote:
>
> That doesn't really help much. I find the syntax below oddly annoying.
> What is strange is that I don't really mind it when there is only a single
> '-' character but when there is more than one I find it irritating -
> especially with size-based-triggering-policy. I can't tell you how many
> times I hit '=' instead of '-' when typing it.
>
>
> Well there's an easy and obvious solution to THAT. Switch to Dvorak. You
> won't accidentally hit = instead of - then. QWERTY sucks. ;-)
>
>
> Right. Instead I will mistype everything. :-)
>
>
> Hah!
>
> Off topic, I switched about two years ago. Before I was touch typing 70-80
> WPM and my wrists hurt. All. The. Time.
>
> Now I touch type 100-110 WPM and my wrists rarely hurt anymore. QWERTY was
> invented for the typewriter, and it was intended to prevent jams by slowing
> typists down by moving all of the most commonly-used keys as far away from
> each other as possible. This causes you to constantly stretch and stress
> your fingers and wrists to type common words. Dvorak [1] was designed to
> bring the 11 most common keys to the home row, the 12 most common keys to
> the top row (second-easiest to reach), and the 10 least common keys to the
> bottom row (hardest to reach). It's possible to type dozens of entire words
> without your fingers leaving the home row. Only possible to type 1-2 that
> way with QWERTY.
>
> [1]
> http://upload.wikimedia.org/wikipedia/commons/thumb/2/25/KB_United_States_Dvorak.svg/400px-KB_United_States_Dvorak.svg.png
>
Which Dvorak keyboard would you get/recommend today?
Gary
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Nick Williams <ni...@nicholaswilliams.net>.
On Aug 17, 2013, at 2:01 AM, Ralph Goers wrote:
>
> On Aug 16, 2013, at 11:58 PM, Nick Williams wrote:
>
>>
>> On Aug 17, 2013, at 1:54 AM, Ralph Goers wrote:
>>
>>> That doesn't really help much. I find the syntax below oddly annoying. What is strange is that I don't really mind it when there is only a single '-' character but when there is more than one I find it irritating - especially with size-based-triggering-policy. I can't tell you how many times I hit '=' instead of '-' when typing it.
>>
>> Well there's an easy and obvious solution to THAT. Switch to Dvorak. You won't accidentally hit = instead of - then. QWERTY sucks. ;-)
>>
>
> Right. Instead I will mistype everything. :-)
Hah!
Off topic, I switched about two years ago. Before I was touch typing 70-80 WPM and my wrists hurt. All. The. Time.
Now I touch type 100-110 WPM and my wrists rarely hurt anymore. QWERTY was invented for the typewriter, and it was intended to prevent jams by slowing typists down by moving all of the most commonly-used keys as far away from each other as possible. This causes you to constantly stretch and stress your fingers and wrists to type common words. Dvorak [1] was designed to bring the 11 most common keys to the home row, the 12 most common keys to the top row (second-easiest to reach), and the 10 least common keys to the bottom row (hardest to reach). It's possible to type dozens of entire words without your fingers leaving the home row. Only possible to type 1-2 that way with QWERTY.
[1] http://upload.wikimedia.org/wikipedia/commons/thumb/2/25/KB_United_States_Dvorak.svg/400px-KB_United_States_Dvorak.svg.png
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
On Aug 16, 2013, at 11:58 PM, Nick Williams wrote:
>
> On Aug 17, 2013, at 1:54 AM, Ralph Goers wrote:
>
>> That doesn't really help much. I find the syntax below oddly annoying. What is strange is that I don't really mind it when there is only a single '-' character but when there is more than one I find it irritating - especially with size-based-triggering-policy. I can't tell you how many times I hit '=' instead of '-' when typing it.
>
> Well there's an easy and obvious solution to THAT. Switch to Dvorak. You won't accidentally hit = instead of - then. QWERTY sucks. ;-)
>
Right. Instead I will mistype everything. :-)
Ralph
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Nick Williams <ni...@nicholaswilliams.net>.
On Aug 17, 2013, at 1:54 AM, Ralph Goers wrote:
> That doesn't really help much. I find the syntax below oddly annoying. What is strange is that I don't really mind it when there is only a single '-' character but when there is more than one I find it irritating - especially with size-based-triggering-policy. I can't tell you how many times I hit '=' instead of '-' when typing it.
Well there's an easy and obvious solution to THAT. Switch to Dvorak. You won't accidentally hit = instead of - then. QWERTY sucks. ;-)
> <configuration status="warn" name="XMLConfigTest" packages="org.apache.logging.log4j.test">
> <properties>
> <property name="filename">target/rolling1/rollingtest.log</Property>
> </properties>
> <threshold-filter level="debug"/>
>
> <appenders>
> <console name="STDOUT">
> <pattern-layout pattern="%m%n"/>
> </console>
> <rolling-file name="RollingFile" file-name="${filename}"
> file-pattern="target/rolling1/test1-$${date:MM-dd-yyyy}-%i.log.gz">
> <pattern-layout>
> <pattern>%d %p %C{1.} [%t] %m%n</pattern>
> </pattern-layout>
> <size-based-triggering-policy size="500" />
> </rolling-file>
> <list name="List">
> <threshold-filter level="error"/>
> </list>
> </appenders>
>
> <loggers>
> <logger name="org.apache.logging.log4j.test1" level="debug" additivity="false">
> <thread-context-map-filter>
> <key-value-pair key="test" value="123"/>
> </thread-context-map-filter>
> <appender-ref ref="STDOUT"/>
> </logger>>
>
> <logger name="org.apache.logging.log4j.core.appender.rolling" level="debug" additivity="false">
> <appender-ref ref="RollingFile"/>
> </logger>>
>
> <root level="error">
> <appender-ref ref="STDOUT"/>
> </root>
> </loggers>
>
> </configuration>
See I think this is glorious.
> On Aug 16, 2013, at 11:41 PM, Nick Williams wrote:
>
>> Or we could just make them all hyphenated, which is my preference. Then we avoid the stripping you detest and the errors you're afraid our users will commit. :-)
>>
>> Nick
>>
>> On Aug 17, 2013, at 1:38 AM, Ralph Goers wrote:
>>
>>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>>
>>> Ralph
>>>
>>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>>
>>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>>
>>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>>
>>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>>
>>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>>
>>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>>
>>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>>
>>>> - Consistency, consistency, consistency.
>>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>>> - camelCase elements AND camelCase attributes.
>>>> - PascalCase elements AND PascalCase attributes.
>>>>
>>>> Nick
>>>>
>>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>>
>>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>>
>>>>> Ralph
>>>>>
>>>>>
>>>>>
>>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>>
>>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>> So far yours is the only vote for that. Anyone else?
>>>>>>
>>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>>> G
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>>
>>>>>>> I think we should do both.
>>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>>
>>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>>> 1) strip '-' characters from element names.
>>>>>>>> 2) allow aliases for element names.
>>>>>>>>
>>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>>
>>>>>>>> Ralph
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>>
>>>>>>>>> Ralph,
>>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>>
>>>>>>>>> Remko
>>>>>>>>>
>>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>>
>>>>>>>>> Ralph
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>>
>>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>>> log4j 1.
>>>>>>>>>>
>>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>>
>>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>>
>>>>>>>>>> Gary
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Gary
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Scott
>>>>>>>>>>
>>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>>>>>> >
>>>>>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>>> >>
>>>>>>>>>> >
>>>>>>>>>> > Hold on to your horses ;)
>>>>>>>>>> >
>>>>>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>>> >
>>>>>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>>> >
>>>>>>>>>> > Gary
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> >>
>>>>>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>>> >>
>>>>>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>>> >> delegate?
>>>>>>>>>> >>
>>>>>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>>> >>
>>>>>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>>>>>> >>>
>>>>>>>>>> >>> Sent from my iPad
>>>>>>>>>> >>>
>>>>>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>>> >>>
>>>>>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>>> >>> attributes?
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>>>>>> >>>
>>>>>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>>>>>> >>>
>>>>>>>>>> >>> Gary
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>>>>>> >>>
>>>>>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>>> >>> use
>>>>>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>>> >>>
>>>>>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>>> >>>
>>>>>>>>>> >>> > Modified:
>>>>>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>>> >>> > URL:
>>>>>>>>>> >>>
>>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> JUnit in Action, Second Edition
>>>>>> Spring Batch in Action
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>
>>>
>>
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
That doesn't really help much. I find the syntax below oddly annoying. What is strange is that I don't really mind it when there is only a single '-' character but when there is more than one I find it irritating - especially with size-based-triggering-policy. I can't tell you how many times I hit '=' instead of '-' when typing it.
<configuration status="warn" name="XMLConfigTest" packages="org.apache.logging.log4j.test">
<properties>
<property name="filename">target/rolling1/rollingtest.log</Property>
</properties>
<threshold-filter level="debug"/>
<appenders>
<console name="STDOUT">
<pattern-layout pattern="%m%n"/>
</console>
<rolling-file name="RollingFile" file-name="${filename}"
file-pattern="target/rolling1/test1-$${date:MM-dd-yyyy}-%i.log.gz">
<pattern-layout>
<pattern>%d %p %C{1.} [%t] %m%n</pattern>
</pattern-layout>
<size-based-triggering-policy size="500" />
</rolling-file>
<list name="List">
<threshold-filter level="error"/>
</list>
</appenders>
<loggers>
<logger name="org.apache.logging.log4j.test1" level="debug" additivity="false">
<thread-context-map-filter>
<key-value-pair key="test" value="123"/>
</thread-context-map-filter>
<appender-ref ref="STDOUT"/>
</logger>>
<logger name="org.apache.logging.log4j.core.appender.rolling" level="debug" additivity="false">
<appender-ref ref="RollingFile"/>
</logger>>
<root level="error">
<appender-ref ref="STDOUT"/>
</root>
</loggers>
</configuration>
On Aug 16, 2013, at 11:41 PM, Nick Williams wrote:
> Or we could just make them all hyphenated, which is my preference. Then we avoid the stripping you detest and the errors you're afraid our users will commit. :-)
>
> Nick
>
> On Aug 17, 2013, at 1:38 AM, Ralph Goers wrote:
>
>> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>>
>> Ralph
>>
>> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>>
>>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>>
>>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>>
>>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>>
>>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>>
>>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>>
>>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>>
>>> - Consistency, consistency, consistency.
>>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>>> - camelCase elements AND camelCase attributes.
>>> - PascalCase elements AND PascalCase attributes.
>>>
>>> Nick
>>>
>>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>>
>>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>>
>>>> Ralph
>>>>
>>>>
>>>>
>>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>>
>>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>> So far yours is the only vote for that. Anyone else?
>>>>>
>>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>>> G
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>>
>>>>>> I think we should do both.
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>
>>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>>> 1) strip '-' characters from element names.
>>>>>>> 2) allow aliases for element names.
>>>>>>>
>>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>>
>>>>>>>> Ralph,
>>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>>
>>>>>>>> Remko
>>>>>>>>
>>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>>
>>>>>>>> Ralph
>>>>>>>>
>>>>>>>>
>>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>>
>>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>>> log4j 1.
>>>>>>>>>
>>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>>
>>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>>
>>>>>>>>> Gary
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Gary
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Scott
>>>>>>>>>
>>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>>>>> >
>>>>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>>> >>
>>>>>>>>> >
>>>>>>>>> > Hold on to your horses ;)
>>>>>>>>> >
>>>>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>>> >
>>>>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>>> >
>>>>>>>>> > Gary
>>>>>>>>> >
>>>>>>>>> >
>>>>>>>>> >>
>>>>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>>> >>
>>>>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>>> >> delegate?
>>>>>>>>> >>
>>>>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>>> >>
>>>>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>>>>> >>>
>>>>>>>>> >>> Sent from my iPad
>>>>>>>>> >>>
>>>>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>>> >>> attributes?
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>>>>> >>>
>>>>>>>>> >>> Gary
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>>> >>> use
>>>>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>>> >>>
>>>>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> > Modified:
>>>>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>>> >>> > URL:
>>>>>>>>> >>>
>>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> JUnit in Action, Second Edition
>>>>> Spring Batch in Action
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Nick Williams <ni...@nicholaswilliams.net>.
Or we could just make them all hyphenated, which is my preference. Then we avoid the stripping you detest and the errors you're afraid our users will commit. :-)
Nick
On Aug 17, 2013, at 1:38 AM, Ralph Goers wrote:
> OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
>
> Ralph
>
> On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
>
>> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>>
>> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>>
>> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
>> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
>> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
>> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>>
>> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>>
>> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>>
>> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>>
>> - Consistency, consistency, consistency.
>> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
>> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
>> - camelCase elements AND camelCase attributes.
>> - PascalCase elements AND PascalCase attributes.
>>
>> Nick
>>
>> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>>
>>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>>
>>> Ralph
>>>
>>>
>>>
>>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>>
>>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>> So far yours is the only vote for that. Anyone else?
>>>>
>>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>>> G
>>>>
>>>> Ralph
>>>>
>>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>>
>>>>> I think we should do both.
>>>>>
>>>>> Gary
>>>>>
>>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>
>>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>>> 1) strip '-' characters from element names.
>>>>>> 2) allow aliases for element names.
>>>>>>
>>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>>
>>>>>>> Ralph,
>>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>>
>>>>>>> Remko
>>>>>>>
>>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>>
>>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>>
>>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>>> log4j 1.
>>>>>>>>
>>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>>
>>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>>
>>>>>>>> Scott
>>>>>>>>
>>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>>>> >
>>>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>>> >>
>>>>>>>> >
>>>>>>>> > Hold on to your horses ;)
>>>>>>>> >
>>>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>>> >
>>>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>>> >
>>>>>>>> > Gary
>>>>>>>> >
>>>>>>>> >
>>>>>>>> >>
>>>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>>> >>
>>>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>>> >> delegate?
>>>>>>>> >>
>>>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>>> >>
>>>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>>>> >>>
>>>>>>>> >>> Sent from my iPad
>>>>>>>> >>>
>>>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>>> >>>
>>>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>>> >>> attributes?
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>>>> >>>
>>>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>>>> >>>
>>>>>>>> >>> Gary
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>>>> >>>
>>>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>>> >>> use
>>>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>>> >>>
>>>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>>> >>>
>>>>>>>> >>> > Modified:
>>>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>>> >>> > URL:
>>>>>>>> >>>
>>>>>>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> JUnit in Action, Second Edition
>>>> Spring Batch in Action
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
OK. In general I guess I agree with your philosophy. However, I consider stripping/ignoring hyphens bad because then <a-p-p-e-n-d-e-r-r-e-f r-e-f="Console"/> becomes valid. The ONLY reason I wanted aliases is because I really believe users who are used to the "other" logging frameworks are constantly going to screw up and do <appender-ref ref="abc"/> instead of <AppenderRef ref="abc"/> simply because they are used to it. However, if my choice is between stripping or leaving it the way it is then I vote to leave it the way it is. Again, I just detest the idea of stripping hyphens.
Ralph
On Aug 16, 2013, at 11:28 PM, Nick Williams wrote:
> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>
> I like consistency. I like the same rules to apply to all parts of the configuration. For example:
>
> - If we decide that an element should be PascalCase, then they should ALL be PascalCase.
> - If we decide that an attribute should be camelCase, then they should ALL be camelCase.
> - If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
> - If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
>
> This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
>
> I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
>
> If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
>
> - Consistency, consistency, consistency.
> - A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
> - All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
> - camelCase elements AND camelCase attributes.
> - PascalCase elements AND PascalCase attributes.
>
> Nick
>
> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>
>> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>>
>> Ralph
>>
>>
>>
>> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>>
>>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>> So far yours is the only vote for that. Anyone else?
>>>
>>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>>> G
>>>
>>> Ralph
>>>
>>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>>
>>>> I think we should do both.
>>>>
>>>> Gary
>>>>
>>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>
>>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>>> 1) strip '-' characters from element names.
>>>>> 2) allow aliases for element names.
>>>>>
>>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>>
>>>>>> Ralph,
>>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>>
>>>>>> Remko
>>>>>>
>>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>>
>>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>>
>>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>>> log4j 1.
>>>>>>>
>>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>>
>>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>>
>>>>>>> Scott
>>>>>>>
>>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>>> >
>>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>>> >>
>>>>>>> >
>>>>>>> > Hold on to your horses ;)
>>>>>>> >
>>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>>> >
>>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>>> >
>>>>>>> > Gary
>>>>>>> >
>>>>>>> >
>>>>>>> >>
>>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>>> >>
>>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>>> >> delegate?
>>>>>>> >>
>>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>>> >>
>>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>>> >>>
>>>>>>> >>> Sent from my iPad
>>>>>>> >>>
>>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>>> >>>
>>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>>> >>> attributes?
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>>> >>>
>>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>>> >>>
>>>>>>> >>> Gary
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>>> >>>
>>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>>> >>> use
>>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>>> >>>
>>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>>> >>>
>>>>>>> >>> > Modified:
>>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>>> >>> > URL:
>>>>>>> >>>
>>>>>
>>>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> JUnit in Action, Second Edition
>>> Spring Batch in Action
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
As an aside, the only sane way to create an XSD would be to generate it
like we generate the dat file.
Gary
On Sat, Aug 17, 2013 at 2:28 AM, Nick Williams <
nicholas@nicholaswilliams.net> wrote:
> Alright. Time to chime in I suppose, since I'm being quoted now. :-)
>
> I like consistency. I like the same rules to apply to all parts of the
> configuration. For example:
>
> - If we decide that an element should be PascalCase, then they should ALL
> be PascalCase.
> - If we decide that an attribute should be camelCase, then they should ALL
> be camelCase.
> - If we decide that an element and/or attribute should be
> case-insensitive, then ALL elements AND attributes should be
> case-insensitive.
> - If we decide that an element and/or attribute should allow hyphens
> between words, then ALL elements AND attributes should allow hyphens
> between words.
>
> This last one is a key point here. Providing aliases would not be a sane
> way to do this, because what if a developer added an attribute but forgot
> to create a hyphenated alias? Suddenly, all elements and attributes would
> allow hyphenation—except that one attribute. This is a consistency failure.
>
> I'm not arguing against aliases, necessarily. I just think they're a Bad
> way to solve the hyphenation dispute (yes, capital Bad). With the
> hyphenation issue solved otherwise (either by disallowing hyphens or by
> stripping hyphens automatically), I no longer see a compelling need for
> aliases. The addition of aliases also makes the task for users of extending
> Log4j / writing plugins for Log4j more confusing.
>
> If I had to chose what we were going to do here, these are my
> preferences/priorities, in order from most important to least important:
>
> - Consistency, consistency, consistency.
> - A strict schema that must be validated against for the Log4j
> configuration to work. No case insensitivity, no stripping of hyphens.
> - All lowercase, hyphenated elements AND attributes. No PascalCase, no
> camelCase.
> - camelCase elements AND camelCase attributes.
> - PascalCase elements AND PascalCase attributes.
>
> Nick
>
> On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
>
> On Aug 10 Nick said "I actually really like hyphenated attributes, but I
> like consistency better.". However, that doesn't imply that he is going to
> like allowing '-' to appear anywhere and be stripped out. Providing
> aliases would be a more sane way to do that.
>
> Ralph
>
>
>
> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>
> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com>wrote:
>
>> So far yours is the only vote for that. Anyone else?
>>
>
> Whomever else mentioned it in the first place! ;) I can't recall who...
> but it's 2am here...
> G
>
>>
>> Ralph
>>
>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>
>> I think we should do both.
>>
>> Gary
>>
>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>
>> Easily done, assuming we have consensus. I am hearing two options:
>> 1) strip '-' characters from element names.
>> 2) allow aliases for element names.
>>
>> These are not mutually exclusive. I see no reason not to go ahead with
>> number 2 and we can continue to discuss where else number 1 might be used.
>>
>> Ralph
>>
>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>
>> Ralph,
>> Don't forget the error-ref attribute for AsyncAppender.
>>
>> Remko
>>
>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>
>>> I'm not in favor of just allowing arbitrary '-' characters wherever
>>> users want. But allowing aliases makes it possible to allow for variations.
>>> I already have this working.
>>>
>>> Ralph
>>>
>>>
>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>
>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
>>>
>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>>>
>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>> stick with he dash format due to folks being familiar with it from
>>> log4j 1.
>>>
>>>
>>> That's a thin argument IMO considering you'll have to read the version 2
>>> config docs to get off the ground anyway, even if you know your way around
>>> version 1.
>>>
>>>
>>> And this is also an opportunity to make our config code even fancier by
>>> normalizing '-' chars ;)
>>>
>>> Gary
>>>
>>>
>>>
>>> Gary
>>>
>>>
>>>
>>> Scott
>>>
>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>> > <ra...@dslextreme.com>wrote:
>>> >
>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>> >>
>>> >
>>> > Hold on to your horses ;)
>>> >
>>> > Another way to look at this is that our config parsing that is already
>>> > case-insensitive could be augmented to strip out "-"s, no aliases
>>> needed.
>>> >
>>> > As someone pointed out here, some folks like-to-talk-like-this (see
>>> JPA).
>>> >
>>> > Gary
>>> >
>>> >
>>> >>
>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>> >>
>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>> >> delegate?
>>> >>
>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>> >>
>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>> >>> currently a way for a plugin to have 2 names.
>>> >>>
>>> >>> Sent from my iPad
>>> >>>
>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
>>> wrote:
>>> >>>
>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>> >>> attributes?
>>> >>>
>>> >>>
>>> >>>
>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>> >>> <ga...@gmail.com>wrote:
>>> >>>
>>> >>> I never thought that Log4J 2 configuration files should be backward
>>> >>> compatible with version 1, and even less so with a different product.
>>> >>>
>>> >>> Gary
>>> >>>
>>> >>>
>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>> >>> <ra...@dslextreme.com>wrote:
>>> >>>
>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>> >>> use
>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>> >>>
>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>> >>>
>>> >>> > Modified:
>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>> >>> > URL:
>>> >>>
>>> <http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff>
>>>
>>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Nick Williams <ni...@nicholaswilliams.net>.
Alright. Time to chime in I suppose, since I'm being quoted now. :-)
I like consistency. I like the same rules to apply to all parts of the configuration. For example:
- If we decide that an element should be PascalCase, then they should ALL be PascalCase.
- If we decide that an attribute should be camelCase, then they should ALL be camelCase.
- If we decide that an element and/or attribute should be case-insensitive, then ALL elements AND attributes should be case-insensitive.
- If we decide that an element and/or attribute should allow hyphens between words, then ALL elements AND attributes should allow hyphens between words.
This last one is a key point here. Providing aliases would not be a sane way to do this, because what if a developer added an attribute but forgot to create a hyphenated alias? Suddenly, all elements and attributes would allow hyphenation—except that one attribute. This is a consistency failure.
I'm not arguing against aliases, necessarily. I just think they're a Bad way to solve the hyphenation dispute (yes, capital Bad). With the hyphenation issue solved otherwise (either by disallowing hyphens or by stripping hyphens automatically), I no longer see a compelling need for aliases. The addition of aliases also makes the task for users of extending Log4j / writing plugins for Log4j more confusing.
If I had to chose what we were going to do here, these are my preferences/priorities, in order from most important to least important:
- Consistency, consistency, consistency.
- A strict schema that must be validated against for the Log4j configuration to work. No case insensitivity, no stripping of hyphens.
- All lowercase, hyphenated elements AND attributes. No PascalCase, no camelCase.
- camelCase elements AND camelCase attributes.
- PascalCase elements AND PascalCase attributes.
Nick
On Aug 17, 2013, at 1:14 AM, Ralph Goers wrote:
> On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
>
> Ralph
>
>
>
> On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
>
>> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>> So far yours is the only vote for that. Anyone else?
>>
>> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
>> G
>>
>> Ralph
>>
>> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>>
>>> I think we should do both.
>>>
>>> Gary
>>>
>>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>>
>>>> Easily done, assuming we have consensus. I am hearing two options:
>>>> 1) strip '-' characters from element names.
>>>> 2) allow aliases for element names.
>>>>
>>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>>
>>>> Ralph
>>>>
>>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>>
>>>>> Ralph,
>>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>>
>>>>> Remko
>>>>>
>>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>>
>>>>> Ralph
>>>>>
>>>>>
>>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>>
>>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>>> stick with he dash format due to folks being familiar with it from
>>>>>> log4j 1.
>>>>>>
>>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>>
>>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>>
>>>>>> Scott
>>>>>>
>>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>>> > <ra...@dslextreme.com>wrote:
>>>>>> >
>>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>>> >>
>>>>>> >
>>>>>> > Hold on to your horses ;)
>>>>>> >
>>>>>> > Another way to look at this is that our config parsing that is already
>>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>>> >
>>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>>> >
>>>>>> > Gary
>>>>>> >
>>>>>> >
>>>>>> >>
>>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>>> >>
>>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>>> >> delegate?
>>>>>> >>
>>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>>> >>
>>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>>> >>> currently a way for a plugin to have 2 names.
>>>>>> >>>
>>>>>> >>> Sent from my iPad
>>>>>> >>>
>>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>>> >>>
>>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>>> >>> attributes?
>>>>>> >>>
>>>>>> >>>
>>>>>> >>>
>>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>>> >>> <ga...@gmail.com>wrote:
>>>>>> >>>
>>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>>> >>>
>>>>>> >>> Gary
>>>>>> >>>
>>>>>> >>>
>>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>>> >>>
>>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>>> >>> use
>>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>>> >>>
>>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>>> >>>
>>>>>> >>> > Modified:
>>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>>> >>> > URL:
>>>>>> >>>
>>>>
>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
On Aug 10 Nick said "I actually really like hyphenated attributes, but I like consistency better.". However, that doesn't imply that he is going to like allowing '-' to appear anywhere and be stripped out. Providing aliases would be a more sane way to do that.
Ralph
On Aug 16, 2013, at 10:57 PM, Gary Gregory wrote:
> On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
> So far yours is the only vote for that. Anyone else?
>
> Whomever else mentioned it in the first place! ;) I can't recall who... but it's 2am here...
> G
>
> Ralph
>
> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>
>> I think we should do both.
>>
>> Gary
>>
>> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>>
>>> Easily done, assuming we have consensus. I am hearing two options:
>>> 1) strip '-' characters from element names.
>>> 2) allow aliases for element names.
>>>
>>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>>
>>> Ralph
>>>
>>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>>
>>>> Ralph,
>>>> Don't forget the error-ref attribute for AsyncAppender.
>>>>
>>>> Remko
>>>>
>>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>>
>>>> Ralph
>>>>
>>>>
>>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>>
>>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>>> stick with he dash format due to folks being familiar with it from
>>>>> log4j 1.
>>>>>
>>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>>
>>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>>
>>>>> Gary
>>>>>
>>>>>
>>>>> Gary
>>>>>
>>>>>
>>>>> Scott
>>>>>
>>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>>> > <ra...@dslextreme.com>wrote:
>>>>> >
>>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>>> >>
>>>>> >
>>>>> > Hold on to your horses ;)
>>>>> >
>>>>> > Another way to look at this is that our config parsing that is already
>>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>>> >
>>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>>> >
>>>>> > Gary
>>>>> >
>>>>> >
>>>>> >>
>>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>>> >>
>>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>>> >> delegate?
>>>>> >>
>>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>>> >>
>>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>>> >>> currently a way for a plugin to have 2 names.
>>>>> >>>
>>>>> >>> Sent from my iPad
>>>>> >>>
>>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>>> >>>
>>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>>> >>> attributes?
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>>> >>> <ga...@gmail.com>wrote:
>>>>> >>>
>>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>>> >>> compatible with version 1, and even less so with a different product.
>>>>> >>>
>>>>> >>> Gary
>>>>> >>>
>>>>> >>>
>>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>>> >>> <ra...@dslextreme.com>wrote:
>>>>> >>>
>>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>>> >>> use
>>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>>> >>>
>>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>>> >>>
>>>>> >>> > Modified:
>>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>>> >>> > URL:
>>>>> >>>
>>>
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Aug 17, 2013 at 1:44 AM, Ralph Goers <ra...@dslextreme.com>wrote:
> So far yours is the only vote for that. Anyone else?
>
Whomever else mentioned it in the first place! ;) I can't recall who... but
it's 2am here...
G
>
> Ralph
>
> On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
>
> I think we should do both.
>
> Gary
>
> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>
> Easily done, assuming we have consensus. I am hearing two options:
> 1) strip '-' characters from element names.
> 2) allow aliases for element names.
>
> These are not mutually exclusive. I see no reason not to go ahead with
> number 2 and we can continue to discuss where else number 1 might be used.
>
> Ralph
>
> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>
> Ralph,
> Don't forget the error-ref attribute for AsyncAppender.
>
> Remko
>
> On Saturday, August 17, 2013, Ralph Goers wrote:
>
>> I'm not in favor of just allowing arbitrary '-' characters wherever users
>> want. But allowing aliases makes it possible to allow for variations. I
>> already have this working.
>>
>> Ralph
>>
>>
>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>
>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
>>
>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>>
>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>> stick with he dash format due to folks being familiar with it from
>> log4j 1.
>>
>>
>> That's a thin argument IMO considering you'll have to read the version 2
>> config docs to get off the ground anyway, even if you know your way around
>> version 1.
>>
>>
>> And this is also an opportunity to make our config code even fancier by
>> normalizing '-' chars ;)
>>
>> Gary
>>
>>
>>
>> Gary
>>
>>
>>
>> Scott
>>
>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>> > <ra...@dslextreme.com>wrote:
>> >
>> >> I'm adding an aliases attribute to the Plugin annotation.
>> >>
>> >
>> > Hold on to your horses ;)
>> >
>> > Another way to look at this is that our config parsing that is already
>> > case-insensitive could be augmented to strip out "-"s, no aliases
>> needed.
>> >
>> > As someone pointed out here, some folks like-to-talk-like-this (see
>> JPA).
>> >
>> > Gary
>> >
>> >
>> >>
>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>> >>
>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>> >> delegate?
>> >>
>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>> >>
>> >>> I had the same thought. People switching from log4j 1 or logback will
>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>> >>> currently using Log4j 2. The problem is that I don't think there is
>> >>> currently a way for a plugin to have 2 names.
>> >>>
>> >>> Sent from my iPad
>> >>>
>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
>> wrote:
>> >>>
>> >>> Would it be an idea to support both appender-ref and appenderRef
>> >>> attributes?
>> >>>
>> >>>
>> >>>
>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>> >>> <ga...@gmail.com>wrote:
>> >>>
>> >>> I never thought that Log4J 2 configuration files should be backward
>> >>> compatible with version 1, and even less so with a different product.
>> >>>
>> >>> Gary
>> >>>
>> >>>
>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>> >>> <ra...@dslextreme.com>wrote:
>> >>>
>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>> >>> use
>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>> >>>
>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>> >>>
>> >>> > Modified:
>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> >>> > URL:
>> >>>
>> <http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff>
>>
>>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
So far yours is the only vote for that. Anyone else?
Ralph
On Aug 16, 2013, at 10:19 PM, Gary Gregory wrote:
> I think we should do both.
>
> Gary
>
> On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
>
>> Easily done, assuming we have consensus. I am hearing two options:
>> 1) strip '-' characters from element names.
>> 2) allow aliases for element names.
>>
>> These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
>>
>> Ralph
>>
>> On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
>>
>>> Ralph,
>>> Don't forget the error-ref attribute for AsyncAppender.
>>>
>>> Remko
>>>
>>> On Saturday, August 17, 2013, Ralph Goers wrote:
>>> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>>>
>>> Ralph
>>>
>>>
>>> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>>>
>>>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>>> stick with he dash format due to folks being familiar with it from
>>>> log4j 1.
>>>>
>>>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>>>
>>>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>>>
>>>> Gary
>>>>
>>>>
>>>> Gary
>>>>
>>>>
>>>> Scott
>>>>
>>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>>> > <ra...@dslextreme.com>wrote:
>>>> >
>>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>>> >>
>>>> >
>>>> > Hold on to your horses ;)
>>>> >
>>>> > Another way to look at this is that our config parsing that is already
>>>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>>>> >
>>>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>>>> >
>>>> > Gary
>>>> >
>>>> >
>>>> >>
>>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>>> >>
>>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>>> >> delegate?
>>>> >>
>>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>>> >>
>>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>>> >>> currently a way for a plugin to have 2 names.
>>>> >>>
>>>> >>> Sent from my iPad
>>>> >>>
>>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>> >>>
>>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>>> >>> attributes?
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>>> >>> <ga...@gmail.com>wrote:
>>>> >>>
>>>> >>> I never thought that Log4J 2 configuration files should be backward
>>>> >>> compatible with version 1, and even less so with a different product.
>>>> >>>
>>>> >>> Gary
>>>> >>>
>>>> >>>
>>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>>> >>> <ra...@dslextreme.com>wrote:
>>>> >>>
>>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>>> >>> use
>>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>> >>>
>>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>> >>>
>>>> >>> > Modified:
>>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>>> >>> > URL:
>>>> >>>
>>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
I think we should do both.
Gary
On Aug 16, 2013, at 21:59, Ralph Goers <ra...@dslextreme.com> wrote:
Easily done, assuming we have consensus. I am hearing two options:
1) strip '-' characters from element names.
2) allow aliases for element names.
These are not mutually exclusive. I see no reason not to go ahead with
number 2 and we can continue to discuss where else number 1 might be used.
Ralph
On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
Ralph,
Don't forget the error-ref attribute for AsyncAppender.
Remko
On Saturday, August 17, 2013, Ralph Goers wrote:
> I'm not in favor of just allowing arbitrary '-' characters wherever users
> want. But allowing aliases makes it possible to allow for variations. I
> already have this working.
>
> Ralph
>
>
> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>
> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
>
> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>
> I'm not sure if this ship has fully sailed, but I'd prefer to see us
> stick with he dash format due to folks being familiar with it from
> log4j 1.
>
>
> That's a thin argument IMO considering you'll have to read the version 2
> config docs to get off the ground anyway, even if you know your way around
> version 1.
>
>
> And this is also an opportunity to make our config code even fancier by
> normalizing '-' chars ;)
>
> Gary
>
>
>
> Gary
>
>
>
> Scott
>
> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
> > <ra...@dslextreme.com>wrote:
> >
> >> I'm adding an aliases attribute to the Plugin annotation.
> >>
> >
> > Hold on to your horses ;)
> >
> > Another way to look at this is that our config parsing that is already
> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
> >
> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
> >
> > Gary
> >
> >
> >>
> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
> >>
> >> Maybe we just need another plugin for the 2nd name then. Subclass or
> >> delegate?
> >>
> >> On Friday, August 16, 2013, Ralph Goers wrote:
> >>
> >>> I had the same thought. People switching from log4j 1 or logback will
> >>> probably make that mistake a lot. Plus this breaks virtually everyone
> >>> currently using Log4j 2. The problem is that I don't think there is
> >>> currently a way for a plugin to have 2 names.
> >>>
> >>> Sent from my iPad
> >>>
> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
> wrote:
> >>>
> >>> Would it be an idea to support both appender-ref and appenderRef
> >>> attributes?
> >>>
> >>>
> >>>
> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
> >>> <ga...@gmail.com>wrote:
> >>>
> >>> I never thought that Log4J 2 configuration files should be backward
> >>> compatible with version 1, and even less so with a different product.
> >>>
> >>> Gary
> >>>
> >>>
> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
> >>> <ra...@dslextreme.com>wrote:
> >>>
> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
> >>> use
> >>> appender-ref. Anyone using Log4j 2 will now be broken.
> >>>
> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
> >>>
> >>> > Modified:
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> >>> > URL:
> >>>
> <http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff>
>
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
Easily done, assuming we have consensus. I am hearing two options:
1) strip '-' characters from element names.
2) allow aliases for element names.
These are not mutually exclusive. I see no reason not to go ahead with number 2 and we can continue to discuss where else number 1 might be used.
Ralph
On Aug 16, 2013, at 2:21 PM, Remko Popma wrote:
> Ralph,
> Don't forget the error-ref attribute for AsyncAppender.
>
> Remko
>
> On Saturday, August 17, 2013, Ralph Goers wrote:
> I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
>
> Ralph
>
>
> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>
>> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>> stick with he dash format due to folks being familiar with it from
>> log4j 1.
>>
>> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>>
>> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>>
>> Gary
>>
>>
>> Gary
>>
>>
>> Scott
>>
>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>> > <ra...@dslextreme.com>wrote:
>> >
>> >> I'm adding an aliases attribute to the Plugin annotation.
>> >>
>> >
>> > Hold on to your horses ;)
>> >
>> > Another way to look at this is that our config parsing that is already
>> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
>> >
>> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>> >
>> > Gary
>> >
>> >
>> >>
>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>> >>
>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>> >> delegate?
>> >>
>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>> >>
>> >>> I had the same thought. People switching from log4j 1 or logback will
>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>> >>> currently using Log4j 2. The problem is that I don't think there is
>> >>> currently a way for a plugin to have 2 names.
>> >>>
>> >>> Sent from my iPad
>> >>>
>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>> >>>
>> >>> Would it be an idea to support both appender-ref and appenderRef
>> >>> attributes?
>> >>>
>> >>>
>> >>>
>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>> >>> <ga...@gmail.com>wrote:
>> >>>
>> >>> I never thought that Log4J 2 configuration files should be backward
>> >>> compatible with version 1, and even less so with a different product.
>> >>>
>> >>> Gary
>> >>>
>> >>>
>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>> >>> <ra...@dslextreme.com>wrote:
>> >>>
>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>> >>> use
>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>> >>>
>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>> >>>
>> >>> > Modified:
>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> >>> > URL:
>> >>>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Remko Popma <re...@gmail.com>.
Ralph,
Don't forget the error-ref attribute for AsyncAppender.
Remko
On Saturday, August 17, 2013, Ralph Goers wrote:
> I'm not in favor of just allowing arbitrary '-' characters wherever users
> want. But allowing aliases makes it possible to allow for variations. I
> already have this working.
>
> Ralph
>
>
> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>
> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
>
> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>
> I'm not sure if this ship has fully sailed, but I'd prefer to see us
> stick with he dash format due to folks being familiar with it from
> log4j 1.
>
>
> That's a thin argument IMO considering you'll have to read the version 2
> config docs to get off the ground anyway, even if you know your way around
> version 1.
>
>
> And this is also an opportunity to make our config code even fancier by
> normalizing '-' chars ;)
>
> Gary
>
>
>
> Gary
>
>
>
> Scott
>
> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
> > <ra...@dslextreme.com>wrote:
> >
> >> I'm adding an aliases attribute to the Plugin annotation.
> >>
> >
> > Hold on to your horses ;)
> >
> > Another way to look at this is that our config parsing that is already
> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
> >
> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
> >
> > Gary
> >
> >
> >>
> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
> >>
> >> Maybe we just need another plugin for the 2nd name then. Subclass or
> >> delegate?
> >>
> >> On Friday, August 16, 2013, Ralph Goers wrote:
> >>
> >>> I had the same thought. People switching from log4j 1 or logback will
> >>> probably make that mistake a lot. Plus this breaks virtually everyone
> >>> currently using Log4j 2. The problem is that I don't think there is
> >>> currently a way for a plugin to have 2 names.
> >>>
> >>> Sent from my iPad
> >>>
> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
> wrote:
> >>>
> >>> Would it be an idea to support both appender-ref and appenderRef
> >>> attributes?
> >>>
> >>>
> >>>
> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
> >>> <ga...@gmail.com>wrote:
> >>>
> >>> I never thought that Log4J 2 configuration files should be backward
> >>> compatible with version 1, and even less so with a different product.
> >>>
> >>> Gary
> >>>
> >>>
> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
> >>> <ra...@dslextreme.com>wrote:
> >>>
> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
> >>> use
> >>> appender-ref. Anyone using Log4j 2 will now be broken.
> >>>
> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
> >>>
> >>> > Modified:
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> >>> > URL:
> >>>
> <http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff>
>
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Aug 16, 2013 at 3:32 PM, Ralph Goers <ra...@dslextreme.com>wrote:
> I'm not in favor of just allowing arbitrary '-' characters wherever users
> want. But allowing aliases makes it possible to allow for variations. I
> already have this working.
>
>
Well, once we opened the door with mixed case configuration, I could see
that we are letting UseRdoWhaTEVerTheyWANT. So, why not '-'? It seems line
a normal follow up, considering that folks LikeItHot and some like-it-cold!
:)
What happens with in a configuration that uses the infamous combo of
uppercase/lowercase under the Turkish Locale?
Gary
> Ralph
>
>
>
> On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
>
> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
>
>> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>>
>>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>>> stick with he dash format due to folks being familiar with it from
>>> log4j 1.
>>>
>>
>> That's a thin argument IMO considering you'll have to read the version 2
>> config docs to get off the ground anyway, even if you know your way around
>> version 1.
>>
>
> And this is also an opportunity to make our config code even fancier by
> normalizing '-' chars ;)
>
> Gary
>
>
>>
>> Gary
>>
>>
>>>
>>> Scott
>>>
>>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>>> > <ra...@dslextreme.com>wrote:
>>> >
>>> >> I'm adding an aliases attribute to the Plugin annotation.
>>> >>
>>> >
>>> > Hold on to your horses ;)
>>> >
>>> > Another way to look at this is that our config parsing that is already
>>> > case-insensitive could be augmented to strip out "-"s, no aliases
>>> needed.
>>> >
>>> > As someone pointed out here, some folks like-to-talk-like-this (see
>>> JPA).
>>> >
>>> > Gary
>>> >
>>> >
>>> >>
>>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>> >>
>>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>>> >> delegate?
>>> >>
>>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>>> >>
>>> >>> I had the same thought. People switching from log4j 1 or logback will
>>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>>> >>> currently using Log4j 2. The problem is that I don't think there is
>>> >>> currently a way for a plugin to have 2 names.
>>> >>>
>>> >>> Sent from my iPad
>>> >>>
>>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
>>> wrote:
>>> >>>
>>> >>> Would it be an idea to support both appender-ref and appenderRef
>>> >>> attributes?
>>> >>>
>>> >>>
>>> >>>
>>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>> >>> <ga...@gmail.com>wrote:
>>> >>>
>>> >>> I never thought that Log4J 2 configuration files should be backward
>>> >>> compatible with version 1, and even less so with a different product.
>>> >>>
>>> >>> Gary
>>> >>>
>>> >>>
>>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>> >>> <ra...@dslextreme.com>wrote:
>>> >>>
>>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>> >>> use
>>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>>> >>>
>>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>> >>>
>>> >>> > Modified:
>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>> >>> > URL:
>>> >>>
>>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> >>> >
>>> >>>
>>> ==============================================================================
>>> >>> > ---
>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>> >>> (original)
>>> >>> > +++
>>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>> Wed
>>> >>> Aug 14 20:05:54 2013
>>> >>> > @@ -30,10 +30,10 @@
>>> >>> > </appenders>
>>> >>> > <loggers>
>>> >>> > <logger name="org.apache.test" level="trace"
>>> additivity="false">
>>> >>> > - <appender-ref ref="List"/>
>>> >>> > + <AppenderRef ref="List"/>
>>> >>> > </logger>
>>> >>> > <root level="error">
>>> >>> > - <appender-ref ref="STDOUT"/>
>>> >>> > + <AppenderRef ref="STDOUT"/>
>>> >>> > </root>
>>> >>> > </loggers>
>>> >>> > </configuration>
>>> >>> > \ No newline at end of file
>>> >>> >
>>> >>> > Modified:
>>> >>>
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>>> >>> > URL:
>>> >>>
>>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> >>> >
>>> >>>
>>> ==============================================================================
>>> >>> > ---
>>> >>>
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>>> >>> (original)
>>> >>> > +++
>>> >>>
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>>> >>> Wed Aug 14 20:05:54 2013
>>> >>> > @@ -25,7 +25,7 @@
>>> >>> > <loggers>
>>> >>> > <logger name="org.foo" level="DEBUG" />
>>> >>> > <root level="TRACE">
>>> >>> > - <appender-ref ref="Console" />
>>> >>> > + <AppenderRef ref="Console" />
>>> >>> > </root>
>>> >>> > </loggers>
>>> >>> > </configuration>
>>> >>> > \ No newline at end of file
>>> >>> >
>>> >>> > Modified:
>>> >>>
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>>> >>> > URL:
>>> >>>
>>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> >>> >
>>> >>>
>>> ==============================================================================
>>> >>> > ---
>>> >>>
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>>> >>> (original)
>>> >>>
>>> >>>
>>> >>
>>> >
>>> >
>>> > --
>>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> > Java Persistence with Hibernate, Second
>>> > Edition<http://www.manning.com/bauer3/>
>>> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> > Spring Batch in Action <http://www.manning.com/templier/>
>>> > Blog: http://garygregory.wordpress.com
>>> > Home: http://garygregory.com/
>>> > Tweet! http://twitter.com/GaryGregory
>>> >
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
I'm not in favor of just allowing arbitrary '-' characters wherever users want. But allowing aliases makes it possible to allow for variations. I already have this working.
Ralph
On Aug 16, 2013, at 11:39 AM, Gary Gregory wrote:
> On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com> wrote:
> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
> I'm not sure if this ship has fully sailed, but I'd prefer to see us
> stick with he dash format due to folks being familiar with it from
> log4j 1.
>
> That's a thin argument IMO considering you'll have to read the version 2 config docs to get off the ground anyway, even if you know your way around version 1.
>
> And this is also an opportunity to make our config code even fancier by normalizing '-' chars ;)
>
> Gary
>
>
> Gary
>
>
> Scott
>
> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
> > <ra...@dslextreme.com>wrote:
> >
> >> I'm adding an aliases attribute to the Plugin annotation.
> >>
> >
> > Hold on to your horses ;)
> >
> > Another way to look at this is that our config parsing that is already
> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
> >
> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
> >
> > Gary
> >
> >
> >>
> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
> >>
> >> Maybe we just need another plugin for the 2nd name then. Subclass or
> >> delegate?
> >>
> >> On Friday, August 16, 2013, Ralph Goers wrote:
> >>
> >>> I had the same thought. People switching from log4j 1 or logback will
> >>> probably make that mistake a lot. Plus this breaks virtually everyone
> >>> currently using Log4j 2. The problem is that I don't think there is
> >>> currently a way for a plugin to have 2 names.
> >>>
> >>> Sent from my iPad
> >>>
> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
> >>>
> >>> Would it be an idea to support both appender-ref and appenderRef
> >>> attributes?
> >>>
> >>>
> >>>
> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
> >>> <ga...@gmail.com>wrote:
> >>>
> >>> I never thought that Log4J 2 configuration files should be backward
> >>> compatible with version 1, and even less so with a different product.
> >>>
> >>> Gary
> >>>
> >>>
> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
> >>> <ra...@dslextreme.com>wrote:
> >>>
> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
> >>> use
> >>> appender-ref. Anyone using Log4j 2 will now be broken.
> >>>
> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
> >>>
> >>> > Modified:
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> >>> > URL:
> >>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >>> >
> >>> ==============================================================================
> >>> > ---
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> >>> (original)
> >>> > +++
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml Wed
> >>> Aug 14 20:05:54 2013
> >>> > @@ -30,10 +30,10 @@
> >>> > </appenders>
> >>> > <loggers>
> >>> > <logger name="org.apache.test" level="trace" additivity="false">
> >>> > - <appender-ref ref="List"/>
> >>> > + <AppenderRef ref="List"/>
> >>> > </logger>
> >>> > <root level="error">
> >>> > - <appender-ref ref="STDOUT"/>
> >>> > + <AppenderRef ref="STDOUT"/>
> >>> > </root>
> >>> > </loggers>
> >>> > </configuration>
> >>> > \ No newline at end of file
> >>> >
> >>> > Modified:
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> >>> > URL:
> >>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >>> >
> >>> ==============================================================================
> >>> > ---
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> >>> (original)
> >>> > +++
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> >>> Wed Aug 14 20:05:54 2013
> >>> > @@ -25,7 +25,7 @@
> >>> > <loggers>
> >>> > <logger name="org.foo" level="DEBUG" />
> >>> > <root level="TRACE">
> >>> > - <appender-ref ref="Console" />
> >>> > + <AppenderRef ref="Console" />
> >>> > </root>
> >>> > </loggers>
> >>> > </configuration>
> >>> > \ No newline at end of file
> >>> >
> >>> > Modified:
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
> >>> > URL:
> >>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >>> >
> >>> ==============================================================================
> >>> > ---
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
> >>> (original)
> >>>
> >>>
> >>
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second
> > Edition<http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Aug 16, 2013 at 2:38 PM, Gary Gregory <ga...@gmail.com>wrote:
> On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com>wrote:
>
>> I'm not sure if this ship has fully sailed, but I'd prefer to see us
>> stick with he dash format due to folks being familiar with it from
>> log4j 1.
>>
>
> That's a thin argument IMO considering you'll have to read the version 2
> config docs to get off the ground anyway, even if you know your way around
> version 1.
>
And this is also an opportunity to make our config code even fancier by
normalizing '-' chars ;)
Gary
>
> Gary
>
>
>>
>> Scott
>>
>> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
>> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
>> > <ra...@dslextreme.com>wrote:
>> >
>> >> I'm adding an aliases attribute to the Plugin annotation.
>> >>
>> >
>> > Hold on to your horses ;)
>> >
>> > Another way to look at this is that our config parsing that is already
>> > case-insensitive could be augmented to strip out "-"s, no aliases
>> needed.
>> >
>> > As someone pointed out here, some folks like-to-talk-like-this (see
>> JPA).
>> >
>> > Gary
>> >
>> >
>> >>
>> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>> >>
>> >> Maybe we just need another plugin for the 2nd name then. Subclass or
>> >> delegate?
>> >>
>> >> On Friday, August 16, 2013, Ralph Goers wrote:
>> >>
>> >>> I had the same thought. People switching from log4j 1 or logback will
>> >>> probably make that mistake a lot. Plus this breaks virtually everyone
>> >>> currently using Log4j 2. The problem is that I don't think there is
>> >>> currently a way for a plugin to have 2 names.
>> >>>
>> >>> Sent from my iPad
>> >>>
>> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
>> wrote:
>> >>>
>> >>> Would it be an idea to support both appender-ref and appenderRef
>> >>> attributes?
>> >>>
>> >>>
>> >>>
>> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>> >>> <ga...@gmail.com>wrote:
>> >>>
>> >>> I never thought that Log4J 2 configuration files should be backward
>> >>> compatible with version 1, and even less so with a different product.
>> >>>
>> >>> Gary
>> >>>
>> >>>
>> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>> >>> <ra...@dslextreme.com>wrote:
>> >>>
>> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>> >>> use
>> >>> appender-ref. Anyone using Log4j 2 will now be broken.
>> >>>
>> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>> >>>
>> >>> > Modified:
>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> >>> > URL:
>> >>>
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >>> >
>> >>>
>> ==============================================================================
>> >>> > ---
>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> >>> (original)
>> >>> > +++
>> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> Wed
>> >>> Aug 14 20:05:54 2013
>> >>> > @@ -30,10 +30,10 @@
>> >>> > </appenders>
>> >>> > <loggers>
>> >>> > <logger name="org.apache.test" level="trace" additivity="false">
>> >>> > - <appender-ref ref="List"/>
>> >>> > + <AppenderRef ref="List"/>
>> >>> > </logger>
>> >>> > <root level="error">
>> >>> > - <appender-ref ref="STDOUT"/>
>> >>> > + <AppenderRef ref="STDOUT"/>
>> >>> > </root>
>> >>> > </loggers>
>> >>> > </configuration>
>> >>> > \ No newline at end of file
>> >>> >
>> >>> > Modified:
>> >>>
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> >>> > URL:
>> >>>
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >>> >
>> >>>
>> ==============================================================================
>> >>> > ---
>> >>>
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> >>> (original)
>> >>> > +++
>> >>>
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> >>> Wed Aug 14 20:05:54 2013
>> >>> > @@ -25,7 +25,7 @@
>> >>> > <loggers>
>> >>> > <logger name="org.foo" level="DEBUG" />
>> >>> > <root level="TRACE">
>> >>> > - <appender-ref ref="Console" />
>> >>> > + <AppenderRef ref="Console" />
>> >>> > </root>
>> >>> > </loggers>
>> >>> > </configuration>
>> >>> > \ No newline at end of file
>> >>> >
>> >>> > Modified:
>> >>>
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>> >>> > URL:
>> >>>
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >>> >
>> >>>
>> ==============================================================================
>> >>> > ---
>> >>>
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>> >>> (original)
>> >>>
>> >>>
>> >>
>> >
>> >
>> > --
>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> > Java Persistence with Hibernate, Second
>> > Edition<http://www.manning.com/bauer3/>
>> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> > Spring Batch in Action <http://www.manning.com/templier/>
>> > Blog: http://garygregory.wordpress.com
>> > Home: http://garygregory.com/
>> > Tweet! http://twitter.com/GaryGregory
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Aug 16, 2013 at 2:28 PM, Scott Deboy <sc...@gmail.com> wrote:
> I'm not sure if this ship has fully sailed, but I'd prefer to see us
> stick with he dash format due to folks being familiar with it from
> log4j 1.
>
That's a thin argument IMO considering you'll have to read the version 2
config docs to get off the ground anyway, even if you know your way around
version 1.
Gary
>
> Scott
>
> On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
> > On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
> > <ra...@dslextreme.com>wrote:
> >
> >> I'm adding an aliases attribute to the Plugin annotation.
> >>
> >
> > Hold on to your horses ;)
> >
> > Another way to look at this is that our config parsing that is already
> > case-insensitive could be augmented to strip out "-"s, no aliases needed.
> >
> > As someone pointed out here, some folks like-to-talk-like-this (see JPA).
> >
> > Gary
> >
> >
> >>
> >> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
> >>
> >> Maybe we just need another plugin for the 2nd name then. Subclass or
> >> delegate?
> >>
> >> On Friday, August 16, 2013, Ralph Goers wrote:
> >>
> >>> I had the same thought. People switching from log4j 1 or logback will
> >>> probably make that mistake a lot. Plus this breaks virtually everyone
> >>> currently using Log4j 2. The problem is that I don't think there is
> >>> currently a way for a plugin to have 2 names.
> >>>
> >>> Sent from my iPad
> >>>
> >>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com>
> wrote:
> >>>
> >>> Would it be an idea to support both appender-ref and appenderRef
> >>> attributes?
> >>>
> >>>
> >>>
> >>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
> >>> <ga...@gmail.com>wrote:
> >>>
> >>> I never thought that Log4J 2 configuration files should be backward
> >>> compatible with version 1, and even less so with a different product.
> >>>
> >>> Gary
> >>>
> >>>
> >>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
> >>> <ra...@dslextreme.com>wrote:
> >>>
> >>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
> >>> use
> >>> appender-ref. Anyone using Log4j 2 will now be broken.
> >>>
> >>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
> >>>
> >>> > Modified:
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> >>> > URL:
> >>>
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >>> >
> >>>
> ==============================================================================
> >>> > ---
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> >>> (original)
> >>> > +++
> >>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> Wed
> >>> Aug 14 20:05:54 2013
> >>> > @@ -30,10 +30,10 @@
> >>> > </appenders>
> >>> > <loggers>
> >>> > <logger name="org.apache.test" level="trace" additivity="false">
> >>> > - <appender-ref ref="List"/>
> >>> > + <AppenderRef ref="List"/>
> >>> > </logger>
> >>> > <root level="error">
> >>> > - <appender-ref ref="STDOUT"/>
> >>> > + <AppenderRef ref="STDOUT"/>
> >>> > </root>
> >>> > </loggers>
> >>> > </configuration>
> >>> > \ No newline at end of file
> >>> >
> >>> > Modified:
> >>>
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> >>> > URL:
> >>>
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >>> >
> >>>
> ==============================================================================
> >>> > ---
> >>>
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> >>> (original)
> >>> > +++
> >>>
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> >>> Wed Aug 14 20:05:54 2013
> >>> > @@ -25,7 +25,7 @@
> >>> > <loggers>
> >>> > <logger name="org.foo" level="DEBUG" />
> >>> > <root level="TRACE">
> >>> > - <appender-ref ref="Console" />
> >>> > + <AppenderRef ref="Console" />
> >>> > </root>
> >>> > </loggers>
> >>> > </configuration>
> >>> > \ No newline at end of file
> >>> >
> >>> > Modified:
> >>>
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
> >>> > URL:
> >>>
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >>> >
> >>>
> ==============================================================================
> >>> > ---
> >>>
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
> >>> (original)
> >>>
> >>>
> >>
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second
> > Edition<http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Scott Deboy <sc...@gmail.com>.
I'm not sure if this ship has fully sailed, but I'd prefer to see us
stick with he dash format due to folks being familiar with it from
log4j 1.
Scott
On 8/16/13, Gary Gregory <ga...@gmail.com> wrote:
> On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers
> <ra...@dslextreme.com>wrote:
>
>> I'm adding an aliases attribute to the Plugin annotation.
>>
>
> Hold on to your horses ;)
>
> Another way to look at this is that our config parsing that is already
> case-insensitive could be augmented to strip out "-"s, no aliases needed.
>
> As someone pointed out here, some folks like-to-talk-like-this (see JPA).
>
> Gary
>
>
>>
>> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>>
>> Maybe we just need another plugin for the 2nd name then. Subclass or
>> delegate?
>>
>> On Friday, August 16, 2013, Ralph Goers wrote:
>>
>>> I had the same thought. People switching from log4j 1 or logback will
>>> probably make that mistake a lot. Plus this breaks virtually everyone
>>> currently using Log4j 2. The problem is that I don't think there is
>>> currently a way for a plugin to have 2 names.
>>>
>>> Sent from my iPad
>>>
>>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>>
>>> Would it be an idea to support both appender-ref and appenderRef
>>> attributes?
>>>
>>>
>>>
>>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory
>>> <ga...@gmail.com>wrote:
>>>
>>> I never thought that Log4J 2 configuration files should be backward
>>> compatible with version 1, and even less so with a different product.
>>>
>>> Gary
>>>
>>>
>>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers
>>> <ra...@dslextreme.com>wrote:
>>>
>>> Now that I see this it kind of scares me. Log4j 1.x and Logback both
>>> use
>>> appender-ref. Anyone using Log4j 2 will now be broken.
>>>
>>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>
>>> > Modified:
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>> > URL:
>>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> >
>>> ==============================================================================
>>> > ---
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>> (original)
>>> > +++
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml Wed
>>> Aug 14 20:05:54 2013
>>> > @@ -30,10 +30,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="org.apache.test" level="trace" additivity="false">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </logger>
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified:
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>>> > URL:
>>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> >
>>> ==============================================================================
>>> > ---
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>>> (original)
>>> > +++
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>>> Wed Aug 14 20:05:54 2013
>>> > @@ -25,7 +25,7 @@
>>> > <loggers>
>>> > <logger name="org.foo" level="DEBUG" />
>>> > <root level="TRACE">
>>> > - <appender-ref ref="Console" />
>>> > + <AppenderRef ref="Console" />
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified:
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>>> > URL:
>>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> >
>>> ==============================================================================
>>> > ---
>>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>>> (original)
>>>
>>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second
> Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Aug 16, 2013 at 1:13 PM, Ralph Goers <ra...@dslextreme.com>wrote:
> I'm adding an aliases attribute to the Plugin annotation.
>
Hold on to your horses ;)
Another way to look at this is that our config parsing that is already
case-insensitive could be augmented to strip out "-"s, no aliases needed.
As someone pointed out here, some folks like-to-talk-like-this (see JPA).
Gary
>
> On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
>
> Maybe we just need another plugin for the 2nd name then. Subclass or
> delegate?
>
> On Friday, August 16, 2013, Ralph Goers wrote:
>
>> I had the same thought. People switching from log4j 1 or logback will
>> probably make that mistake a lot. Plus this breaks virtually everyone
>> currently using Log4j 2. The problem is that I don't think there is
>> currently a way for a plugin to have 2 names.
>>
>> Sent from my iPad
>>
>> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>>
>> Would it be an idea to support both appender-ref and appenderRef
>> attributes?
>>
>>
>>
>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory <ga...@gmail.com>wrote:
>>
>> I never thought that Log4J 2 configuration files should be backward
>> compatible with version 1, and even less so with a different product.
>>
>> Gary
>>
>>
>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers <ra...@dslextreme.com>wrote:
>>
>> Now that I see this it kind of scares me. Log4j 1.x and Logback both use
>> appender-ref. Anyone using Log4j 2 will now be broken.
>>
>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -30,10 +30,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="org.apache.test" level="trace" additivity="false">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -25,7 +25,7 @@
>> > <loggers>
>> > <logger name="org.foo" level="DEBUG" />
>> > <root level="TRACE">
>> > - <appender-ref ref="Console" />
>> > + <AppenderRef ref="Console" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>> (original)
>>
>>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
I'm adding an aliases attribute to the Plugin annotation.
On Aug 16, 2013, at 6:38 AM, Remko Popma wrote:
> Maybe we just need another plugin for the 2nd name then. Subclass or delegate?
>
> On Friday, August 16, 2013, Ralph Goers wrote:
> I had the same thought. People switching from log4j 1 or logback will probably make that mistake a lot. Plus this breaks virtually everyone currently using Log4j 2. The problem is that I don't think there is currently a way for a plugin to have 2 names.
>
> Sent from my iPad
>
> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>
>> Would it be an idea to support both appender-ref and appenderRef attributes?
>>
>>
>>
>> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory <ga...@gmail.com> wrote:
>> I never thought that Log4J 2 configuration files should be backward compatible with version 1, and even less so with a different product.
>>
>> Gary
>>
>>
>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>> Now that I see this it kind of scares me. Log4j 1.x and Logback both use appender-ref. Anyone using Log4j 2 will now be broken.
>>
>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>
>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> > ==============================================================================
>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml (original)
>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml Wed Aug 14 20:05:54 2013
>> > @@ -30,10 +30,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="org.apache.test" level="trace" additivity="false">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> > ==============================================================================
>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml (original)
>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml Wed Aug 14 20:05:54 2013
>> > @@ -25,7 +25,7 @@
>> > <loggers>
>> > <logger name="org.foo" level="DEBUG" />
>> > <root level="TRACE">
>> > - <appender-ref ref="Console" />
>> > + <AppenderRef ref="Console" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> > ==============================================================================
>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml (original)
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Remko Popma <re...@gmail.com>.
Maybe we just need another plugin for the 2nd name then. Subclass or
delegate?
On Friday, August 16, 2013, Ralph Goers wrote:
> I had the same thought. People switching from log4j 1 or logback will
> probably make that mistake a lot. Plus this breaks virtually everyone
> currently using Log4j 2. The problem is that I don't think there is
> currently a way for a plugin to have 2 names.
>
> Sent from my iPad
>
> On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
>
> Would it be an idea to support both appender-ref and appenderRef
> attributes?
>
>
>
> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory <ga...@gmail.com>wrote:
>
> I never thought that Log4J 2 configuration files should be backward
> compatible with version 1, and even less so with a different product.
>
> Gary
>
>
> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers <ra...@dslextreme.com>wrote:
>
> Now that I see this it kind of scares me. Log4j 1.x and Logback both use
> appender-ref. Anyone using Log4j 2 will now be broken.
>
> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> Wed Aug 14 20:05:54 2013
> > @@ -30,10 +30,10 @@
> > </appenders>
> > <loggers>
> > <logger name="org.apache.test" level="trace" additivity="false">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </logger>
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> Wed Aug 14 20:05:54 2013
> > @@ -25,7 +25,7 @@
> > <loggers>
> > <logger name="org.foo" level="DEBUG" />
> > <root level="TRACE">
> > - <appender-ref ref="Console" />
> > + <AppenderRef ref="Console" />
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
> (original)
>
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <rg...@apache.org>.
I had the same thought. People switching from log4j 1 or logback will probably make that mistake a lot. Plus this breaks virtually everyone currently using Log4j 2. The problem is that I don't think there is currently a way for a plugin to have 2 names.
Sent from my iPad
On Aug 16, 2013, at 6:03 AM, Remko Popma <re...@gmail.com> wrote:
> Would it be an idea to support both appender-ref and appenderRef attributes?
>
>
>
> On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory <ga...@gmail.com> wrote:
>> I never thought that Log4J 2 configuration files should be backward compatible with version 1, and even less so with a different product.
>>
>> Gary
>>
>>
>> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>> Now that I see this it kind of scares me. Log4j 1.x and Logback both use appender-ref. Anyone using Log4j 2 will now be broken.
>>>
>>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>>
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml Wed Aug 14 20:05:54 2013
>>> > @@ -30,10 +30,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="org.apache.test" level="trace" additivity="false">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </logger>
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml Wed Aug 14 20:05:54 2013
>>> > @@ -25,7 +25,7 @@
>>> > <loggers>
>>> > <logger name="org.foo" level="DEBUG" />
>>> > <root level="TRACE">
>>> > - <appender-ref ref="Console" />
>>> > + <AppenderRef ref="Console" />
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml Wed Aug 14 20:05:54 2013
>>> > @@ -25,7 +25,7 @@
>>> > <loggers>
>>> > <logger name="org.foo" level="DEBUG" />
>>> > <root level="TRACE">
>>> > - <appender-ref ref="Console" />
>>> > + <AppenderRef ref="Console" />
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml Wed Aug 14 20:05:54 2013
>>> > @@ -25,7 +25,7 @@
>>> > <loggers>
>>> > <logger name="org.foo" level="DEBUG" />
>>> > <root level="TRACE">
>>> > - <appender-ref ref="Console" />
>>> > + <AppenderRef ref="Console" />
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml Wed Aug 14 20:05:54 2013
>>> > @@ -25,7 +25,7 @@
>>> > <loggers>
>>> > <logger name="org.foo" level="DEBUG" />
>>> > <root level="TRACE">
>>> > - <appender-ref ref="Console" />
>>> > + <AppenderRef ref="Console" />
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml Wed Aug 14 20:05:54 2013
>>> > @@ -25,7 +25,7 @@
>>> > <loggers>
>>> > <logger name="org.foo" level="DEBUG" />
>>> > <root level="TRACE">
>>> > - <appender-ref ref="Console" />
>>> > + <AppenderRef ref="Console" />
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml Wed Aug 14 20:05:54 2013
>>> > @@ -25,7 +25,7 @@
>>> > <loggers>
>>> > <logger name="org.foo" level="DEBUG" />
>>> > <root level="TRACE">
>>> > - <appender-ref ref="Console" />
>>> > + <AppenderRef ref="Console" />
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml Wed Aug 14 20:05:54 2013
>>> > @@ -27,7 +27,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml Wed Aug 14 20:05:54 2013
>>> > @@ -28,7 +28,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="LIST"/>
>>> > + <AppenderRef ref="LIST"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml Wed Aug 14 20:05:54 2013
>>> > @@ -30,7 +30,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="TestLogfile"/>
>>> > + <AppenderRef ref="TestLogfile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml Wed Aug 14 20:05:54 2013
>>> > @@ -26,7 +26,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="debug">
>>> > - <appender-ref ref="TestLogfile"/>
>>> > + <AppenderRef ref="TestLogfile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml Wed Aug 14 20:05:54 2013
>>> > @@ -26,7 +26,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="TestLogfile"/>
>>> > + <AppenderRef ref="TestLogfile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml Wed Aug 14 20:05:54 2013
>>> > @@ -28,7 +28,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="LIST"/>
>>> > + <AppenderRef ref="LIST"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml Wed Aug 14 20:05:54 2013
>>> > @@ -23,6 +23,6 @@
>>> > </appender>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="Console" />
>>> > + <AppenderRef ref="Console" />
>>> > </root>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml Wed Aug 14 20:05:54 2013
>>> > @@ -31,6 +31,6 @@
>>> > </appender>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="TestLogfile" />
>>> > + <AppenderRef ref="TestLogfile" />
>>> > </root>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml Wed Aug 14 20:05:54 2013
>>> > @@ -25,6 +25,6 @@
>>> > </appender>
>>> >
>>> > <root level="debug">
>>> > - <appender-ref ref="TestLogfile" />
>>> > + <AppenderRef ref="TestLogfile" />
>>> > </root>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml Wed Aug 14 20:05:54 2013
>>> > @@ -24,6 +24,6 @@
>>> > </appender>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="TestLogfile" />
>>> > + <AppenderRef ref="TestLogfile" />
>>> > </root>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml Wed Aug 14 20:05:54 2013
>>> > @@ -23,6 +23,6 @@
>>> > </appender>
>>> >
>>> > <root level="debug">
>>> > - <appender-ref ref="stdout" />
>>> > + <AppenderRef ref="stdout" />
>>> > </root>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml Wed Aug 14 20:05:54 2013
>>> > @@ -11,11 +11,11 @@
>>> > <loggers>
>>> > <!--
>>> > <root level="info" includeLocation="false">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </root>
>>> > -->
>>> > <logger name="sample" level="info" includeLocation="false">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </logger>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml Wed Aug 14 20:05:54 2013
>>> > @@ -34,11 +34,11 @@
>>> >
>>> > <loggers>
>>> > <logger name="org.apache.logging.log4j.core.appender.db" level="debug">
>>> > - <appender-ref ref="databaseAppender" />
>>> > + <AppenderRef ref="databaseAppender" />
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml Wed Aug 14 20:05:54 2013
>>> > @@ -34,11 +34,11 @@
>>> >
>>> > <loggers>
>>> > <logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
>>> > - <appender-ref ref="databaseAppender" />
>>> > + <AppenderRef ref="databaseAppender" />
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml Wed Aug 14 20:05:54 2013
>>> > @@ -35,11 +35,11 @@
>>> >
>>> > <loggers>
>>> > <logger name="org.apache.logging.log4j.core.appender.db" level="debug">
>>> > - <appender-ref ref="databaseAppender" />
>>> > + <AppenderRef ref="databaseAppender" />
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml Wed Aug 14 20:05:54 2013
>>> > @@ -34,11 +34,11 @@
>>> >
>>> > <loggers>
>>> > <logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
>>> > - <appender-ref ref="databaseAppender" />
>>> > + <AppenderRef ref="databaseAppender" />
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml Wed Aug 14 20:05:54 2013
>>> > @@ -35,11 +35,11 @@
>>> >
>>> > <loggers>
>>> > <logger name="org.apache.logging.log4j.core.appender.db" level="debug">
>>> > - <appender-ref ref="databaseAppender" />
>>> > + <AppenderRef ref="databaseAppender" />
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml Wed Aug 14 20:05:54 2013
>>> > @@ -27,11 +27,11 @@
>>> >
>>> > <loggers>
>>> > <logger name="org.apache.logging.log4j.core.appender.db" level="debug">
>>> > - <appender-ref ref="databaseAppender" />
>>> > + <AppenderRef ref="databaseAppender" />
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml Wed Aug 14 20:05:54 2013
>>> > @@ -27,11 +27,11 @@
>>> >
>>> > <loggers>
>>> > <logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
>>> > - <appender-ref ref="databaseAppender" />
>>> > + <AppenderRef ref="databaseAppender" />
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml Wed Aug 14 20:05:54 2013
>>> > @@ -27,11 +27,11 @@
>>> >
>>> > <loggers>
>>> > <logger name="org.apache.logging.log4j.core.appender.db" level="debug">
>>> > - <appender-ref ref="databaseAppender" />
>>> > + <AppenderRef ref="databaseAppender" />
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml Wed Aug 14 20:05:54 2013
>>> > @@ -27,11 +27,11 @@
>>> >
>>> > <loggers>
>>> > <logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
>>> > - <appender-ref ref="databaseAppender" />
>>> > + <AppenderRef ref="databaseAppender" />
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml Wed Aug 14 20:05:54 2013
>>> > @@ -11,10 +11,10 @@
>>> > </appender>
>>> > <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
>>> > <param name="BufferSize" value="262144"/>
>>> > - <appender-ref ref="File"/>
>>> > + <AppenderRef ref="File"/>
>>> > </appender>
>>> > <root>
>>> > <priority value="debug" />
>>> > - <appender-ref ref="ASYNC" />
>>> > + <AppenderRef ref="ASYNC" />
>>> > </root>
>>> > </log4j:configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml Wed Aug 14 20:05:54 2013
>>> > @@ -11,6 +11,6 @@
>>> > </appender>
>>> > <root>
>>> > <priority value="debug" />
>>> > - <appender-ref ref="File" />
>>> > + <AppenderRef ref="File" />
>>> > </root>
>>> > </log4j:configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml Wed Aug 14 20:05:54 2013
>>> > @@ -12,10 +12,10 @@
>>> > <queueSize>262144</queueSize>
>>> > <discardingThreshold>0</discardingThreshold>
>>> > <includeCallerData>false</includeCallerData>
>>> > - <appender-ref ref="FILE" />
>>> > + <AppenderRef ref="FILE" />
>>> > </appender>
>>> >
>>> > <root level="debug">
>>> > - <appender-ref ref="ASYNC" />
>>> > + <AppenderRef ref="ASYNC" />
>>> > </root>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml Wed Aug 14 20:05:54 2013
>>> > @@ -10,6 +10,6 @@
>>> > </appender>
>>> >
>>> > <root level="debug">
>>> > - <appender-ref ref="FILE" />
>>> > + <AppenderRef ref="FILE" />
>>> > </root>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml Wed Aug 14 20:05:54 2013
>>> > @@ -9,7 +9,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="info" includeLocation="false">
>>> > - <appender-ref ref="RandomAccessFile"/>
>>> > + <AppenderRef ref="RandomAccessFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml Wed Aug 14 20:05:54 2013
>>> > @@ -9,7 +9,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="info" includeLocation="false">
>>> > - <appender-ref ref="File"/>
>>> > + <AppenderRef ref="File"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml Wed Aug 14 20:05:54 2013
>>> > @@ -14,7 +14,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="info" includeLocation="false">
>>> > - <appender-ref ref="RollingRandomAccessFile"/>
>>> > + <AppenderRef ref="RollingRandomAccessFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml Wed Aug 14 20:05:54 2013
>>> > @@ -14,7 +14,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="info" includeLocation="false">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml Wed Aug 14 20:05:54 2013
>>> > @@ -9,7 +9,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="info" includeLocation="false">
>>> > - <appender-ref ref="RandomAccessFile"/>
>>> > + <AppenderRef ref="RandomAccessFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml Wed Aug 14 20:05:54 2013
>>> > @@ -9,7 +9,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="info" includeLocation="true">
>>> > - <appender-ref ref="RandomAccessFile"/>
>>> > + <AppenderRef ref="RandomAccessFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml Wed Aug 14 20:05:54 2013
>>> > @@ -7,12 +7,12 @@
>>> > </PatternLayout>
>>> > </RandomAccessFile>
>>> > <Async name="Async" blocking="true" bufferSize="262144">
>>> > - <appender-ref ref="RandomAccessFile"/>
>>> > + <AppenderRef ref="RandomAccessFile"/>
>>> > </Async>
>>> > </appenders>
>>> > <loggers>
>>> > <root level="info" includeLocation="false">
>>> > - <appender-ref ref="Async"/>
>>> > + <AppenderRef ref="Async"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml Wed Aug 14 20:05:54 2013
>>> > @@ -7,12 +7,12 @@
>>> > </PatternLayout>
>>> > </RandomAccessFile>
>>> > <Async name="Async" includeLocation="true" blocking="true" bufferSize="262144">
>>> > - <appender-ref ref="RandomAccessFile"/>
>>> > + <AppenderRef ref="RandomAccessFile"/>
>>> > </Async>
>>> > </appenders>
>>> > <loggers>
>>> > <root level="info" includeLocation="true">
>>> > - <appender-ref ref="Async"/>
>>> > + <AppenderRef ref="Async"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml Wed Aug 14 20:05:54 2013
>>> > @@ -9,7 +9,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <asyncRoot level="info" includeLocation="false">
>>> > - <appender-ref ref="RandomAccessFile"/>
>>> > + <AppenderRef ref="RandomAccessFile"/>
>>> > </asyncRoot>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml Wed Aug 14 20:05:54 2013
>>> > @@ -9,7 +9,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <asyncRoot level="info" includeLocation="true">
>>> > - <appender-ref ref="RandomAccessFile"/>
>>> > + <AppenderRef ref="RandomAccessFile"/>
>>> > </asyncRoot>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml Wed Aug 14 20:05:54 2013
>>> > @@ -10,10 +10,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="EventLogger" level="info">
>>> > - <appender-ref ref="events"/>
>>> > + <AppenderRef ref="events"/>
>>> > </logger>
>>> > <root level="warn">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml Wed Aug 14 20:05:54 2013
>>> > @@ -12,10 +12,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="EventLogger" level="info" additivity="false">
>>> > - <appender-ref ref="eventLogger"/>
>>> > + <AppenderRef ref="eventLogger"/>
>>> > </logger>
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml Wed Aug 14 20:05:54 2013
>>> > @@ -32,10 +32,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="EventLogger" level="info" additivity="false">
>>> > - <appender-ref ref="eventLogger"/>
>>> > + <AppenderRef ref="eventLogger"/>
>>> > </logger>
>>> > <root level="warn">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml Wed Aug 14 20:05:54 2013
>>> > @@ -15,10 +15,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="EventLogger" level="info" additivity="false">
>>> > - <appender-ref ref="eventLogger"/>
>>> > + <AppenderRef ref="eventLogger"/>
>>> > </logger>
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml Wed Aug 14 20:05:54 2013
>>> > @@ -24,15 +24,15 @@
>>> >
>>> > <loggers>
>>> > <logger name="EventLogger" level="info" additivity="false">
>>> > - <appender-ref ref="EventLogger"/>
>>> > + <AppenderRef ref="EventLogger"/>
>>> > </logger>>
>>> >
>>> > <logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
>>> > - <appender-ref ref="File"/>
>>> > + <AppenderRef ref="File"/>
>>> > </logger>>
>>> >
>>> > <root level="trace">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java (original)
>>> > +++ logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java Wed Aug 14 20:05:54 2013
>>> > @@ -24,22 +24,23 @@ import static org.junit.Assert.assertTru
>>> > import java.util.Date;
>>> > import java.util.List;
>>> >
>>> > -import ch.qos.logback.classic.joran.JoranConfigurator;
>>> > -import ch.qos.logback.classic.spi.ILoggingEvent;
>>> > -import ch.qos.logback.core.joran.spi.JoranException;
>>> > import org.apache.logging.log4j.LogManager;
>>> > import org.apache.logging.log4j.Logger;
>>> > import org.apache.logging.log4j.ThreadContext;
>>> > import org.apache.logging.log4j.message.MessageFactory;
>>> > import org.apache.logging.log4j.message.ParameterizedMessageFactory;
>>> > import org.apache.logging.log4j.message.StringFormatterMessageFactory;
>>> > -import ch.qos.logback.core.testUtil.StringListAppender;
>>> > -import ch.qos.logback.classic.LoggerContext;
>>> > import org.junit.Before;
>>> > import org.junit.BeforeClass;
>>> > import org.junit.Test;
>>> > import org.slf4j.LoggerFactory;
>>> >
>>> > +import ch.qos.logback.classic.LoggerContext;
>>> > +import ch.qos.logback.classic.joran.JoranConfigurator;
>>> > +import ch.qos.logback.classic.spi.ILoggingEvent;
>>> > +import ch.qos.logback.core.joran.spi.JoranException;
>>> > +import ch.qos.logback.core.testUtil.StringListAppender;
>>> > +
>>> > /**
>>> > *
>>> > */
>>> > @@ -74,6 +75,8 @@ public class LoggerTest {
>>> >
>>> > @Before
>>> > public void before() {
>>> > + assertNotNull(list);
>>> > + assertNotNull(list.strList);
>>> > list.strList.clear();
>>> > }
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml Wed Aug 14 20:05:54 2013
>>> > @@ -27,13 +27,13 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="org.apache.test.logging" level="debug" additivity="false">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </logger>
>>> > <logger name="org.apache.test" level="trace" additivity="false">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </logger>
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> > \ No newline at end of file
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml Wed Aug 14 20:05:54 2013
>>> > @@ -40,10 +40,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="EventLogger" level="WARN" additivity="false">
>>> > - <appender-ref ref="flume" />
>>> > + <AppenderRef ref="flume" />
>>> > </logger>
>>> > <root level="debug">
>>> > - <appender-ref ref="RollingFile" />
>>> > + <AppenderRef ref="RollingFile" />
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml Wed Aug 14 20:05:54 2013
>>> > @@ -40,10 +40,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="EventLogger" level="WARN" additivity="false">
>>> > - <appender-ref ref="flume" />
>>> > + <AppenderRef ref="flume" />
>>> > </logger>
>>> > <root level="debug">
>>> > - <appender-ref ref="RollingFile" />
>>> > + <AppenderRef ref="RollingFile" />
>>> > </root>
>>> > </loggers>
>>> > </configuration>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml Wed Aug 14 20:05:54 2013
>>> > @@ -25,15 +25,15 @@
>>> >
>>> > <loggers>
>>> > <logger name="EventLogger" level="info" additivity="false">
>>> > - <appender-ref ref="EventLogger"/>
>>> > + <AppenderRef ref="EventLogger"/>
>>> > </logger>>
>>> >
>>> > <logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
>>> > - <appender-ref ref="File"/>
>>> > + <AppenderRef ref="File"/>
>>> > </logger>>
>>> >
>>> > <root level="trace">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/src/changes/changes.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/changes/changes.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/src/changes/changes.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/src/changes/changes.xml Wed Aug 14 20:05:54 2013
>>> > @@ -432,7 +432,7 @@
>>> > The blocking parameter did not work properly on AsynchAppender.
>>> > </action>
>>> > <action issue="LOG4J2-188" dev="rgoers" type="fix" due-to="Werner">
>>> > - appender-refs on AsynchAppender didn't support the level and filter elements.
>>> > + AppenderRefs on AsynchAppender didn't support the level and filter elements.
>>> > </action>
>>> > <action issue="LOG4J2-176" dev="rgoers" type="fix" due-to="Remko Popma">
>>> > Avoid IllegalArgumentException in AsynchAppender.
>>> > @@ -797,7 +797,7 @@
>>> > </release>
>>> > <release version="2.0-alpha1" date="2012-07-29" description="Rewrite of Log4j">
>>> > <action issue="LOG4J2-60" dev="rgoers" type="add" due-to="Shane Kelly">
>>> > - Added ability to filter on the appender-ref by adding either a level or a filter.
>>> > + Added ability to filter on the AppenderRef by adding either a level or a filter.
>>> > </action>
>>> > <action issue="LOG4J2-56" dev="rgoers" type="fix" due-to="John Owen Atala">
>>> > Level.toLevel would throw an IllegalArgumentException instead of returning the default value.
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml Wed Aug 14 20:05:54 2013
>>> > @@ -59,9 +59,9 @@
>>> > <th>Description</th>
>>> > </tr>
>>> > <tr>
>>> > - <td>appender-ref</td>
>>> > + <td>AppenderRef</td>
>>> > <td>String</td>
>>> > - <td>The name of the Appenders to invoke asynchronously. Multiple appender-ref
>>> > + <td>The name of the Appenders to invoke asynchronously. Multiple AppenderRef
>>> > elements can be configured.</td>
>>> > </tr>
>>> > <tr>
>>> > @@ -122,12 +122,12 @@
>>> > </PatternLayout>
>>> > </File>
>>> > <Async name="Async">
>>> > - <appender-ref ref="MyFile"/>
>>> > + <AppenderRef ref="MyFile"/>
>>> > </Async>
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="Async"/>
>>> > + <AppenderRef ref="Async"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -196,7 +196,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -271,13 +271,13 @@
>>> > </Console>
>>> > <Failover name="Failover" primary="RollingFile">
>>> > <Failovers>
>>> > - <appender-ref ref="Console"/>
>>> > + <AppenderRef ref="Console"/>
>>> > </Failovers>
>>> > </Failover>
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="Failover"/>
>>> > + <AppenderRef ref="Failover"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -387,7 +387,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="MyFile"/>
>>> > + <AppenderRef ref="MyFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -588,7 +588,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingRandomAccessFile"/>
>>> > + <AppenderRef ref="RollingRandomAccessFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -613,7 +613,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingRandomAccessFile"/>
>>> > + <AppenderRef ref="RollingRandomAccessFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -647,7 +647,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingRandomAccessFile"/>
>>> > + <AppenderRef ref="RollingRandomAccessFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -749,7 +749,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="MyFile"/>
>>> > + <AppenderRef ref="MyFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -927,7 +927,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="eventLogger"/>
>>> > + <AppenderRef ref="eventLogger"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -948,7 +948,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="eventLogger"/>
>>> > + <AppenderRef ref="eventLogger"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -972,10 +972,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="EventLogger" level="info">
>>> > - <appender-ref ref="eventLogger"/>
>>> > + <AppenderRef ref="eventLogger"/>
>>> > </logger>
>>> > <root level="warn">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1016,10 +1016,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="EventLogger" level="info">
>>> > - <appender-ref ref="eventLogger"/>
>>> > + <AppenderRef ref="eventLogger"/>
>>> > </logger>
>>> > <root level="warn">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1216,7 +1216,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="warn">
>>> > - <appender-ref ref="databaseAppender"/>
>>> > + <AppenderRef ref="databaseAppender"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1235,7 +1235,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="warn">
>>> > - <appender-ref ref="databaseAppender"/>
>>> > + <AppenderRef ref="databaseAppender"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1255,7 +1255,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="warn">
>>> > - <appender-ref ref="databaseAppender"/>
>>> > + <AppenderRef ref="databaseAppender"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1365,7 +1365,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="jmsQueue"/>
>>> > + <AppenderRef ref="jmsQueue"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1476,7 +1476,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="jmsQueue"/>
>>> > + <AppenderRef ref="jmsQueue"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1552,7 +1552,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="warn">
>>> > - <appender-ref ref="databaseAppender"/>
>>> > + <AppenderRef ref="databaseAppender"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1806,7 +1806,7 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <root level="warn">
>>> > - <appender-ref ref="databaseAppender"/>
>>> > + <AppenderRef ref="databaseAppender"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1821,7 +1821,7 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <root level="warn">
>>> > - <appender-ref ref="databaseAppender"/>
>>> > + <AppenderRef ref="databaseAppender"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1836,7 +1836,7 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <root level="warn">
>>> > - <appender-ref ref="databaseAppender"/>
>>> > + <AppenderRef ref="databaseAppender"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -1919,9 +1919,9 @@ public class JpaLogEntity extends Abstra
>>> > <th>Description</th>
>>> > </tr>
>>> > <tr>
>>> > - <td>appender-ref</td>
>>> > + <td>AppenderRef</td>
>>> > <td>String</td>
>>> > - <td>The name of the Appenders to call after the LogEvent has been manipulated. Multiple appender-ref
>>> > + <td>The name of the Appenders to call after the LogEvent has been manipulated. Multiple AppenderRef
>>> > elements can be configured.</td>
>>> > </tr>
>>> > <tr>
>>> > @@ -1989,7 +1989,7 @@ public class JpaLogEntity extends Abstra
>>> > <PatternLayout pattern="%m%n"/>
>>> > </Console>
>>> > <Rewrite name="rewrite">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > <MapRewritePolicy mode="Add">
>>> > <KeyValuePair key="product" value="TestProduct"/>
>>> > </MapRewritePolicy>
>>> > @@ -1997,7 +1997,7 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="Rewrite"/>
>>> > + <AppenderRef ref="Rewrite"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -2032,7 +2032,7 @@ public class JpaLogEntity extends Abstra
>>> > <PatternLayout pattern="%m%n"/>
>>> > </Console>
>>> > <Rewrite name="rewrite">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > <PropertiesRewritePolicy>
>>> > <Property key="user">${sys:user.name}</Property>
>>> > <Property key="env">${sys:environment}</Property>
>>> > @@ -2041,7 +2041,7 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="Rewrite"/>
>>> > + <AppenderRef ref="Rewrite"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -2357,7 +2357,7 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -2381,7 +2381,7 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -2408,7 +2408,7 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -2468,7 +2468,7 @@ public class JpaLogEntity extends Abstra
>>> > can be configured as the default.
>>> > </p>
>>> > <p>
>>> > - Each Route must reference an Appender. If the Route contains an appender-ref attribute then the
>>> > + Each Route must reference an Appender. If the Route contains an AppenderRef attribute then the
>>> > Route will reference an Appender that was defined in the configuration. If the Route contains an
>>> > Appender definition then an Appender will be created within the context of the RoutingAppender and
>>> > will be reused each time a matching Appender name is referenced through a Route.
>>> > @@ -2498,13 +2498,13 @@ public class JpaLogEntity extends Abstra
>>> > <SizeBasedTriggeringPolicy size="500" />
>>> > </RollingFile>
>>> > </Route>
>>> > - <Route appender-ref="AuditLogger" key="Audit"/>
>>> > + <Route AppenderRef="AuditLogger" key="Audit"/>
>>> > </Routes>
>>> > </Routing>
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="Routing"/>
>>> > + <AppenderRef ref="Routing"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -2631,7 +2631,7 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="Mail"/>
>>> > + <AppenderRef ref="Mail"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -2722,7 +2722,7 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="socket"/>
>>> > + <AppenderRef ref="socket"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -2904,10 +2904,10 @@ public class JpaLogEntity extends Abstra
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="com.mycorp" level="error">
>>> > - <appender-ref ref="RFC5424"/>
>>> > + <AppenderRef ref="RFC5424"/>
>>> > </logger>
>>> > <root level="error">
>>> > - <appender-ref ref="bsd"/>
>>> > + <AppenderRef ref="bsd"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml Wed Aug 14 20:05:54 2013
>>> > @@ -162,7 +162,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="info" includeLocation="false">
>>> > - <appender-ref ref="RandomAccessFile"/>
>>> > + <AppenderRef ref="RandomAccessFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -360,10 +360,10 @@
>>> > <loggers>
>>> > <!-- pattern layout actually uses location, so we need to include it -->
>>> > <asyncLogger name="com.foo.Bar" level="trace" includeLocation="true">
>>> > - <appender-ref ref="RandomAccessFile"/>
>>> > + <AppenderRef ref="RandomAccessFile"/>
>>> > </asyncLogger>
>>> > <root level="info" includeLocation="true">
>>> > - <appender-ref ref="RandomAccessFile"/>
>>> > + <AppenderRef ref="RandomAccessFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm (original)
>>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm Wed Aug 14 20:05:54 2013
>>> > @@ -161,7 +161,7 @@ public class Bar {
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="Console"/>
>>> > + <AppenderRef ref="Console"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -186,7 +186,7 @@ public class Bar {
>>> > <pre class="prettyprint linenums"><![CDATA[
>>> > <logger name="com.foo.Bar" level="TRACE"/>
>>> > <root level="ERROR">
>>> > - <appender-ref ref="STDOUT">
>>> > + <AppenderRef ref="STDOUT">
>>> > </root>]]></pre>
>>> > <p>
>>> > With this configuration all log events from <code>com.foo.Bar</code> will be recorded while only error events will
>>> > @@ -210,10 +210,10 @@ public class Bar {
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="com.foo.Bar" level="trace">
>>> > - <appender-ref ref="Console"/>
>>> > + <AppenderRef ref="Console"/>
>>> > </logger>
>>> > <root level="error">
>>> > - <appender-ref ref="Console"/>
>>> > + <AppenderRef ref="Console"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -242,10 +242,10 @@ public class Bar {
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="com.foo.Bar" level="trace" additivity="false">
>>> > - <appender-ref ref="Console"/>
>>> > + <AppenderRef ref="Console"/>
>>> > </logger>
>>> > <root level="error">
>>> > - <appender-ref ref="Console"/>
>>> > + <AppenderRef ref="Console"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -408,7 +408,7 @@ public class Bar {
>>> > </logger>
>>> > ...
>>> > <root level="level">
>>> > - <appender-ref ref="name"/>
>>> > + <AppenderRef ref="name"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -443,7 +443,7 @@ public class Bar {
>>> > </logger>
>>> > ...
>>> > <root level="level">
>>> > - <appender-ref ref="name"/>
>>> > + <AppenderRef ref="name"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -488,15 +488,15 @@ public class Bar {
>>> > <filter type="ThreadContextMapFilter">
>>> > <KeyValuePair key="test" value="123"/>
>>> > </filter>
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </logger>>
>>> >
>>> > <logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
>>> > - <appender-ref ref="File"/>
>>> > + <AppenderRef ref="File"/>
>>> > </logger>>
>>> >
>>> > <root level="trace">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> > @@ -537,16 +537,16 @@ public class Bar {
>>> > "SizeBasedTriggeringPolicy": { "size": "500" }
>>> > }
>>> > },
>>> > - { "appender-ref": "STDOUT", "key": "Audit"},
>>> > - { "appender-ref": "List", "key": "Service"}
>>> > + { "AppenderRef": "STDOUT", "key": "Audit"},
>>> > + { "AppenderRef": "List", "key": "Service"}
>>> > ]
>>> > }
>>> > }
>>> > },
>>> > "loggers": {
>>> > "logger": { "name": "EventLogger", "level": "info", "additivity": "false",
>>> > - "appender-ref": { "ref": "Routing" }},
>>> > - "root": { "level": "error", "appender-ref": { "ref": "STDOUT" }}
>>> > + "AppenderRef": { "ref": "Routing" }},
>>> > + "root": { "level": "error", "AppenderRef": { "ref": "STDOUT" }}
>>> > }
>>> > }
>>> > }</pre>
>>> > @@ -580,8 +580,8 @@ public class Bar {
>>> > "SizeBasedTriggeringPolicy": { "size": "500" }
>>> > }
>>> > },
>>> > - { "appender-ref": "STDOUT", "key": "Audit"},
>>> > - { "appender-ref": "List", "key": "Service"}
>>> > + { "AppenderRef": "STDOUT", "key": "Audit"},
>>> > + { "AppenderRef": "List", "key": "Service"}
>>> > ]
>>> > }
>>> > }
>>> > @@ -590,11 +590,11 @@ public class Bar {
>>> > "loggers": {
>>> > "logger": [
>>> > { "name": "EventLogger", "level": "info", "additivity": "false",
>>> > - "appender-ref": { "ref": "Routing" }},
>>> > + "AppenderRef": { "ref": "Routing" }},
>>> > { "name": "com.foo.bar", "level": "error", "additivity": "false",
>>> > - "appender-ref": { "ref": "Console" }}
>>> > + "AppenderRef": { "ref": "Console" }}
>>> > ],
>>> > - "root": { "level": "error", "appender-ref": { "ref": "STDOUT" }}
>>> > + "root": { "level": "error", "AppenderRef": { "ref": "STDOUT" }}
>>> > }
>>> > }
>>> > }</pre>
>>> > @@ -638,7 +638,7 @@ public class Bar {
>>> > using variables.
>>> > </p>
>>> > <p>
>>> > - The LoggerConfig may also be configured with one or more appender-ref elements. Each appender
>>> > + The LoggerConfig may also be configured with one or more AppenderRef elements. Each appender
>>> > referenced will become associated with the specified LoggerConfig. If multiple appenders
>>> > are configured on the LoggerConfig each of them be called when processing logging events.
>>> > </p>
>>> > @@ -718,21 +718,21 @@ public class Bar {
>>> > <ThreadContextMapFilter>
>>> > <KeyValuePair key="test" value="123"/>
>>> > </ThreadContextMapFilter>
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </logger>>
>>> >
>>> > <logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
>>> > <property name="user">${dollar}{sys:user.name}</property>
>>> > - <appender-ref ref="File">
>>> > + <AppenderRef ref="File">
>>> > <ThreadContextMapFilter>
>>> > <KeyValuePair key="test" value="123"/>
>>> > </ThreadContextMapFilter>
>>> > - </appender-ref>
>>> > - <appender-ref ref="STDOUT" level="error"/>
>>> > + </AppenderRef>
>>> > + <AppenderRef ref="STDOUT" level="error"/>
>>> > </logger>>
>>> >
>>> > <root level="trace">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> > @@ -776,19 +776,19 @@ public class Bar {
>>> > <SizeBasedTriggeringPolicy size="500" />
>>> > </RollingFile>
>>> > </Route>
>>> > - <Route appender-ref="STDOUT" key="Audit"/>
>>> > - <Route appender-ref="List" key="Service"/>
>>> > + <Route AppenderRef="STDOUT" key="Audit"/>
>>> > + <Route AppenderRef="List" key="Service"/>
>>> > </Routes>
>>> > </Routing>
>>> > </appenders>
>>> >
>>> > <loggers>
>>> > <logger name="EventLogger" level="info" additivity="false">
>>> > - <appender-ref ref="Routing"/>
>>> > + <AppenderRef ref="Routing"/>
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> > @@ -916,19 +916,19 @@ public class Bar {
>>> > <SizeBasedTriggeringPolicy size="500" />
>>> > </RollingFile>
>>> > </Route>
>>> > - <Route appender-ref="STDOUT" key="Audit"/>
>>> > - <Route appender-ref="List" key="Service"/>
>>> > + <Route AppenderRef="STDOUT" key="Audit"/>
>>> > + <Route AppenderRef="List" key="Service"/>
>>> > </Routes>
>>> > </Routing>
>>> > </appenders>
>>> >
>>> > <loggers>
>>> > <logger name="EventLogger" level="info" additivity="false">
>>> > - <appender-ref ref="Routing"/>
>>> > + <AppenderRef ref="Routing"/>
>>> > </logger>
>>> >
>>> > <root level="error">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> >
>>> > @@ -961,11 +961,11 @@ public class Bar {
>>> > appender.ListAppender for element List with params(name="List", entryPerNewLine="null",
>>> > raw="null", null, ThresholdFilter(DEBUG))
>>> > 2011-11-23 17:08:00,813 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.
>>> > - routing.Route for element Route with params(appender-ref="null", key="null", Node=Route)
>>> > + routing.Route for element Route with params(AppenderRef="null", key="null", Node=Route)
>>> > 2011-11-23 17:08:00,823 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.
>>> > - routing.Route for element Route with params(appender-ref="STDOUT", key="Audit", Node=Route)
>>> > + routing.Route for element Route with params(AppenderRef="STDOUT", key="Audit", Node=Route)
>>> > 2011-11-23 17:08:00,824 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.
>>> > - routing.Route for element Route with params(appender-ref="List", key="Service", Node=Route)
>>> > + routing.Route for element Route with params(AppenderRef="List", key="Service", Node=Route)
>>> > 2011-11-23 17:08:00,825 DEBUG Calling createRoutes on class org.apache.logging.log4j.core.appender.
>>> > routing.Routes for element Routes with params(pattern="${dollar}{sd:type}",
>>> > routes={Route(type=dynamic default), Route(type=static Reference=STDOUT key='Audit'),
>>> > @@ -978,16 +978,16 @@ public class Bar {
>>> > 2011-11-23 17:08:00,827 DEBUG Calling createAppenders on class org.apache.logging.log4j.core.config.
>>> > plugins.AppendersPlugin for element appenders with params(appenders={STDOUT, List, Routing})
>>> > 2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.
>>> > - config.plugins.AppenderRefPlugin for element appender-ref with params(ref="Routing")
>>> > + config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="Routing")
>>> > 2011-11-23 17:08:00,829 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.
>>> > LoggerConfig for element logger with params(additivity="false", level="info", name="EventLogger",
>>> > - appender-ref={Routing}, null)
>>> > + AppenderRef={Routing}, null)
>>> > 2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.
>>> > - config.plugins.AppenderRefPlugin for element appender-ref with params(ref="STDOUT")</pre>
>>> > + config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="STDOUT")</pre>
>>> > <pre class="prettyprint linenums">
>>> > 2011-11-23 17:08:00,831 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.
>>> > LoggerConfig$RootLogger for element root with params(additivity="null", level="error",
>>> > - appender-ref={STDOUT}, null)
>>> > + AppenderRef={STDOUT}, null)
>>> > 2011-11-23 17:08:00,833 DEBUG Calling createLoggers on class org.apache.logging.log4j.core.
>>> > config.plugins.LoggersPlugin for element loggers with params(loggers={EventLogger, root})
>>> > 2011-11-23 17:08:00,834 DEBUG Reconfiguration completed
>>> > @@ -1024,16 +1024,16 @@ public class Bar {
>>> > 2011-11-23 17:08:00,804 DEBUG Calling createAppender on class org.apache.logging.log4j.core.appender.ConsoleAppender for element Console with params(PatternLayout(%m%n), null, target="null", name="STDOUT", ignoreExceptions="null")
>>> > 2011-11-23 17:08:00,804 DEBUG Calling createFilter on class org.apache.logging.log4j.core.filter.ThresholdFilter for element ThresholdFilter with params(level="debug", onMatch="null", onMismatch="null")
>>> > 2011-11-23 17:08:00,806 DEBUG Calling createAppender on class org.apache.logging.log4j.test.appender.ListAppender for element List with params(name="List", entryPerNewLine="null", raw="null", null, ThresholdFilter(DEBUG))
>>> > -2011-11-23 17:08:00,813 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(appender-ref="null", key="null", Node=Route)
>>> > -2011-11-23 17:08:00,823 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(appender-ref="STDOUT", key="Audit", Node=Route)
>>> > -2011-11-23 17:08:00,824 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(appender-ref="List", key="Service", Node=Route)
>>> > +2011-11-23 17:08:00,813 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(AppenderRef="null", key="null", Node=Route)
>>> > +2011-11-23 17:08:00,823 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(AppenderRef="STDOUT", key="Audit", Node=Route)
>>> > +2011-11-23 17:08:00,824 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(AppenderRef="List", key="Service", Node=Route)
>>> > 2011-11-23 17:08:00,825 DEBUG Calling createRoutes on class org.apache.logging.log4j.core.appender.routing.Routes for element Routes with params(pattern="${dollar}{sd:type}", routes={Route(type=dynamic default), Route(type=static Reference=STDOUT key='Audit'), Route(type=static Reference=List key='Service')})
>>> > 2011-11-23 17:08:00,827 DEBUG Calling createAppender on class org.apache.logging.log4j.core.appender.routing.RoutingAppender for element Routing with params(name="Routing", ignoreExceptions="null", Routes({Route(type=dynamic default),Route(type=static Reference=STDOUT key='Audit'),Route(type=static Reference=List key='Service')}), Configuration(RoutingTest), null, null)
>>> > 2011-11-23 17:08:00,827 DEBUG Calling createAppenders on class org.apache.logging.log4j.core.config.plugins.AppendersPlugin for element appenders with params(appenders={STDOUT, List, Routing})
>>> > -2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element appender-ref with params(ref="Routing")
>>> > -2011-11-23 17:08:00,829 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig for element logger with params(additivity="false", level="info", name="EventLogger", appender-ref={Routing}, null)
>>> > -2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element appender-ref with params(ref="STDOUT")
>>> > -2011-11-23 17:08:00,831 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element root with params(additivity="null", level="error", appender-ref={STDOUT}, null)
>>> > +2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="Routing")
>>> > +2011-11-23 17:08:00,829 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig for element logger with params(additivity="false", level="info", name="EventLogger", AppenderRef={Routing}, null)
>>> > +2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="STDOUT")
>>> > +2011-11-23 17:08:00,831 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element root with params(additivity="null", level="error", AppenderRef={STDOUT}, null)
>>> > 2011-11-23 17:08:00,833 DEBUG Calling createLoggers on class org.apache.logging.log4j.core.config.plugins.LoggersPlugin for element loggers with params(loggers={EventLogger, root})
>>> > 2011-11-23 17:08:00,834 DEBUG Reconfiguration completed
>>> > 2011-11-23 17:08:00,846 DEBUG Calling createLayout on class org.apache.logging.log4j.core.layout.PatternLayout for element PatternLayout with params(pattern="%d %p %c{1.} [%t] %m%n", Configuration(RoutingTest), null, charset="null")
>>> > @@ -1053,7 +1053,7 @@ public class Bar {
>>> > makes troubleshooting configuration errors possible. As an example, if the configuration above is changed
>>> > to have the status set to error and the logger declaration is:</p>
>>> > <pre class="prettyprint linenums"><![CDATA[<logger name="EventLogger" level="info" additivity="false">
>>> > - <appender-ref ref="Routng"/>
>>> > + <AppenderRef ref="Routng"/>
>>> > </logger>]]></pre>
>>> > <p>
>>> > the following error message will be produced.
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml Wed Aug 14 20:05:54 2013
>>> > @@ -143,7 +143,7 @@ public static class RootLogger extends L
>>> > @PluginFactory
>>> > public static LoggerConfig createLogger(@PluginAttr("additivity") String additivity,
>>> > @PluginAttr("level") String loggerLevel,
>>> > - @PluginElement("appender-ref") AppenderRef[] refs,
>>> > + @PluginElement("AppenderRef") AppenderRef[] refs,
>>> > @PluginElement("filters") Filter filter) {
>>> > List<AppenderRef> appenderRefs = Arrays.asList(refs);
>>> > Level level;
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml Wed Aug 14 20:05:54 2013
>>> > @@ -109,7 +109,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -151,10 +151,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="EventLogger" level="info">
>>> > - <appender-ref ref="Audit"/>
>>> > + <AppenderRef ref="Audit"/>
>>> > </logger>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -220,7 +220,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -284,7 +284,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -311,8 +311,8 @@
>>> > <KeyValuePair key="eventId" value="Login"/>
>>> > <KeyValuePair key="eventId" value="Logout"/>
>>> > </MapFilter>
>>> > - <appender-ref ref="RollingFile">
>>> > - </appender-ref>
>>> > + <AppenderRef ref="RollingFile">
>>> > + </AppenderRef>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -335,12 +335,12 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile">
>>> > + <AppenderRef ref="RollingFile">
>>> > <MapFilter onMatch="ACCEPT" onMismatch="NEUTRAL" operator="or">
>>> > <KeyValuePair key="eventId" value="Login"/>
>>> > <KeyValuePair key="eventId" value="Logout"/>
>>> > </MapFilter>
>>> > - </appender-ref>
>>> > + </AppenderRef>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -396,7 +396,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -456,7 +456,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -523,7 +523,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -587,7 +587,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -608,7 +608,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > <ThreadContextMapFilter onMatch="ACCEPT" onMismatch="NEUTRAL" operator="or">
>>> > <KeyValuePair key="foo" value="bar"/>
>>> > <KeyValuePair key="User2" value="WARN"/>
>>> > @@ -670,7 +670,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -740,7 +740,7 @@
>>> > </appenders>
>>> > <loggers>
>>> > <root level="error">
>>> > - <appender-ref ref="RollingFile"/>
>>> > + <AppenderRef ref="RollingFile"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml Wed Aug 14 20:05:54 2013
>>> > @@ -154,7 +154,7 @@ public class App {
>>> > </appenders>
>>> > <loggers>
>>> > <root level="trace">
>>> > - <appender-ref ref="log"/>
>>> > + <AppenderRef ref="log"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml Wed Aug 14 20:05:54 2013
>>> > @@ -81,7 +81,7 @@
>>> > </category>
>>> > <root>
>>> > <priority value ="debug" />
>>> > - <appender-ref ref="STDOUT" />
>>> > + <AppenderRef ref="STDOUT" />
>>> > </root>
>>> > </log4j:configuration>]]></pre>
>>> > <p>Log4j 2 XML configuration</p>
>>> > @@ -95,7 +95,7 @@
>>> > <loggers>
>>> > <logger name="org.apache.log4j.xml" level="info"/>
>>> > <root level="debug">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -119,11 +119,11 @@
>>> > </appender>
>>> > <category name="org.apache.log4j.xml">
>>> > <priority value="debug" />
>>> > - <appender-ref ref="A1" />
>>> > + <AppenderRef ref="A1" />
>>> > </category>
>>> > <root>
>>> > <priority value ="debug" />
>>> > - <appender-ref ref="STDOUT" />
>>> > + <AppenderRef ref="STDOUT" />
>>> > </root>
>>> > </log4j:configuration>]]></pre>
>>> >
>>> > @@ -140,10 +140,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="org.apache.log4j.xml" level="debug">
>>> > - <appender-ref ref="A1"/>
>>> > + <AppenderRef ref="A1"/>
>>> > </logger>
>>> > <root level="debug">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -169,11 +169,11 @@
>>> > </appender>
>>> > <category name="org.apache.log4j.xml">
>>> > <priority value="debug"/>
>>> > - <appender-ref ref="A1"/>
>>> > + <AppenderRef ref="A1"/>
>>> > </category>
>>> > <root>
>>> > <priority value="debug"/>
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </log4j:configuration>]]></pre>
>>> >
>>> > @@ -190,10 +190,10 @@
>>> > </appenders>
>>> > <loggers>
>>> > <logger name="org.apache.log4j.xml" level="debug">
>>> > - <appender-ref ref="A1"/>
>>> > + <AppenderRef ref="A1"/>
>>> > </logger>
>>> > <root level="debug">
>>> > - <appender-ref ref="STDOUT"/>
>>> > + <AppenderRef ref="STDOUT"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -204,7 +204,7 @@
>>> > <!DOCTYPE log4j:configuration PUBLIC "-//APACHE//DTD LOG4J 1.2//EN" "log4j.dtd">
>>> > <log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/" configDebug="true">
>>> > <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
>>> > - <appender-ref ref="TEMP"/>
>>> > + <AppenderRef ref="TEMP"/>
>>> > </appender>
>>> > <appender name="TEMP" class="org.apache.log4j.FileAppender">
>>> > <param name="File" value="temp"/>
>>> > @@ -214,7 +214,7 @@
>>> > </appender>
>>> > <root>
>>> > <priority value="debug"/>
>>> > - <appender-ref ref="ASYNC"/>
>>> > + <AppenderRef ref="ASYNC"/>
>>> > </root>
>>> > </log4j:configuration>]]></pre>
>>> >
>>> > @@ -226,12 +226,12 @@
>>> > <PatternLayout pattern="%d %-5p [%t] %C{2} (%F:%L) - %m%n"/>
>>> > </File>
>>> > <Async name="ASYNC">
>>> > - <appender-ref ref="TEMP"/>
>>> > + <AppenderRef ref="TEMP"/>
>>> > </Async>
>>> > </appenders>
>>> > <loggers>
>>> > <root level="debug">
>>> > - <appender-ref ref="ASYNC"/>
>>> > + <AppenderRef ref="ASYNC"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> > @@ -243,8 +243,8 @@
>>> > <!DOCTYPE log4j:configuration PUBLIC "-//APACHE//DTD LOG4J 1.2//EN" "log4j.dtd">
>>> > <log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/" configDebug="true">
>>> > <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
>>> > - <appender-ref ref="TEMP"/>
>>> > - <appender-ref ref="CONSOLE"/>
>>> > + <AppenderRef ref="TEMP"/>
>>> > + <AppenderRef ref="CONSOLE"/>
>>> > </appender>
>>> > <appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender">
>>> > <layout class="org.apache.log4j.PatternLayout">
>>> > @@ -259,7 +259,7 @@
>>> > </appender>
>>> > <root>
>>> > <priority value="debug"/>
>>> > - <appender-ref ref="ASYNC"/>
>>> > + <AppenderRef ref="ASYNC"/>
>>> > </root>
>>> > </log4j:configuration>]]></pre>
>>> >
>>> > @@ -275,13 +275,13 @@
>>> > <PatternLayout pattern="%d %-5p [%t] %C{2} (%F:%L) - %m%n"/>
>>> > </File>
>>> > <Async name="ASYNC">
>>> > - <appender-ref ref="TEMP"/>
>>> > - <appender-ref ref="CONSOLE"/>
>>> > + <AppenderRef ref="TEMP"/>
>>> > + <AppenderRef ref="CONSOLE"/>
>>> > </Async>
>>> > </appenders>
>>> > <loggers>
>>> > <root level="debug">
>>> > - <appender-ref ref="ASYNC"/>
>>> > + <AppenderRef ref="ASYNC"/>
>>> > </root>
>>> > </loggers>
>>> > </configuration>]]></pre>
>>> >
>>> > Modified: logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml
>>> > URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>>> > ==============================================================================
>>> > --- logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml (original)
>>> > +++ logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml Wed Aug 14 20:05:54 2013
>>> > @@ -24,15 +24,15 @@
>>> >
>>> > <loggers>
>>> > <logger name="EventLogger" level="info" additivity="false">
>>> > - <appender-ref ref="EventLogger"/>
>>> > + <AppenderRef ref="EventLogger"/>
>>> > </logger>>
>>> >
>>> > <logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
>>> > - <appender-ref ref="File"/>
>>> > + <AppenderRef ref="File"/>
>>> > </logger>>
>>> >
>>> > <root level="trace">
>>> > - <appender-ref ref="List"/>
>>> > + <AppenderRef ref="List"/>
>>> > </root>
>>> >
>>> > <logger name="IfEnabledTagTest" level="warn" />
>>> >
>>> >
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Remko Popma <re...@gmail.com>.
Would it be an idea to support both appender-ref and appenderRef attributes?
On Thu, Aug 15, 2013 at 10:22 AM, Gary Gregory <ga...@gmail.com>wrote:
> I never thought that Log4J 2 configuration files should be backward
> compatible with version 1, and even less so with a different product.
>
> Gary
>
>
> On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers <ra...@dslextreme.com>wrote:
>
>> Now that I see this it kind of scares me. Log4j 1.x and Logback both use
>> appender-ref. Anyone using Log4j 2 will now be broken.
>>
>> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>>
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -30,10 +30,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="org.apache.test" level="trace" additivity="false">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -25,7 +25,7 @@
>> > <loggers>
>> > <logger name="org.foo" level="DEBUG" />
>> > <root level="TRACE">
>> > - <appender-ref ref="Console" />
>> > + <AppenderRef ref="Console" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -25,7 +25,7 @@
>> > <loggers>
>> > <logger name="org.foo" level="DEBUG" />
>> > <root level="TRACE">
>> > - <appender-ref ref="Console" />
>> > + <AppenderRef ref="Console" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -25,7 +25,7 @@
>> > <loggers>
>> > <logger name="org.foo" level="DEBUG" />
>> > <root level="TRACE">
>> > - <appender-ref ref="Console" />
>> > + <AppenderRef ref="Console" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -25,7 +25,7 @@
>> > <loggers>
>> > <logger name="org.foo" level="DEBUG" />
>> > <root level="TRACE">
>> > - <appender-ref ref="Console" />
>> > + <AppenderRef ref="Console" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -25,7 +25,7 @@
>> > <loggers>
>> > <logger name="org.foo" level="DEBUG" />
>> > <root level="TRACE">
>> > - <appender-ref ref="Console" />
>> > + <AppenderRef ref="Console" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -25,7 +25,7 @@
>> > <loggers>
>> > <logger name="org.foo" level="DEBUG" />
>> > <root level="TRACE">
>> > - <appender-ref ref="Console" />
>> > + <AppenderRef ref="Console" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -27,7 +27,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -28,7 +28,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="LIST"/>
>> > + <AppenderRef ref="LIST"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -30,7 +30,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="TestLogfile"/>
>> > + <AppenderRef ref="TestLogfile"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -26,7 +26,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="debug">
>> > - <appender-ref ref="TestLogfile"/>
>> > + <AppenderRef ref="TestLogfile"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -26,7 +26,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="TestLogfile"/>
>> > + <AppenderRef ref="TestLogfile"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -28,7 +28,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="LIST"/>
>> > + <AppenderRef ref="LIST"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -23,6 +23,6 @@
>> > </appender>
>> >
>> > <root level="error">
>> > - <appender-ref ref="Console" />
>> > + <AppenderRef ref="Console" />
>> > </root>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -31,6 +31,6 @@
>> > </appender>
>> >
>> > <root level="error">
>> > - <appender-ref ref="TestLogfile" />
>> > + <AppenderRef ref="TestLogfile" />
>> > </root>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -25,6 +25,6 @@
>> > </appender>
>> >
>> > <root level="debug">
>> > - <appender-ref ref="TestLogfile" />
>> > + <AppenderRef ref="TestLogfile" />
>> > </root>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -24,6 +24,6 @@
>> > </appender>
>> >
>> > <root level="error">
>> > - <appender-ref ref="TestLogfile" />
>> > + <AppenderRef ref="TestLogfile" />
>> > </root>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -23,6 +23,6 @@
>> > </appender>
>> >
>> > <root level="debug">
>> > - <appender-ref ref="stdout" />
>> > + <AppenderRef ref="stdout" />
>> > </root>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -11,11 +11,11 @@
>> > <loggers>
>> > <!--
>> > <root level="info" includeLocation="false">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </root>
>> > -->
>> > <logger name="sample" level="info" includeLocation="false">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </logger>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -34,11 +34,11 @@
>> >
>> > <loggers>
>> > <logger name="org.apache.logging.log4j.core.appender.db"
>> level="debug">
>> > - <appender-ref ref="databaseAppender" />
>> > + <AppenderRef ref="databaseAppender" />
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -34,11 +34,11 @@
>> >
>> > <loggers>
>> > <logger name="org.apache.logging.log4j.core.appender.db"
>> level="debug" additivity="false">
>> > - <appender-ref ref="databaseAppender" />
>> > + <AppenderRef ref="databaseAppender" />
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -35,11 +35,11 @@
>> >
>> > <loggers>
>> > <logger name="org.apache.logging.log4j.core.appender.db"
>> level="debug">
>> > - <appender-ref ref="databaseAppender" />
>> > + <AppenderRef ref="databaseAppender" />
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -34,11 +34,11 @@
>> >
>> > <loggers>
>> > <logger name="org.apache.logging.log4j.core.appender.db"
>> level="debug" additivity="false">
>> > - <appender-ref ref="databaseAppender" />
>> > + <AppenderRef ref="databaseAppender" />
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -35,11 +35,11 @@
>> >
>> > <loggers>
>> > <logger name="org.apache.logging.log4j.core.appender.db"
>> level="debug">
>> > - <appender-ref ref="databaseAppender" />
>> > + <AppenderRef ref="databaseAppender" />
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -27,11 +27,11 @@
>> >
>> > <loggers>
>> > <logger name="org.apache.logging.log4j.core.appender.db"
>> level="debug">
>> > - <appender-ref ref="databaseAppender" />
>> > + <AppenderRef ref="databaseAppender" />
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -27,11 +27,11 @@
>> >
>> > <loggers>
>> > <logger name="org.apache.logging.log4j.core.appender.db"
>> level="debug" additivity="false">
>> > - <appender-ref ref="databaseAppender" />
>> > + <AppenderRef ref="databaseAppender" />
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -27,11 +27,11 @@
>> >
>> > <loggers>
>> > <logger name="org.apache.logging.log4j.core.appender.db"
>> level="debug">
>> > - <appender-ref ref="databaseAppender" />
>> > + <AppenderRef ref="databaseAppender" />
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -27,11 +27,11 @@
>> >
>> > <loggers>
>> > <logger name="org.apache.logging.log4j.core.appender.db"
>> level="debug" additivity="false">
>> > - <appender-ref ref="databaseAppender" />
>> > + <AppenderRef ref="databaseAppender" />
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -11,10 +11,10 @@
>> > </appender>
>> > <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
>> > <param name="BufferSize" value="262144"/>
>> > - <appender-ref ref="File"/>
>> > + <AppenderRef ref="File"/>
>> > </appender>
>> > <root>
>> > <priority value="debug" />
>> > - <appender-ref ref="ASYNC" />
>> > + <AppenderRef ref="ASYNC" />
>> > </root>
>> > </log4j:configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -11,6 +11,6 @@
>> > </appender>
>> > <root>
>> > <priority value="debug" />
>> > - <appender-ref ref="File" />
>> > + <AppenderRef ref="File" />
>> > </root>
>> > </log4j:configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -12,10 +12,10 @@
>> > <queueSize>262144</queueSize>
>> > <discardingThreshold>0</discardingThreshold>
>> > <includeCallerData>false</includeCallerData>
>> > - <appender-ref ref="FILE" />
>> > + <AppenderRef ref="FILE" />
>> > </appender>
>> >
>> > <root level="debug">
>> > - <appender-ref ref="ASYNC" />
>> > + <AppenderRef ref="ASYNC" />
>> > </root>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -10,6 +10,6 @@
>> > </appender>
>> >
>> > <root level="debug">
>> > - <appender-ref ref="FILE" />
>> > + <AppenderRef ref="FILE" />
>> > </root>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -9,7 +9,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="info" includeLocation="false">
>> > - <appender-ref ref="RandomAccessFile"/>
>> > + <AppenderRef ref="RandomAccessFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -9,7 +9,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="info" includeLocation="false">
>> > - <appender-ref ref="File"/>
>> > + <AppenderRef ref="File"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -14,7 +14,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="info" includeLocation="false">
>> > - <appender-ref ref="RollingRandomAccessFile"/>
>> > + <AppenderRef ref="RollingRandomAccessFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -14,7 +14,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="info" includeLocation="false">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -9,7 +9,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="info" includeLocation="false">
>> > - <appender-ref ref="RandomAccessFile"/>
>> > + <AppenderRef ref="RandomAccessFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -9,7 +9,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="info" includeLocation="true">
>> > - <appender-ref ref="RandomAccessFile"/>
>> > + <AppenderRef ref="RandomAccessFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -7,12 +7,12 @@
>> > </PatternLayout>
>> > </RandomAccessFile>
>> > <Async name="Async" blocking="true" bufferSize="262144">
>> > - <appender-ref ref="RandomAccessFile"/>
>> > + <AppenderRef ref="RandomAccessFile"/>
>> > </Async>
>> > </appenders>
>> > <loggers>
>> > <root level="info" includeLocation="false">
>> > - <appender-ref ref="Async"/>
>> > + <AppenderRef ref="Async"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -7,12 +7,12 @@
>> > </PatternLayout>
>> > </RandomAccessFile>
>> > <Async name="Async" includeLocation="true" blocking="true"
>> bufferSize="262144">
>> > - <appender-ref ref="RandomAccessFile"/>
>> > + <AppenderRef ref="RandomAccessFile"/>
>> > </Async>
>> > </appenders>
>> > <loggers>
>> > <root level="info" includeLocation="true">
>> > - <appender-ref ref="Async"/>
>> > + <AppenderRef ref="Async"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -9,7 +9,7 @@
>> > </appenders>
>> > <loggers>
>> > <asyncRoot level="info" includeLocation="false">
>> > - <appender-ref ref="RandomAccessFile"/>
>> > + <AppenderRef ref="RandomAccessFile"/>
>> > </asyncRoot>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -9,7 +9,7 @@
>> > </appenders>
>> > <loggers>
>> > <asyncRoot level="info" includeLocation="true">
>> > - <appender-ref ref="RandomAccessFile"/>
>> > + <AppenderRef ref="RandomAccessFile"/>
>> > </asyncRoot>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -10,10 +10,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="EventLogger" level="info">
>> > - <appender-ref ref="events"/>
>> > + <AppenderRef ref="events"/>
>> > </logger>
>> > <root level="warn">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -12,10 +12,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="EventLogger" level="info" additivity="false">
>> > - <appender-ref ref="eventLogger"/>
>> > + <AppenderRef ref="eventLogger"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -32,10 +32,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="EventLogger" level="info" additivity="false">
>> > - <appender-ref ref="eventLogger"/>
>> > + <AppenderRef ref="eventLogger"/>
>> > </logger>
>> > <root level="warn">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -15,10 +15,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="EventLogger" level="info" additivity="false">
>> > - <appender-ref ref="eventLogger"/>
>> > + <AppenderRef ref="eventLogger"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -24,15 +24,15 @@
>> >
>> > <loggers>
>> > <logger name="EventLogger" level="info" additivity="false">
>> > - <appender-ref ref="EventLogger"/>
>> > + <AppenderRef ref="EventLogger"/>
>> > </logger>>
>> >
>> > <logger name="org.apache.logging.log4j.test2" level="debug"
>> additivity="false">
>> > - <appender-ref ref="File"/>
>> > + <AppenderRef ref="File"/>
>> > </logger>>
>> >
>> > <root level="trace">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
>> Wed Aug 14 20:05:54 2013
>> > @@ -24,22 +24,23 @@ import static org.junit.Assert.assertTru
>> > import java.util.Date;
>> > import java.util.List;
>> >
>> > -import ch.qos.logback.classic.joran.JoranConfigurator;
>> > -import ch.qos.logback.classic.spi.ILoggingEvent;
>> > -import ch.qos.logback.core.joran.spi.JoranException;
>> > import org.apache.logging.log4j.LogManager;
>> > import org.apache.logging.log4j.Logger;
>> > import org.apache.logging.log4j.ThreadContext;
>> > import org.apache.logging.log4j.message.MessageFactory;
>> > import org.apache.logging.log4j.message.ParameterizedMessageFactory;
>> > import org.apache.logging.log4j.message.StringFormatterMessageFactory;
>> > -import ch.qos.logback.core.testUtil.StringListAppender;
>> > -import ch.qos.logback.classic.LoggerContext;
>> > import org.junit.Before;
>> > import org.junit.BeforeClass;
>> > import org.junit.Test;
>> > import org.slf4j.LoggerFactory;
>> >
>> > +import ch.qos.logback.classic.LoggerContext;
>> > +import ch.qos.logback.classic.joran.JoranConfigurator;
>> > +import ch.qos.logback.classic.spi.ILoggingEvent;
>> > +import ch.qos.logback.core.joran.spi.JoranException;
>> > +import ch.qos.logback.core.testUtil.StringListAppender;
>> > +
>> > /**
>> > *
>> > */
>> > @@ -74,6 +75,8 @@ public class LoggerTest {
>> >
>> > @Before
>> > public void before() {
>> > + assertNotNull(list);
>> > + assertNotNull(list.strList);
>> > list.strList.clear();
>> > }
>> >
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -27,13 +27,13 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="org.apache.test.logging" level="debug"
>> additivity="false">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </logger>
>> > <logger name="org.apache.test" level="trace" additivity="false">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>
>> > \ No newline at end of file
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -40,10 +40,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="EventLogger" level="WARN"
>> additivity="false">
>> > - <appender-ref ref="flume" />
>> > + <AppenderRef ref="flume" />
>> > </logger>
>> > <root level="debug">
>> > - <appender-ref ref="RollingFile" />
>> > + <AppenderRef ref="RollingFile" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -40,10 +40,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="EventLogger" level="WARN"
>> additivity="false">
>> > - <appender-ref ref="flume" />
>> > + <AppenderRef ref="flume" />
>> > </logger>
>> > <root level="debug">
>> > - <appender-ref ref="RollingFile" />
>> > + <AppenderRef ref="RollingFile" />
>> > </root>
>> > </loggers>
>> > </configuration>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml
>> Wed Aug 14 20:05:54 2013
>> > @@ -25,15 +25,15 @@
>> >
>> > <loggers>
>> > <logger name="EventLogger" level="info" additivity="false">
>> > - <appender-ref ref="EventLogger"/>
>> > + <AppenderRef ref="EventLogger"/>
>> > </logger>>
>> >
>> > <logger name="org.apache.logging.log4j.test2" level="debug"
>> additivity="false">
>> > - <appender-ref ref="File"/>
>> > + <AppenderRef ref="File"/>
>> > </logger>>
>> >
>> > <root level="trace">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </root>
>> > </loggers>
>> >
>> >
>> > Modified: logging/log4j/log4j2/trunk/src/changes/changes.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/changes/changes.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/src/changes/changes.xml (original)
>> > +++ logging/log4j/log4j2/trunk/src/changes/changes.xml Wed Aug 14
>> 20:05:54 2013
>> > @@ -432,7 +432,7 @@
>> > The blocking parameter did not work properly on AsynchAppender.
>> > </action>
>> > <action issue="LOG4J2-188" dev="rgoers" type="fix"
>> due-to="Werner">
>> > - appender-refs on AsynchAppender didn't support the level and
>> filter elements.
>> > + AppenderRefs on AsynchAppender didn't support the level and
>> filter elements.
>> > </action>
>> > <action issue="LOG4J2-176" dev="rgoers" type="fix" due-to="Remko
>> Popma">
>> > Avoid IllegalArgumentException in AsynchAppender.
>> > @@ -797,7 +797,7 @@
>> > </release>
>> > <release version="2.0-alpha1" date="2012-07-29"
>> description="Rewrite of Log4j">
>> > <action issue="LOG4J2-60" dev="rgoers" type="add" due-to="Shane
>> Kelly">
>> > - Added ability to filter on the appender-ref by adding either a
>> level or a filter.
>> > + Added ability to filter on the AppenderRef by adding either a
>> level or a filter.
>> > </action>
>> > <action issue="LOG4J2-56" dev="rgoers" type="fix" due-to="John
>> Owen Atala">
>> > Level.toLevel would throw an IllegalArgumentException instead
>> of returning the default value.
>> >
>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -59,9 +59,9 @@
>> > <th>Description</th>
>> > </tr>
>> > <tr>
>> > - <td>appender-ref</td>
>> > + <td>AppenderRef</td>
>> > <td>String</td>
>> > - <td>The name of the Appenders to invoke asynchronously.
>> Multiple appender-ref
>> > + <td>The name of the Appenders to invoke asynchronously.
>> Multiple AppenderRef
>> > elements can be configured.</td>
>> > </tr>
>> > <tr>
>> > @@ -122,12 +122,12 @@
>> > </PatternLayout>
>> > </File>
>> > <Async name="Async">
>> > - <appender-ref ref="MyFile"/>
>> > + <AppenderRef ref="MyFile"/>
>> > </Async>
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="Async"/>
>> > + <AppenderRef ref="Async"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -196,7 +196,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -271,13 +271,13 @@
>> > </Console>
>> > <Failover name="Failover" primary="RollingFile">
>> > <Failovers>
>> > - <appender-ref ref="Console"/>
>> > + <AppenderRef ref="Console"/>
>> > </Failovers>
>> > </Failover>
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="Failover"/>
>> > + <AppenderRef ref="Failover"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -387,7 +387,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="MyFile"/>
>> > + <AppenderRef ref="MyFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -588,7 +588,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingRandomAccessFile"/>
>> > + <AppenderRef ref="RollingRandomAccessFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -613,7 +613,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingRandomAccessFile"/>
>> > + <AppenderRef ref="RollingRandomAccessFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -647,7 +647,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingRandomAccessFile"/>
>> > + <AppenderRef ref="RollingRandomAccessFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -749,7 +749,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="MyFile"/>
>> > + <AppenderRef ref="MyFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -927,7 +927,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="eventLogger"/>
>> > + <AppenderRef ref="eventLogger"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -948,7 +948,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="eventLogger"/>
>> > + <AppenderRef ref="eventLogger"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -972,10 +972,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="EventLogger" level="info">
>> > - <appender-ref ref="eventLogger"/>
>> > + <AppenderRef ref="eventLogger"/>
>> > </logger>
>> > <root level="warn">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1016,10 +1016,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="EventLogger" level="info">
>> > - <appender-ref ref="eventLogger"/>
>> > + <AppenderRef ref="eventLogger"/>
>> > </logger>
>> > <root level="warn">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1216,7 +1216,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="warn">
>> > - <appender-ref ref="databaseAppender"/>
>> > + <AppenderRef ref="databaseAppender"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1235,7 +1235,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="warn">
>> > - <appender-ref ref="databaseAppender"/>
>> > + <AppenderRef ref="databaseAppender"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1255,7 +1255,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="warn">
>> > - <appender-ref ref="databaseAppender"/>
>> > + <AppenderRef ref="databaseAppender"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1365,7 +1365,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="jmsQueue"/>
>> > + <AppenderRef ref="jmsQueue"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1476,7 +1476,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="jmsQueue"/>
>> > + <AppenderRef ref="jmsQueue"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1552,7 +1552,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="warn">
>> > - <appender-ref ref="databaseAppender"/>
>> > + <AppenderRef ref="databaseAppender"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1806,7 +1806,7 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <root level="warn">
>> > - <appender-ref ref="databaseAppender"/>
>> > + <AppenderRef ref="databaseAppender"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1821,7 +1821,7 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <root level="warn">
>> > - <appender-ref ref="databaseAppender"/>
>> > + <AppenderRef ref="databaseAppender"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1836,7 +1836,7 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <root level="warn">
>> > - <appender-ref ref="databaseAppender"/>
>> > + <AppenderRef ref="databaseAppender"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -1919,9 +1919,9 @@ public class JpaLogEntity extends Abstra
>> > <th>Description</th>
>> > </tr>
>> > <tr>
>> > - <td>appender-ref</td>
>> > + <td>AppenderRef</td>
>> > <td>String</td>
>> > - <td>The name of the Appenders to call after the LogEvent
>> has been manipulated. Multiple appender-ref
>> > + <td>The name of the Appenders to call after the LogEvent
>> has been manipulated. Multiple AppenderRef
>> > elements can be configured.</td>
>> > </tr>
>> > <tr>
>> > @@ -1989,7 +1989,7 @@ public class JpaLogEntity extends Abstra
>> > <PatternLayout pattern="%m%n"/>
>> > </Console>
>> > <Rewrite name="rewrite">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > <MapRewritePolicy mode="Add">
>> > <KeyValuePair key="product" value="TestProduct"/>
>> > </MapRewritePolicy>
>> > @@ -1997,7 +1997,7 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="Rewrite"/>
>> > + <AppenderRef ref="Rewrite"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -2032,7 +2032,7 @@ public class JpaLogEntity extends Abstra
>> > <PatternLayout pattern="%m%n"/>
>> > </Console>
>> > <Rewrite name="rewrite">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > <PropertiesRewritePolicy>
>> > <Property key="user">${sys:user.name}</Property>
>> > <Property key="env">${sys:environment}</Property>
>> > @@ -2041,7 +2041,7 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="Rewrite"/>
>> > + <AppenderRef ref="Rewrite"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -2357,7 +2357,7 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -2381,7 +2381,7 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -2408,7 +2408,7 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -2468,7 +2468,7 @@ public class JpaLogEntity extends Abstra
>> > can be configured as the default.
>> > </p>
>> > <p>
>> > - Each Route must reference an Appender. If the Route
>> contains an appender-ref attribute then the
>> > + Each Route must reference an Appender. If the Route
>> contains an AppenderRef attribute then the
>> > Route will reference an Appender that was defined in the
>> configuration. If the Route contains an
>> > Appender definition then an Appender will be created
>> within the context of the RoutingAppender and
>> > will be reused each time a matching Appender name is
>> referenced through a Route.
>> > @@ -2498,13 +2498,13 @@ public class JpaLogEntity extends Abstra
>> > <SizeBasedTriggeringPolicy size="500" />
>> > </RollingFile>
>> > </Route>
>> > - <Route appender-ref="AuditLogger" key="Audit"/>
>> > + <Route AppenderRef="AuditLogger" key="Audit"/>
>> > </Routes>
>> > </Routing>
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="Routing"/>
>> > + <AppenderRef ref="Routing"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -2631,7 +2631,7 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="Mail"/>
>> > + <AppenderRef ref="Mail"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -2722,7 +2722,7 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="socket"/>
>> > + <AppenderRef ref="socket"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -2904,10 +2904,10 @@ public class JpaLogEntity extends Abstra
>> > </appenders>
>> > <loggers>
>> > <logger name="com.mycorp" level="error">
>> > - <appender-ref ref="RFC5424"/>
>> > + <AppenderRef ref="RFC5424"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="bsd"/>
>> > + <AppenderRef ref="bsd"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> >
>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml (original)
>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml Wed Aug
>> 14 20:05:54 2013
>> > @@ -162,7 +162,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="info" includeLocation="false">
>> > - <appender-ref ref="RandomAccessFile"/>
>> > + <AppenderRef ref="RandomAccessFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -360,10 +360,10 @@
>> > <loggers>
>> > <!-- pattern layout actually uses location, so we need to include
>> it -->
>> > <asyncLogger name="com.foo.Bar" level="trace"
>> includeLocation="true">
>> > - <appender-ref ref="RandomAccessFile"/>
>> > + <AppenderRef ref="RandomAccessFile"/>
>> > </asyncLogger>
>> > <root level="info" includeLocation="true">
>> > - <appender-ref ref="RandomAccessFile"/>
>> > + <AppenderRef ref="RandomAccessFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm Wed
>> Aug 14 20:05:54 2013
>> > @@ -161,7 +161,7 @@ public class Bar {
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="Console"/>
>> > + <AppenderRef ref="Console"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -186,7 +186,7 @@ public class Bar {
>> > <pre class="prettyprint linenums"><![CDATA[
>> > <logger name="com.foo.Bar" level="TRACE"/>
>> > <root level="ERROR">
>> > - <appender-ref ref="STDOUT">
>> > + <AppenderRef ref="STDOUT">
>> > </root>]]></pre>
>> > <p>
>> > With this configuration all log events from
>> <code>com.foo.Bar</code> will be recorded while only error events will
>> > @@ -210,10 +210,10 @@ public class Bar {
>> > </appenders>
>> > <loggers>
>> > <logger name="com.foo.Bar" level="trace">
>> > - <appender-ref ref="Console"/>
>> > + <AppenderRef ref="Console"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="Console"/>
>> > + <AppenderRef ref="Console"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -242,10 +242,10 @@ public class Bar {
>> > </appenders>
>> > <loggers>
>> > <logger name="com.foo.Bar" level="trace" additivity="false">
>> > - <appender-ref ref="Console"/>
>> > + <AppenderRef ref="Console"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="Console"/>
>> > + <AppenderRef ref="Console"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -408,7 +408,7 @@ public class Bar {
>> > </logger>
>> > ...
>> > <root level="level">
>> > - <appender-ref ref="name"/>
>> > + <AppenderRef ref="name"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -443,7 +443,7 @@ public class Bar {
>> > </logger>
>> > ...
>> > <root level="level">
>> > - <appender-ref ref="name"/>
>> > + <AppenderRef ref="name"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -488,15 +488,15 @@ public class Bar {
>> > <filter type="ThreadContextMapFilter">
>> > <KeyValuePair key="test" value="123"/>
>> > </filter>
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </logger>>
>> >
>> > <logger name="org.apache.logging.log4j.test2" level="debug"
>> additivity="false">
>> > - <appender-ref ref="File"/>
>> > + <AppenderRef ref="File"/>
>> > </logger>>
>> >
>> > <root level="trace">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </root>
>> > </loggers>
>> >
>> > @@ -537,16 +537,16 @@ public class Bar {
>> > "SizeBasedTriggeringPolicy": { "size": "500" }
>> > }
>> > },
>> > - { "appender-ref": "STDOUT", "key": "Audit"},
>> > - { "appender-ref": "List", "key": "Service"}
>> > + { "AppenderRef": "STDOUT", "key": "Audit"},
>> > + { "AppenderRef": "List", "key": "Service"}
>> > ]
>> > }
>> > }
>> > },
>> > "loggers": {
>> > "logger": { "name": "EventLogger", "level": "info", "additivity":
>> "false",
>> > - "appender-ref": { "ref": "Routing" }},
>> > - "root": { "level": "error", "appender-ref": { "ref": "STDOUT" }}
>> > + "AppenderRef": { "ref": "Routing" }},
>> > + "root": { "level": "error", "AppenderRef": { "ref": "STDOUT" }}
>> > }
>> > }
>> > }</pre>
>> > @@ -580,8 +580,8 @@ public class Bar {
>> > "SizeBasedTriggeringPolicy": { "size": "500" }
>> > }
>> > },
>> > - { "appender-ref": "STDOUT", "key": "Audit"},
>> > - { "appender-ref": "List", "key": "Service"}
>> > + { "AppenderRef": "STDOUT", "key": "Audit"},
>> > + { "AppenderRef": "List", "key": "Service"}
>> > ]
>> > }
>> > }
>> > @@ -590,11 +590,11 @@ public class Bar {
>> > "loggers": {
>> > "logger": [
>> > { "name": "EventLogger", "level": "info", "additivity": "false",
>> > - "appender-ref": { "ref": "Routing" }},
>> > + "AppenderRef": { "ref": "Routing" }},
>> > { "name": "com.foo.bar", "level": "error", "additivity":
>> "false",
>> > - "appender-ref": { "ref": "Console" }}
>> > + "AppenderRef": { "ref": "Console" }}
>> > ],
>> > - "root": { "level": "error", "appender-ref": { "ref": "STDOUT" }}
>> > + "root": { "level": "error", "AppenderRef": { "ref": "STDOUT" }}
>> > }
>> > }
>> > }</pre>
>> > @@ -638,7 +638,7 @@ public class Bar {
>> > using variables.
>> > </p>
>> > <p>
>> > - The LoggerConfig may also be configured with one or more
>> appender-ref elements. Each appender
>> > + The LoggerConfig may also be configured with one or more
>> AppenderRef elements. Each appender
>> > referenced will become associated with the specified
>> LoggerConfig. If multiple appenders
>> > are configured on the LoggerConfig each of them be called
>> when processing logging events.
>> > </p>
>> > @@ -718,21 +718,21 @@ public class Bar {
>> > <ThreadContextMapFilter>
>> > <KeyValuePair key="test" value="123"/>
>> > </ThreadContextMapFilter>
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </logger>>
>> >
>> > <logger name="org.apache.logging.log4j.test2" level="debug"
>> additivity="false">
>> > <property name="user">${dollar}{sys:user.name}</property>
>> > - <appender-ref ref="File">
>> > + <AppenderRef ref="File">
>> > <ThreadContextMapFilter>
>> > <KeyValuePair key="test" value="123"/>
>> > </ThreadContextMapFilter>
>> > - </appender-ref>
>> > - <appender-ref ref="STDOUT" level="error"/>
>> > + </AppenderRef>
>> > + <AppenderRef ref="STDOUT" level="error"/>
>> > </logger>>
>> >
>> > <root level="trace">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </root>
>> > </loggers>
>> >
>> > @@ -776,19 +776,19 @@ public class Bar {
>> > <SizeBasedTriggeringPolicy size="500" />
>> > </RollingFile>
>> > </Route>
>> > - <Route appender-ref="STDOUT" key="Audit"/>
>> > - <Route appender-ref="List" key="Service"/>
>> > + <Route AppenderRef="STDOUT" key="Audit"/>
>> > + <Route AppenderRef="List" key="Service"/>
>> > </Routes>
>> > </Routing>
>> > </appenders>
>> >
>> > <loggers>
>> > <logger name="EventLogger" level="info" additivity="false">
>> > - <appender-ref ref="Routing"/>
>> > + <AppenderRef ref="Routing"/>
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> > @@ -916,19 +916,19 @@ public class Bar {
>> > <SizeBasedTriggeringPolicy size="500" />
>> > </RollingFile>
>> > </Route>
>> > - <Route appender-ref="STDOUT" key="Audit"/>
>> > - <Route appender-ref="List" key="Service"/>
>> > + <Route AppenderRef="STDOUT" key="Audit"/>
>> > + <Route AppenderRef="List" key="Service"/>
>> > </Routes>
>> > </Routing>
>> > </appenders>
>> >
>> > <loggers>
>> > <logger name="EventLogger" level="info" additivity="false">
>> > - <appender-ref ref="Routing"/>
>> > + <AppenderRef ref="Routing"/>
>> > </logger>
>> >
>> > <root level="error">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> >
>> > @@ -961,11 +961,11 @@ public class Bar {
>> > appender.ListAppender for element List with params(name="List",
>> entryPerNewLine="null",
>> > raw="null", null, ThresholdFilter(DEBUG))
>> > 2011-11-23 17:08:00,813 DEBUG Calling createRoute on class
>> org.apache.logging.log4j.core.appender.
>> > - routing.Route for element Route with
>> params(appender-ref="null", key="null", Node=Route)
>> > + routing.Route for element Route with params(AppenderRef="null",
>> key="null", Node=Route)
>> > 2011-11-23 17:08:00,823 DEBUG Calling createRoute on class
>> org.apache.logging.log4j.core.appender.
>> > - routing.Route for element Route with
>> params(appender-ref="STDOUT", key="Audit", Node=Route)
>> > + routing.Route for element Route with
>> params(AppenderRef="STDOUT", key="Audit", Node=Route)
>> > 2011-11-23 17:08:00,824 DEBUG Calling createRoute on class
>> org.apache.logging.log4j.core.appender.
>> > - routing.Route for element Route with
>> params(appender-ref="List", key="Service", Node=Route)
>> > + routing.Route for element Route with params(AppenderRef="List",
>> key="Service", Node=Route)
>> > 2011-11-23 17:08:00,825 DEBUG Calling createRoutes on class
>> org.apache.logging.log4j.core.appender.
>> > routing.Routes for element Routes with
>> params(pattern="${dollar}{sd:type}",
>> > routes={Route(type=dynamic default), Route(type=static
>> Reference=STDOUT key='Audit'),
>> > @@ -978,16 +978,16 @@ public class Bar {
>> > 2011-11-23 17:08:00,827 DEBUG Calling createAppenders on class
>> org.apache.logging.log4j.core.config.
>> > plugins.AppendersPlugin for element appenders with
>> params(appenders={STDOUT, List, Routing})
>> > 2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class
>> org.apache.logging.log4j.core.
>> > - config.plugins.AppenderRefPlugin for element appender-ref with
>> params(ref="Routing")
>> > + config.plugins.AppenderRefPlugin for element AppenderRef with
>> params(ref="Routing")
>> > 2011-11-23 17:08:00,829 DEBUG Calling createLogger on class
>> org.apache.logging.log4j.core.config.
>> > LoggerConfig for element logger with params(additivity="false",
>> level="info", name="EventLogger",
>> > - appender-ref={Routing}, null)
>> > + AppenderRef={Routing}, null)
>> > 2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class
>> org.apache.logging.log4j.core.
>> > - config.plugins.AppenderRefPlugin for element appender-ref with
>> params(ref="STDOUT")</pre>
>> > + config.plugins.AppenderRefPlugin for element AppenderRef with
>> params(ref="STDOUT")</pre>
>> > <pre class="prettyprint linenums">
>> > 2011-11-23 17:08:00,831 DEBUG Calling createLogger on class
>> org.apache.logging.log4j.core.config.
>> > LoggerConfig$RootLogger for element root with
>> params(additivity="null", level="error",
>> > - appender-ref={STDOUT}, null)
>> > + AppenderRef={STDOUT}, null)
>> > 2011-11-23 17:08:00,833 DEBUG Calling createLoggers on class
>> org.apache.logging.log4j.core.
>> > config.plugins.LoggersPlugin for element loggers with
>> params(loggers={EventLogger, root})
>> > 2011-11-23 17:08:00,834 DEBUG Reconfiguration completed
>> > @@ -1024,16 +1024,16 @@ public class Bar {
>> > 2011-11-23 17:08:00,804 DEBUG Calling createAppender on class
>> org.apache.logging.log4j.core.appender.ConsoleAppender for element Console
>> with params(PatternLayout(%m%n), null, target="null", name="STDOUT",
>> ignoreExceptions="null")
>> > 2011-11-23 17:08:00,804 DEBUG Calling createFilter on class
>> org.apache.logging.log4j.core.filter.ThresholdFilter for element
>> ThresholdFilter with params(level="debug", onMatch="null",
>> onMismatch="null")
>> > 2011-11-23 17:08:00,806 DEBUG Calling createAppender on class
>> org.apache.logging.log4j.test.appender.ListAppender for element List with
>> params(name="List", entryPerNewLine="null", raw="null", null,
>> ThresholdFilter(DEBUG))
>> > -2011-11-23 17:08:00,813 DEBUG Calling createRoute on class
>> org.apache.logging.log4j.core.appender.routing.Route for element Route with
>> params(appender-ref="null", key="null", Node=Route)
>> > -2011-11-23 17:08:00,823 DEBUG Calling createRoute on class
>> org.apache.logging.log4j.core.appender.routing.Route for element Route with
>> params(appender-ref="STDOUT", key="Audit", Node=Route)
>> > -2011-11-23 17:08:00,824 DEBUG Calling createRoute on class
>> org.apache.logging.log4j.core.appender.routing.Route for element Route with
>> params(appender-ref="List", key="Service", Node=Route)
>> > +2011-11-23 17:08:00,813 DEBUG Calling createRoute on class
>> org.apache.logging.log4j.core.appender.routing.Route for element Route with
>> params(AppenderRef="null", key="null", Node=Route)
>> > +2011-11-23 17:08:00,823 DEBUG Calling createRoute on class
>> org.apache.logging.log4j.core.appender.routing.Route for element Route with
>> params(AppenderRef="STDOUT", key="Audit", Node=Route)
>> > +2011-11-23 17:08:00,824 DEBUG Calling createRoute on class
>> org.apache.logging.log4j.core.appender.routing.Route for element Route with
>> params(AppenderRef="List", key="Service", Node=Route)
>> > 2011-11-23 17:08:00,825 DEBUG Calling createRoutes on class
>> org.apache.logging.log4j.core.appender.routing.Routes for element Routes
>> with params(pattern="${dollar}{sd:type}", routes={Route(type=dynamic
>> default), Route(type=static Reference=STDOUT key='Audit'),
>> Route(type=static Reference=List key='Service')})
>> > 2011-11-23 17:08:00,827 DEBUG Calling createAppender on class
>> org.apache.logging.log4j.core.appender.routing.RoutingAppender for element
>> Routing with params(name="Routing", ignoreExceptions="null",
>> Routes({Route(type=dynamic default),Route(type=static Reference=STDOUT
>> key='Audit'),Route(type=static Reference=List key='Service')}),
>> Configuration(RoutingTest), null, null)
>> > 2011-11-23 17:08:00,827 DEBUG Calling createAppenders on class
>> org.apache.logging.log4j.core.config.plugins.AppendersPlugin for element
>> appenders with params(appenders={STDOUT, List, Routing})
>> > -2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class
>> org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element
>> appender-ref with params(ref="Routing")
>> > -2011-11-23 17:08:00,829 DEBUG Calling createLogger on class
>> org.apache.logging.log4j.core.config.LoggerConfig for element logger with
>> params(additivity="false", level="info", name="EventLogger",
>> appender-ref={Routing}, null)
>> > -2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class
>> org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element
>> appender-ref with params(ref="STDOUT")
>> > -2011-11-23 17:08:00,831 DEBUG Calling createLogger on class
>> org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element
>> root with params(additivity="null", level="error", appender-ref={STDOUT},
>> null)
>> > +2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class
>> org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element
>> AppenderRef with params(ref="Routing")
>> > +2011-11-23 17:08:00,829 DEBUG Calling createLogger on class
>> org.apache.logging.log4j.core.config.LoggerConfig for element logger with
>> params(additivity="false", level="info", name="EventLogger",
>> AppenderRef={Routing}, null)
>> > +2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class
>> org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element
>> AppenderRef with params(ref="STDOUT")
>> > +2011-11-23 17:08:00,831 DEBUG Calling createLogger on class
>> org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element
>> root with params(additivity="null", level="error", AppenderRef={STDOUT},
>> null)
>> > 2011-11-23 17:08:00,833 DEBUG Calling createLoggers on class
>> org.apache.logging.log4j.core.config.plugins.LoggersPlugin for element
>> loggers with params(loggers={EventLogger, root})
>> > 2011-11-23 17:08:00,834 DEBUG Reconfiguration completed
>> > 2011-11-23 17:08:00,846 DEBUG Calling createLayout on class
>> org.apache.logging.log4j.core.layout.PatternLayout for element
>> PatternLayout with params(pattern="%d %p %c{1.} [%t] %m%n",
>> Configuration(RoutingTest), null, charset="null")
>> > @@ -1053,7 +1053,7 @@ public class Bar {
>> > makes troubleshooting configuration errors possible. As an
>> example, if the configuration above is changed
>> > to have the status set to error and the logger declaration
>> is:</p>
>> > <pre class="prettyprint linenums"><![CDATA[<logger name="EventLogger"
>> level="info" additivity="false">
>> > - <appender-ref ref="Routng"/>
>> > + <AppenderRef ref="Routng"/>
>> > </logger>]]></pre>
>> > <p>
>> > the following error message will be produced.
>> >
>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -143,7 +143,7 @@ public static class RootLogger extends L
>> > @PluginFactory
>> > public static LoggerConfig createLogger(@PluginAttr("additivity")
>> String additivity,
>> > @PluginAttr("level") String
>> loggerLevel,
>> > -
>> @PluginElement("appender-ref") AppenderRef[] refs,
>> > +
>> @PluginElement("AppenderRef") AppenderRef[] refs,
>> > @PluginElement("filters")
>> Filter filter) {
>> > List<AppenderRef> appenderRefs = Arrays.asList(refs);
>> > Level level;
>> >
>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml Wed Aug
>> 14 20:05:54 2013
>> > @@ -109,7 +109,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -151,10 +151,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="EventLogger" level="info">
>> > - <appender-ref ref="Audit"/>
>> > + <AppenderRef ref="Audit"/>
>> > </logger>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -220,7 +220,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -284,7 +284,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -311,8 +311,8 @@
>> > <KeyValuePair key="eventId" value="Login"/>
>> > <KeyValuePair key="eventId" value="Logout"/>
>> > </MapFilter>
>> > - <appender-ref ref="RollingFile">
>> > - </appender-ref>
>> > + <AppenderRef ref="RollingFile">
>> > + </AppenderRef>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -335,12 +335,12 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile">
>> > + <AppenderRef ref="RollingFile">
>> > <MapFilter onMatch="ACCEPT" onMismatch="NEUTRAL" operator="or">
>> > <KeyValuePair key="eventId" value="Login"/>
>> > <KeyValuePair key="eventId" value="Logout"/>
>> > </MapFilter>
>> > - </appender-ref>
>> > + </AppenderRef>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -396,7 +396,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -456,7 +456,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -523,7 +523,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -587,7 +587,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -608,7 +608,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > <ThreadContextMapFilter onMatch="ACCEPT" onMismatch="NEUTRAL"
>> operator="or">
>> > <KeyValuePair key="foo" value="bar"/>
>> > <KeyValuePair key="User2" value="WARN"/>
>> > @@ -670,7 +670,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -740,7 +740,7 @@
>> > </appenders>
>> > <loggers>
>> > <root level="error">
>> > - <appender-ref ref="RollingFile"/>
>> > + <AppenderRef ref="RollingFile"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -154,7 +154,7 @@ public class App {
>> > </appenders>
>> > <loggers>
>> > <root level="trace">
>> > - <appender-ref ref="log"/>
>> > + <AppenderRef ref="log"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> >
>> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml
>> (original)
>> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -81,7 +81,7 @@
>> > </category>
>> > <root>
>> > <priority value ="debug" />
>> > - <appender-ref ref="STDOUT" />
>> > + <AppenderRef ref="STDOUT" />
>> > </root>
>> > </log4j:configuration>]]></pre>
>> > <p>Log4j 2 XML configuration</p>
>> > @@ -95,7 +95,7 @@
>> > <loggers>
>> > <logger name="org.apache.log4j.xml" level="info"/>
>> > <root level="debug">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -119,11 +119,11 @@
>> > </appender>
>> > <category name="org.apache.log4j.xml">
>> > <priority value="debug" />
>> > - <appender-ref ref="A1" />
>> > + <AppenderRef ref="A1" />
>> > </category>
>> > <root>
>> > <priority value ="debug" />
>> > - <appender-ref ref="STDOUT" />
>> > + <AppenderRef ref="STDOUT" />
>> > </root>
>> > </log4j:configuration>]]></pre>
>> >
>> > @@ -140,10 +140,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="org.apache.log4j.xml" level="debug">
>> > - <appender-ref ref="A1"/>
>> > + <AppenderRef ref="A1"/>
>> > </logger>
>> > <root level="debug">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -169,11 +169,11 @@
>> > </appender>
>> > <category name="org.apache.log4j.xml">
>> > <priority value="debug"/>
>> > - <appender-ref ref="A1"/>
>> > + <AppenderRef ref="A1"/>
>> > </category>
>> > <root>
>> > <priority value="debug"/>
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </log4j:configuration>]]></pre>
>> >
>> > @@ -190,10 +190,10 @@
>> > </appenders>
>> > <loggers>
>> > <logger name="org.apache.log4j.xml" level="debug">
>> > - <appender-ref ref="A1"/>
>> > + <AppenderRef ref="A1"/>
>> > </logger>
>> > <root level="debug">
>> > - <appender-ref ref="STDOUT"/>
>> > + <AppenderRef ref="STDOUT"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -204,7 +204,7 @@
>> > <!DOCTYPE log4j:configuration PUBLIC "-//APACHE//DTD LOG4J 1.2//EN"
>> "log4j.dtd">
>> > <log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/"
>> configDebug="true">
>> > <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
>> > - <appender-ref ref="TEMP"/>
>> > + <AppenderRef ref="TEMP"/>
>> > </appender>
>> > <appender name="TEMP" class="org.apache.log4j.FileAppender">
>> > <param name="File" value="temp"/>
>> > @@ -214,7 +214,7 @@
>> > </appender>
>> > <root>
>> > <priority value="debug"/>
>> > - <appender-ref ref="ASYNC"/>
>> > + <AppenderRef ref="ASYNC"/>
>> > </root>
>> > </log4j:configuration>]]></pre>
>> >
>> > @@ -226,12 +226,12 @@
>> > <PatternLayout pattern="%d %-5p [%t] %C{2} (%F:%L) - %m%n"/>
>> > </File>
>> > <Async name="ASYNC">
>> > - <appender-ref ref="TEMP"/>
>> > + <AppenderRef ref="TEMP"/>
>> > </Async>
>> > </appenders>
>> > <loggers>
>> > <root level="debug">
>> > - <appender-ref ref="ASYNC"/>
>> > + <AppenderRef ref="ASYNC"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> > @@ -243,8 +243,8 @@
>> > <!DOCTYPE log4j:configuration PUBLIC "-//APACHE//DTD LOG4J 1.2//EN"
>> "log4j.dtd">
>> > <log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/"
>> configDebug="true">
>> > <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
>> > - <appender-ref ref="TEMP"/>
>> > - <appender-ref ref="CONSOLE"/>
>> > + <AppenderRef ref="TEMP"/>
>> > + <AppenderRef ref="CONSOLE"/>
>> > </appender>
>> > <appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender">
>> > <layout class="org.apache.log4j.PatternLayout">
>> > @@ -259,7 +259,7 @@
>> > </appender>
>> > <root>
>> > <priority value="debug"/>
>> > - <appender-ref ref="ASYNC"/>
>> > + <AppenderRef ref="ASYNC"/>
>> > </root>
>> > </log4j:configuration>]]></pre>
>> >
>> > @@ -275,13 +275,13 @@
>> > <PatternLayout pattern="%d %-5p [%t] %C{2} (%F:%L) - %m%n"/>
>> > </File>
>> > <Async name="ASYNC">
>> > - <appender-ref ref="TEMP"/>
>> > - <appender-ref ref="CONSOLE"/>
>> > + <AppenderRef ref="TEMP"/>
>> > + <AppenderRef ref="CONSOLE"/>
>> > </Async>
>> > </appenders>
>> > <loggers>
>> > <root level="debug">
>> > - <appender-ref ref="ASYNC"/>
>> > + <AppenderRef ref="ASYNC"/>
>> > </root>
>> > </loggers>
>> > </configuration>]]></pre>
>> >
>> > Modified:
>> logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml
>> > URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
>> >
>> ==============================================================================
>> > ---
>> logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml
>> (original)
>> > +++
>> logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml Wed
>> Aug 14 20:05:54 2013
>> > @@ -24,15 +24,15 @@
>> >
>> > <loggers>
>> > <logger name="EventLogger" level="info" additivity="false">
>> > - <appender-ref ref="EventLogger"/>
>> > + <AppenderRef ref="EventLogger"/>
>> > </logger>>
>> >
>> > <logger name="org.apache.logging.log4j.test2" level="debug"
>> additivity="false">
>> > - <appender-ref ref="File"/>
>> > + <AppenderRef ref="File"/>
>> > </logger>>
>> >
>> > <root level="trace">
>> > - <appender-ref ref="List"/>
>> > + <AppenderRef ref="List"/>
>> > </root>
>> >
>> > <logger name="IfEnabledTagTest" level="warn" />
>> >
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk:
core/src/main/java/org/apache/logging/log4j/core/appender/
core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/
core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Gary Gregory <ga...@gmail.com>.
I never thought that Log4J 2 configuration files should be backward
compatible with version 1, and even less so with a different product.
Gary
On Wed, Aug 14, 2013 at 8:51 PM, Ralph Goers <ra...@dslextreme.com>wrote:
> Now that I see this it kind of scares me. Log4j 1.x and Logback both use
> appender-ref. Anyone using Log4j 2 will now be broken.
>
> On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
>
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> Wed Aug 14 20:05:54 2013
> > @@ -30,10 +30,10 @@
> > </appenders>
> > <loggers>
> > <logger name="org.apache.test" level="trace" additivity="false">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </logger>
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> Wed Aug 14 20:05:54 2013
> > @@ -25,7 +25,7 @@
> > <loggers>
> > <logger name="org.foo" level="DEBUG" />
> > <root level="TRACE">
> > - <appender-ref ref="Console" />
> > + <AppenderRef ref="Console" />
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
> Wed Aug 14 20:05:54 2013
> > @@ -25,7 +25,7 @@
> > <loggers>
> > <logger name="org.foo" level="DEBUG" />
> > <root level="TRACE">
> > - <appender-ref ref="Console" />
> > + <AppenderRef ref="Console" />
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml
> Wed Aug 14 20:05:54 2013
> > @@ -25,7 +25,7 @@
> > <loggers>
> > <logger name="org.foo" level="DEBUG" />
> > <root level="TRACE">
> > - <appender-ref ref="Console" />
> > + <AppenderRef ref="Console" />
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml
> Wed Aug 14 20:05:54 2013
> > @@ -25,7 +25,7 @@
> > <loggers>
> > <logger name="org.foo" level="DEBUG" />
> > <root level="TRACE">
> > - <appender-ref ref="Console" />
> > + <AppenderRef ref="Console" />
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml
> Wed Aug 14 20:05:54 2013
> > @@ -25,7 +25,7 @@
> > <loggers>
> > <logger name="org.foo" level="DEBUG" />
> > <root level="TRACE">
> > - <appender-ref ref="Console" />
> > + <AppenderRef ref="Console" />
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml Wed
> Aug 14 20:05:54 2013
> > @@ -25,7 +25,7 @@
> > <loggers>
> > <logger name="org.foo" level="DEBUG" />
> > <root level="TRACE">
> > - <appender-ref ref="Console" />
> > + <AppenderRef ref="Console" />
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml
> Wed Aug 14 20:05:54 2013
> > @@ -27,7 +27,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml Wed
> Aug 14 20:05:54 2013
> > @@ -28,7 +28,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="LIST"/>
> > + <AppenderRef ref="LIST"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml
> Wed Aug 14 20:05:54 2013
> > @@ -30,7 +30,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="TestLogfile"/>
> > + <AppenderRef ref="TestLogfile"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml
> Wed Aug 14 20:05:54 2013
> > @@ -26,7 +26,7 @@
> > </appenders>
> > <loggers>
> > <root level="debug">
> > - <appender-ref ref="TestLogfile"/>
> > + <AppenderRef ref="TestLogfile"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml
> Wed Aug 14 20:05:54 2013
> > @@ -26,7 +26,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="TestLogfile"/>
> > + <AppenderRef ref="TestLogfile"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml Wed
> Aug 14 20:05:54 2013
> > @@ -28,7 +28,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="LIST"/>
> > + <AppenderRef ref="LIST"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml
> Wed Aug 14 20:05:54 2013
> > @@ -23,6 +23,6 @@
> > </appender>
> >
> > <root level="error">
> > - <appender-ref ref="Console" />
> > + <AppenderRef ref="Console" />
> > </root>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml
> Wed Aug 14 20:05:54 2013
> > @@ -31,6 +31,6 @@
> > </appender>
> >
> > <root level="error">
> > - <appender-ref ref="TestLogfile" />
> > + <AppenderRef ref="TestLogfile" />
> > </root>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml
> Wed Aug 14 20:05:54 2013
> > @@ -25,6 +25,6 @@
> > </appender>
> >
> > <root level="debug">
> > - <appender-ref ref="TestLogfile" />
> > + <AppenderRef ref="TestLogfile" />
> > </root>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml
> Wed Aug 14 20:05:54 2013
> > @@ -24,6 +24,6 @@
> > </appender>
> >
> > <root level="error">
> > - <appender-ref ref="TestLogfile" />
> > + <AppenderRef ref="TestLogfile" />
> > </root>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml
> Wed Aug 14 20:05:54 2013
> > @@ -23,6 +23,6 @@
> > </appender>
> >
> > <root level="debug">
> > - <appender-ref ref="stdout" />
> > + <AppenderRef ref="stdout" />
> > </root>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml
> Wed Aug 14 20:05:54 2013
> > @@ -11,11 +11,11 @@
> > <loggers>
> > <!--
> > <root level="info" includeLocation="false">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </root>
> > -->
> > <logger name="sample" level="info" includeLocation="false">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </logger>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml
> Wed Aug 14 20:05:54 2013
> > @@ -34,11 +34,11 @@
> >
> > <loggers>
> > <logger name="org.apache.logging.log4j.core.appender.db"
> level="debug">
> > - <appender-ref ref="databaseAppender" />
> > + <AppenderRef ref="databaseAppender" />
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml
> Wed Aug 14 20:05:54 2013
> > @@ -34,11 +34,11 @@
> >
> > <loggers>
> > <logger name="org.apache.logging.log4j.core.appender.db"
> level="debug" additivity="false">
> > - <appender-ref ref="databaseAppender" />
> > + <AppenderRef ref="databaseAppender" />
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml
> Wed Aug 14 20:05:54 2013
> > @@ -35,11 +35,11 @@
> >
> > <loggers>
> > <logger name="org.apache.logging.log4j.core.appender.db"
> level="debug">
> > - <appender-ref ref="databaseAppender" />
> > + <AppenderRef ref="databaseAppender" />
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml
> Wed Aug 14 20:05:54 2013
> > @@ -34,11 +34,11 @@
> >
> > <loggers>
> > <logger name="org.apache.logging.log4j.core.appender.db"
> level="debug" additivity="false">
> > - <appender-ref ref="databaseAppender" />
> > + <AppenderRef ref="databaseAppender" />
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml
> Wed Aug 14 20:05:54 2013
> > @@ -35,11 +35,11 @@
> >
> > <loggers>
> > <logger name="org.apache.logging.log4j.core.appender.db"
> level="debug">
> > - <appender-ref ref="databaseAppender" />
> > + <AppenderRef ref="databaseAppender" />
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml
> Wed Aug 14 20:05:54 2013
> > @@ -27,11 +27,11 @@
> >
> > <loggers>
> > <logger name="org.apache.logging.log4j.core.appender.db"
> level="debug">
> > - <appender-ref ref="databaseAppender" />
> > + <AppenderRef ref="databaseAppender" />
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml
> Wed Aug 14 20:05:54 2013
> > @@ -27,11 +27,11 @@
> >
> > <loggers>
> > <logger name="org.apache.logging.log4j.core.appender.db"
> level="debug" additivity="false">
> > - <appender-ref ref="databaseAppender" />
> > + <AppenderRef ref="databaseAppender" />
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml
> Wed Aug 14 20:05:54 2013
> > @@ -27,11 +27,11 @@
> >
> > <loggers>
> > <logger name="org.apache.logging.log4j.core.appender.db"
> level="debug">
> > - <appender-ref ref="databaseAppender" />
> > + <AppenderRef ref="databaseAppender" />
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml
> Wed Aug 14 20:05:54 2013
> > @@ -27,11 +27,11 @@
> >
> > <loggers>
> > <logger name="org.apache.logging.log4j.core.appender.db"
> level="debug" additivity="false">
> > - <appender-ref ref="databaseAppender" />
> > + <AppenderRef ref="databaseAppender" />
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml
> Wed Aug 14 20:05:54 2013
> > @@ -11,10 +11,10 @@
> > </appender>
> > <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
> > <param name="BufferSize" value="262144"/>
> > - <appender-ref ref="File"/>
> > + <AppenderRef ref="File"/>
> > </appender>
> > <root>
> > <priority value="debug" />
> > - <appender-ref ref="ASYNC" />
> > + <AppenderRef ref="ASYNC" />
> > </root>
> > </log4j:configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml
> Wed Aug 14 20:05:54 2013
> > @@ -11,6 +11,6 @@
> > </appender>
> > <root>
> > <priority value="debug" />
> > - <appender-ref ref="File" />
> > + <AppenderRef ref="File" />
> > </root>
> > </log4j:configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml
> Wed Aug 14 20:05:54 2013
> > @@ -12,10 +12,10 @@
> > <queueSize>262144</queueSize>
> > <discardingThreshold>0</discardingThreshold>
> > <includeCallerData>false</includeCallerData>
> > - <appender-ref ref="FILE" />
> > + <AppenderRef ref="FILE" />
> > </appender>
> >
> > <root level="debug">
> > - <appender-ref ref="ASYNC" />
> > + <AppenderRef ref="ASYNC" />
> > </root>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml
> Wed Aug 14 20:05:54 2013
> > @@ -10,6 +10,6 @@
> > </appender>
> >
> > <root level="debug">
> > - <appender-ref ref="FILE" />
> > + <AppenderRef ref="FILE" />
> > </root>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml
> Wed Aug 14 20:05:54 2013
> > @@ -9,7 +9,7 @@
> > </appenders>
> > <loggers>
> > <root level="info" includeLocation="false">
> > - <appender-ref ref="RandomAccessFile"/>
> > + <AppenderRef ref="RandomAccessFile"/>
> > </root>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml
> Wed Aug 14 20:05:54 2013
> > @@ -9,7 +9,7 @@
> > </appenders>
> > <loggers>
> > <root level="info" includeLocation="false">
> > - <appender-ref ref="File"/>
> > + <AppenderRef ref="File"/>
> > </root>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml
> Wed Aug 14 20:05:54 2013
> > @@ -14,7 +14,7 @@
> > </appenders>
> > <loggers>
> > <root level="info" includeLocation="false">
> > - <appender-ref ref="RollingRandomAccessFile"/>
> > + <AppenderRef ref="RollingRandomAccessFile"/>
> > </root>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml
> Wed Aug 14 20:05:54 2013
> > @@ -14,7 +14,7 @@
> > </appenders>
> > <loggers>
> > <root level="info" includeLocation="false">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml Wed
> Aug 14 20:05:54 2013
> > @@ -9,7 +9,7 @@
> > </appenders>
> > <loggers>
> > <root level="info" includeLocation="false">
> > - <appender-ref ref="RandomAccessFile"/>
> > + <AppenderRef ref="RandomAccessFile"/>
> > </root>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml
> Wed Aug 14 20:05:54 2013
> > @@ -9,7 +9,7 @@
> > </appenders>
> > <loggers>
> > <root level="info" includeLocation="true">
> > - <appender-ref ref="RandomAccessFile"/>
> > + <AppenderRef ref="RandomAccessFile"/>
> > </root>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml
> Wed Aug 14 20:05:54 2013
> > @@ -7,12 +7,12 @@
> > </PatternLayout>
> > </RandomAccessFile>
> > <Async name="Async" blocking="true" bufferSize="262144">
> > - <appender-ref ref="RandomAccessFile"/>
> > + <AppenderRef ref="RandomAccessFile"/>
> > </Async>
> > </appenders>
> > <loggers>
> > <root level="info" includeLocation="false">
> > - <appender-ref ref="Async"/>
> > + <AppenderRef ref="Async"/>
> > </root>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml
> Wed Aug 14 20:05:54 2013
> > @@ -7,12 +7,12 @@
> > </PatternLayout>
> > </RandomAccessFile>
> > <Async name="Async" includeLocation="true" blocking="true"
> bufferSize="262144">
> > - <appender-ref ref="RandomAccessFile"/>
> > + <AppenderRef ref="RandomAccessFile"/>
> > </Async>
> > </appenders>
> > <loggers>
> > <root level="info" includeLocation="true">
> > - <appender-ref ref="Async"/>
> > + <AppenderRef ref="Async"/>
> > </root>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml Wed
> Aug 14 20:05:54 2013
> > @@ -9,7 +9,7 @@
> > </appenders>
> > <loggers>
> > <asyncRoot level="info" includeLocation="false">
> > - <appender-ref ref="RandomAccessFile"/>
> > + <AppenderRef ref="RandomAccessFile"/>
> > </asyncRoot>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml
> Wed Aug 14 20:05:54 2013
> > @@ -9,7 +9,7 @@
> > </appenders>
> > <loggers>
> > <asyncRoot level="info" includeLocation="true">
> > - <appender-ref ref="RandomAccessFile"/>
> > + <AppenderRef ref="RandomAccessFile"/>
> > </asyncRoot>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml
> Wed Aug 14 20:05:54 2013
> > @@ -10,10 +10,10 @@
> > </appenders>
> > <loggers>
> > <logger name="EventLogger" level="info">
> > - <appender-ref ref="events"/>
> > + <AppenderRef ref="events"/>
> > </logger>
> > <root level="warn">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml
> Wed Aug 14 20:05:54 2013
> > @@ -12,10 +12,10 @@
> > </appenders>
> > <loggers>
> > <logger name="EventLogger" level="info" additivity="false">
> > - <appender-ref ref="eventLogger"/>
> > + <AppenderRef ref="eventLogger"/>
> > </logger>
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml
> Wed Aug 14 20:05:54 2013
> > @@ -32,10 +32,10 @@
> > </appenders>
> > <loggers>
> > <logger name="EventLogger" level="info" additivity="false">
> > - <appender-ref ref="eventLogger"/>
> > + <AppenderRef ref="eventLogger"/>
> > </logger>
> > <root level="warn">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml Wed
> Aug 14 20:05:54 2013
> > @@ -15,10 +15,10 @@
> > </appenders>
> > <loggers>
> > <logger name="EventLogger" level="info" additivity="false">
> > - <appender-ref ref="eventLogger"/>
> > + <AppenderRef ref="eventLogger"/>
> > </logger>
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml
> Wed Aug 14 20:05:54 2013
> > @@ -24,15 +24,15 @@
> >
> > <loggers>
> > <logger name="EventLogger" level="info" additivity="false">
> > - <appender-ref ref="EventLogger"/>
> > + <AppenderRef ref="EventLogger"/>
> > </logger>>
> >
> > <logger name="org.apache.logging.log4j.test2" level="debug"
> additivity="false">
> > - <appender-ref ref="File"/>
> > + <AppenderRef ref="File"/>
> > </logger>>
> >
> > <root level="trace">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </root>
> > </loggers>
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
> (original)
> > +++
> logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
> Wed Aug 14 20:05:54 2013
> > @@ -24,22 +24,23 @@ import static org.junit.Assert.assertTru
> > import java.util.Date;
> > import java.util.List;
> >
> > -import ch.qos.logback.classic.joran.JoranConfigurator;
> > -import ch.qos.logback.classic.spi.ILoggingEvent;
> > -import ch.qos.logback.core.joran.spi.JoranException;
> > import org.apache.logging.log4j.LogManager;
> > import org.apache.logging.log4j.Logger;
> > import org.apache.logging.log4j.ThreadContext;
> > import org.apache.logging.log4j.message.MessageFactory;
> > import org.apache.logging.log4j.message.ParameterizedMessageFactory;
> > import org.apache.logging.log4j.message.StringFormatterMessageFactory;
> > -import ch.qos.logback.core.testUtil.StringListAppender;
> > -import ch.qos.logback.classic.LoggerContext;
> > import org.junit.Before;
> > import org.junit.BeforeClass;
> > import org.junit.Test;
> > import org.slf4j.LoggerFactory;
> >
> > +import ch.qos.logback.classic.LoggerContext;
> > +import ch.qos.logback.classic.joran.JoranConfigurator;
> > +import ch.qos.logback.classic.spi.ILoggingEvent;
> > +import ch.qos.logback.core.joran.spi.JoranException;
> > +import ch.qos.logback.core.testUtil.StringListAppender;
> > +
> > /**
> > *
> > */
> > @@ -74,6 +75,8 @@ public class LoggerTest {
> >
> > @Before
> > public void before() {
> > + assertNotNull(list);
> > + assertNotNull(list.strList);
> > list.strList.clear();
> > }
> >
> >
> > Modified:
> logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml
> Wed Aug 14 20:05:54 2013
> > @@ -27,13 +27,13 @@
> > </appenders>
> > <loggers>
> > <logger name="org.apache.test.logging" level="debug"
> additivity="false">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </logger>
> > <logger name="org.apache.test" level="trace" additivity="false">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </logger>
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>
> > \ No newline at end of file
> >
> > Modified:
> logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml
> Wed Aug 14 20:05:54 2013
> > @@ -40,10 +40,10 @@
> > </appenders>
> > <loggers>
> > <logger name="EventLogger" level="WARN" additivity="false">
> > - <appender-ref ref="flume" />
> > + <AppenderRef ref="flume" />
> > </logger>
> > <root level="debug">
> > - <appender-ref ref="RollingFile" />
> > + <AppenderRef ref="RollingFile" />
> > </root>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml
> Wed Aug 14 20:05:54 2013
> > @@ -40,10 +40,10 @@
> > </appenders>
> > <loggers>
> > <logger name="EventLogger" level="WARN" additivity="false">
> > - <appender-ref ref="flume" />
> > + <AppenderRef ref="flume" />
> > </logger>
> > <root level="debug">
> > - <appender-ref ref="RollingFile" />
> > + <AppenderRef ref="RollingFile" />
> > </root>
> > </loggers>
> > </configuration>
> >
> > Modified:
> logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml
> (original)
> > +++
> logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml
> Wed Aug 14 20:05:54 2013
> > @@ -25,15 +25,15 @@
> >
> > <loggers>
> > <logger name="EventLogger" level="info" additivity="false">
> > - <appender-ref ref="EventLogger"/>
> > + <AppenderRef ref="EventLogger"/>
> > </logger>>
> >
> > <logger name="org.apache.logging.log4j.test2" level="debug"
> additivity="false">
> > - <appender-ref ref="File"/>
> > + <AppenderRef ref="File"/>
> > </logger>>
> >
> > <root level="trace">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </root>
> > </loggers>
> >
> >
> > Modified: logging/log4j/log4j2/trunk/src/changes/changes.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/changes/changes.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/src/changes/changes.xml (original)
> > +++ logging/log4j/log4j2/trunk/src/changes/changes.xml Wed Aug 14
> 20:05:54 2013
> > @@ -432,7 +432,7 @@
> > The blocking parameter did not work properly on AsynchAppender.
> > </action>
> > <action issue="LOG4J2-188" dev="rgoers" type="fix" due-to="Werner">
> > - appender-refs on AsynchAppender didn't support the level and
> filter elements.
> > + AppenderRefs on AsynchAppender didn't support the level and
> filter elements.
> > </action>
> > <action issue="LOG4J2-176" dev="rgoers" type="fix" due-to="Remko
> Popma">
> > Avoid IllegalArgumentException in AsynchAppender.
> > @@ -797,7 +797,7 @@
> > </release>
> > <release version="2.0-alpha1" date="2012-07-29" description="Rewrite
> of Log4j">
> > <action issue="LOG4J2-60" dev="rgoers" type="add" due-to="Shane
> Kelly">
> > - Added ability to filter on the appender-ref by adding either a
> level or a filter.
> > + Added ability to filter on the AppenderRef by adding either a
> level or a filter.
> > </action>
> > <action issue="LOG4J2-56" dev="rgoers" type="fix" due-to="John
> Owen Atala">
> > Level.toLevel would throw an IllegalArgumentException instead of
> returning the default value.
> >
> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml Wed
> Aug 14 20:05:54 2013
> > @@ -59,9 +59,9 @@
> > <th>Description</th>
> > </tr>
> > <tr>
> > - <td>appender-ref</td>
> > + <td>AppenderRef</td>
> > <td>String</td>
> > - <td>The name of the Appenders to invoke asynchronously.
> Multiple appender-ref
> > + <td>The name of the Appenders to invoke asynchronously.
> Multiple AppenderRef
> > elements can be configured.</td>
> > </tr>
> > <tr>
> > @@ -122,12 +122,12 @@
> > </PatternLayout>
> > </File>
> > <Async name="Async">
> > - <appender-ref ref="MyFile"/>
> > + <AppenderRef ref="MyFile"/>
> > </Async>
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="Async"/>
> > + <AppenderRef ref="Async"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -196,7 +196,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -271,13 +271,13 @@
> > </Console>
> > <Failover name="Failover" primary="RollingFile">
> > <Failovers>
> > - <appender-ref ref="Console"/>
> > + <AppenderRef ref="Console"/>
> > </Failovers>
> > </Failover>
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="Failover"/>
> > + <AppenderRef ref="Failover"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -387,7 +387,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="MyFile"/>
> > + <AppenderRef ref="MyFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -588,7 +588,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingRandomAccessFile"/>
> > + <AppenderRef ref="RollingRandomAccessFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -613,7 +613,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingRandomAccessFile"/>
> > + <AppenderRef ref="RollingRandomAccessFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -647,7 +647,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingRandomAccessFile"/>
> > + <AppenderRef ref="RollingRandomAccessFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -749,7 +749,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="MyFile"/>
> > + <AppenderRef ref="MyFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -927,7 +927,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="eventLogger"/>
> > + <AppenderRef ref="eventLogger"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -948,7 +948,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="eventLogger"/>
> > + <AppenderRef ref="eventLogger"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -972,10 +972,10 @@
> > </appenders>
> > <loggers>
> > <logger name="EventLogger" level="info">
> > - <appender-ref ref="eventLogger"/>
> > + <AppenderRef ref="eventLogger"/>
> > </logger>
> > <root level="warn">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1016,10 +1016,10 @@
> > </appenders>
> > <loggers>
> > <logger name="EventLogger" level="info">
> > - <appender-ref ref="eventLogger"/>
> > + <AppenderRef ref="eventLogger"/>
> > </logger>
> > <root level="warn">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1216,7 +1216,7 @@
> > </appenders>
> > <loggers>
> > <root level="warn">
> > - <appender-ref ref="databaseAppender"/>
> > + <AppenderRef ref="databaseAppender"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1235,7 +1235,7 @@
> > </appenders>
> > <loggers>
> > <root level="warn">
> > - <appender-ref ref="databaseAppender"/>
> > + <AppenderRef ref="databaseAppender"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1255,7 +1255,7 @@
> > </appenders>
> > <loggers>
> > <root level="warn">
> > - <appender-ref ref="databaseAppender"/>
> > + <AppenderRef ref="databaseAppender"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1365,7 +1365,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="jmsQueue"/>
> > + <AppenderRef ref="jmsQueue"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1476,7 +1476,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="jmsQueue"/>
> > + <AppenderRef ref="jmsQueue"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1552,7 +1552,7 @@
> > </appenders>
> > <loggers>
> > <root level="warn">
> > - <appender-ref ref="databaseAppender"/>
> > + <AppenderRef ref="databaseAppender"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1806,7 +1806,7 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <root level="warn">
> > - <appender-ref ref="databaseAppender"/>
> > + <AppenderRef ref="databaseAppender"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1821,7 +1821,7 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <root level="warn">
> > - <appender-ref ref="databaseAppender"/>
> > + <AppenderRef ref="databaseAppender"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1836,7 +1836,7 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <root level="warn">
> > - <appender-ref ref="databaseAppender"/>
> > + <AppenderRef ref="databaseAppender"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -1919,9 +1919,9 @@ public class JpaLogEntity extends Abstra
> > <th>Description</th>
> > </tr>
> > <tr>
> > - <td>appender-ref</td>
> > + <td>AppenderRef</td>
> > <td>String</td>
> > - <td>The name of the Appenders to call after the LogEvent
> has been manipulated. Multiple appender-ref
> > + <td>The name of the Appenders to call after the LogEvent
> has been manipulated. Multiple AppenderRef
> > elements can be configured.</td>
> > </tr>
> > <tr>
> > @@ -1989,7 +1989,7 @@ public class JpaLogEntity extends Abstra
> > <PatternLayout pattern="%m%n"/>
> > </Console>
> > <Rewrite name="rewrite">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > <MapRewritePolicy mode="Add">
> > <KeyValuePair key="product" value="TestProduct"/>
> > </MapRewritePolicy>
> > @@ -1997,7 +1997,7 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="Rewrite"/>
> > + <AppenderRef ref="Rewrite"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -2032,7 +2032,7 @@ public class JpaLogEntity extends Abstra
> > <PatternLayout pattern="%m%n"/>
> > </Console>
> > <Rewrite name="rewrite">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > <PropertiesRewritePolicy>
> > <Property key="user">${sys:user.name}</Property>
> > <Property key="env">${sys:environment}</Property>
> > @@ -2041,7 +2041,7 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="Rewrite"/>
> > + <AppenderRef ref="Rewrite"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -2357,7 +2357,7 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -2381,7 +2381,7 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -2408,7 +2408,7 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -2468,7 +2468,7 @@ public class JpaLogEntity extends Abstra
> > can be configured as the default.
> > </p>
> > <p>
> > - Each Route must reference an Appender. If the Route
> contains an appender-ref attribute then the
> > + Each Route must reference an Appender. If the Route
> contains an AppenderRef attribute then the
> > Route will reference an Appender that was defined in the
> configuration. If the Route contains an
> > Appender definition then an Appender will be created
> within the context of the RoutingAppender and
> > will be reused each time a matching Appender name is
> referenced through a Route.
> > @@ -2498,13 +2498,13 @@ public class JpaLogEntity extends Abstra
> > <SizeBasedTriggeringPolicy size="500" />
> > </RollingFile>
> > </Route>
> > - <Route appender-ref="AuditLogger" key="Audit"/>
> > + <Route AppenderRef="AuditLogger" key="Audit"/>
> > </Routes>
> > </Routing>
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="Routing"/>
> > + <AppenderRef ref="Routing"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -2631,7 +2631,7 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="Mail"/>
> > + <AppenderRef ref="Mail"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -2722,7 +2722,7 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="socket"/>
> > + <AppenderRef ref="socket"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -2904,10 +2904,10 @@ public class JpaLogEntity extends Abstra
> > </appenders>
> > <loggers>
> > <logger name="com.mycorp" level="error">
> > - <appender-ref ref="RFC5424"/>
> > + <AppenderRef ref="RFC5424"/>
> > </logger>
> > <root level="error">
> > - <appender-ref ref="bsd"/>
> > + <AppenderRef ref="bsd"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> >
> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml (original)
> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml Wed Aug 14
> 20:05:54 2013
> > @@ -162,7 +162,7 @@
> > </appenders>
> > <loggers>
> > <root level="info" includeLocation="false">
> > - <appender-ref ref="RandomAccessFile"/>
> > + <AppenderRef ref="RandomAccessFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -360,10 +360,10 @@
> > <loggers>
> > <!-- pattern layout actually uses location, so we need to include it
> -->
> > <asyncLogger name="com.foo.Bar" level="trace" includeLocation="true">
> > - <appender-ref ref="RandomAccessFile"/>
> > + <AppenderRef ref="RandomAccessFile"/>
> > </asyncLogger>
> > <root level="info" includeLocation="true">
> > - <appender-ref ref="RandomAccessFile"/>
> > + <AppenderRef ref="RandomAccessFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> >
> > Modified:
> logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm
> (original)
> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm
> Wed Aug 14 20:05:54 2013
> > @@ -161,7 +161,7 @@ public class Bar {
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="Console"/>
> > + <AppenderRef ref="Console"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -186,7 +186,7 @@ public class Bar {
> > <pre class="prettyprint linenums"><![CDATA[
> > <logger name="com.foo.Bar" level="TRACE"/>
> > <root level="ERROR">
> > - <appender-ref ref="STDOUT">
> > + <AppenderRef ref="STDOUT">
> > </root>]]></pre>
> > <p>
> > With this configuration all log events from
> <code>com.foo.Bar</code> will be recorded while only error events will
> > @@ -210,10 +210,10 @@ public class Bar {
> > </appenders>
> > <loggers>
> > <logger name="com.foo.Bar" level="trace">
> > - <appender-ref ref="Console"/>
> > + <AppenderRef ref="Console"/>
> > </logger>
> > <root level="error">
> > - <appender-ref ref="Console"/>
> > + <AppenderRef ref="Console"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -242,10 +242,10 @@ public class Bar {
> > </appenders>
> > <loggers>
> > <logger name="com.foo.Bar" level="trace" additivity="false">
> > - <appender-ref ref="Console"/>
> > + <AppenderRef ref="Console"/>
> > </logger>
> > <root level="error">
> > - <appender-ref ref="Console"/>
> > + <AppenderRef ref="Console"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -408,7 +408,7 @@ public class Bar {
> > </logger>
> > ...
> > <root level="level">
> > - <appender-ref ref="name"/>
> > + <AppenderRef ref="name"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -443,7 +443,7 @@ public class Bar {
> > </logger>
> > ...
> > <root level="level">
> > - <appender-ref ref="name"/>
> > + <AppenderRef ref="name"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -488,15 +488,15 @@ public class Bar {
> > <filter type="ThreadContextMapFilter">
> > <KeyValuePair key="test" value="123"/>
> > </filter>
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </logger>>
> >
> > <logger name="org.apache.logging.log4j.test2" level="debug"
> additivity="false">
> > - <appender-ref ref="File"/>
> > + <AppenderRef ref="File"/>
> > </logger>>
> >
> > <root level="trace">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </root>
> > </loggers>
> >
> > @@ -537,16 +537,16 @@ public class Bar {
> > "SizeBasedTriggeringPolicy": { "size": "500" }
> > }
> > },
> > - { "appender-ref": "STDOUT", "key": "Audit"},
> > - { "appender-ref": "List", "key": "Service"}
> > + { "AppenderRef": "STDOUT", "key": "Audit"},
> > + { "AppenderRef": "List", "key": "Service"}
> > ]
> > }
> > }
> > },
> > "loggers": {
> > "logger": { "name": "EventLogger", "level": "info", "additivity":
> "false",
> > - "appender-ref": { "ref": "Routing" }},
> > - "root": { "level": "error", "appender-ref": { "ref": "STDOUT" }}
> > + "AppenderRef": { "ref": "Routing" }},
> > + "root": { "level": "error", "AppenderRef": { "ref": "STDOUT" }}
> > }
> > }
> > }</pre>
> > @@ -580,8 +580,8 @@ public class Bar {
> > "SizeBasedTriggeringPolicy": { "size": "500" }
> > }
> > },
> > - { "appender-ref": "STDOUT", "key": "Audit"},
> > - { "appender-ref": "List", "key": "Service"}
> > + { "AppenderRef": "STDOUT", "key": "Audit"},
> > + { "AppenderRef": "List", "key": "Service"}
> > ]
> > }
> > }
> > @@ -590,11 +590,11 @@ public class Bar {
> > "loggers": {
> > "logger": [
> > { "name": "EventLogger", "level": "info", "additivity": "false",
> > - "appender-ref": { "ref": "Routing" }},
> > + "AppenderRef": { "ref": "Routing" }},
> > { "name": "com.foo.bar", "level": "error", "additivity": "false",
> > - "appender-ref": { "ref": "Console" }}
> > + "AppenderRef": { "ref": "Console" }}
> > ],
> > - "root": { "level": "error", "appender-ref": { "ref": "STDOUT" }}
> > + "root": { "level": "error", "AppenderRef": { "ref": "STDOUT" }}
> > }
> > }
> > }</pre>
> > @@ -638,7 +638,7 @@ public class Bar {
> > using variables.
> > </p>
> > <p>
> > - The LoggerConfig may also be configured with one or more
> appender-ref elements. Each appender
> > + The LoggerConfig may also be configured with one or more
> AppenderRef elements. Each appender
> > referenced will become associated with the specified
> LoggerConfig. If multiple appenders
> > are configured on the LoggerConfig each of them be called
> when processing logging events.
> > </p>
> > @@ -718,21 +718,21 @@ public class Bar {
> > <ThreadContextMapFilter>
> > <KeyValuePair key="test" value="123"/>
> > </ThreadContextMapFilter>
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </logger>>
> >
> > <logger name="org.apache.logging.log4j.test2" level="debug"
> additivity="false">
> > <property name="user">${dollar}{sys:user.name}</property>
> > - <appender-ref ref="File">
> > + <AppenderRef ref="File">
> > <ThreadContextMapFilter>
> > <KeyValuePair key="test" value="123"/>
> > </ThreadContextMapFilter>
> > - </appender-ref>
> > - <appender-ref ref="STDOUT" level="error"/>
> > + </AppenderRef>
> > + <AppenderRef ref="STDOUT" level="error"/>
> > </logger>>
> >
> > <root level="trace">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </root>
> > </loggers>
> >
> > @@ -776,19 +776,19 @@ public class Bar {
> > <SizeBasedTriggeringPolicy size="500" />
> > </RollingFile>
> > </Route>
> > - <Route appender-ref="STDOUT" key="Audit"/>
> > - <Route appender-ref="List" key="Service"/>
> > + <Route AppenderRef="STDOUT" key="Audit"/>
> > + <Route AppenderRef="List" key="Service"/>
> > </Routes>
> > </Routing>
> > </appenders>
> >
> > <loggers>
> > <logger name="EventLogger" level="info" additivity="false">
> > - <appender-ref ref="Routing"/>
> > + <AppenderRef ref="Routing"/>
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> > @@ -916,19 +916,19 @@ public class Bar {
> > <SizeBasedTriggeringPolicy size="500" />
> > </RollingFile>
> > </Route>
> > - <Route appender-ref="STDOUT" key="Audit"/>
> > - <Route appender-ref="List" key="Service"/>
> > + <Route AppenderRef="STDOUT" key="Audit"/>
> > + <Route AppenderRef="List" key="Service"/>
> > </Routes>
> > </Routing>
> > </appenders>
> >
> > <loggers>
> > <logger name="EventLogger" level="info" additivity="false">
> > - <appender-ref ref="Routing"/>
> > + <AppenderRef ref="Routing"/>
> > </logger>
> >
> > <root level="error">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> >
> > @@ -961,11 +961,11 @@ public class Bar {
> > appender.ListAppender for element List with params(name="List",
> entryPerNewLine="null",
> > raw="null", null, ThresholdFilter(DEBUG))
> > 2011-11-23 17:08:00,813 DEBUG Calling createRoute on class
> org.apache.logging.log4j.core.appender.
> > - routing.Route for element Route with params(appender-ref="null",
> key="null", Node=Route)
> > + routing.Route for element Route with params(AppenderRef="null",
> key="null", Node=Route)
> > 2011-11-23 17:08:00,823 DEBUG Calling createRoute on class
> org.apache.logging.log4j.core.appender.
> > - routing.Route for element Route with
> params(appender-ref="STDOUT", key="Audit", Node=Route)
> > + routing.Route for element Route with
> params(AppenderRef="STDOUT", key="Audit", Node=Route)
> > 2011-11-23 17:08:00,824 DEBUG Calling createRoute on class
> org.apache.logging.log4j.core.appender.
> > - routing.Route for element Route with params(appender-ref="List",
> key="Service", Node=Route)
> > + routing.Route for element Route with params(AppenderRef="List",
> key="Service", Node=Route)
> > 2011-11-23 17:08:00,825 DEBUG Calling createRoutes on class
> org.apache.logging.log4j.core.appender.
> > routing.Routes for element Routes with
> params(pattern="${dollar}{sd:type}",
> > routes={Route(type=dynamic default), Route(type=static
> Reference=STDOUT key='Audit'),
> > @@ -978,16 +978,16 @@ public class Bar {
> > 2011-11-23 17:08:00,827 DEBUG Calling createAppenders on class
> org.apache.logging.log4j.core.config.
> > plugins.AppendersPlugin for element appenders with
> params(appenders={STDOUT, List, Routing})
> > 2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class
> org.apache.logging.log4j.core.
> > - config.plugins.AppenderRefPlugin for element appender-ref with
> params(ref="Routing")
> > + config.plugins.AppenderRefPlugin for element AppenderRef with
> params(ref="Routing")
> > 2011-11-23 17:08:00,829 DEBUG Calling createLogger on class
> org.apache.logging.log4j.core.config.
> > LoggerConfig for element logger with params(additivity="false",
> level="info", name="EventLogger",
> > - appender-ref={Routing}, null)
> > + AppenderRef={Routing}, null)
> > 2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class
> org.apache.logging.log4j.core.
> > - config.plugins.AppenderRefPlugin for element appender-ref with
> params(ref="STDOUT")</pre>
> > + config.plugins.AppenderRefPlugin for element AppenderRef with
> params(ref="STDOUT")</pre>
> > <pre class="prettyprint linenums">
> > 2011-11-23 17:08:00,831 DEBUG Calling createLogger on class
> org.apache.logging.log4j.core.config.
> > LoggerConfig$RootLogger for element root with
> params(additivity="null", level="error",
> > - appender-ref={STDOUT}, null)
> > + AppenderRef={STDOUT}, null)
> > 2011-11-23 17:08:00,833 DEBUG Calling createLoggers on class
> org.apache.logging.log4j.core.
> > config.plugins.LoggersPlugin for element loggers with
> params(loggers={EventLogger, root})
> > 2011-11-23 17:08:00,834 DEBUG Reconfiguration completed
> > @@ -1024,16 +1024,16 @@ public class Bar {
> > 2011-11-23 17:08:00,804 DEBUG Calling createAppender on class
> org.apache.logging.log4j.core.appender.ConsoleAppender for element Console
> with params(PatternLayout(%m%n), null, target="null", name="STDOUT",
> ignoreExceptions="null")
> > 2011-11-23 17:08:00,804 DEBUG Calling createFilter on class
> org.apache.logging.log4j.core.filter.ThresholdFilter for element
> ThresholdFilter with params(level="debug", onMatch="null",
> onMismatch="null")
> > 2011-11-23 17:08:00,806 DEBUG Calling createAppender on class
> org.apache.logging.log4j.test.appender.ListAppender for element List with
> params(name="List", entryPerNewLine="null", raw="null", null,
> ThresholdFilter(DEBUG))
> > -2011-11-23 17:08:00,813 DEBUG Calling createRoute on class
> org.apache.logging.log4j.core.appender.routing.Route for element Route with
> params(appender-ref="null", key="null", Node=Route)
> > -2011-11-23 17:08:00,823 DEBUG Calling createRoute on class
> org.apache.logging.log4j.core.appender.routing.Route for element Route with
> params(appender-ref="STDOUT", key="Audit", Node=Route)
> > -2011-11-23 17:08:00,824 DEBUG Calling createRoute on class
> org.apache.logging.log4j.core.appender.routing.Route for element Route with
> params(appender-ref="List", key="Service", Node=Route)
> > +2011-11-23 17:08:00,813 DEBUG Calling createRoute on class
> org.apache.logging.log4j.core.appender.routing.Route for element Route with
> params(AppenderRef="null", key="null", Node=Route)
> > +2011-11-23 17:08:00,823 DEBUG Calling createRoute on class
> org.apache.logging.log4j.core.appender.routing.Route for element Route with
> params(AppenderRef="STDOUT", key="Audit", Node=Route)
> > +2011-11-23 17:08:00,824 DEBUG Calling createRoute on class
> org.apache.logging.log4j.core.appender.routing.Route for element Route with
> params(AppenderRef="List", key="Service", Node=Route)
> > 2011-11-23 17:08:00,825 DEBUG Calling createRoutes on class
> org.apache.logging.log4j.core.appender.routing.Routes for element Routes
> with params(pattern="${dollar}{sd:type}", routes={Route(type=dynamic
> default), Route(type=static Reference=STDOUT key='Audit'),
> Route(type=static Reference=List key='Service')})
> > 2011-11-23 17:08:00,827 DEBUG Calling createAppender on class
> org.apache.logging.log4j.core.appender.routing.RoutingAppender for element
> Routing with params(name="Routing", ignoreExceptions="null",
> Routes({Route(type=dynamic default),Route(type=static Reference=STDOUT
> key='Audit'),Route(type=static Reference=List key='Service')}),
> Configuration(RoutingTest), null, null)
> > 2011-11-23 17:08:00,827 DEBUG Calling createAppenders on class
> org.apache.logging.log4j.core.config.plugins.AppendersPlugin for element
> appenders with params(appenders={STDOUT, List, Routing})
> > -2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class
> org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element
> appender-ref with params(ref="Routing")
> > -2011-11-23 17:08:00,829 DEBUG Calling createLogger on class
> org.apache.logging.log4j.core.config.LoggerConfig for element logger with
> params(additivity="false", level="info", name="EventLogger",
> appender-ref={Routing}, null)
> > -2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class
> org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element
> appender-ref with params(ref="STDOUT")
> > -2011-11-23 17:08:00,831 DEBUG Calling createLogger on class
> org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element
> root with params(additivity="null", level="error", appender-ref={STDOUT},
> null)
> > +2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class
> org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element
> AppenderRef with params(ref="Routing")
> > +2011-11-23 17:08:00,829 DEBUG Calling createLogger on class
> org.apache.logging.log4j.core.config.LoggerConfig for element logger with
> params(additivity="false", level="info", name="EventLogger",
> AppenderRef={Routing}, null)
> > +2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class
> org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element
> AppenderRef with params(ref="STDOUT")
> > +2011-11-23 17:08:00,831 DEBUG Calling createLogger on class
> org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element
> root with params(additivity="null", level="error", AppenderRef={STDOUT},
> null)
> > 2011-11-23 17:08:00,833 DEBUG Calling createLoggers on class
> org.apache.logging.log4j.core.config.plugins.LoggersPlugin for element
> loggers with params(loggers={EventLogger, root})
> > 2011-11-23 17:08:00,834 DEBUG Reconfiguration completed
> > 2011-11-23 17:08:00,846 DEBUG Calling createLayout on class
> org.apache.logging.log4j.core.layout.PatternLayout for element
> PatternLayout with params(pattern="%d %p %c{1.} [%t] %m%n",
> Configuration(RoutingTest), null, charset="null")
> > @@ -1053,7 +1053,7 @@ public class Bar {
> > makes troubleshooting configuration errors possible. As an
> example, if the configuration above is changed
> > to have the status set to error and the logger declaration
> is:</p>
> > <pre class="prettyprint linenums"><![CDATA[<logger name="EventLogger"
> level="info" additivity="false">
> > - <appender-ref ref="Routng"/>
> > + <AppenderRef ref="Routng"/>
> > </logger>]]></pre>
> > <p>
> > the following error message will be produced.
> >
> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml Wed
> Aug 14 20:05:54 2013
> > @@ -143,7 +143,7 @@ public static class RootLogger extends L
> > @PluginFactory
> > public static LoggerConfig createLogger(@PluginAttr("additivity")
> String additivity,
> > @PluginAttr("level") String
> loggerLevel,
> > -
> @PluginElement("appender-ref") AppenderRef[] refs,
> > +
> @PluginElement("AppenderRef") AppenderRef[] refs,
> > @PluginElement("filters")
> Filter filter) {
> > List<AppenderRef> appenderRefs = Arrays.asList(refs);
> > Level level;
> >
> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml Wed Aug
> 14 20:05:54 2013
> > @@ -109,7 +109,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -151,10 +151,10 @@
> > </appenders>
> > <loggers>
> > <logger name="EventLogger" level="info">
> > - <appender-ref ref="Audit"/>
> > + <AppenderRef ref="Audit"/>
> > </logger>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -220,7 +220,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -284,7 +284,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -311,8 +311,8 @@
> > <KeyValuePair key="eventId" value="Login"/>
> > <KeyValuePair key="eventId" value="Logout"/>
> > </MapFilter>
> > - <appender-ref ref="RollingFile">
> > - </appender-ref>
> > + <AppenderRef ref="RollingFile">
> > + </AppenderRef>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -335,12 +335,12 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile">
> > + <AppenderRef ref="RollingFile">
> > <MapFilter onMatch="ACCEPT" onMismatch="NEUTRAL" operator="or">
> > <KeyValuePair key="eventId" value="Login"/>
> > <KeyValuePair key="eventId" value="Logout"/>
> > </MapFilter>
> > - </appender-ref>
> > + </AppenderRef>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -396,7 +396,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -456,7 +456,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -523,7 +523,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -587,7 +587,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -608,7 +608,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > <ThreadContextMapFilter onMatch="ACCEPT" onMismatch="NEUTRAL"
> operator="or">
> > <KeyValuePair key="foo" value="bar"/>
> > <KeyValuePair key="User2" value="WARN"/>
> > @@ -670,7 +670,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -740,7 +740,7 @@
> > </appenders>
> > <loggers>
> > <root level="error">
> > - <appender-ref ref="RollingFile"/>
> > + <AppenderRef ref="RollingFile"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> >
> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml Wed
> Aug 14 20:05:54 2013
> > @@ -154,7 +154,7 @@ public class App {
> > </appenders>
> > <loggers>
> > <root level="trace">
> > - <appender-ref ref="log"/>
> > + <AppenderRef ref="log"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> >
> > Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml Wed
> Aug 14 20:05:54 2013
> > @@ -81,7 +81,7 @@
> > </category>
> > <root>
> > <priority value ="debug" />
> > - <appender-ref ref="STDOUT" />
> > + <AppenderRef ref="STDOUT" />
> > </root>
> > </log4j:configuration>]]></pre>
> > <p>Log4j 2 XML configuration</p>
> > @@ -95,7 +95,7 @@
> > <loggers>
> > <logger name="org.apache.log4j.xml" level="info"/>
> > <root level="debug">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -119,11 +119,11 @@
> > </appender>
> > <category name="org.apache.log4j.xml">
> > <priority value="debug" />
> > - <appender-ref ref="A1" />
> > + <AppenderRef ref="A1" />
> > </category>
> > <root>
> > <priority value ="debug" />
> > - <appender-ref ref="STDOUT" />
> > + <AppenderRef ref="STDOUT" />
> > </root>
> > </log4j:configuration>]]></pre>
> >
> > @@ -140,10 +140,10 @@
> > </appenders>
> > <loggers>
> > <logger name="org.apache.log4j.xml" level="debug">
> > - <appender-ref ref="A1"/>
> > + <AppenderRef ref="A1"/>
> > </logger>
> > <root level="debug">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -169,11 +169,11 @@
> > </appender>
> > <category name="org.apache.log4j.xml">
> > <priority value="debug"/>
> > - <appender-ref ref="A1"/>
> > + <AppenderRef ref="A1"/>
> > </category>
> > <root>
> > <priority value="debug"/>
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </log4j:configuration>]]></pre>
> >
> > @@ -190,10 +190,10 @@
> > </appenders>
> > <loggers>
> > <logger name="org.apache.log4j.xml" level="debug">
> > - <appender-ref ref="A1"/>
> > + <AppenderRef ref="A1"/>
> > </logger>
> > <root level="debug">
> > - <appender-ref ref="STDOUT"/>
> > + <AppenderRef ref="STDOUT"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -204,7 +204,7 @@
> > <!DOCTYPE log4j:configuration PUBLIC "-//APACHE//DTD LOG4J 1.2//EN"
> "log4j.dtd">
> > <log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/"
> configDebug="true">
> > <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
> > - <appender-ref ref="TEMP"/>
> > + <AppenderRef ref="TEMP"/>
> > </appender>
> > <appender name="TEMP" class="org.apache.log4j.FileAppender">
> > <param name="File" value="temp"/>
> > @@ -214,7 +214,7 @@
> > </appender>
> > <root>
> > <priority value="debug"/>
> > - <appender-ref ref="ASYNC"/>
> > + <AppenderRef ref="ASYNC"/>
> > </root>
> > </log4j:configuration>]]></pre>
> >
> > @@ -226,12 +226,12 @@
> > <PatternLayout pattern="%d %-5p [%t] %C{2} (%F:%L) - %m%n"/>
> > </File>
> > <Async name="ASYNC">
> > - <appender-ref ref="TEMP"/>
> > + <AppenderRef ref="TEMP"/>
> > </Async>
> > </appenders>
> > <loggers>
> > <root level="debug">
> > - <appender-ref ref="ASYNC"/>
> > + <AppenderRef ref="ASYNC"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> > @@ -243,8 +243,8 @@
> > <!DOCTYPE log4j:configuration PUBLIC "-//APACHE//DTD LOG4J 1.2//EN"
> "log4j.dtd">
> > <log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/"
> configDebug="true">
> > <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
> > - <appender-ref ref="TEMP"/>
> > - <appender-ref ref="CONSOLE"/>
> > + <AppenderRef ref="TEMP"/>
> > + <AppenderRef ref="CONSOLE"/>
> > </appender>
> > <appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender">
> > <layout class="org.apache.log4j.PatternLayout">
> > @@ -259,7 +259,7 @@
> > </appender>
> > <root>
> > <priority value="debug"/>
> > - <appender-ref ref="ASYNC"/>
> > + <AppenderRef ref="ASYNC"/>
> > </root>
> > </log4j:configuration>]]></pre>
> >
> > @@ -275,13 +275,13 @@
> > <PatternLayout pattern="%d %-5p [%t] %C{2} (%F:%L) - %m%n"/>
> > </File>
> > <Async name="ASYNC">
> > - <appender-ref ref="TEMP"/>
> > - <appender-ref ref="CONSOLE"/>
> > + <AppenderRef ref="TEMP"/>
> > + <AppenderRef ref="CONSOLE"/>
> > </Async>
> > </appenders>
> > <loggers>
> > <root level="debug">
> > - <appender-ref ref="ASYNC"/>
> > + <AppenderRef ref="ASYNC"/>
> > </root>
> > </loggers>
> > </configuration>]]></pre>
> >
> > Modified:
> logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> >
> ==============================================================================
> > --- logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml
> (original)
> > +++ logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml
> Wed Aug 14 20:05:54 2013
> > @@ -24,15 +24,15 @@
> >
> > <loggers>
> > <logger name="EventLogger" level="info" additivity="false">
> > - <appender-ref ref="EventLogger"/>
> > + <AppenderRef ref="EventLogger"/>
> > </logger>>
> >
> > <logger name="org.apache.logging.log4j.test2" level="debug"
> additivity="false">
> > - <appender-ref ref="File"/>
> > + <AppenderRef ref="File"/>
> > </logger>>
> >
> > <root level="trace">
> > - <appender-ref ref="List"/>
> > + <AppenderRef ref="List"/>
> > </root>
> >
> > <logger name="IfEnabledTagTest" level="warn" />
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1514021 [2/2] - in /logging/log4j/log4j2/trunk: core/src/main/java/org/apache/logging/log4j/core/appender/ core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ core/src/main/java/org/apache/logging/log4j/core/async/ core/src/...
Posted by Ralph Goers <ra...@dslextreme.com>.
Now that I see this it kind of scares me. Log4j 1.x and Logback both use appender-ref. Anyone using Log4j 2 will now be broken.
On Aug 14, 2013, at 1:05 PM, ggregory@apache.org wrote:
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-config.xml Wed Aug 14 20:05:54 2013
> @@ -30,10 +30,10 @@
> </appenders>
> <loggers>
> <logger name="org.apache.test" level="trace" additivity="false">
> - <appender-ref ref="List"/>
> + <AppenderRef ref="List"/>
> </logger>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-default.xml Wed Aug 14 20:05:54 2013
> @@ -25,7 +25,7 @@
> <loggers>
> <logger name="org.foo" level="DEBUG" />
> <root level="TRACE">
> - <appender-ref ref="Console" />
> + <AppenderRef ref="Console" />
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight-logback.xml Wed Aug 14 20:05:54 2013
> @@ -25,7 +25,7 @@
> <loggers>
> <logger name="org.foo" level="DEBUG" />
> <root level="TRACE">
> - <appender-ref ref="Console" />
> + <AppenderRef ref="Console" />
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-highlight.xml Wed Aug 14 20:05:54 2013
> @@ -25,7 +25,7 @@
> <loggers>
> <logger name="org.foo" level="DEBUG" />
> <root level="TRACE">
> - <appender-ref ref="Console" />
> + <AppenderRef ref="Console" />
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-ansi.xml Wed Aug 14 20:05:54 2013
> @@ -25,7 +25,7 @@
> <loggers>
> <logger name="org.foo" level="DEBUG" />
> <root level="TRACE">
> - <appender-ref ref="Console" />
> + <AppenderRef ref="Console" />
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console-style-name-ansi.xml Wed Aug 14 20:05:54 2013
> @@ -25,7 +25,7 @@
> <loggers>
> <logger name="org.foo" level="DEBUG" />
> <root level="TRACE">
> - <appender-ref ref="Console" />
> + <AppenderRef ref="Console" />
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-console.xml Wed Aug 14 20:05:54 2013
> @@ -25,7 +25,7 @@
> <loggers>
> <logger name="org.foo" level="DEBUG" />
> <root level="TRACE">
> - <appender-ref ref="Console" />
> + <AppenderRef ref="Console" />
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-dynamicfilter.xml Wed Aug 14 20:05:54 2013
> @@ -27,7 +27,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-mapfilter.xml Wed Aug 14 20:05:54 2013
> @@ -28,7 +28,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="LIST"/>
> + <AppenderRef ref="LIST"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf-filter.xml Wed Aug 14 20:05:54 2013
> @@ -30,7 +30,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="TestLogfile"/>
> + <AppenderRef ref="TestLogfile"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf.xml Wed Aug 14 20:05:54 2013
> @@ -26,7 +26,7 @@
> </appenders>
> <loggers>
> <root level="debug">
> - <appender-ref ref="TestLogfile"/>
> + <AppenderRef ref="TestLogfile"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-perf2.xml Wed Aug 14 20:05:54 2013
> @@ -26,7 +26,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="TestLogfile"/>
> + <AppenderRef ref="TestLogfile"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/log4j2-sdfilter.xml Wed Aug 14 20:05:54 2013
> @@ -28,7 +28,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="LIST"/>
> + <AppenderRef ref="LIST"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-flume.xml Wed Aug 14 20:05:54 2013
> @@ -23,6 +23,6 @@
> </appender>
>
> <root level="error">
> - <appender-ref ref="Console" />
> + <AppenderRef ref="Console" />
> </root>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf-filter.xml Wed Aug 14 20:05:54 2013
> @@ -31,6 +31,6 @@
> </appender>
>
> <root level="error">
> - <appender-ref ref="TestLogfile" />
> + <AppenderRef ref="TestLogfile" />
> </root>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf.xml Wed Aug 14 20:05:54 2013
> @@ -25,6 +25,6 @@
> </appender>
>
> <root level="debug">
> - <appender-ref ref="TestLogfile" />
> + <AppenderRef ref="TestLogfile" />
> </root>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-perf2.xml Wed Aug 14 20:05:54 2013
> @@ -24,6 +24,6 @@
> </appender>
>
> <root level="error">
> - <appender-ref ref="TestLogfile" />
> + <AppenderRef ref="TestLogfile" />
> </root>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/logback-subst.xml Wed Aug 14 20:05:54 2013
> @@ -23,6 +23,6 @@
> </appender>
>
> <root level="debug">
> - <appender-ref ref="stdout" />
> + <AppenderRef ref="stdout" />
> </root>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/missingRootLogger.xml Wed Aug 14 20:05:54 2013
> @@ -11,11 +11,11 @@
> <loggers>
> <!--
> <root level="info" includeLocation="false">
> - <appender-ref ref="List"/>
> + <AppenderRef ref="List"/>
> </root>
> -->
> <logger name="sample" level="info" includeLocation="false">
> - <appender-ref ref="List"/>
> + <AppenderRef ref="List"/>
> </logger>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-data-source.xml Wed Aug 14 20:05:54 2013
> @@ -34,11 +34,11 @@
>
> <loggers>
> <logger name="org.apache.logging.log4j.core.appender.db" level="debug">
> - <appender-ref ref="databaseAppender" />
> + <AppenderRef ref="databaseAppender" />
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-driver-manager.xml Wed Aug 14 20:05:54 2013
> @@ -34,11 +34,11 @@
>
> <loggers>
> <logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
> - <appender-ref ref="databaseAppender" />
> + <AppenderRef ref="databaseAppender" />
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-h2-factory-method.xml Wed Aug 14 20:05:54 2013
> @@ -35,11 +35,11 @@
>
> <loggers>
> <logger name="org.apache.logging.log4j.core.appender.db" level="debug">
> - <appender-ref ref="databaseAppender" />
> + <AppenderRef ref="databaseAppender" />
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-driver-manager.xml Wed Aug 14 20:05:54 2013
> @@ -34,11 +34,11 @@
>
> <loggers>
> <logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
> - <appender-ref ref="databaseAppender" />
> + <AppenderRef ref="databaseAppender" />
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jdbc/log4j2-hsqldb-factory-method.xml Wed Aug 14 20:05:54 2013
> @@ -35,11 +35,11 @@
>
> <loggers>
> <logger name="org.apache.logging.log4j.core.appender.db" level="debug">
> - <appender-ref ref="databaseAppender" />
> + <AppenderRef ref="databaseAppender" />
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-base.xml Wed Aug 14 20:05:54 2013
> @@ -27,11 +27,11 @@
>
> <loggers>
> <logger name="org.apache.logging.log4j.core.appender.db" level="debug">
> - <appender-ref ref="databaseAppender" />
> + <AppenderRef ref="databaseAppender" />
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-h2-jpa-basic.xml Wed Aug 14 20:05:54 2013
> @@ -27,11 +27,11 @@
>
> <loggers>
> <logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
> - <appender-ref ref="databaseAppender" />
> + <AppenderRef ref="databaseAppender" />
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-base.xml Wed Aug 14 20:05:54 2013
> @@ -27,11 +27,11 @@
>
> <loggers>
> <logger name="org.apache.logging.log4j.core.appender.db" level="debug">
> - <appender-ref ref="databaseAppender" />
> + <AppenderRef ref="databaseAppender" />
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/org/apache/logging/log4j/core/appender/db/jpa/log4j2-hsqldb-jpa-basic.xml Wed Aug 14 20:05:54 2013
> @@ -27,11 +27,11 @@
>
> <loggers>
> <logger name="org.apache.logging.log4j.core.appender.db" level="debug" additivity="false">
> - <appender-ref ref="databaseAppender" />
> + <AppenderRef ref="databaseAppender" />
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12-async.xml Wed Aug 14 20:05:54 2013
> @@ -11,10 +11,10 @@
> </appender>
> <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
> <param name="BufferSize" value="262144"/>
> - <appender-ref ref="File"/>
> + <AppenderRef ref="File"/>
> </appender>
> <root>
> <priority value="debug" />
> - <appender-ref ref="ASYNC" />
> + <AppenderRef ref="ASYNC" />
> </root>
> </log4j:configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-log4j12.xml Wed Aug 14 20:05:54 2013
> @@ -11,6 +11,6 @@
> </appender>
> <root>
> <priority value="debug" />
> - <appender-ref ref="File" />
> + <AppenderRef ref="File" />
> </root>
> </log4j:configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback-async.xml Wed Aug 14 20:05:54 2013
> @@ -12,10 +12,10 @@
> <queueSize>262144</queueSize>
> <discardingThreshold>0</discardingThreshold>
> <includeCallerData>false</includeCallerData>
> - <appender-ref ref="FILE" />
> + <AppenderRef ref="FILE" />
> </appender>
>
> <root level="debug">
> - <appender-ref ref="ASYNC" />
> + <AppenderRef ref="ASYNC" />
> </root>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf-logback.xml Wed Aug 14 20:05:54 2013
> @@ -10,6 +10,6 @@
> </appender>
>
> <root level="debug">
> - <appender-ref ref="FILE" />
> + <AppenderRef ref="FILE" />
> </root>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFastFile.xml Wed Aug 14 20:05:54 2013
> @@ -9,7 +9,7 @@
> </appenders>
> <loggers>
> <root level="info" includeLocation="false">
> - <appender-ref ref="RandomAccessFile"/>
> + <AppenderRef ref="RandomAccessFile"/>
> </root>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf1syncFile.xml Wed Aug 14 20:05:54 2013
> @@ -9,7 +9,7 @@
> </appenders>
> <loggers>
> <root level="info" includeLocation="false">
> - <appender-ref ref="File"/>
> + <AppenderRef ref="File"/>
> </root>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFastFile.xml Wed Aug 14 20:05:54 2013
> @@ -14,7 +14,7 @@
> </appenders>
> <loggers>
> <root level="info" includeLocation="false">
> - <appender-ref ref="RollingRandomAccessFile"/>
> + <AppenderRef ref="RollingRandomAccessFile"/>
> </root>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf2syncRollFile.xml Wed Aug 14 20:05:54 2013
> @@ -14,7 +14,7 @@
> </appenders>
> <loggers>
> <root level="info" includeLocation="false">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf3PlainNoLoc.xml Wed Aug 14 20:05:54 2013
> @@ -9,7 +9,7 @@
> </appenders>
> <loggers>
> <root level="info" includeLocation="false">
> - <appender-ref ref="RandomAccessFile"/>
> + <AppenderRef ref="RandomAccessFile"/>
> </root>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf4PlainLocation.xml Wed Aug 14 20:05:54 2013
> @@ -9,7 +9,7 @@
> </appenders>
> <loggers>
> <root level="info" includeLocation="true">
> - <appender-ref ref="RandomAccessFile"/>
> + <AppenderRef ref="RandomAccessFile"/>
> </root>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf5AsyncApndNoLoc.xml Wed Aug 14 20:05:54 2013
> @@ -7,12 +7,12 @@
> </PatternLayout>
> </RandomAccessFile>
> <Async name="Async" blocking="true" bufferSize="262144">
> - <appender-ref ref="RandomAccessFile"/>
> + <AppenderRef ref="RandomAccessFile"/>
> </Async>
> </appenders>
> <loggers>
> <root level="info" includeLocation="false">
> - <appender-ref ref="Async"/>
> + <AppenderRef ref="Async"/>
> </root>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf6AsyncApndLoc.xml Wed Aug 14 20:05:54 2013
> @@ -7,12 +7,12 @@
> </PatternLayout>
> </RandomAccessFile>
> <Async name="Async" includeLocation="true" blocking="true" bufferSize="262144">
> - <appender-ref ref="RandomAccessFile"/>
> + <AppenderRef ref="RandomAccessFile"/>
> </Async>
> </appenders>
> <loggers>
> <root level="info" includeLocation="true">
> - <appender-ref ref="Async"/>
> + <AppenderRef ref="Async"/>
> </root>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf7MixedNoLoc.xml Wed Aug 14 20:05:54 2013
> @@ -9,7 +9,7 @@
> </appenders>
> <loggers>
> <asyncRoot level="info" includeLocation="false">
> - <appender-ref ref="RandomAccessFile"/>
> + <AppenderRef ref="RandomAccessFile"/>
> </asyncRoot>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/perf8MixedLoc.xml Wed Aug 14 20:05:54 2013
> @@ -9,7 +9,7 @@
> </appenders>
> <loggers>
> <asyncRoot level="info" includeLocation="true">
> - <appender-ref ref="RandomAccessFile"/>
> + <AppenderRef ref="RandomAccessFile"/>
> </asyncRoot>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml (original)
> +++ logging/log4j/log4j2/trunk/core/src/test/resources/xml-events.xml Wed Aug 14 20:05:54 2013
> @@ -10,10 +10,10 @@
> </appenders>
> <loggers>
> <logger name="EventLogger" level="info">
> - <appender-ref ref="events"/>
> + <AppenderRef ref="events"/>
> </logger>
> <root level="warn">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml (original)
> +++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/default_embedded.xml Wed Aug 14 20:05:54 2013
> @@ -12,10 +12,10 @@
> </appenders>
> <loggers>
> <logger name="EventLogger" level="info" additivity="false">
> - <appender-ref ref="eventLogger"/>
> + <AppenderRef ref="eventLogger"/>
> </logger>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml (original)
> +++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/embedded.xml Wed Aug 14 20:05:54 2013
> @@ -32,10 +32,10 @@
> </appenders>
> <loggers>
> <logger name="EventLogger" level="info" additivity="false">
> - <appender-ref ref="eventLogger"/>
> + <AppenderRef ref="eventLogger"/>
> </logger>
> <root level="warn">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml (original)
> +++ logging/log4j/log4j2/trunk/flume-ng/src/test/resources/persistent.xml Wed Aug 14 20:05:54 2013
> @@ -15,10 +15,10 @@
> </appenders>
> <loggers>
> <logger name="EventLogger" level="info" additivity="false">
> - <appender-ref ref="eventLogger"/>
> + <AppenderRef ref="eventLogger"/>
> </logger>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml (original)
> +++ logging/log4j/log4j2/trunk/jcl-bridge/src/test/resources/log4j-test1.xml Wed Aug 14 20:05:54 2013
> @@ -24,15 +24,15 @@
>
> <loggers>
> <logger name="EventLogger" level="info" additivity="false">
> - <appender-ref ref="EventLogger"/>
> + <AppenderRef ref="EventLogger"/>
> </logger>>
>
> <logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
> - <appender-ref ref="File"/>
> + <AppenderRef ref="File"/>
> </logger>>
>
> <root level="trace">
> - <appender-ref ref="List"/>
> + <AppenderRef ref="List"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java (original)
> +++ logging/log4j/log4j2/trunk/log4j-to-slf4j/src/test/java/org/apache/logging/slf4j/LoggerTest.java Wed Aug 14 20:05:54 2013
> @@ -24,22 +24,23 @@ import static org.junit.Assert.assertTru
> import java.util.Date;
> import java.util.List;
>
> -import ch.qos.logback.classic.joran.JoranConfigurator;
> -import ch.qos.logback.classic.spi.ILoggingEvent;
> -import ch.qos.logback.core.joran.spi.JoranException;
> import org.apache.logging.log4j.LogManager;
> import org.apache.logging.log4j.Logger;
> import org.apache.logging.log4j.ThreadContext;
> import org.apache.logging.log4j.message.MessageFactory;
> import org.apache.logging.log4j.message.ParameterizedMessageFactory;
> import org.apache.logging.log4j.message.StringFormatterMessageFactory;
> -import ch.qos.logback.core.testUtil.StringListAppender;
> -import ch.qos.logback.classic.LoggerContext;
> import org.junit.Before;
> import org.junit.BeforeClass;
> import org.junit.Test;
> import org.slf4j.LoggerFactory;
>
> +import ch.qos.logback.classic.LoggerContext;
> +import ch.qos.logback.classic.joran.JoranConfigurator;
> +import ch.qos.logback.classic.spi.ILoggingEvent;
> +import ch.qos.logback.core.joran.spi.JoranException;
> +import ch.qos.logback.core.testUtil.StringListAppender;
> +
> /**
> *
> */
> @@ -74,6 +75,8 @@ public class LoggerTest {
>
> @Before
> public void before() {
> + assertNotNull(list);
> + assertNotNull(list.strList);
> list.strList.clear();
> }
>
>
> Modified: logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml (original)
> +++ logging/log4j/log4j2/trunk/log4j12-api/src/test/resources/log4j2-config.xml Wed Aug 14 20:05:54 2013
> @@ -27,13 +27,13 @@
> </appenders>
> <loggers>
> <logger name="org.apache.test.logging" level="debug" additivity="false">
> - <appender-ref ref="List"/>
> + <AppenderRef ref="List"/>
> </logger>
> <logger name="org.apache.test" level="trace" additivity="false">
> - <appender-ref ref="List"/>
> + <AppenderRef ref="List"/>
> </logger>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>
> \ No newline at end of file
>
> Modified: logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml (original)
> +++ logging/log4j/log4j2/trunk/samples/flume-embedded/src/main/resources/log4j-embedded.xml Wed Aug 14 20:05:54 2013
> @@ -40,10 +40,10 @@
> </appenders>
> <loggers>
> <logger name="EventLogger" level="WARN" additivity="false">
> - <appender-ref ref="flume" />
> + <AppenderRef ref="flume" />
> </logger>
> <root level="debug">
> - <appender-ref ref="RollingFile" />
> + <AppenderRef ref="RollingFile" />
> </root>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml (original)
> +++ logging/log4j/log4j2/trunk/samples/flume-remote/src/main/resources/log4j-remote.xml Wed Aug 14 20:05:54 2013
> @@ -40,10 +40,10 @@
> </appenders>
> <loggers>
> <logger name="EventLogger" level="WARN" additivity="false">
> - <appender-ref ref="flume" />
> + <AppenderRef ref="flume" />
> </logger>
> <root level="debug">
> - <appender-ref ref="RollingFile" />
> + <AppenderRef ref="RollingFile" />
> </root>
> </loggers>
> </configuration>
>
> Modified: logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml (original)
> +++ logging/log4j/log4j2/trunk/slf4j-impl/src/test/resources/log4j-test1.xml Wed Aug 14 20:05:54 2013
> @@ -25,15 +25,15 @@
>
> <loggers>
> <logger name="EventLogger" level="info" additivity="false">
> - <appender-ref ref="EventLogger"/>
> + <AppenderRef ref="EventLogger"/>
> </logger>>
>
> <logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
> - <appender-ref ref="File"/>
> + <AppenderRef ref="File"/>
> </logger>>
>
> <root level="trace">
> - <appender-ref ref="List"/>
> + <AppenderRef ref="List"/>
> </root>
> </loggers>
>
>
> Modified: logging/log4j/log4j2/trunk/src/changes/changes.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/changes/changes.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/src/changes/changes.xml (original)
> +++ logging/log4j/log4j2/trunk/src/changes/changes.xml Wed Aug 14 20:05:54 2013
> @@ -432,7 +432,7 @@
> The blocking parameter did not work properly on AsynchAppender.
> </action>
> <action issue="LOG4J2-188" dev="rgoers" type="fix" due-to="Werner">
> - appender-refs on AsynchAppender didn't support the level and filter elements.
> + AppenderRefs on AsynchAppender didn't support the level and filter elements.
> </action>
> <action issue="LOG4J2-176" dev="rgoers" type="fix" due-to="Remko Popma">
> Avoid IllegalArgumentException in AsynchAppender.
> @@ -797,7 +797,7 @@
> </release>
> <release version="2.0-alpha1" date="2012-07-29" description="Rewrite of Log4j">
> <action issue="LOG4J2-60" dev="rgoers" type="add" due-to="Shane Kelly">
> - Added ability to filter on the appender-ref by adding either a level or a filter.
> + Added ability to filter on the AppenderRef by adding either a level or a filter.
> </action>
> <action issue="LOG4J2-56" dev="rgoers" type="fix" due-to="John Owen Atala">
> Level.toLevel would throw an IllegalArgumentException instead of returning the default value.
>
> Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml (original)
> +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/appenders.xml Wed Aug 14 20:05:54 2013
> @@ -59,9 +59,9 @@
> <th>Description</th>
> </tr>
> <tr>
> - <td>appender-ref</td>
> + <td>AppenderRef</td>
> <td>String</td>
> - <td>The name of the Appenders to invoke asynchronously. Multiple appender-ref
> + <td>The name of the Appenders to invoke asynchronously. Multiple AppenderRef
> elements can be configured.</td>
> </tr>
> <tr>
> @@ -122,12 +122,12 @@
> </PatternLayout>
> </File>
> <Async name="Async">
> - <appender-ref ref="MyFile"/>
> + <AppenderRef ref="MyFile"/>
> </Async>
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="Async"/>
> + <AppenderRef ref="Async"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -196,7 +196,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -271,13 +271,13 @@
> </Console>
> <Failover name="Failover" primary="RollingFile">
> <Failovers>
> - <appender-ref ref="Console"/>
> + <AppenderRef ref="Console"/>
> </Failovers>
> </Failover>
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="Failover"/>
> + <AppenderRef ref="Failover"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -387,7 +387,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="MyFile"/>
> + <AppenderRef ref="MyFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -588,7 +588,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingRandomAccessFile"/>
> + <AppenderRef ref="RollingRandomAccessFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -613,7 +613,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingRandomAccessFile"/>
> + <AppenderRef ref="RollingRandomAccessFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -647,7 +647,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingRandomAccessFile"/>
> + <AppenderRef ref="RollingRandomAccessFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -749,7 +749,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="MyFile"/>
> + <AppenderRef ref="MyFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -927,7 +927,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="eventLogger"/>
> + <AppenderRef ref="eventLogger"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -948,7 +948,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="eventLogger"/>
> + <AppenderRef ref="eventLogger"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -972,10 +972,10 @@
> </appenders>
> <loggers>
> <logger name="EventLogger" level="info">
> - <appender-ref ref="eventLogger"/>
> + <AppenderRef ref="eventLogger"/>
> </logger>
> <root level="warn">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1016,10 +1016,10 @@
> </appenders>
> <loggers>
> <logger name="EventLogger" level="info">
> - <appender-ref ref="eventLogger"/>
> + <AppenderRef ref="eventLogger"/>
> </logger>
> <root level="warn">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1216,7 +1216,7 @@
> </appenders>
> <loggers>
> <root level="warn">
> - <appender-ref ref="databaseAppender"/>
> + <AppenderRef ref="databaseAppender"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1235,7 +1235,7 @@
> </appenders>
> <loggers>
> <root level="warn">
> - <appender-ref ref="databaseAppender"/>
> + <AppenderRef ref="databaseAppender"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1255,7 +1255,7 @@
> </appenders>
> <loggers>
> <root level="warn">
> - <appender-ref ref="databaseAppender"/>
> + <AppenderRef ref="databaseAppender"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1365,7 +1365,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="jmsQueue"/>
> + <AppenderRef ref="jmsQueue"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1476,7 +1476,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="jmsQueue"/>
> + <AppenderRef ref="jmsQueue"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1552,7 +1552,7 @@
> </appenders>
> <loggers>
> <root level="warn">
> - <appender-ref ref="databaseAppender"/>
> + <AppenderRef ref="databaseAppender"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1806,7 +1806,7 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <root level="warn">
> - <appender-ref ref="databaseAppender"/>
> + <AppenderRef ref="databaseAppender"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1821,7 +1821,7 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <root level="warn">
> - <appender-ref ref="databaseAppender"/>
> + <AppenderRef ref="databaseAppender"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1836,7 +1836,7 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <root level="warn">
> - <appender-ref ref="databaseAppender"/>
> + <AppenderRef ref="databaseAppender"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -1919,9 +1919,9 @@ public class JpaLogEntity extends Abstra
> <th>Description</th>
> </tr>
> <tr>
> - <td>appender-ref</td>
> + <td>AppenderRef</td>
> <td>String</td>
> - <td>The name of the Appenders to call after the LogEvent has been manipulated. Multiple appender-ref
> + <td>The name of the Appenders to call after the LogEvent has been manipulated. Multiple AppenderRef
> elements can be configured.</td>
> </tr>
> <tr>
> @@ -1989,7 +1989,7 @@ public class JpaLogEntity extends Abstra
> <PatternLayout pattern="%m%n"/>
> </Console>
> <Rewrite name="rewrite">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> <MapRewritePolicy mode="Add">
> <KeyValuePair key="product" value="TestProduct"/>
> </MapRewritePolicy>
> @@ -1997,7 +1997,7 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="Rewrite"/>
> + <AppenderRef ref="Rewrite"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -2032,7 +2032,7 @@ public class JpaLogEntity extends Abstra
> <PatternLayout pattern="%m%n"/>
> </Console>
> <Rewrite name="rewrite">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> <PropertiesRewritePolicy>
> <Property key="user">${sys:user.name}</Property>
> <Property key="env">${sys:environment}</Property>
> @@ -2041,7 +2041,7 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="Rewrite"/>
> + <AppenderRef ref="Rewrite"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -2357,7 +2357,7 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -2381,7 +2381,7 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -2408,7 +2408,7 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -2468,7 +2468,7 @@ public class JpaLogEntity extends Abstra
> can be configured as the default.
> </p>
> <p>
> - Each Route must reference an Appender. If the Route contains an appender-ref attribute then the
> + Each Route must reference an Appender. If the Route contains an AppenderRef attribute then the
> Route will reference an Appender that was defined in the configuration. If the Route contains an
> Appender definition then an Appender will be created within the context of the RoutingAppender and
> will be reused each time a matching Appender name is referenced through a Route.
> @@ -2498,13 +2498,13 @@ public class JpaLogEntity extends Abstra
> <SizeBasedTriggeringPolicy size="500" />
> </RollingFile>
> </Route>
> - <Route appender-ref="AuditLogger" key="Audit"/>
> + <Route AppenderRef="AuditLogger" key="Audit"/>
> </Routes>
> </Routing>
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="Routing"/>
> + <AppenderRef ref="Routing"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -2631,7 +2631,7 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="Mail"/>
> + <AppenderRef ref="Mail"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -2722,7 +2722,7 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="socket"/>
> + <AppenderRef ref="socket"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -2904,10 +2904,10 @@ public class JpaLogEntity extends Abstra
> </appenders>
> <loggers>
> <logger name="com.mycorp" level="error">
> - <appender-ref ref="RFC5424"/>
> + <AppenderRef ref="RFC5424"/>
> </logger>
> <root level="error">
> - <appender-ref ref="bsd"/>
> + <AppenderRef ref="bsd"/>
> </root>
> </loggers>
> </configuration>]]></pre>
>
> Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml (original)
> +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/async.xml Wed Aug 14 20:05:54 2013
> @@ -162,7 +162,7 @@
> </appenders>
> <loggers>
> <root level="info" includeLocation="false">
> - <appender-ref ref="RandomAccessFile"/>
> + <AppenderRef ref="RandomAccessFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -360,10 +360,10 @@
> <loggers>
> <!-- pattern layout actually uses location, so we need to include it -->
> <asyncLogger name="com.foo.Bar" level="trace" includeLocation="true">
> - <appender-ref ref="RandomAccessFile"/>
> + <AppenderRef ref="RandomAccessFile"/>
> </asyncLogger>
> <root level="info" includeLocation="true">
> - <appender-ref ref="RandomAccessFile"/>
> + <AppenderRef ref="RandomAccessFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
>
> Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm (original)
> +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/configuration.xml.vm Wed Aug 14 20:05:54 2013
> @@ -161,7 +161,7 @@ public class Bar {
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="Console"/>
> + <AppenderRef ref="Console"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -186,7 +186,7 @@ public class Bar {
> <pre class="prettyprint linenums"><![CDATA[
> <logger name="com.foo.Bar" level="TRACE"/>
> <root level="ERROR">
> - <appender-ref ref="STDOUT">
> + <AppenderRef ref="STDOUT">
> </root>]]></pre>
> <p>
> With this configuration all log events from <code>com.foo.Bar</code> will be recorded while only error events will
> @@ -210,10 +210,10 @@ public class Bar {
> </appenders>
> <loggers>
> <logger name="com.foo.Bar" level="trace">
> - <appender-ref ref="Console"/>
> + <AppenderRef ref="Console"/>
> </logger>
> <root level="error">
> - <appender-ref ref="Console"/>
> + <AppenderRef ref="Console"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -242,10 +242,10 @@ public class Bar {
> </appenders>
> <loggers>
> <logger name="com.foo.Bar" level="trace" additivity="false">
> - <appender-ref ref="Console"/>
> + <AppenderRef ref="Console"/>
> </logger>
> <root level="error">
> - <appender-ref ref="Console"/>
> + <AppenderRef ref="Console"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -408,7 +408,7 @@ public class Bar {
> </logger>
> ...
> <root level="level">
> - <appender-ref ref="name"/>
> + <AppenderRef ref="name"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -443,7 +443,7 @@ public class Bar {
> </logger>
> ...
> <root level="level">
> - <appender-ref ref="name"/>
> + <AppenderRef ref="name"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -488,15 +488,15 @@ public class Bar {
> <filter type="ThreadContextMapFilter">
> <KeyValuePair key="test" value="123"/>
> </filter>
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </logger>>
>
> <logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
> - <appender-ref ref="File"/>
> + <AppenderRef ref="File"/>
> </logger>>
>
> <root level="trace">
> - <appender-ref ref="List"/>
> + <AppenderRef ref="List"/>
> </root>
> </loggers>
>
> @@ -537,16 +537,16 @@ public class Bar {
> "SizeBasedTriggeringPolicy": { "size": "500" }
> }
> },
> - { "appender-ref": "STDOUT", "key": "Audit"},
> - { "appender-ref": "List", "key": "Service"}
> + { "AppenderRef": "STDOUT", "key": "Audit"},
> + { "AppenderRef": "List", "key": "Service"}
> ]
> }
> }
> },
> "loggers": {
> "logger": { "name": "EventLogger", "level": "info", "additivity": "false",
> - "appender-ref": { "ref": "Routing" }},
> - "root": { "level": "error", "appender-ref": { "ref": "STDOUT" }}
> + "AppenderRef": { "ref": "Routing" }},
> + "root": { "level": "error", "AppenderRef": { "ref": "STDOUT" }}
> }
> }
> }</pre>
> @@ -580,8 +580,8 @@ public class Bar {
> "SizeBasedTriggeringPolicy": { "size": "500" }
> }
> },
> - { "appender-ref": "STDOUT", "key": "Audit"},
> - { "appender-ref": "List", "key": "Service"}
> + { "AppenderRef": "STDOUT", "key": "Audit"},
> + { "AppenderRef": "List", "key": "Service"}
> ]
> }
> }
> @@ -590,11 +590,11 @@ public class Bar {
> "loggers": {
> "logger": [
> { "name": "EventLogger", "level": "info", "additivity": "false",
> - "appender-ref": { "ref": "Routing" }},
> + "AppenderRef": { "ref": "Routing" }},
> { "name": "com.foo.bar", "level": "error", "additivity": "false",
> - "appender-ref": { "ref": "Console" }}
> + "AppenderRef": { "ref": "Console" }}
> ],
> - "root": { "level": "error", "appender-ref": { "ref": "STDOUT" }}
> + "root": { "level": "error", "AppenderRef": { "ref": "STDOUT" }}
> }
> }
> }</pre>
> @@ -638,7 +638,7 @@ public class Bar {
> using variables.
> </p>
> <p>
> - The LoggerConfig may also be configured with one or more appender-ref elements. Each appender
> + The LoggerConfig may also be configured with one or more AppenderRef elements. Each appender
> referenced will become associated with the specified LoggerConfig. If multiple appenders
> are configured on the LoggerConfig each of them be called when processing logging events.
> </p>
> @@ -718,21 +718,21 @@ public class Bar {
> <ThreadContextMapFilter>
> <KeyValuePair key="test" value="123"/>
> </ThreadContextMapFilter>
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </logger>>
>
> <logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
> <property name="user">${dollar}{sys:user.name}</property>
> - <appender-ref ref="File">
> + <AppenderRef ref="File">
> <ThreadContextMapFilter>
> <KeyValuePair key="test" value="123"/>
> </ThreadContextMapFilter>
> - </appender-ref>
> - <appender-ref ref="STDOUT" level="error"/>
> + </AppenderRef>
> + <AppenderRef ref="STDOUT" level="error"/>
> </logger>>
>
> <root level="trace">
> - <appender-ref ref="List"/>
> + <AppenderRef ref="List"/>
> </root>
> </loggers>
>
> @@ -776,19 +776,19 @@ public class Bar {
> <SizeBasedTriggeringPolicy size="500" />
> </RollingFile>
> </Route>
> - <Route appender-ref="STDOUT" key="Audit"/>
> - <Route appender-ref="List" key="Service"/>
> + <Route AppenderRef="STDOUT" key="Audit"/>
> + <Route AppenderRef="List" key="Service"/>
> </Routes>
> </Routing>
> </appenders>
>
> <loggers>
> <logger name="EventLogger" level="info" additivity="false">
> - <appender-ref ref="Routing"/>
> + <AppenderRef ref="Routing"/>
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
> @@ -916,19 +916,19 @@ public class Bar {
> <SizeBasedTriggeringPolicy size="500" />
> </RollingFile>
> </Route>
> - <Route appender-ref="STDOUT" key="Audit"/>
> - <Route appender-ref="List" key="Service"/>
> + <Route AppenderRef="STDOUT" key="Audit"/>
> + <Route AppenderRef="List" key="Service"/>
> </Routes>
> </Routing>
> </appenders>
>
> <loggers>
> <logger name="EventLogger" level="info" additivity="false">
> - <appender-ref ref="Routing"/>
> + <AppenderRef ref="Routing"/>
> </logger>
>
> <root level="error">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
>
> @@ -961,11 +961,11 @@ public class Bar {
> appender.ListAppender for element List with params(name="List", entryPerNewLine="null",
> raw="null", null, ThresholdFilter(DEBUG))
> 2011-11-23 17:08:00,813 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.
> - routing.Route for element Route with params(appender-ref="null", key="null", Node=Route)
> + routing.Route for element Route with params(AppenderRef="null", key="null", Node=Route)
> 2011-11-23 17:08:00,823 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.
> - routing.Route for element Route with params(appender-ref="STDOUT", key="Audit", Node=Route)
> + routing.Route for element Route with params(AppenderRef="STDOUT", key="Audit", Node=Route)
> 2011-11-23 17:08:00,824 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.
> - routing.Route for element Route with params(appender-ref="List", key="Service", Node=Route)
> + routing.Route for element Route with params(AppenderRef="List", key="Service", Node=Route)
> 2011-11-23 17:08:00,825 DEBUG Calling createRoutes on class org.apache.logging.log4j.core.appender.
> routing.Routes for element Routes with params(pattern="${dollar}{sd:type}",
> routes={Route(type=dynamic default), Route(type=static Reference=STDOUT key='Audit'),
> @@ -978,16 +978,16 @@ public class Bar {
> 2011-11-23 17:08:00,827 DEBUG Calling createAppenders on class org.apache.logging.log4j.core.config.
> plugins.AppendersPlugin for element appenders with params(appenders={STDOUT, List, Routing})
> 2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.
> - config.plugins.AppenderRefPlugin for element appender-ref with params(ref="Routing")
> + config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="Routing")
> 2011-11-23 17:08:00,829 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.
> LoggerConfig for element logger with params(additivity="false", level="info", name="EventLogger",
> - appender-ref={Routing}, null)
> + AppenderRef={Routing}, null)
> 2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.
> - config.plugins.AppenderRefPlugin for element appender-ref with params(ref="STDOUT")</pre>
> + config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="STDOUT")</pre>
> <pre class="prettyprint linenums">
> 2011-11-23 17:08:00,831 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.
> LoggerConfig$RootLogger for element root with params(additivity="null", level="error",
> - appender-ref={STDOUT}, null)
> + AppenderRef={STDOUT}, null)
> 2011-11-23 17:08:00,833 DEBUG Calling createLoggers on class org.apache.logging.log4j.core.
> config.plugins.LoggersPlugin for element loggers with params(loggers={EventLogger, root})
> 2011-11-23 17:08:00,834 DEBUG Reconfiguration completed
> @@ -1024,16 +1024,16 @@ public class Bar {
> 2011-11-23 17:08:00,804 DEBUG Calling createAppender on class org.apache.logging.log4j.core.appender.ConsoleAppender for element Console with params(PatternLayout(%m%n), null, target="null", name="STDOUT", ignoreExceptions="null")
> 2011-11-23 17:08:00,804 DEBUG Calling createFilter on class org.apache.logging.log4j.core.filter.ThresholdFilter for element ThresholdFilter with params(level="debug", onMatch="null", onMismatch="null")
> 2011-11-23 17:08:00,806 DEBUG Calling createAppender on class org.apache.logging.log4j.test.appender.ListAppender for element List with params(name="List", entryPerNewLine="null", raw="null", null, ThresholdFilter(DEBUG))
> -2011-11-23 17:08:00,813 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(appender-ref="null", key="null", Node=Route)
> -2011-11-23 17:08:00,823 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(appender-ref="STDOUT", key="Audit", Node=Route)
> -2011-11-23 17:08:00,824 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(appender-ref="List", key="Service", Node=Route)
> +2011-11-23 17:08:00,813 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(AppenderRef="null", key="null", Node=Route)
> +2011-11-23 17:08:00,823 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(AppenderRef="STDOUT", key="Audit", Node=Route)
> +2011-11-23 17:08:00,824 DEBUG Calling createRoute on class org.apache.logging.log4j.core.appender.routing.Route for element Route with params(AppenderRef="List", key="Service", Node=Route)
> 2011-11-23 17:08:00,825 DEBUG Calling createRoutes on class org.apache.logging.log4j.core.appender.routing.Routes for element Routes with params(pattern="${dollar}{sd:type}", routes={Route(type=dynamic default), Route(type=static Reference=STDOUT key='Audit'), Route(type=static Reference=List key='Service')})
> 2011-11-23 17:08:00,827 DEBUG Calling createAppender on class org.apache.logging.log4j.core.appender.routing.RoutingAppender for element Routing with params(name="Routing", ignoreExceptions="null", Routes({Route(type=dynamic default),Route(type=static Reference=STDOUT key='Audit'),Route(type=static Reference=List key='Service')}), Configuration(RoutingTest), null, null)
> 2011-11-23 17:08:00,827 DEBUG Calling createAppenders on class org.apache.logging.log4j.core.config.plugins.AppendersPlugin for element appenders with params(appenders={STDOUT, List, Routing})
> -2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element appender-ref with params(ref="Routing")
> -2011-11-23 17:08:00,829 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig for element logger with params(additivity="false", level="info", name="EventLogger", appender-ref={Routing}, null)
> -2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element appender-ref with params(ref="STDOUT")
> -2011-11-23 17:08:00,831 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element root with params(additivity="null", level="error", appender-ref={STDOUT}, null)
> +2011-11-23 17:08:00,828 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="Routing")
> +2011-11-23 17:08:00,829 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig for element logger with params(additivity="false", level="info", name="EventLogger", AppenderRef={Routing}, null)
> +2011-11-23 17:08:00,830 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.plugins.AppenderRefPlugin for element AppenderRef with params(ref="STDOUT")
> +2011-11-23 17:08:00,831 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element root with params(additivity="null", level="error", AppenderRef={STDOUT}, null)
> 2011-11-23 17:08:00,833 DEBUG Calling createLoggers on class org.apache.logging.log4j.core.config.plugins.LoggersPlugin for element loggers with params(loggers={EventLogger, root})
> 2011-11-23 17:08:00,834 DEBUG Reconfiguration completed
> 2011-11-23 17:08:00,846 DEBUG Calling createLayout on class org.apache.logging.log4j.core.layout.PatternLayout for element PatternLayout with params(pattern="%d %p %c{1.} [%t] %m%n", Configuration(RoutingTest), null, charset="null")
> @@ -1053,7 +1053,7 @@ public class Bar {
> makes troubleshooting configuration errors possible. As an example, if the configuration above is changed
> to have the status set to error and the logger declaration is:</p>
> <pre class="prettyprint linenums"><![CDATA[<logger name="EventLogger" level="info" additivity="false">
> - <appender-ref ref="Routng"/>
> + <AppenderRef ref="Routng"/>
> </logger>]]></pre>
> <p>
> the following error message will be produced.
>
> Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml (original)
> +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/extending.xml Wed Aug 14 20:05:54 2013
> @@ -143,7 +143,7 @@ public static class RootLogger extends L
> @PluginFactory
> public static LoggerConfig createLogger(@PluginAttr("additivity") String additivity,
> @PluginAttr("level") String loggerLevel,
> - @PluginElement("appender-ref") AppenderRef[] refs,
> + @PluginElement("AppenderRef") AppenderRef[] refs,
> @PluginElement("filters") Filter filter) {
> List<AppenderRef> appenderRefs = Arrays.asList(refs);
> Level level;
>
> Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml (original)
> +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/filters.xml Wed Aug 14 20:05:54 2013
> @@ -109,7 +109,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -151,10 +151,10 @@
> </appenders>
> <loggers>
> <logger name="EventLogger" level="info">
> - <appender-ref ref="Audit"/>
> + <AppenderRef ref="Audit"/>
> </logger>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -220,7 +220,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -284,7 +284,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -311,8 +311,8 @@
> <KeyValuePair key="eventId" value="Login"/>
> <KeyValuePair key="eventId" value="Logout"/>
> </MapFilter>
> - <appender-ref ref="RollingFile">
> - </appender-ref>
> + <AppenderRef ref="RollingFile">
> + </AppenderRef>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -335,12 +335,12 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile">
> + <AppenderRef ref="RollingFile">
> <MapFilter onMatch="ACCEPT" onMismatch="NEUTRAL" operator="or">
> <KeyValuePair key="eventId" value="Login"/>
> <KeyValuePair key="eventId" value="Logout"/>
> </MapFilter>
> - </appender-ref>
> + </AppenderRef>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -396,7 +396,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -456,7 +456,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -523,7 +523,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -587,7 +587,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -608,7 +608,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> <ThreadContextMapFilter onMatch="ACCEPT" onMismatch="NEUTRAL" operator="or">
> <KeyValuePair key="foo" value="bar"/>
> <KeyValuePair key="User2" value="WARN"/>
> @@ -670,7 +670,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -740,7 +740,7 @@
> </appenders>
> <loggers>
> <root level="error">
> - <appender-ref ref="RollingFile"/>
> + <AppenderRef ref="RollingFile"/>
> </root>
> </loggers>
> </configuration>]]></pre>
>
> Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml (original)
> +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/flowtracing.xml Wed Aug 14 20:05:54 2013
> @@ -154,7 +154,7 @@ public class App {
> </appenders>
> <loggers>
> <root level="trace">
> - <appender-ref ref="log"/>
> + <AppenderRef ref="log"/>
> </root>
> </loggers>
> </configuration>]]></pre>
>
> Modified: logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml (original)
> +++ logging/log4j/log4j2/trunk/src/site/xdoc/manual/migration.xml Wed Aug 14 20:05:54 2013
> @@ -81,7 +81,7 @@
> </category>
> <root>
> <priority value ="debug" />
> - <appender-ref ref="STDOUT" />
> + <AppenderRef ref="STDOUT" />
> </root>
> </log4j:configuration>]]></pre>
> <p>Log4j 2 XML configuration</p>
> @@ -95,7 +95,7 @@
> <loggers>
> <logger name="org.apache.log4j.xml" level="info"/>
> <root level="debug">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -119,11 +119,11 @@
> </appender>
> <category name="org.apache.log4j.xml">
> <priority value="debug" />
> - <appender-ref ref="A1" />
> + <AppenderRef ref="A1" />
> </category>
> <root>
> <priority value ="debug" />
> - <appender-ref ref="STDOUT" />
> + <AppenderRef ref="STDOUT" />
> </root>
> </log4j:configuration>]]></pre>
>
> @@ -140,10 +140,10 @@
> </appenders>
> <loggers>
> <logger name="org.apache.log4j.xml" level="debug">
> - <appender-ref ref="A1"/>
> + <AppenderRef ref="A1"/>
> </logger>
> <root level="debug">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -169,11 +169,11 @@
> </appender>
> <category name="org.apache.log4j.xml">
> <priority value="debug"/>
> - <appender-ref ref="A1"/>
> + <AppenderRef ref="A1"/>
> </category>
> <root>
> <priority value="debug"/>
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </log4j:configuration>]]></pre>
>
> @@ -190,10 +190,10 @@
> </appenders>
> <loggers>
> <logger name="org.apache.log4j.xml" level="debug">
> - <appender-ref ref="A1"/>
> + <AppenderRef ref="A1"/>
> </logger>
> <root level="debug">
> - <appender-ref ref="STDOUT"/>
> + <AppenderRef ref="STDOUT"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -204,7 +204,7 @@
> <!DOCTYPE log4j:configuration PUBLIC "-//APACHE//DTD LOG4J 1.2//EN" "log4j.dtd">
> <log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/" configDebug="true">
> <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
> - <appender-ref ref="TEMP"/>
> + <AppenderRef ref="TEMP"/>
> </appender>
> <appender name="TEMP" class="org.apache.log4j.FileAppender">
> <param name="File" value="temp"/>
> @@ -214,7 +214,7 @@
> </appender>
> <root>
> <priority value="debug"/>
> - <appender-ref ref="ASYNC"/>
> + <AppenderRef ref="ASYNC"/>
> </root>
> </log4j:configuration>]]></pre>
>
> @@ -226,12 +226,12 @@
> <PatternLayout pattern="%d %-5p [%t] %C{2} (%F:%L) - %m%n"/>
> </File>
> <Async name="ASYNC">
> - <appender-ref ref="TEMP"/>
> + <AppenderRef ref="TEMP"/>
> </Async>
> </appenders>
> <loggers>
> <root level="debug">
> - <appender-ref ref="ASYNC"/>
> + <AppenderRef ref="ASYNC"/>
> </root>
> </loggers>
> </configuration>]]></pre>
> @@ -243,8 +243,8 @@
> <!DOCTYPE log4j:configuration PUBLIC "-//APACHE//DTD LOG4J 1.2//EN" "log4j.dtd">
> <log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/" configDebug="true">
> <appender name="ASYNC" class="org.apache.log4j.AsyncAppender">
> - <appender-ref ref="TEMP"/>
> - <appender-ref ref="CONSOLE"/>
> + <AppenderRef ref="TEMP"/>
> + <AppenderRef ref="CONSOLE"/>
> </appender>
> <appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender">
> <layout class="org.apache.log4j.PatternLayout">
> @@ -259,7 +259,7 @@
> </appender>
> <root>
> <priority value="debug"/>
> - <appender-ref ref="ASYNC"/>
> + <AppenderRef ref="ASYNC"/>
> </root>
> </log4j:configuration>]]></pre>
>
> @@ -275,13 +275,13 @@
> <PatternLayout pattern="%d %-5p [%t] %C{2} (%F:%L) - %m%n"/>
> </File>
> <Async name="ASYNC">
> - <appender-ref ref="TEMP"/>
> - <appender-ref ref="CONSOLE"/>
> + <AppenderRef ref="TEMP"/>
> + <AppenderRef ref="CONSOLE"/>
> </Async>
> </appenders>
> <loggers>
> <root level="debug">
> - <appender-ref ref="ASYNC"/>
> + <AppenderRef ref="ASYNC"/>
> </root>
> </loggers>
> </configuration>]]></pre>
>
> Modified: logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml?rev=1514021&r1=1514020&r2=1514021&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml (original)
> +++ logging/log4j/log4j2/trunk/taglib/src/test/resources/log4j-test1.xml Wed Aug 14 20:05:54 2013
> @@ -24,15 +24,15 @@
>
> <loggers>
> <logger name="EventLogger" level="info" additivity="false">
> - <appender-ref ref="EventLogger"/>
> + <AppenderRef ref="EventLogger"/>
> </logger>>
>
> <logger name="org.apache.logging.log4j.test2" level="debug" additivity="false">
> - <appender-ref ref="File"/>
> + <AppenderRef ref="File"/>
> </logger>>
>
> <root level="trace">
> - <appender-ref ref="List"/>
> + <AppenderRef ref="List"/>
> </root>
>
> <logger name="IfEnabledTagTest" level="warn" />
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org