You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2024/06/04 14:00:24 UTC

[PR] fix(knative): remove Broker type limitation [camel-k]

squakez opened a new pull request, #5580:
URL: https://github.com/apache/camel-k/pull/5580

   Close #5529
   
   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   fix(knative): remove Broker type limitation
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(knative): remove Broker type limitation [camel-k]

Posted by "christophd (via GitHub)" <gi...@apache.org>.

christophd commented on PR #5580:
URL: https://github.com/apache/camel-k/pull/5580#issuecomment-2148055372

   I think we are mixing up things here a bit. The type information is not the broker name but the cloud event type set as a field on the cloud event message.
   
   We should not set this to the broker name using `e.Ref.Name` as supposed in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(knative): remove Broker type limitation [camel-k]

Posted by "squakez (via GitHub)" <gi...@apache.org>.

squakez closed pull request #5580: fix(knative): remove Broker type limitation
URL: https://github.com/apache/camel-k/pull/5580


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org