[jira] [Commented] (HIVE-6684) Beeline does not accept comments that are preceded by spaces

["Xuefu Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988547#comment-13988547 ] 

Xuefu Zhang commented on HIVE-6684:
-----------------------------------

Patch looks good. Minor nit though, is that in the line
{code}
+    return line.trim().startsWith("#") || line.trim().startsWith("--");
{code}
line.trim() may be called twice, which is unnecessary. Better if just to trim once.

> Beeline does not accept comments that are preceded by spaces
> ------------------------------------------------------------
>
>                 Key: HIVE-6684
>                 URL: https://issues.apache.org/jira/browse/HIVE-6684
>             Project: Hive
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 0.10.0
>            Reporter: Jeremy Beard
>         Attachments: HIVE-6684.1.patch
>
>
> Beeline throws an error if single-line comments are indented with spaces. This works in the embedded Hive CLI.
> For example:
> SELECT
>    -- this is the field we want
>    field
> FROM
>    table;
> Error: Error while processing statement: FAILED: ParseException line 1:71 cannot recognize input near '<EOF>' '<EOF>' '<EOF>' in select clause (state=42000,code=40000)



--
This message was sent by Atlassian JIRA
(v6.2#6252)