You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sakthi (JIRA)" <ji...@apache.org> on 2018/12/23 03:31:00 UTC

[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.

    [ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727793#comment-16727793 ] 

Sakthi commented on HBASE-21634:
--------------------------------

We can either
 * just throw exception saying "Invalid value xyz for LIMIT. Not updating quotas."
 * Or we can accept them as bytes (like we are already doing) and print out a warning message saying: "Invalid value xyz for LIMIT. Setting LIMIT to abc bytes.'

I prefer the second one, where just warning the user would be okay, as the user can always re-run the set-quota command with the updated LIMIT value.

> Print error message when user uses unacceptable values for LIMIT while setting quotas.
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-21634
>                 URL: https://issues.apache.org/jira/browse/HBASE-21634
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sakthi
>            Assignee: Sakthi
>            Priority: Minor
>
> When unacceptable value(like 2.3G or 70H) to LIMITĀ areĀ passed while setting quotas, we currently do not print any error message (informing the user about the erroneous input). Like below:
> {noformat}
> hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', POLICY => NO_WRITES
> Took 0.0792 seconds
> hbase(main):003:0> list_quotas
> OWNER                                                        QUOTAS
>  TABLE => t2                                                 TYPE => SPACE, TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES
> 1 row(s)
> Took 0.0512 seconds
> hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', POLICY => NO_WRITES
> Took 0.0088 seconds
> hbase(main):007:0> list_quotas
> OWNER                                                        QUOTAS
>  TABLE => t2                                                 TYPE => SPACE, TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES
> 1 row(s)
> Took 0.0448 seconds
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)