You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/02 07:44:53 UTC

[GitHub] [airflow] xinbinhuang commented on pull request #15120: Do not log info when ssm secret not found

xinbinhuang commented on pull request #15120:
URL: https://github.com/apache/airflow/pull/15120#issuecomment-812394314


   By logging error, it can be helpful if the user expects to use a specific backend for the secret or fails for unexpected reasons (PermissionDenied). https://github.com/apache/airflow/blob/4d1b2e985492894e6064235688cf8f381b1e8858/airflow/providers/google/cloud/_internal_client/secret_manager_client.py#L92-L98
   
   But regardless of the final decision of using error or debug, do you mind also fix the `aws/secrets/secrets_manager.py` ? It's using `log.debug` right now, so better to make it consistent


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org