You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Isaac Chiang <is...@gmail.com> on 2013/05/03 08:40:22 UTC
Review Request: CLOUSTACK-2076 : DIsplaying zones causes the UI to go on an
infinite scrolling
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10912/
-----------------------------------------------------------
Review request for cloudstack and Pranav Saxena.
Description
-------
This issue is a defect of scrolling in listView. The original scroll event cause page attribute unlimited increasing. This patch add some conditions to prevent the situation.
This addresses bug CLOUDSTACK-2076.
Diffs
-----
ui/scripts/ui/widgets/listView.js f368951
Diff: https://reviews.apache.org/r/10912/diff/
Testing
-------
Test from UI and work as expect.
Thanks,
Isaac Chiang
Re: Review Request: CLOUSTACK-2076 : DIsplaying zones causes the UI to go on
an infinite scrolling
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10912/#review20168
-----------------------------------------------------------
Merged with master . Please mark the review request as Submitted . Thanks for the patch !
- Pranav Saxena
On May 3, 2013, 6:40 a.m., Isaac Chiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10912/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 6:40 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Description
> -------
>
> This issue is a defect of scrolling in listView. The original scroll event cause page attribute unlimited increasing. This patch add some conditions to prevent the situation.
>
>
> This addresses bug CLOUDSTACK-2076.
>
>
> Diffs
> -----
>
> ui/scripts/ui/widgets/listView.js f368951
>
> Diff: https://reviews.apache.org/r/10912/diff/
>
>
> Testing
> -------
>
> Test from UI and work as expect.
>
>
> Thanks,
>
> Isaac Chiang
>
>
Re: Review Request: CLOUSTACK-2076 : DIsplaying zones causes the UI to go on
an infinite scrolling
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10912/#review20167
-----------------------------------------------------------
Ship it!
Fix looks good .Nice way to use a boolean flag to set the table height accordingly . I'll merge this patch with master . Thanks !
- Pranav Saxena
On May 3, 2013, 6:40 a.m., Isaac Chiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10912/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 6:40 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Description
> -------
>
> This issue is a defect of scrolling in listView. The original scroll event cause page attribute unlimited increasing. This patch add some conditions to prevent the situation.
>
>
> This addresses bug CLOUDSTACK-2076.
>
>
> Diffs
> -----
>
> ui/scripts/ui/widgets/listView.js f368951
>
> Diff: https://reviews.apache.org/r/10912/diff/
>
>
> Testing
> -------
>
> Test from UI and work as expect.
>
>
> Thanks,
>
> Isaac Chiang
>
>