You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2013/12/06 03:13:35 UTC
Review Request 16074: HIVE-5951 improve performance of adding partitions
from client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16074/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA. RB does not include generated code.
Diffs
-----
metastore/if/hive_metastore.thrift 43b3907
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 65406d9
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cacfa07
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 27ae3c4
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 57f1e67
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java c0e720f
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d32be59
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 947b65c
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java f4476a9
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 321759b
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 7443ea4
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java e97d948
ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44
ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26
ql/src/test/results/clientpositive/add_part_multiple.q.out b2525cf
Diff: https://reviews.apache.org/r/16074/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 16074: HIVE-5951 improve performance of adding partitions
from client
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16074/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 7:33 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA. RB does not include generated code.
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 43b3907
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h d7e9625
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 75f8a08
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 01e7e1f
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h abc4d65
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 62ecaa0
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java b67d808
metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 7d65daf
metastore/src/gen/thrift/gen-php/metastore/Types.php 4c93bea
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote da323e0
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py c0b308b
metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py d796aae
metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 616e5b3
metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb ff88f49
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 56e9f0c
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ed2cb5a
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cacfa07
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 0a52b4d
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 27ae3c4
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 57f1e67
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java c0e720f
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java dc45ea2
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java fccea89
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 441f329
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 849bbf4
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java c5bfe59
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java efe3286
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 0de3dca
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 8ed5b70
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 52d7c75
ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44
ql/src/test/results/clientnegative/addpart1.q.out b4be19c
ql/src/test/results/clientnegative/alter_table_add_partition.q.out 557ac4d
ql/src/test/results/clientnegative/alter_view_failure4.q.out b218c19
ql/src/test/results/clientnegative/alter_view_failure5.q.out 83511ee
ql/src/test/results/clientnegative/alter_view_failure7.q.out e2967b1
ql/src/test/results/clientnegative/analyze1.q.out d60baa3
ql/src/test/results/clientnegative/dyn_part1.q.out 197923a
ql/src/test/results/clientnegative/truncate_partition_column.q.out 082001d
ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26
ql/src/test/results/clientpositive/add_part_multiple.q.out 7bc071e
ql/src/test/results/clientpositive/create_view_partitioned.q.out e90ffc7
ql/src/test/results/clientpositive/partitions_json.q.out deb7a1f
Diff: https://reviews.apache.org/r/16074/diff/
Testing
-------
running clidriver, some more query results will change
Thanks,
Sergey Shelukhin
Re: Review Request 16074: HIVE-5951 improve performance of adding partitions
from client
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16074/
-----------------------------------------------------------
(Updated Jan. 10, 2014, 11:09 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA. RB does not include generated code.
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 43b3907
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h d7e9625
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 75f8a08
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 01e7e1f
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h abc4d65
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 62ecaa0
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java b67d808
metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 7d65daf
metastore/src/gen/thrift/gen-php/metastore/Types.php 4c93bea
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote da323e0
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py c0b308b
metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py d796aae
metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 616e5b3
metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb ff88f49
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ed2cb5a
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cacfa07
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java adf80d7
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 27ae3c4
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 57f1e67
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java c0e720f
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9e4f1c7
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java fccea89
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2fe86e1
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 83514a2
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 0180b87
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3dbbff4
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 713bd54
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 1ab5a60
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e68fcf
ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44
ql/src/test/results/clientnegative/addpart1.q.out b4be19c
ql/src/test/results/clientnegative/alter_table_add_partition.q.out 557ac4d
ql/src/test/results/clientnegative/alter_view_failure4.q.out b218c19
ql/src/test/results/clientnegative/alter_view_failure5.q.out 83511ee
ql/src/test/results/clientnegative/truncate_partition_column.q.out 082001d
ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26
ql/src/test/results/clientpositive/add_part_multiple.q.out 7bc071e
ql/src/test/results/clientpositive/create_view_partitioned.q.out e90ffc7
ql/src/test/results/clientpositive/partitions_json.q.out deb7a1f
Diff: https://reviews.apache.org/r/16074/diff/
Testing
-------
running clidriver, some more query results will change
Thanks,
Sergey Shelukhin
Re: Review Request 16074: HIVE-5951 improve performance of adding partitions
from client
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16074/
-----------------------------------------------------------
(Updated Jan. 10, 2014, 7:12 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA. RB does not include generated code.
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 43b3907
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h d7e9625
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 75f8a08
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 01e7e1f
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h abc4d65
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 62ecaa0
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java b67d808
metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 7d65daf
metastore/src/gen/thrift/gen-php/metastore/Types.php 4c93bea
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote da323e0
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py c0b308b
metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py d796aae
metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 616e5b3
metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb ff88f49
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java ed2cb5a
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cacfa07
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java adf80d7
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 27ae3c4
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 57f1e67
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java c0e720f
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9e4f1c7
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java fccea89
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2fe86e1
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 0fe260d
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 877d342
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3dbbff4
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 713bd54
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 1ab5a60
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e68fcf
ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44
ql/src/test/results/clientnegative/addpart1.q.out b4be19c
ql/src/test/results/clientnegative/alter_view_failure4.q.out b218c19
ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26
ql/src/test/results/clientpositive/add_part_multiple.q.out 7bc071e
ql/src/test/results/clientpositive/create_view_partitioned.q.out e90ffc7
ql/src/test/results/clientpositive/partitions_json.q.out deb7a1f
Diff: https://reviews.apache.org/r/16074/diff/
Testing
-------
running clidriver, some more query results will change
Thanks,
Sergey Shelukhin
Re: Review Request 16074: HIVE-5951 improve performance of adding partitions
from client
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Jan. 9, 2014, 11:44 p.m., Ashutosh Chauhan wrote:
> > metastore/if/hive_metastore.thrift, line 299
> > <https://reviews.apache.org/r/16074/diff/4/?file=395723#file395723line299>
> >
> > Should this be list<bool>? I guess in current form, this implies same boolean value for all partitions passed in the request. Will be good to document.
that is intended... does not exist flag is per command
> On Jan. 9, 2014, 11:44 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 1529
> > <https://reviews.apache.org/r/16074/diff/4/?file=395732#file395732line1529>
> >
> > Lets pass false, otherwise server may return huge output (for large number of partitions) which is of no use to client.
The output is only as huge as the command :)
I think this is better done in separate jira. For backward compat we'd rather have to pass some sort of flag; it might require syntax change to specify that flag
> On Jan. 9, 2014, 11:44 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java, line 154
> > <https://reviews.apache.org/r/16074/diff/4/?file=395733#file395733line154>
> >
> > We should do this via Kryo. Probably matter for another jira though.
Yeah I just added the comment, code is old
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16074/#review31486
-----------------------------------------------------------
On Dec. 9, 2013, 7:36 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16074/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2013, 7:36 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See JIRA. RB does not include generated code.
>
>
> Diffs
> -----
>
> metastore/if/hive_metastore.thrift 43b3907
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 65406d9
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cacfa07
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 27ae3c4
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 57f1e67
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java c0e720f
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d32be59
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 947b65c
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java f4476a9
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 321759b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 7443ea4
> ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java e97d948
> ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44
> ql/src/test/results/clientnegative/addpart1.q.out b4be19c
> ql/src/test/results/clientnegative/alter_view_failure4.q.out b218c19
> ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26
> ql/src/test/results/clientpositive/add_part_multiple.q.out 7bc071e
> ql/src/test/results/clientpositive/create_view_partitioned.q.out e90ffc7
> ql/src/test/results/clientpositive/partitions_json.q.out deb7a1f
>
> Diff: https://reviews.apache.org/r/16074/diff/
>
>
> Testing
> -------
>
> running clidriver, some more query results will change
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 16074: HIVE-5951 improve performance of adding partitions
from client
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16074/#review31486
-----------------------------------------------------------
metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/16074/#comment59988>
Should this be list<bool>? I guess in current form, this implies same boolean value for all partitions passed in the request. Will be good to document.
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<https://reviews.apache.org/r/16074/#comment59989>
I wonder instead we should create all MPartition and then do pm.makePersistentAll(List<MPartition>) ?
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/16074/#comment59990>
Lets pass false, otherwise server may return huge output (for large number of partitions) which is of no use to client.
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java
<https://reviews.apache.org/r/16074/#comment59991>
We should do this via Kryo. Probably matter for another jira though.
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/16074/#comment59992>
It its not lot of work, might make sense to do this TODO now.
- Ashutosh Chauhan
On Dec. 9, 2013, 7:36 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16074/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2013, 7:36 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See JIRA. RB does not include generated code.
>
>
> Diffs
> -----
>
> metastore/if/hive_metastore.thrift 43b3907
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 65406d9
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cacfa07
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 27ae3c4
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 57f1e67
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java c0e720f
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d32be59
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 947b65c
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java f4476a9
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 321759b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 7443ea4
> ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java e97d948
> ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44
> ql/src/test/results/clientnegative/addpart1.q.out b4be19c
> ql/src/test/results/clientnegative/alter_view_failure4.q.out b218c19
> ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26
> ql/src/test/results/clientpositive/add_part_multiple.q.out 7bc071e
> ql/src/test/results/clientpositive/create_view_partitioned.q.out e90ffc7
> ql/src/test/results/clientpositive/partitions_json.q.out deb7a1f
>
> Diff: https://reviews.apache.org/r/16074/diff/
>
>
> Testing
> -------
>
> running clidriver, some more query results will change
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 16074: HIVE-5951 improve performance of adding partitions
from client
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16074/
-----------------------------------------------------------
(Updated Dec. 9, 2013, 7:36 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA. RB does not include generated code.
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 43b3907
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 65406d9
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cacfa07
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 27ae3c4
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 57f1e67
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java c0e720f
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d32be59
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 947b65c
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java f4476a9
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 321759b
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 7443ea4
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java e97d948
ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44
ql/src/test/results/clientnegative/addpart1.q.out b4be19c
ql/src/test/results/clientnegative/alter_view_failure4.q.out b218c19
ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26
ql/src/test/results/clientpositive/add_part_multiple.q.out 7bc071e
ql/src/test/results/clientpositive/create_view_partitioned.q.out e90ffc7
ql/src/test/results/clientpositive/partitions_json.q.out deb7a1f
Diff: https://reviews.apache.org/r/16074/diff/
Testing
-------
running clidriver, some more query results will change
Thanks,
Sergey Shelukhin
Re: Review Request 16074: HIVE-5951 improve performance of adding partitions
from client
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16074/
-----------------------------------------------------------
(Updated Dec. 7, 2013, 1:18 a.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA. RB does not include generated code.
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 43b3907
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 65406d9
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cacfa07
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 27ae3c4
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 57f1e67
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java c0e720f
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d32be59
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 947b65c
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java f4476a9
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 321759b
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 7443ea4
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java e97d948
ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44
ql/src/test/results/clientnegative/addpart1.q.out b4be19c
ql/src/test/results/clientnegative/alter_view_failure4.q.out b218c19
ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26
ql/src/test/results/clientpositive/add_part_multiple.q.out b2525cf
ql/src/test/results/clientpositive/create_view_partitioned.q.out e90ffc7
ql/src/test/results/clientpositive/partitions_json.q.out deb7a1f
Diff: https://reviews.apache.org/r/16074/diff/
Testing
-------
running clidriver, some more query results will change
Thanks,
Sergey Shelukhin
Re: Review Request 16074: HIVE-5951 improve performance of adding partitions
from client
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16074/
-----------------------------------------------------------
(Updated Dec. 6, 2013, 9:16 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA. RB does not include generated code.
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 43b3907
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 65406d9
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cacfa07
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 27ae3c4
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 57f1e67
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java c0e720f
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d32be59
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 947b65c
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java f4476a9
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 321759b
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 7443ea4
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java e97d948
ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44
ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26
ql/src/test/results/clientpositive/add_part_multiple.q.out b2525cf
ql/src/test/results/clientpositive/create_view_partitioned.q.out e90ffc7
ql/src/test/results/clientpositive/partitions_json.q.out deb7a1f
Diff: https://reviews.apache.org/r/16074/diff/
Testing
-------
running clidriver, some more query results will change
Thanks,
Sergey Shelukhin
Re: Review Request 16074: HIVE-5951 improve performance of adding partitions
from client
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16074/
-----------------------------------------------------------
(Updated Dec. 6, 2013, 2:13 a.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
See JIRA. RB does not include generated code.
Diffs
-----
metastore/if/hive_metastore.thrift 43b3907
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 01c2626
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 65406d9
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cacfa07
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 04d399f
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 27ae3c4
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 57f1e67
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java c0e720f
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d32be59
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 947b65c
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java f4476a9
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 321759b
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 7443ea4
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java e97d948
ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ff60e44
ql/src/test/results/clientpositive/add_part_exist.q.out 559cb26
ql/src/test/results/clientpositive/add_part_multiple.q.out b2525cf
Diff: https://reviews.apache.org/r/16074/diff/
Testing (updated)
-------
running clidriver, some more query results will change
Thanks,
Sergey Shelukhin