You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/07 03:47:08 UTC
[GitHub] [iceberg] wuwenchi opened a new pull request #3680: bugfix:description for flink streaming job
wuwenchi opened a new pull request #3680:
URL: https://github.com/apache/iceberg/pull/3680
modify description for flink streaming job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick edited a comment on pull request #3680: bugfix:description for flink streaming job
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #3680:
URL: https://github.com/apache/iceberg/pull/3680#issuecomment-987548260
Nit: Can you please edit the PR description to say something like the following "Fix Flink job incorrectly labeled as streaming job when it's a batch job"? @wuwenchi?
I had to open the file to see what the issue was, it's not clear from the diff alone. It's helpful for other reviewers to have proper context when reviewing PRs. Again, thanks for this patch! 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wuwenchi commented on pull request #3680: bugfix:description for flink streaming job
Posted by GitBox <gi...@apache.org>.
wuwenchi commented on pull request #3680:
URL: https://github.com/apache/iceberg/pull/3680#issuecomment-987621490
@kbendick Sorry for the problem with the PR format ... Thanks for your advice, and I will follow the convention in the future to improve efficiency ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3680: Site Docs - Fix Flink batch job incorrectly labeled as streaming
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3680:
URL: https://github.com/apache/iceberg/pull/3680#issuecomment-988389064
No worries @wuwenchi! Just thought I'd give you a heads up. Your contribution is greatly appreciated!
cc @samredai for a docs related PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3680: bugfix:description for flink streaming job
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3680:
URL: https://github.com/apache/iceberg/pull/3680#issuecomment-987548260
Can you please edit the PR description to say something like the following "Fix Flink job incorrectly labeled as streaming job when it's a batch job"? @wuwenchi?
I had to open the file to see what the issue was, it's not clear from the diff alone. It's helpful for other reviewers to have proper context when reviewing PRs. Again, thanks for this patch! 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3680: Site Docs - Fix Flink batch job incorrectly labeled as streaming
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3680:
URL: https://github.com/apache/iceberg/pull/3680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3680: bugfix:description for flink streaming job
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3680:
URL: https://github.com/apache/iceberg/pull/3680#issuecomment-987549786
Also, for PR titles, by convention we tend to use "[Primary Project Component] - Description of what was fixed".
For this PR, you'll get more PR reviewers / the correct PR reviewers if you use a title more like "Site Docs - Fix Flink batch job incorrectly labeled as streaming" or something similar.
Certain people focus more on the docs or on different areas, so that convention helps them prioritize where to review. Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org