You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/02 02:16:56 UTC
[GitHub] [flink] SteNicholas commented on a change in pull request #14028: [FLINK-20020][client] Make UnsuccessfulExecutionException part of the JobClient.getJobExecutionResult() contract
SteNicholas commented on a change in pull request #14028:
URL: https://github.com/apache/flink/pull/14028#discussion_r533850366
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
##########
@@ -257,7 +258,7 @@ public void run() {
runner.join();
final Throwable t = errorRef.get();
- if (t != null) {
+ if (t != null && ((JobExecutionException) t).getStatus() == ApplicationStatus.FAILED) {
Review comment:
@tillrohrmann , I got your point for this change, and I would like to update commit for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org