You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/05/17 07:27:58 UTC

[GitHub] [rocketmq] zhangjidi2016 opened a new pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

zhangjidi2016 opened a new pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899


   
   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   #2898 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhangjidi2016 removed a comment on pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 removed a comment on pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899#issuecomment-842892080


   > as i build with lastest codes, all is fine.
   > check your local IDE config
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling merged pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhangjidi2016 commented on pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899#issuecomment-842892080


   > as i build with lastest codes, all is fine.
   > check your local IDE config
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhangjidi2016 commented on pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899#issuecomment-842898716


   When I use the CheckStyle plugin to check the code following the checkstyle.xml specification in RocketMQ, the check does not pass
   ![image](https://user-images.githubusercontent.com/18254437/118603880-12764000-b7e7-11eb-96e9-464c092ced44.png)
   ![image](https://user-images.githubusercontent.com/18254437/118603990-32a5ff00-b7e7-11eb-9dd1-41358d0915c2.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899#issuecomment-842092368


   
   [![Coverage Status](https://coveralls.io/builds/39770626/badge)](https://coveralls.io/builds/39770626)
   
   Coverage decreased (-0.02%) to 52.359% when pulling **fbb35d3d66bc732f9213e15c85071ad603daa168 on zhangjidi2016:develop** into **be6eaf858cf5e98bee072353f6580572d652951d on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling commented on pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899#issuecomment-843686133


   Yes, you are correct. Note that we have bound checkstyle to verify the phase now. If bound to the validate phase, it would check the code prior to compiling the code. If the code is invalid, the parsing errors reported by checkstyle may be different than what would be expected from the javac compiler. However, it's guaranteed to run. But for verify phase which would run much later (and allow the javac compiler to flag invalid code prior to checkstyle). However, if developers generally just use "mvn test" prior to pushing changes, checkstyle would not run as verify occurs after the test phase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899#issuecomment-842092368


   
   [![Coverage Status](https://coveralls.io/builds/39733588/badge)](https://coveralls.io/builds/39733588)
   
   Coverage decreased (-0.01%) to 52.37% when pulling **fbb35d3d66bc732f9213e15c85071ad603daa168 on zhangjidi2016:develop** into **be6eaf858cf5e98bee072353f6580572d652951d on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899#issuecomment-842092368


   
   [![Coverage Status](https://coveralls.io/builds/39733588/badge)](https://coveralls.io/builds/39733588)
   
   Coverage decreased (-0.01%) to 52.37% when pulling **fbb35d3d66bc732f9213e15c85071ad603daa168 on zhangjidi2016:develop** into **be6eaf858cf5e98bee072353f6580572d652951d on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899#issuecomment-842909430


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2899?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2899](https://codecov.io/gh/apache/rocketmq/pull/2899?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fbb35d3) into [develop](https://codecov.io/gh/apache/rocketmq/commit/be6eaf858cf5e98bee072353f6580572d652951d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be6eaf8) will **decrease** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2899/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/2899?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #2899      +/-   ##
   =============================================
   - Coverage      46.67%   46.58%   -0.09%     
   + Complexity      4418     4413       -5     
   =============================================
     Files            552      552              
     Lines          36500    36500              
     Branches        4828     4828              
   =============================================
   - Hits           17035    17003      -32     
   - Misses         17344    17376      +32     
     Partials        2121     2121              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2899?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ain/java/org/apache/rocketmq/test/util/MQWait.java](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RV2FpdC5qYXZh) | `43.24% <0.00%> (-16.22%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `43.28% <0.00%> (-8.96%)` | `17.00% <0.00%> (-3.00%)` | |
   | [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `75.55% <0.00%> (-4.45%)` | `9.00% <0.00%> (-1.00%)` | |
   | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `58.60% <0.00%> (-3.73%)` | `31.00% <0.00%> (-2.00%)` | |
   | [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.98% <0.00%> (-3.62%)` | `16.00% <0.00%> (ø%)` | |
   | [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `29.50% <0.00%> (-1.32%)` | `26.00% <0.00%> (-2.00%)` | |
   | [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRUb2xlcmFuY2VJbXBsLmphdmE=) | `50.00% <0.00%> (-1.29%)` | `8.00% <0.00%> (ø%)` | |
   | [...java/org/apache/rocketmq/logging/inner/Logger.java](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnZXIuamF2YQ==) | `51.67% <0.00%> (-0.96%)` | `28.00% <0.00%> (ø%)` | |
   | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `55.31% <0.00%> (-0.30%)` | `109.00% <0.00%> (-1.00%)` | |
   | [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | `44.89% <0.00%> (+0.24%)` | `83.00% <0.00%> (ø%)` | |
   | ... and [7 more](https://codecov.io/gh/apache/rocketmq/pull/2899/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2899?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2899?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [be6eaf8...fbb35d3](https://codecov.io/gh/apache/rocketmq/pull/2899?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhangjidi2016 closed pull request #2899: [ISSUE #2898] Resolve rocketmq-example project failed during checkstyle execution.

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 closed pull request #2899:
URL: https://github.com/apache/rocketmq/pull/2899


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org