[jira] [Commented] (GEODE-8259) when client encountered SerializationException, it should retry

["Xiaojian Zhou (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142423#comment-17142423 ] 

Xiaojian Zhou commented on GEODE-8259:
--------------------------------------

Change the title from null to a title string will enable the retry once more after singlehop failure. 
Remove the exToThrow = new ServerOperationException will enable the retry up to serverNumber times in non-singlehop scenario. 

Before the code base contains refactoring of GEODE-7090, the fix is only to enable the retry for SerializationException. 
After the code base contains refactoring of GEODE-7090, the fix should also consider the cause of the exception will be thrown as RuntimeException, which should be caught as convert to SerializationException.

support/9.7, 9.8, 9.9 does not contain refactoring of GEODE-7090. support/9.10 and after contains refactoring of GEODE-7090. 

> when client encountered SerializationException, it should retry
> ---------------------------------------------------------------
>
>                 Key: GEODE-8259
>                 URL: https://issues.apache.org/jira/browse/GEODE-8259
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Xiaojian Zhou
>            Priority: Major
>
> In GEOEDE-7090, DSFIDSerializerImpl.invokeFromData() will catch RunTimeException and throw. But convert Exception to be IOException. The idea is to avoid using SerializationException which is in another package. 
> However, if my fromData() failed with IndexOutOfBoundary exception (which is an RTE), it will be thrown directly instead of treating it in handleException(), thus my serialization exception will never get handled. 
> The fix is to merge the catch RunTimeException into catch Exception.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)