You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2014/06/06 18:14:44 UTC
svn commit: r1600950 - in /tomcat/trunk:
java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml
Author: remm
Date: Fri Jun 6 16:14:44 2014
New Revision: 1600950
URL: http://svn.apache.org/r1600950
Log:
Try removing the beta tag from the NIO2 connector to get more feedback, after the latest round of fixes. In practice since it is not used by default, it doesn't change much.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java?rev=1600950&r1=1600949&r2=1600950&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Fri Jun 6 16:14:44 2014
@@ -353,9 +353,6 @@ public class Nio2Endpoint extends Abstra
running = true;
paused = false;
- // FIXME: remove when more stable
- log.warn("The NIO2 connector is currently BETA and should not be used in production");
-
// Create worker collection
if ( getExecutor() == null ) {
createExecutor();
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1600950&r1=1600949&r2=1600950&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Jun 6 16:14:44 2014
@@ -158,6 +158,9 @@
make it easier for the client to differentiate between a complete
response and one that failed part way though. (markt)
</fix>
+ <scode>
+ Remove the beta tag from the NIO2 connectors. (remm)
+ </scode>
</changelog>
</subsection>
<subsection name="Jasper">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java
webapps/docs/changelog.xml
Posted by Rémy Maucherat <re...@apache.org>.
2014-06-06 18:39 GMT+02:00 Konstantin Kolinko <kn...@gmail.com>:
> 1. Doesn't it feel too early?
>
Maybe, but tests pass and no reports.
>
> 2. You only removed a startup warning. I think the documentation still
> labels it as beta.
>
This could be a good middle ground.
Rémy
Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java
webapps/docs/changelog.xml
Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-06-06 20:17 GMT+04:00 Rémy Maucherat <re...@apache.org>:
> 2014-06-06 18:14 GMT+02:00 <re...@apache.org>:
>
>> Author: remm
>> Date: Fri Jun 6 16:14:44 2014
>> New Revision: 1600950
>>
>> URL: http://svn.apache.org/r1600950
>> Log:
>> Try removing the beta tag from the NIO2 connector to get more feedback,
>> after the latest round of fixes. In practice since it is not used by
>> default, it doesn't change much.
>>
>
> So if someone wants to keep it as beta, let me know before the tag.
1. Doesn't it feel too early?
2. You only removed a startup warning. I think the documentation still
labels it as beta.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java
webapps/docs/changelog.xml
Posted by Rémy Maucherat <re...@apache.org>.
2014-06-06 18:14 GMT+02:00 <re...@apache.org>:
> Author: remm
> Date: Fri Jun 6 16:14:44 2014
> New Revision: 1600950
>
> URL: http://svn.apache.org/r1600950
> Log:
> Try removing the beta tag from the NIO2 connector to get more feedback,
> after the latest round of fixes. In practice since it is not used by
> default, it doesn't change much.
>
So if someone wants to keep it as beta, let me know before the tag.
Rémy